From: Ulf Hansson <ulf.hansson@linaro.org> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "Rafael J . Wysocki" <rafael@kernel.org>, linux-kernel@vger.kernel.org Cc: Arnd Bergmann <arnd@arndb.de>, Christoph Hellwig <hch@lst.de>, Russell King <linux@armlinux.org.uk>, Linus Walleij <linus.walleij@linaro.org>, Vinod Koul <vkoul@kernel.org>, Haibo Chen <haibo.chen@nxp.com>, Ludovic Barre <ludovic.barre@st.com>, linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, Ulf Hansson <ulf.hansson@linaro.org>, stable@vger.kernel.org Subject: [PATCH 2/2] amba: Initialize dma_parms for amba devices Date: Wed, 25 Mar 2020 12:34:07 +0100 [thread overview] Message-ID: <20200325113407.26996-3-ulf.hansson@linaro.org> (raw) In-Reply-To: <20200325113407.26996-1-ulf.hansson@linaro.org> It's currently the amba driver's responsibility to initialize the pointer, dma_parms, for its corresponding struct device. The benefit with this approach allows us to avoid the initialization and to not waste memory for the struct device_dma_parameters, as this can be decided on a case by case basis. However, it has turned out that this approach is not very practical. Not only does it lead to open coding, but also to real errors. In principle callers of dma_set_max_seg_size() doesn't check the error code, but just assumes it succeeds. For these reasons, let's do the initialization from the common amba bus at the device registration point. This also follows the way the PCI devices are being managed, see pci_device_add(). Suggested-by: Christoph Hellwig <hch@lst.de> Cc: Russell King <linux@armlinux.org.uk> Cc: <stable@vger.kernel.org> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> --- drivers/amba/bus.c | 2 ++ include/linux/amba/bus.h | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c index fe1523664816..5e61783ce92d 100644 --- a/drivers/amba/bus.c +++ b/drivers/amba/bus.c @@ -374,6 +374,8 @@ static int amba_device_try_add(struct amba_device *dev, struct resource *parent) WARN_ON(dev->irq[0] == (unsigned int)-1); WARN_ON(dev->irq[1] == (unsigned int)-1); + dev->dev.dma_parms = &dev->dma_parms; + ret = request_resource(parent, &dev->res); if (ret) goto err_out; diff --git a/include/linux/amba/bus.h b/include/linux/amba/bus.h index 26f0ecf401ea..0bbfd647f5c6 100644 --- a/include/linux/amba/bus.h +++ b/include/linux/amba/bus.h @@ -65,6 +65,7 @@ struct amba_device { struct device dev; struct resource res; struct clk *pclk; + struct device_dma_parameters dma_parms; unsigned int periphid; unsigned int cid; struct amba_cs_uci_id uci; -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Ulf Hansson <ulf.hansson@linaro.org> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "Rafael J . Wysocki" <rafael@kernel.org>, linux-kernel@vger.kernel.org Cc: Ulf Hansson <ulf.hansson@linaro.org>, Arnd Bergmann <arnd@arndb.de>, Linus Walleij <linus.walleij@linaro.org>, Russell King <linux@armlinux.org.uk>, Haibo Chen <haibo.chen@nxp.com>, Vinod Koul <vkoul@kernel.org>, linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, stable@vger.kernel.org, Christoph Hellwig <hch@lst.de>, Ludovic Barre <ludovic.barre@st.com> Subject: [PATCH 2/2] amba: Initialize dma_parms for amba devices Date: Wed, 25 Mar 2020 12:34:07 +0100 [thread overview] Message-ID: <20200325113407.26996-3-ulf.hansson@linaro.org> (raw) In-Reply-To: <20200325113407.26996-1-ulf.hansson@linaro.org> It's currently the amba driver's responsibility to initialize the pointer, dma_parms, for its corresponding struct device. The benefit with this approach allows us to avoid the initialization and to not waste memory for the struct device_dma_parameters, as this can be decided on a case by case basis. However, it has turned out that this approach is not very practical. Not only does it lead to open coding, but also to real errors. In principle callers of dma_set_max_seg_size() doesn't check the error code, but just assumes it succeeds. For these reasons, let's do the initialization from the common amba bus at the device registration point. This also follows the way the PCI devices are being managed, see pci_device_add(). Suggested-by: Christoph Hellwig <hch@lst.de> Cc: Russell King <linux@armlinux.org.uk> Cc: <stable@vger.kernel.org> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> --- drivers/amba/bus.c | 2 ++ include/linux/amba/bus.h | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c index fe1523664816..5e61783ce92d 100644 --- a/drivers/amba/bus.c +++ b/drivers/amba/bus.c @@ -374,6 +374,8 @@ static int amba_device_try_add(struct amba_device *dev, struct resource *parent) WARN_ON(dev->irq[0] == (unsigned int)-1); WARN_ON(dev->irq[1] == (unsigned int)-1); + dev->dev.dma_parms = &dev->dma_parms; + ret = request_resource(parent, &dev->res); if (ret) goto err_out; diff --git a/include/linux/amba/bus.h b/include/linux/amba/bus.h index 26f0ecf401ea..0bbfd647f5c6 100644 --- a/include/linux/amba/bus.h +++ b/include/linux/amba/bus.h @@ -65,6 +65,7 @@ struct amba_device { struct device dev; struct resource res; struct clk *pclk; + struct device_dma_parameters dma_parms; unsigned int periphid; unsigned int cid; struct amba_cs_uci_id uci; -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-25 11:34 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-25 11:34 [PATCH 0/2] amba/platform: Initialize dma_parms at the bus level Ulf Hansson 2020-03-25 11:34 ` Ulf Hansson 2020-03-25 11:34 ` [PATCH 1/2] driver core: platform: Initialize dma_parms for platform devices Ulf Hansson 2020-03-25 11:34 ` Ulf Hansson 2020-03-25 15:23 ` Ludovic BARRE 2020-03-25 15:23 ` Ludovic BARRE 2020-03-26 11:01 ` Linus Walleij 2020-03-26 11:01 ` Linus Walleij 2020-03-26 11:06 ` Arnd Bergmann 2020-03-26 11:06 ` Arnd Bergmann 2020-03-27 15:03 ` Sasha Levin 2020-03-25 11:34 ` Ulf Hansson [this message] 2020-03-25 11:34 ` [PATCH 2/2] amba: Initialize dma_parms for amba devices Ulf Hansson 2020-03-25 15:24 ` Ludovic BARRE 2020-03-25 15:24 ` Ludovic BARRE 2020-03-26 11:02 ` Linus Walleij 2020-03-26 11:02 ` Linus Walleij 2020-03-26 11:07 ` Arnd Bergmann 2020-03-26 11:07 ` Arnd Bergmann 2020-03-26 4:41 ` [PATCH 0/2] amba/platform: Initialize dma_parms at the bus level BOUGH CHEN 2020-03-26 4:41 ` BOUGH CHEN 2020-03-27 3:02 ` BOUGH CHEN 2020-03-27 3:02 ` BOUGH CHEN 2020-03-27 15:34 ` Ulf Hansson 2020-03-27 15:34 ` Ulf Hansson 2020-03-27 19:15 ` Robin Murphy 2020-03-27 19:15 ` Robin Murphy 2020-03-31 18:08 ` Ulf Hansson 2020-03-31 18:08 ` Ulf Hansson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200325113407.26996-3-ulf.hansson@linaro.org \ --to=ulf.hansson@linaro.org \ --cc=arnd@arndb.de \ --cc=dmaengine@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=haibo.chen@nxp.com \ --cc=hch@lst.de \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=ludovic.barre@st.com \ --cc=rafael@kernel.org \ --cc=stable@vger.kernel.org \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.