From: Christoph Hellwig <hch@lst.de>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Jerome Glisse <jglisse@redhat.com>,
Ralph Campbell <rcampbell@nvidia.com>,
Felix.Kuehling@amd.com, linux-mm@kvack.org,
John Hubbard <jhubbard@nvidia.com>,
dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
Christoph Hellwig <hch@lst.de>, Philip Yang <Philip.Yang@amd.com>,
Jason Gunthorpe <jgg@mellanox.com>
Subject: Re: [PATCH v2 hmm 2/9] mm/hmm: return the fault type from hmm_pte_need_fault()
Date: Sat, 28 Mar 2020 09:10:06 +0100 [thread overview]
Message-ID: <20200328081006.GA26015@lst.de> (raw)
In-Reply-To: <20200327200021.29372-3-jgg@ziepe.ca>
On Fri, Mar 27, 2020 at 05:00:14PM -0300, Jason Gunthorpe wrote:
> From: Jason Gunthorpe <jgg@mellanox.com>
>
> Using two bools instead of flags return is not necessary and leads to
> bugs. Returning a value is easier for the compiler to check and easier to
> pass around the code flow.
>
> Convert the two bools into flags and push the change to all callers.
>
> Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Philip Yang <Philip.Yang@amd.com>,
Ralph Campbell <rcampbell@nvidia.com>,
John Hubbard <jhubbard@nvidia.com>,
Felix.Kuehling@amd.com, dri-devel@lists.freedesktop.org,
linux-mm@kvack.org, Jerome Glisse <jglisse@redhat.com>,
Jason Gunthorpe <jgg@mellanox.com>,
amd-gfx@lists.freedesktop.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2 hmm 2/9] mm/hmm: return the fault type from hmm_pte_need_fault()
Date: Sat, 28 Mar 2020 09:10:06 +0100 [thread overview]
Message-ID: <20200328081006.GA26015@lst.de> (raw)
In-Reply-To: <20200327200021.29372-3-jgg@ziepe.ca>
On Fri, Mar 27, 2020 at 05:00:14PM -0300, Jason Gunthorpe wrote:
> From: Jason Gunthorpe <jgg@mellanox.com>
>
> Using two bools instead of flags return is not necessary and leads to
> bugs. Returning a value is easier for the compiler to check and easier to
> pass around the code flow.
>
> Convert the two bools into flags and push the change to all callers.
>
> Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2020-03-28 8:10 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 20:00 [PATCH v3 hmm 0/9] Small hmm_range_fault() cleanups Jason Gunthorpe
2020-03-27 20:00 ` Jason Gunthorpe
2020-03-27 20:00 ` Jason Gunthorpe
2020-03-27 20:00 ` [PATCH v2 hmm 1/9] mm/hmm: remove pgmap checking for devmap pages Jason Gunthorpe
2020-03-27 20:00 ` Jason Gunthorpe
2020-03-27 20:00 ` Jason Gunthorpe
2020-03-27 20:00 ` [PATCH v2 hmm 2/9] mm/hmm: return the fault type from hmm_pte_need_fault() Jason Gunthorpe
2020-03-27 20:00 ` Jason Gunthorpe
2020-03-27 20:00 ` Jason Gunthorpe
2020-03-28 8:10 ` Christoph Hellwig [this message]
2020-03-28 8:10 ` Christoph Hellwig
2020-03-27 20:00 ` [PATCH v2 hmm 3/9] mm/hmm: remove unused code and tidy comments Jason Gunthorpe
2020-03-27 20:00 ` Jason Gunthorpe
2020-03-27 20:00 ` Jason Gunthorpe
2020-03-27 20:00 ` [PATCH v2 hmm 4/9] mm/hmm: remove HMM_FAULT_SNAPSHOT Jason Gunthorpe
2020-03-27 20:00 ` Jason Gunthorpe
2020-03-27 20:00 ` Jason Gunthorpe
2020-03-28 8:11 ` Christoph Hellwig
2020-03-28 8:11 ` Christoph Hellwig
2020-03-27 20:00 ` [PATCH v2 hmm 5/9] mm/hmm: remove the CONFIG_TRANSPARENT_HUGEPAGE #ifdef Jason Gunthorpe
2020-03-27 20:00 ` Jason Gunthorpe
2020-03-27 20:00 ` Jason Gunthorpe
2020-03-27 20:00 ` [PATCH v2 hmm 6/9] mm/hmm: use device_private_entry_to_pfn() Jason Gunthorpe
2020-03-27 20:00 ` Jason Gunthorpe
2020-03-27 20:00 ` Jason Gunthorpe
2020-03-27 20:00 ` [PATCH v2 hmm 7/9] mm/hmm: do not unconditionally set pfns when returning EBUSY Jason Gunthorpe
2020-03-27 20:00 ` Jason Gunthorpe
2020-03-27 20:00 ` Jason Gunthorpe
2020-03-27 20:00 ` [PATCH v2 hmm 8/9] mm/hmm: do not set pfns when returning an error code Jason Gunthorpe
2020-03-27 20:00 ` Jason Gunthorpe
2020-03-27 20:00 ` Jason Gunthorpe
2020-03-27 20:00 ` [PATCH v2 hmm 9/9] mm/hmm: return error for non-vma snapshots Jason Gunthorpe
2020-03-27 20:00 ` Jason Gunthorpe
2020-03-27 20:00 ` Jason Gunthorpe
-- strict thread matches above, loose matches on Subject: below --
2020-03-24 1:14 [PATCH v2 hmm 0/9] Small hmm_range_fault() cleanups Jason Gunthorpe
2020-03-24 1:14 ` [PATCH v2 hmm 2/9] mm/hmm: return the fault type from hmm_pte_need_fault() Jason Gunthorpe
2020-03-24 1:14 ` Jason Gunthorpe
2020-03-24 1:14 ` Jason Gunthorpe
2020-03-24 7:27 ` Christoph Hellwig
2020-03-24 7:27 ` Christoph Hellwig
2020-03-24 18:58 ` Jason Gunthorpe
2020-03-24 18:58 ` Jason Gunthorpe
2020-03-24 18:58 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200328081006.GA26015@lst.de \
--to=hch@lst.de \
--cc=Felix.Kuehling@amd.com \
--cc=Philip.Yang@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jgg@mellanox.com \
--cc=jgg@ziepe.ca \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=linux-mm@kvack.org \
--cc=rcampbell@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.