From: Sam Ravnborg <sam@ravnborg.org>
To: Jules Irenge <jbi.octave@gmail.com>
Cc: linux-kernel@vger.kernel.org,
"open list:FRAMEBUFFER LAYER" <linux-fbdev@vger.kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
boqun.feng@gmail.com, Russell King <linux@armlinux.org.uk>,
"open list:FRAMEBUFFER LAYER" <dri-devel@lists.freedesktop.org>,
"moderated list:CYBERPRO FB DRIVER"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/5] video: Add missing annotation for cyber2000fb_enable_ddc() and cyber2000fb_disable_ddc()
Date: Tue, 7 Apr 2020 21:48:24 +0200 [thread overview]
Message-ID: <20200407194824.GA28801@ravnborg.org> (raw)
In-Reply-To: <20200403160505.2832-3-jbi.octave@gmail.com>
Hi Jules.
On Fri, Apr 03, 2020 at 05:05:02PM +0100, Jules Irenge wrote:
> Sparse reports warnings at cyber2000fb_enable_ddc()
> and cyber2000fb_disable_ddc()
>
> warning: context imbalance in cyber2000fb_enable_ddc()
> - wrong count at exit
>
> warning: context imbalance in cyber2000fb_disable_ddc()
> - unexpected unlock
>
> The root cause is the missing annotation at cyber2000fb_enable_ddc()
> and cyber2000fb_disable_ddc()
>
> Add the missing __acquires(&cfb->reg_b0_lock) annotation
> Add the missing __releases(&cfb->reg_b0_lock) annotation
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Thanks, added to drm-misc-next, so the patch will hit the kernel
when the merge windows opens the next time.
Was this the only locking relevant warning in fbdev?
I would expect a few more.
Sam
> ---
> drivers/video/fbdev/cyber2000fb.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/video/fbdev/cyber2000fb.c b/drivers/video/fbdev/cyber2000fb.c
> index 460826a7ad55..513f58f28b0f 100644
> --- a/drivers/video/fbdev/cyber2000fb.c
> +++ b/drivers/video/fbdev/cyber2000fb.c
> @@ -1160,12 +1160,14 @@ EXPORT_SYMBOL(cyber2000fb_detach);
> #define DDC_SDA_IN (1 << 6)
>
> static void cyber2000fb_enable_ddc(struct cfb_info *cfb)
> + __acquires(&cfb->reg_b0_lock)
> {
> spin_lock(&cfb->reg_b0_lock);
> cyber2000fb_writew(0x1bf, 0x3ce, cfb);
> }
>
> static void cyber2000fb_disable_ddc(struct cfb_info *cfb)
> + __releases(&cfb->reg_b0_lock)
> {
> cyber2000fb_writew(0x0bf, 0x3ce, cfb);
> spin_unlock(&cfb->reg_b0_lock);
> --
> 2.24.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Jules Irenge <jbi.octave@gmail.com>
Cc: "open list:FRAMEBUFFER LAYER" <linux-fbdev@vger.kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
boqun.feng@gmail.com, Russell King <linux@armlinux.org.uk>,
"open list:FRAMEBUFFER LAYER" <dri-devel@lists.freedesktop.org>,
linux-kernel@vger.kernel.org,
"moderated list:CYBERPRO FB DRIVER"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/5] video: Add missing annotation for cyber2000fb_enable_ddc() and cyber2000fb_disable_d
Date: Tue, 07 Apr 2020 19:48:24 +0000 [thread overview]
Message-ID: <20200407194824.GA28801@ravnborg.org> (raw)
In-Reply-To: <20200403160505.2832-3-jbi.octave@gmail.com>
Hi Jules.
On Fri, Apr 03, 2020 at 05:05:02PM +0100, Jules Irenge wrote:
> Sparse reports warnings at cyber2000fb_enable_ddc()
> and cyber2000fb_disable_ddc()
>
> warning: context imbalance in cyber2000fb_enable_ddc()
> - wrong count at exit
>
> warning: context imbalance in cyber2000fb_disable_ddc()
> - unexpected unlock
>
> The root cause is the missing annotation at cyber2000fb_enable_ddc()
> and cyber2000fb_disable_ddc()
>
> Add the missing __acquires(&cfb->reg_b0_lock) annotation
> Add the missing __releases(&cfb->reg_b0_lock) annotation
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Thanks, added to drm-misc-next, so the patch will hit the kernel
when the merge windows opens the next time.
Was this the only locking relevant warning in fbdev?
I would expect a few more.
Sam
> ---
> drivers/video/fbdev/cyber2000fb.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/video/fbdev/cyber2000fb.c b/drivers/video/fbdev/cyber2000fb.c
> index 460826a7ad55..513f58f28b0f 100644
> --- a/drivers/video/fbdev/cyber2000fb.c
> +++ b/drivers/video/fbdev/cyber2000fb.c
> @@ -1160,12 +1160,14 @@ EXPORT_SYMBOL(cyber2000fb_detach);
> #define DDC_SDA_IN (1 << 6)
>
> static void cyber2000fb_enable_ddc(struct cfb_info *cfb)
> + __acquires(&cfb->reg_b0_lock)
> {
> spin_lock(&cfb->reg_b0_lock);
> cyber2000fb_writew(0x1bf, 0x3ce, cfb);
> }
>
> static void cyber2000fb_disable_ddc(struct cfb_info *cfb)
> + __releases(&cfb->reg_b0_lock)
> {
> cyber2000fb_writew(0x0bf, 0x3ce, cfb);
> spin_unlock(&cfb->reg_b0_lock);
> --
> 2.24.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Jules Irenge <jbi.octave@gmail.com>
Cc: "open list:FRAMEBUFFER LAYER" <linux-fbdev@vger.kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
boqun.feng@gmail.com, Russell King <linux@armlinux.org.uk>,
"open list:FRAMEBUFFER LAYER" <dri-devel@lists.freedesktop.org>,
linux-kernel@vger.kernel.org,
"moderated list:CYBERPRO FB DRIVER"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/5] video: Add missing annotation for cyber2000fb_enable_ddc() and cyber2000fb_disable_ddc()
Date: Tue, 7 Apr 2020 21:48:24 +0200 [thread overview]
Message-ID: <20200407194824.GA28801@ravnborg.org> (raw)
In-Reply-To: <20200403160505.2832-3-jbi.octave@gmail.com>
Hi Jules.
On Fri, Apr 03, 2020 at 05:05:02PM +0100, Jules Irenge wrote:
> Sparse reports warnings at cyber2000fb_enable_ddc()
> and cyber2000fb_disable_ddc()
>
> warning: context imbalance in cyber2000fb_enable_ddc()
> - wrong count at exit
>
> warning: context imbalance in cyber2000fb_disable_ddc()
> - unexpected unlock
>
> The root cause is the missing annotation at cyber2000fb_enable_ddc()
> and cyber2000fb_disable_ddc()
>
> Add the missing __acquires(&cfb->reg_b0_lock) annotation
> Add the missing __releases(&cfb->reg_b0_lock) annotation
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Thanks, added to drm-misc-next, so the patch will hit the kernel
when the merge windows opens the next time.
Was this the only locking relevant warning in fbdev?
I would expect a few more.
Sam
> ---
> drivers/video/fbdev/cyber2000fb.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/video/fbdev/cyber2000fb.c b/drivers/video/fbdev/cyber2000fb.c
> index 460826a7ad55..513f58f28b0f 100644
> --- a/drivers/video/fbdev/cyber2000fb.c
> +++ b/drivers/video/fbdev/cyber2000fb.c
> @@ -1160,12 +1160,14 @@ EXPORT_SYMBOL(cyber2000fb_detach);
> #define DDC_SDA_IN (1 << 6)
>
> static void cyber2000fb_enable_ddc(struct cfb_info *cfb)
> + __acquires(&cfb->reg_b0_lock)
> {
> spin_lock(&cfb->reg_b0_lock);
> cyber2000fb_writew(0x1bf, 0x3ce, cfb);
> }
>
> static void cyber2000fb_disable_ddc(struct cfb_info *cfb)
> + __releases(&cfb->reg_b0_lock)
> {
> cyber2000fb_writew(0x0bf, 0x3ce, cfb);
> spin_unlock(&cfb->reg_b0_lock);
> --
> 2.24.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Jules Irenge <jbi.octave@gmail.com>
Cc: "open list:FRAMEBUFFER LAYER" <linux-fbdev@vger.kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
boqun.feng@gmail.com, Russell King <linux@armlinux.org.uk>,
"open list:FRAMEBUFFER LAYER" <dri-devel@lists.freedesktop.org>,
linux-kernel@vger.kernel.org,
"moderated list:CYBERPRO FB DRIVER"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/5] video: Add missing annotation for cyber2000fb_enable_ddc() and cyber2000fb_disable_ddc()
Date: Tue, 7 Apr 2020 21:48:24 +0200 [thread overview]
Message-ID: <20200407194824.GA28801@ravnborg.org> (raw)
In-Reply-To: <20200403160505.2832-3-jbi.octave@gmail.com>
Hi Jules.
On Fri, Apr 03, 2020 at 05:05:02PM +0100, Jules Irenge wrote:
> Sparse reports warnings at cyber2000fb_enable_ddc()
> and cyber2000fb_disable_ddc()
>
> warning: context imbalance in cyber2000fb_enable_ddc()
> - wrong count at exit
>
> warning: context imbalance in cyber2000fb_disable_ddc()
> - unexpected unlock
>
> The root cause is the missing annotation at cyber2000fb_enable_ddc()
> and cyber2000fb_disable_ddc()
>
> Add the missing __acquires(&cfb->reg_b0_lock) annotation
> Add the missing __releases(&cfb->reg_b0_lock) annotation
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Thanks, added to drm-misc-next, so the patch will hit the kernel
when the merge windows opens the next time.
Was this the only locking relevant warning in fbdev?
I would expect a few more.
Sam
> ---
> drivers/video/fbdev/cyber2000fb.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/video/fbdev/cyber2000fb.c b/drivers/video/fbdev/cyber2000fb.c
> index 460826a7ad55..513f58f28b0f 100644
> --- a/drivers/video/fbdev/cyber2000fb.c
> +++ b/drivers/video/fbdev/cyber2000fb.c
> @@ -1160,12 +1160,14 @@ EXPORT_SYMBOL(cyber2000fb_detach);
> #define DDC_SDA_IN (1 << 6)
>
> static void cyber2000fb_enable_ddc(struct cfb_info *cfb)
> + __acquires(&cfb->reg_b0_lock)
> {
> spin_lock(&cfb->reg_b0_lock);
> cyber2000fb_writew(0x1bf, 0x3ce, cfb);
> }
>
> static void cyber2000fb_disable_ddc(struct cfb_info *cfb)
> + __releases(&cfb->reg_b0_lock)
> {
> cyber2000fb_writew(0x0bf, 0x3ce, cfb);
> spin_unlock(&cfb->reg_b0_lock);
> --
> 2.24.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-04-07 19:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0/5>
2020-04-03 16:05 ` [PATCH 0/5] lock warnings cleanup Jules Irenge
2020-04-03 16:05 ` [PATCH 1/5] ipc/msg: Add missing annotation for freeque() Jules Irenge
2020-04-03 16:05 ` [PATCH 2/5] video: Add missing annotation for cyber2000fb_enable_ddc() and cyber2000fb_disable_ddc() Jules Irenge
2020-04-03 16:05 ` Jules Irenge
2020-04-03 16:05 ` Jules Irenge
2020-04-03 16:05 ` Jules Irenge
2020-04-07 19:48 ` Sam Ravnborg [this message]
2020-04-07 19:48 ` Sam Ravnborg
2020-04-07 19:48 ` Sam Ravnborg
2020-04-07 19:48 ` [PATCH 2/5] video: Add missing annotation for cyber2000fb_enable_ddc() and cyber2000fb_disable_d Sam Ravnborg
2020-04-03 16:05 ` [PATCH 3/5] ocfs2: Add missing annotation for dlm_empty_lockres() Jules Irenge
2020-04-03 16:05 ` [Ocfs2-devel] " Jules Irenge
2020-04-03 23:45 ` Joseph Qi
2020-04-03 23:45 ` [Ocfs2-devel] " Joseph Qi
2020-04-16 3:02 ` Andrew Morton
2020-04-16 3:02 ` [Ocfs2-devel] " Andrew Morton
2020-04-03 16:05 ` [PATCH 4/5] libata: Add missing annotation for ata_scsi_rbuf_get() and ata_scsi_rbuf_fill() Jules Irenge
2020-04-03 16:05 ` [PATCH 5/5] ipmi: Add missing annotation for ipmi_ssif_lock_cond() and ipmi_ssif_unlock_cond() Jules Irenge
2020-04-03 18:35 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200407194824.GA28801@ravnborg.org \
--to=sam@ravnborg.org \
--cc=b.zolnierkie@samsung.com \
--cc=boqun.feng@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jbi.octave@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.