From: Daniel Vetter <daniel@ffwll.ch> To: Hans de Goede <hdegoede@redhat.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Sam Ravnborg <sam@ravnborg.org>, DRI Development <dri-devel@lists.freedesktop.org>, Daniel Vetter <daniel.vetter@intel.com> Subject: Re: [PATCH 05/59] drm/vboxvidoe: use managed pci functions Date: Wed, 15 Apr 2020 19:44:18 +0200 [thread overview] Message-ID: <20200415174418.GH3456981@phenom.ffwll.local> (raw) In-Reply-To: <75d2db08-a47f-a331-84bc-b61072da94e8@redhat.com> On Wed, Apr 15, 2020 at 05:03:55PM +0200, Hans de Goede wrote: > Hi, > > On 4/15/20 9:39 AM, Daniel Vetter wrote: > > Allows us to drop the cleanup code on the floor. > > > > Sam noticed in his review: > > > With this change we avoid calling pci_disable_device() > > > twise in case vbox_mm_init() fails. > > > Once in vbox_hw_fini() and once in the error path. > > > > v2: Include Sam's review remarks > > > > Acked-by: Sam Ravnborg <sam@ravnborg.org> > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > > Cc: Hans de Goede <hdegoede@redhat.com> > > --- > > drivers/gpu/drm/vboxvideo/vbox_drv.c | 6 ++---- > > drivers/gpu/drm/vboxvideo/vbox_main.c | 7 +------ > > 2 files changed, 3 insertions(+), 10 deletions(-) > > > > diff --git a/drivers/gpu/drm/vboxvideo/vbox_drv.c b/drivers/gpu/drm/vboxvideo/vbox_drv.c > > index cfa4639c5142..cf2e3e6a2388 100644 > > --- a/drivers/gpu/drm/vboxvideo/vbox_drv.c > > +++ b/drivers/gpu/drm/vboxvideo/vbox_drv.c > > @@ -55,13 +55,13 @@ static int vbox_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > > pci_set_drvdata(pdev, vbox); > > mutex_init(&vbox->hw_mutex); > > - ret = pci_enable_device(pdev); > > + ret = pcim_enable_device(pdev); > > if (ret) > > return ret; > > ret = vbox_hw_init(vbox); > > if (ret) > > - goto err_pci_disable; > > + return ret; > > ret = vbox_mm_init(vbox); > > if (ret) > > @@ -91,8 +91,6 @@ static int vbox_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > > vbox_mm_fini(vbox); > > err_hw_fini: > > vbox_hw_fini(vbox); > > -err_pci_disable: > > - pci_disable_device(pdev); > > return ret; > > } > > diff --git a/drivers/gpu/drm/vboxvideo/vbox_main.c b/drivers/gpu/drm/vboxvideo/vbox_main.c > > index 9dcab115a261..1336ab9795fc 100644 > > --- a/drivers/gpu/drm/vboxvideo/vbox_main.c > > +++ b/drivers/gpu/drm/vboxvideo/vbox_main.c > > @@ -71,8 +71,6 @@ static void vbox_accel_fini(struct vbox_private *vbox) > > for (i = 0; i < vbox->num_crtcs; ++i) > > vbva_disable(&vbox->vbva_info[i], vbox->guest_pool, i); > > - > > - pci_iounmap(vbox->ddev.pdev, vbox->vbva_buffers); > > } > > /* Do we support the 4.3 plus mode hint reporting interface? */ > > This seems to be missing the conversion of the iomap_range call to > the devm equivalent ? : > > drivers/gpu/drm/vboxvideo/vbox_main.c > 44: vbox->vbva_buffers = pci_iomap_range(vbox->ddev.pdev, 0, ... pcim_enable_device is pure magic, it converts _all_ pci_ calls on that device to the managed version. There's no other manged pci_ functions (ok 1-2 more, but they're rather special). -Daniel > > Regards, > > Hans > > > > > > > @@ -125,7 +123,7 @@ int vbox_hw_init(struct vbox_private *vbox) > > /* Create guest-heap mem-pool use 2^4 = 16 byte chunks */ > > vbox->guest_pool = gen_pool_create(4, -1); > > if (!vbox->guest_pool) > > - goto err_unmap_guest_heap; > > + return -ENOMEM; > > ret = gen_pool_add_virt(vbox->guest_pool, > > (unsigned long)vbox->guest_heap, > > @@ -168,8 +166,6 @@ int vbox_hw_init(struct vbox_private *vbox) > > err_destroy_guest_pool: > > gen_pool_destroy(vbox->guest_pool); > > -err_unmap_guest_heap: > > - pci_iounmap(vbox->ddev.pdev, vbox->guest_heap); > > return ret; > > } > > @@ -177,5 +173,4 @@ void vbox_hw_fini(struct vbox_private *vbox) > > { > > vbox_accel_fini(vbox); > > gen_pool_destroy(vbox->guest_pool); > > - pci_iounmap(vbox->ddev.pdev, vbox->guest_heap); > > } > > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch> To: Hans de Goede <hdegoede@redhat.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Sam Ravnborg <sam@ravnborg.org>, DRI Development <dri-devel@lists.freedesktop.org>, Daniel Vetter <daniel.vetter@intel.com> Subject: Re: [Intel-gfx] [PATCH 05/59] drm/vboxvidoe: use managed pci functions Date: Wed, 15 Apr 2020 19:44:18 +0200 [thread overview] Message-ID: <20200415174418.GH3456981@phenom.ffwll.local> (raw) In-Reply-To: <75d2db08-a47f-a331-84bc-b61072da94e8@redhat.com> On Wed, Apr 15, 2020 at 05:03:55PM +0200, Hans de Goede wrote: > Hi, > > On 4/15/20 9:39 AM, Daniel Vetter wrote: > > Allows us to drop the cleanup code on the floor. > > > > Sam noticed in his review: > > > With this change we avoid calling pci_disable_device() > > > twise in case vbox_mm_init() fails. > > > Once in vbox_hw_fini() and once in the error path. > > > > v2: Include Sam's review remarks > > > > Acked-by: Sam Ravnborg <sam@ravnborg.org> > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > > Cc: Hans de Goede <hdegoede@redhat.com> > > --- > > drivers/gpu/drm/vboxvideo/vbox_drv.c | 6 ++---- > > drivers/gpu/drm/vboxvideo/vbox_main.c | 7 +------ > > 2 files changed, 3 insertions(+), 10 deletions(-) > > > > diff --git a/drivers/gpu/drm/vboxvideo/vbox_drv.c b/drivers/gpu/drm/vboxvideo/vbox_drv.c > > index cfa4639c5142..cf2e3e6a2388 100644 > > --- a/drivers/gpu/drm/vboxvideo/vbox_drv.c > > +++ b/drivers/gpu/drm/vboxvideo/vbox_drv.c > > @@ -55,13 +55,13 @@ static int vbox_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > > pci_set_drvdata(pdev, vbox); > > mutex_init(&vbox->hw_mutex); > > - ret = pci_enable_device(pdev); > > + ret = pcim_enable_device(pdev); > > if (ret) > > return ret; > > ret = vbox_hw_init(vbox); > > if (ret) > > - goto err_pci_disable; > > + return ret; > > ret = vbox_mm_init(vbox); > > if (ret) > > @@ -91,8 +91,6 @@ static int vbox_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > > vbox_mm_fini(vbox); > > err_hw_fini: > > vbox_hw_fini(vbox); > > -err_pci_disable: > > - pci_disable_device(pdev); > > return ret; > > } > > diff --git a/drivers/gpu/drm/vboxvideo/vbox_main.c b/drivers/gpu/drm/vboxvideo/vbox_main.c > > index 9dcab115a261..1336ab9795fc 100644 > > --- a/drivers/gpu/drm/vboxvideo/vbox_main.c > > +++ b/drivers/gpu/drm/vboxvideo/vbox_main.c > > @@ -71,8 +71,6 @@ static void vbox_accel_fini(struct vbox_private *vbox) > > for (i = 0; i < vbox->num_crtcs; ++i) > > vbva_disable(&vbox->vbva_info[i], vbox->guest_pool, i); > > - > > - pci_iounmap(vbox->ddev.pdev, vbox->vbva_buffers); > > } > > /* Do we support the 4.3 plus mode hint reporting interface? */ > > This seems to be missing the conversion of the iomap_range call to > the devm equivalent ? : > > drivers/gpu/drm/vboxvideo/vbox_main.c > 44: vbox->vbva_buffers = pci_iomap_range(vbox->ddev.pdev, 0, ... pcim_enable_device is pure magic, it converts _all_ pci_ calls on that device to the managed version. There's no other manged pci_ functions (ok 1-2 more, but they're rather special). -Daniel > > Regards, > > Hans > > > > > > > @@ -125,7 +123,7 @@ int vbox_hw_init(struct vbox_private *vbox) > > /* Create guest-heap mem-pool use 2^4 = 16 byte chunks */ > > vbox->guest_pool = gen_pool_create(4, -1); > > if (!vbox->guest_pool) > > - goto err_unmap_guest_heap; > > + return -ENOMEM; > > ret = gen_pool_add_virt(vbox->guest_pool, > > (unsigned long)vbox->guest_heap, > > @@ -168,8 +166,6 @@ int vbox_hw_init(struct vbox_private *vbox) > > err_destroy_guest_pool: > > gen_pool_destroy(vbox->guest_pool); > > -err_unmap_guest_heap: > > - pci_iounmap(vbox->ddev.pdev, vbox->guest_heap); > > return ret; > > } > > @@ -177,5 +173,4 @@ void vbox_hw_fini(struct vbox_private *vbox) > > { > > vbox_accel_fini(vbox); > > gen_pool_destroy(vbox->guest_pool); > > - pci_iounmap(vbox->ddev.pdev, vbox->guest_heap); > > } > > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-04-15 17:44 UTC|newest] Thread overview: 317+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-15 7:39 [PATCH 00/59] devm_drm_dev_alloc, v2 Daniel Vetter 2020-04-15 7:39 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:39 ` [PATCH 01/59] drm: Add devm_drm_dev_alloc macro Daniel Vetter 2020-04-15 7:39 ` [Intel-gfx] " Daniel Vetter 2020-04-20 13:36 ` Thomas Zimmermann 2020-04-20 13:36 ` [Intel-gfx] " Thomas Zimmermann 2020-04-21 10:45 ` Daniel Vetter 2020-04-21 10:45 ` [Intel-gfx] " Daniel Vetter 2020-04-21 14:03 ` Thomas Zimmermann 2020-04-21 14:03 ` [Intel-gfx] " Thomas Zimmermann 2020-04-21 20:32 ` Sam Ravnborg 2020-04-21 20:32 ` [Intel-gfx] " Sam Ravnborg 2020-04-28 13:06 ` Daniel Vetter 2020-04-28 13:06 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:39 ` [PATCH 02/59] drm/vboxvideo: drop DRM_MTRR_WC #define Daniel Vetter 2020-04-15 7:39 ` [Intel-gfx] " Daniel Vetter 2020-04-15 15:01 ` Hans de Goede 2020-04-15 15:01 ` [Intel-gfx] " Hans de Goede 2020-04-15 7:39 ` [PATCH 03/59] drm/vboxvideo: Use devm_drm_dev_alloc Daniel Vetter 2020-04-15 7:39 ` [Intel-gfx] " Daniel Vetter 2020-04-15 15:02 ` Hans de Goede 2020-04-15 15:02 ` [Intel-gfx] " Hans de Goede 2020-04-24 16:33 ` Sam Ravnborg 2020-04-24 16:33 ` [Intel-gfx] " Sam Ravnborg 2020-04-15 7:39 ` [PATCH 04/59] drm/vboxvideo: Stop using drm_device->dev_private Daniel Vetter 2020-04-15 7:39 ` [Intel-gfx] " Daniel Vetter 2020-04-15 15:02 ` Hans de Goede 2020-04-15 15:02 ` [Intel-gfx] " Hans de Goede 2020-04-15 7:39 ` [PATCH 05/59] drm/vboxvidoe: use managed pci functions Daniel Vetter 2020-04-15 7:39 ` [Intel-gfx] " Daniel Vetter 2020-04-15 15:03 ` Hans de Goede 2020-04-15 15:03 ` [Intel-gfx] " Hans de Goede 2020-04-15 17:44 ` Daniel Vetter [this message] 2020-04-15 17:44 ` Daniel Vetter 2020-04-20 13:16 ` Hans de Goede 2020-04-20 13:16 ` [Intel-gfx] " Hans de Goede 2020-04-15 17:32 ` Thomas Zimmermann 2020-04-15 17:32 ` [Intel-gfx] " Thomas Zimmermann 2020-04-15 7:39 ` [PATCH 06/59] drm/vboxvideo: Use devm_gen_pool_create Daniel Vetter 2020-04-15 7:39 ` [Intel-gfx] " Daniel Vetter 2020-04-15 15:04 ` Hans de Goede 2020-04-15 15:04 ` [Intel-gfx] " Hans de Goede 2020-04-15 7:39 ` [PATCH 07/59] drm/v3d: Don't set drm_device->dev_private Daniel Vetter 2020-04-15 7:39 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:39 ` [PATCH 08/59] drm/v3d: Use devm_drm_dev_alloc Daniel Vetter 2020-04-15 7:39 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:39 ` [PATCH 09/59] drm/v3d: Delete v3d_dev->dev Daniel Vetter 2020-04-15 7:39 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:39 ` [PATCH 10/59] drm/v3d: Delete v3d_dev->pdev Daniel Vetter 2020-04-15 7:39 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:39 ` [PATCH 11/59] drm/udl: Use devm_drm_dev_alloc Daniel Vetter 2020-04-15 7:39 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:55 ` Thomas Zimmermann 2020-04-15 7:55 ` [Intel-gfx] " Thomas Zimmermann 2020-04-24 14:55 ` Sam Ravnborg 2020-04-24 14:55 ` [Intel-gfx] " Sam Ravnborg 2020-04-28 13:18 ` Daniel Vetter 2020-04-28 13:18 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:39 ` [PATCH 12/59] drm/udl: don't set drm_device->dev_private Daniel Vetter 2020-04-15 7:39 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:39 ` [PATCH 13/59] drm/st7735r: Use devm_drm_dev_alloc Daniel Vetter 2020-04-15 7:39 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:39 ` [PATCH 14/59] drm/st7586: " Daniel Vetter 2020-04-15 7:39 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:39 ` [PATCH 15/59] drm/repaper: " Daniel Vetter 2020-04-15 7:39 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:39 ` [PATCH 16/59] drm/mi0283qt: " Daniel Vetter 2020-04-15 7:39 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:39 ` [PATCH 17/59] drm/ili9486: " Daniel Vetter 2020-04-15 7:39 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:39 ` [PATCH 18/59] drm/ili9341: " Daniel Vetter 2020-04-15 7:39 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:39 ` [PATCH 19/59] drm/ili9225: " Daniel Vetter 2020-04-15 7:39 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:39 ` [PATCH 20/59] drm/hx8357d: " Daniel Vetter 2020-04-15 7:39 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:39 ` [PATCH 21/59] drm/gm12u320: " Daniel Vetter 2020-04-15 7:39 ` [Intel-gfx] " Daniel Vetter 2020-04-15 15:04 ` Hans de Goede 2020-04-15 15:04 ` [Intel-gfx] " Hans de Goede 2020-04-15 7:39 ` [PATCH 22/59] drm/gm12u320: Don't use drm_device->dev_private Daniel Vetter 2020-04-15 7:39 ` [Intel-gfx] " Daniel Vetter 2020-04-15 15:05 ` Hans de Goede 2020-04-15 15:05 ` [Intel-gfx] " Hans de Goede 2020-04-15 7:39 ` [PATCH 23/59] drm/tidss: Use devm_drm_dev_alloc Daniel Vetter 2020-04-15 7:39 ` [Intel-gfx] " Daniel Vetter 2020-04-21 11:03 ` Tomi Valkeinen 2020-04-21 11:03 ` [Intel-gfx] " Tomi Valkeinen 2020-04-15 7:39 ` [PATCH 24/59] drm/tidss: Don't use drm_device->dev_private Daniel Vetter 2020-04-15 7:39 ` [Intel-gfx] " Daniel Vetter 2020-04-21 11:05 ` Tomi Valkeinen 2020-04-21 11:05 ` [Intel-gfx] " Tomi Valkeinen 2020-04-15 7:40 ` [PATCH 25/59] drm/tidss: Delete tidss->saved_state Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-21 11:05 ` Tomi Valkeinen 2020-04-21 11:05 ` [Intel-gfx] " Tomi Valkeinen 2020-04-15 7:40 ` [PATCH 26/59] drm/qxl: Use devm_drm_dev_alloc Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:40 ` Daniel Vetter 2020-04-24 15:09 ` Sam Ravnborg 2020-04-24 15:09 ` [Intel-gfx] " Sam Ravnborg 2020-04-24 15:09 ` Sam Ravnborg 2020-04-28 14:00 ` Daniel Vetter 2020-04-28 14:00 ` [Intel-gfx] " Daniel Vetter 2020-04-28 14:00 ` Daniel Vetter 2020-04-28 17:00 ` Sam Ravnborg 2020-04-28 17:00 ` [Intel-gfx] " Sam Ravnborg 2020-04-28 17:00 ` Sam Ravnborg 2020-04-28 18:04 ` Daniel Vetter 2020-04-28 18:04 ` [Intel-gfx] " Daniel Vetter 2020-04-28 18:04 ` Daniel Vetter 2020-04-15 7:40 ` [PATCH 27/59] drm/qxl: Don't use drm_device->dev_private Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:40 ` Daniel Vetter 2020-04-24 15:12 ` Sam Ravnborg 2020-04-24 15:12 ` [Intel-gfx] " Sam Ravnborg 2020-04-24 15:12 ` Sam Ravnborg 2020-04-15 7:40 ` [PATCH 28/59] drm/mcde: Use devm_drm_dev_alloc Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-15 12:20 ` Linus Walleij 2020-04-15 12:20 ` [Intel-gfx] " Linus Walleij 2020-04-15 7:40 ` [PATCH 29/59] drm/mcde: Don't use drm_device->dev_private Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:40 ` [PATCH 30/59] drm/ingenic: Use devm_drm_dev_alloc Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:40 ` [PATCH 31/59] drm/ingenic: Don't set drm_device->dev_private Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:40 ` [PATCH 32/59] drm/komeda: use devm_drm_dev_alloc Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:40 ` [PATCH 33/59] drm/armada: Use devm_drm_dev_alloc Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:40 ` [PATCH 34/59] drm/armada: Don't use drm_device->dev_private Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:40 ` [PATCH 35/59] drm/cirrus: Use devm_drm_dev_alloc Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:40 ` Daniel Vetter 2020-04-15 7:40 ` [PATCH 36/59] drm/cirrus: Don't use drm_device->dev_private Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:40 ` Daniel Vetter 2020-04-15 7:40 ` [PATCH 37/59] drm/cirrus: Move to drm/tiny Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:40 ` Daniel Vetter 2020-04-15 8:01 ` Thomas Zimmermann 2020-04-15 8:01 ` [Intel-gfx] " Thomas Zimmermann 2020-04-15 8:01 ` Thomas Zimmermann 2020-04-15 8:19 ` Daniel Vetter 2020-04-15 8:19 ` [Intel-gfx] " Daniel Vetter 2020-04-15 8:19 ` Daniel Vetter 2020-04-15 8:46 ` Thomas Zimmermann 2020-04-15 8:46 ` [Intel-gfx] " Thomas Zimmermann 2020-04-15 8:46 ` Thomas Zimmermann 2020-04-15 9:31 ` Daniel Vetter 2020-04-15 9:31 ` [Intel-gfx] " Daniel Vetter 2020-04-15 9:31 ` Daniel Vetter 2020-04-21 7:37 ` Gerd Hoffmann 2020-04-21 7:37 ` [Intel-gfx] " Gerd Hoffmann 2020-04-21 7:37 ` Gerd Hoffmann 2020-04-24 16:37 ` Sam Ravnborg 2020-04-24 16:37 ` [Intel-gfx] " Sam Ravnborg 2020-04-24 16:37 ` Sam Ravnborg 2020-04-15 7:40 ` [PATCH 38/59] drm/i915: Use devm_drm_dev_alloc Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-28 18:52 ` Daniel Vetter 2020-04-28 18:52 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:40 ` [PATCH 39/59] drm/arcpgu: Switch to devm_drm_dev_alloc Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-24 16:43 ` Sam Ravnborg 2020-04-24 16:43 ` [Intel-gfx] " Sam Ravnborg 2020-04-15 7:40 ` [PATCH 40/59] drm/arcpgu: Stop using drm_device->dev_private Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-24 16:46 ` Sam Ravnborg 2020-04-24 16:46 ` [Intel-gfx] " Sam Ravnborg 2020-09-04 13:42 ` Daniel Vetter 2020-09-04 13:42 ` [Intel-gfx] " Daniel Vetter 2020-09-04 14:42 ` Sam Ravnborg 2020-09-04 14:42 ` [Intel-gfx] " Sam Ravnborg 2020-04-15 7:40 ` [PATCH 41/59] drm/arcpgu: Delete arcpgu_priv->fb Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-24 16:47 ` Sam Ravnborg 2020-04-24 16:47 ` [Intel-gfx] " Sam Ravnborg 2020-04-15 7:40 ` [PATCH 42/59] drm/arc: Embedded a drm_simple_display_pipe Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-24 17:34 ` Sam Ravnborg 2020-04-24 17:34 ` [Intel-gfx] " Sam Ravnborg 2020-04-15 7:40 ` [PATCH 43/59] drm/arc: Embedd a drm_connector for sim case Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-24 17:34 ` Sam Ravnborg 2020-04-24 17:34 ` [Intel-gfx] " Sam Ravnborg 2020-04-15 7:40 ` [PATCH 44/59] drm/arc: Drop surplus connector registration Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-24 16:51 ` Sam Ravnborg 2020-04-24 16:51 ` [Intel-gfx] " Sam Ravnborg 2020-04-15 7:40 ` [PATCH 45/59] drm/arc: Use drmm_mode_config_cleanup Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-24 17:36 ` Sam Ravnborg 2020-04-24 17:36 ` [Intel-gfx] " Sam Ravnborg 2020-04-15 7:40 ` [PATCH 46/59] drm/arc: Align with simple pipe helpers Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-25 12:24 ` Sam Ravnborg 2020-04-25 12:24 ` [Intel-gfx] " Sam Ravnborg 2020-04-15 7:40 ` [PATCH 47/59] drm/arc: Convert to drm_simple_kms_pipe_helper Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-24 17:40 ` Sam Ravnborg 2020-04-24 17:40 ` [Intel-gfx] " Sam Ravnborg 2020-04-15 7:40 ` [PATCH 48/59] drm/arc: Drop fb/crtc check in arc_pgu_update Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-24 17:45 ` Sam Ravnborg 2020-04-24 17:45 ` [Intel-gfx] " Sam Ravnborg 2020-04-15 7:40 ` [PATCH 49/59] drm/arc: Inline arcpgu_crtc.c Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-24 17:51 ` Sam Ravnborg 2020-04-24 17:51 ` [Intel-gfx] " Sam Ravnborg 2020-04-15 7:40 ` [PATCH 50/59] drm/arc: Inline arcpgu_drm_hdmi_init Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-24 17:54 ` Sam Ravnborg 2020-04-24 17:54 ` [Intel-gfx] " Sam Ravnborg 2020-04-15 7:40 ` [PATCH 51/59] drm/arc: Inline remaining files Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-24 17:56 ` Sam Ravnborg 2020-04-24 17:56 ` [Intel-gfx] " Sam Ravnborg 2020-04-15 7:40 ` [PATCH 52/59] drm/arc: Initialize sim connector before display pipe Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-24 17:58 ` Sam Ravnborg 2020-04-24 17:58 ` [Intel-gfx] " Sam Ravnborg 2020-04-15 7:40 ` [PATCH 53/59] drm/arc: Move to drm/tiny Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-15 8:04 ` Thomas Zimmermann 2020-04-15 8:04 ` [Intel-gfx] " Thomas Zimmermann 2020-04-15 8:22 ` Daniel Vetter 2020-04-15 8:22 ` [Intel-gfx] " Daniel Vetter 2020-04-15 9:45 ` Sam Ravnborg 2020-04-15 9:45 ` [Intel-gfx] " Sam Ravnborg 2020-04-15 12:02 ` Alexey Brodkin 2020-04-15 12:02 ` [Intel-gfx] " Alexey Brodkin 2020-04-15 12:20 ` Daniel Vetter 2020-04-15 12:20 ` [Intel-gfx] " Daniel Vetter 2020-04-28 14:08 ` Daniel Vetter 2020-04-28 14:08 ` [Intel-gfx] " Daniel Vetter 2020-05-08 13:56 ` Alexey Brodkin 2020-05-08 13:56 ` [Intel-gfx] " Alexey Brodkin 2020-05-08 18:07 ` Daniel Vetter 2020-05-08 18:07 ` [Intel-gfx] " Daniel Vetter 2020-06-04 8:05 ` Daniel Vetter 2020-06-04 8:05 ` [Intel-gfx] " Daniel Vetter 2020-06-04 10:38 ` Eugeniy Paltsev 2020-06-04 10:38 ` [Intel-gfx] " Eugeniy Paltsev 2020-06-04 11:19 ` Daniel Vetter 2020-06-04 11:19 ` [Intel-gfx] " Daniel Vetter 2020-06-04 19:00 ` Eugeniy Paltsev 2020-06-04 19:00 ` [Intel-gfx] " Eugeniy Paltsev 2020-06-05 19:55 ` Daniel Vetter 2020-06-05 19:55 ` [Intel-gfx] " Daniel Vetter 2020-06-09 12:08 ` Eugeniy Paltsev 2020-06-09 12:08 ` [Intel-gfx] " Eugeniy Paltsev 2020-06-09 13:02 ` Daniel Vetter 2020-06-09 13:02 ` [Intel-gfx] " Daniel Vetter 2020-07-17 9:04 ` Daniel Vetter 2020-07-17 9:04 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:40 ` [PATCH 54/59] drm/aspeed: Drop aspeed_gfx->fbdev Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:40 ` Daniel Vetter 2020-04-24 18:00 ` Sam Ravnborg 2020-04-24 18:00 ` [Intel-gfx] " Sam Ravnborg 2020-04-24 18:00 ` Sam Ravnborg 2020-04-15 7:40 ` [PATCH 55/59] drm/aspeed: Use devm_drm_dev_alloc Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:40 ` Daniel Vetter 2020-04-24 18:02 ` Sam Ravnborg 2020-04-24 18:02 ` [Intel-gfx] " Sam Ravnborg 2020-04-24 18:02 ` Sam Ravnborg 2020-04-15 7:40 ` [PATCH 56/59] drm/aspeed: Use managed drmm_mode_config_cleanup Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:40 ` Daniel Vetter 2020-04-24 18:10 ` Sam Ravnborg 2020-04-24 18:10 ` [Intel-gfx] " Sam Ravnborg 2020-04-24 18:10 ` Sam Ravnborg 2020-04-28 14:12 ` Daniel Vetter 2020-04-28 14:12 ` [Intel-gfx] " Daniel Vetter 2020-04-28 14:12 ` Daniel Vetter 2020-04-28 17:03 ` Sam Ravnborg 2020-04-28 17:03 ` [Intel-gfx] " Sam Ravnborg 2020-04-28 17:03 ` Sam Ravnborg 2020-04-15 7:40 ` [PATCH 57/59] drm/ast: Use managed pci functions Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:52 ` Thomas Zimmermann 2020-04-15 7:52 ` [Intel-gfx] " Thomas Zimmermann 2020-04-15 8:09 ` Daniel Vetter 2020-04-15 8:09 ` [Intel-gfx] " Daniel Vetter 2020-04-15 8:17 ` Daniel Vetter 2020-04-15 8:17 ` [Intel-gfx] " Daniel Vetter 2020-04-15 12:23 ` Daniel Vetter 2020-04-15 12:23 ` [Intel-gfx] " Daniel Vetter 2020-06-11 12:04 ` Thomas Zimmermann 2020-06-11 12:04 ` [Intel-gfx] " Thomas Zimmermann 2020-06-16 11:55 ` Daniel Vetter 2020-06-16 11:55 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:40 ` [PATCH 58/59] drm/ast: Drop explicit connector register/unregister Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:53 ` Thomas Zimmermann 2020-04-15 7:53 ` [Intel-gfx] " Thomas Zimmermann 2020-04-24 18:11 ` Sam Ravnborg 2020-04-24 18:11 ` [Intel-gfx] " Sam Ravnborg 2020-04-15 7:40 ` [PATCH 59/59] drm/bochs: Remove explicit drm_connector_register Daniel Vetter 2020-04-15 7:40 ` [Intel-gfx] " Daniel Vetter 2020-04-15 7:40 ` Daniel Vetter 2020-04-21 7:39 ` Gerd Hoffmann 2020-04-21 7:39 ` [Intel-gfx] " Gerd Hoffmann 2020-04-21 7:39 ` Gerd Hoffmann 2020-04-24 18:11 ` Sam Ravnborg 2020-04-24 18:11 ` [Intel-gfx] " Sam Ravnborg 2020-04-24 18:11 ` Sam Ravnborg 2020-04-15 8:04 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for devm_drm_dev_alloc, v2 Patchwork 2020-04-15 8:23 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork 2020-04-15 8:26 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2020-04-15 23:45 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2020-06-04 11:58 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for devm_drm_dev_alloc, v2 (rev2) Patchwork 2020-06-04 19:36 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for devm_drm_dev_alloc, v2 (rev3) Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200415174418.GH3456981@phenom.ffwll.local \ --to=daniel@ffwll.ch \ --cc=daniel.vetter@ffwll.ch \ --cc=daniel.vetter@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=hdegoede@redhat.com \ --cc=intel-gfx@lists.freedesktop.org \ --cc=sam@ravnborg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.