From: weiping zhang <zhangweiping@didichuxing.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: <axboe@kernel.dk>, <linux-block@vger.kernel.org>,
Weiping Zhang <zhangweiping@didiglobal.com>
Subject: Re: [PATCH v3 6/7] block: refactor __blk_mq_alloc_rq_map_and_requests
Date: Tue, 21 Apr 2020 21:24:45 +0800 [thread overview]
Message-ID: <20200421132440.GB20391@192.168.3.9> (raw)
In-Reply-To: <e289ea06-c799-8444-2b2a-720f5d75f2c2@acm.org>
On Mon, Apr 20, 2020 at 02:07:13PM -0700, Bart Van Assche wrote:
> On 4/6/20 12:37 PM, Weiping Zhang wrote:
> >This patch add a new member nr_allocated_map_rqs to the
> >struct blk_mq_tag_set to record the number of maps and requests have
> >been allocated for this tagset.
> >
> >Now there is a problem when we increase hardware queue count, we do not
> >allocate maps and request for the new allocated hardware queue, it will
> >be fixed in the next patch.
> >
> >Since request needs lots of memory, it's not easy alloc so many memory
> >dynamically, espeicially when system is under memory pressure.
> >
> >This patch allow nr_hw_queues does not equal to the nr_allocated_map_rqs,
> >to avoid alloc/free memory when change hardware queue count.
>
> It seems to me that patches 6 and 7 combined fix a single issue. How
> about combining these two patches into a single patch?
>
It's ok for me, the reason why I split two patches is that make patch
review more easily, since patch-6 actually does not change original
logic. If you think combined them is more better, I can merge these
two patches.
Thanks
> Thanks,
>
> Bart.
next prev parent reply other threads:[~2020-04-21 13:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 19:35 [PATCH v3 0/7] Fix potential kernel panic when increase hardware queue Weiping Zhang
2020-04-06 19:36 ` [PATCH v3 1/7] block: rename __blk_mq_alloc_rq_map Weiping Zhang
2020-04-20 20:41 ` Bart Van Assche
2020-04-21 1:25 ` Ming Lei
2020-04-21 13:17 ` weiping zhang
2020-04-06 19:36 ` [PATCH v3 2/7] block: rename __blk_mq_alloc_rq_maps Weiping Zhang
2020-04-20 20:46 ` Bart Van Assche
2020-04-06 19:36 ` [PATCH v3 3/7] block: rename blk_mq_alloc_rq_maps Weiping Zhang
2020-04-20 20:47 ` Bart Van Assche
2020-04-06 19:36 ` [PATCH v3 4/7] block: free both map and request Weiping Zhang
2020-04-20 20:58 ` Bart Van Assche
2020-04-21 13:15 ` weiping zhang
2020-04-06 19:37 ` [PATCH v3 5/7] block: save previous hardware queue count before udpate Weiping Zhang
2020-04-20 21:00 ` Bart Van Assche
2020-04-06 19:37 ` [PATCH v3 6/7] block: refactor __blk_mq_alloc_rq_map_and_requests Weiping Zhang
2020-04-20 21:07 ` Bart Van Assche
2020-04-21 13:24 ` weiping zhang [this message]
2020-04-06 19:37 ` [PATCH v3 7/7] block: alloc map and request for new hardware queue Weiping Zhang
2020-04-08 12:25 ` [PATCH v3 0/7] Fix potential kernel panic when increase " Weiping Zhang
2020-04-20 11:15 ` Weiping Zhang
2020-04-20 19:30 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200421132440.GB20391@192.168.3.9 \
--to=zhangweiping@didichuxing.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=linux-block@vger.kernel.org \
--cc=zhangweiping@didiglobal.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.