From: Bart Van Assche <bvanassche@acm.org>
To: axboe@kernel.dk, linux-block@vger.kernel.org,
Weiping Zhang <zhangweiping@didiglobal.com>
Subject: Re: [PATCH v3 3/7] block: rename blk_mq_alloc_rq_maps
Date: Mon, 20 Apr 2020 13:47:30 -0700 [thread overview]
Message-ID: <26c03c0d-ee4b-68aa-2fa8-e0312c955214@acm.org> (raw)
In-Reply-To: <dc8ec91cff01d55ab21a11ffc745023dd223627c.1586199103.git.zhangweiping@didiglobal.com>
On 4/6/20 12:36 PM, Weiping Zhang wrote:
> rename blk_mq_alloc_rq_maps to blk_mq_alloc_rq_map_and_requests,
> this function alloc both map and request, make function name
> align with function.
>
> Signed-off-by: Weiping Zhang <zhangweiping@didiglobal.com>
> ---
> block/blk-mq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index 5a322130aaf2..4692e8232699 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -3000,7 +3000,7 @@ static int __blk_mq_alloc_rq_map_and_requests(struct blk_mq_tag_set *set)
> * may reduce the depth asked for, if memory is tight. set->queue_depth
> * will be updated to reflect the allocated depth.
> */
> -static int blk_mq_alloc_rq_maps(struct blk_mq_tag_set *set)
> +static int blk_mq_alloc_rq_map_and_requests(struct blk_mq_tag_set *set)
> {
> unsigned int depth;
> int err;
> @@ -3160,7 +3160,7 @@ int blk_mq_alloc_tag_set(struct blk_mq_tag_set *set)
> if (ret)
> goto out_free_mq_map;
>
> - ret = blk_mq_alloc_rq_maps(set);
> + ret = blk_mq_alloc_rq_map_and_requests(set);
> if (ret)
> goto out_free_mq_map;
Personally I'm fine with the current name of this function. However,
others may have another opinion.
Thanks,
Bart.
next prev parent reply other threads:[~2020-04-20 20:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 19:35 [PATCH v3 0/7] Fix potential kernel panic when increase hardware queue Weiping Zhang
2020-04-06 19:36 ` [PATCH v3 1/7] block: rename __blk_mq_alloc_rq_map Weiping Zhang
2020-04-20 20:41 ` Bart Van Assche
2020-04-21 1:25 ` Ming Lei
2020-04-21 13:17 ` weiping zhang
2020-04-06 19:36 ` [PATCH v3 2/7] block: rename __blk_mq_alloc_rq_maps Weiping Zhang
2020-04-20 20:46 ` Bart Van Assche
2020-04-06 19:36 ` [PATCH v3 3/7] block: rename blk_mq_alloc_rq_maps Weiping Zhang
2020-04-20 20:47 ` Bart Van Assche [this message]
2020-04-06 19:36 ` [PATCH v3 4/7] block: free both map and request Weiping Zhang
2020-04-20 20:58 ` Bart Van Assche
2020-04-21 13:15 ` weiping zhang
2020-04-06 19:37 ` [PATCH v3 5/7] block: save previous hardware queue count before udpate Weiping Zhang
2020-04-20 21:00 ` Bart Van Assche
2020-04-06 19:37 ` [PATCH v3 6/7] block: refactor __blk_mq_alloc_rq_map_and_requests Weiping Zhang
2020-04-20 21:07 ` Bart Van Assche
2020-04-21 13:24 ` weiping zhang
2020-04-06 19:37 ` [PATCH v3 7/7] block: alloc map and request for new hardware queue Weiping Zhang
2020-04-08 12:25 ` [PATCH v3 0/7] Fix potential kernel panic when increase " Weiping Zhang
2020-04-20 11:15 ` Weiping Zhang
2020-04-20 19:30 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26c03c0d-ee4b-68aa-2fa8-e0312c955214@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=zhangweiping@didiglobal.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.