From: Will Deacon <will@kernel.org>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Julien Thierry <julien.thierry.kdev@gmail.com>,
kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
Raphael Gault <raphael.gault@arm.com>,
Sami Mujawar <sami.mujawar@arm.com>,
Alexandru Elisei <Alexandru.Elisei@arm.com>,
Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH kvmtool v4 0/5] Add CFI flash emulation
Date: Fri, 24 Apr 2020 09:40:51 +0100 [thread overview]
Message-ID: <20200424084051.GA20801@willie-the-truck> (raw)
In-Reply-To: <20200423173844.24220-1-andre.przywara@arm.com>
On Thu, Apr 23, 2020 at 06:38:39PM +0100, Andre Przywara wrote:
> an update for the CFI flash emulation, addressing Alex' comments and
> adding direct mapping support.
> The actual code changes to the flash emulation are minimal, mostly this
> is about renaming and cleanups.
> This versions now adds some patches. 1/5 is a required fix, the last
> three patches add mapping support as an extension. See below.
Cheers, this mostly looks good to me. I've left a couple of minor comments,
and I'll give Alexandru a chance to have another look, but hopefully we can
merge it soon.
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will@kernel.org>
To: Andre Przywara <andre.przywara@arm.com>
Cc: kvm@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>,
Raphael Gault <raphael.gault@arm.com>,
Sami Mujawar <sami.mujawar@arm.com>,
kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH kvmtool v4 0/5] Add CFI flash emulation
Date: Fri, 24 Apr 2020 09:40:51 +0100 [thread overview]
Message-ID: <20200424084051.GA20801@willie-the-truck> (raw)
In-Reply-To: <20200423173844.24220-1-andre.przywara@arm.com>
On Thu, Apr 23, 2020 at 06:38:39PM +0100, Andre Przywara wrote:
> an update for the CFI flash emulation, addressing Alex' comments and
> adding direct mapping support.
> The actual code changes to the flash emulation are minimal, mostly this
> is about renaming and cleanups.
> This versions now adds some patches. 1/5 is a required fix, the last
> three patches add mapping support as an extension. See below.
Cheers, this mostly looks good to me. I've left a couple of minor comments,
and I'll give Alexandru a chance to have another look, but hopefully we can
merge it soon.
Will
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2020-04-24 8:40 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 17:38 [PATCH kvmtool v4 0/5] Add CFI flash emulation Andre Przywara
2020-04-23 17:38 ` Andre Przywara
2020-04-23 17:38 ` [PATCH kvmtool v4 1/5] virtio-mmio: Assign IRQ line directly before registering device Andre Przywara
2020-04-23 17:38 ` Andre Przywara
2020-04-24 8:41 ` Will Deacon
2020-04-24 8:41 ` Will Deacon
2020-04-24 8:50 ` André Przywara
2020-04-24 8:50 ` André Przywara
2020-04-24 9:51 ` Will Deacon
2020-04-24 9:51 ` Will Deacon
2020-04-23 17:38 ` [PATCH kvmtool v4 2/5] Add emulation for CFI compatible flash memory Andre Przywara
2020-04-23 17:38 ` Andre Przywara
2020-04-23 17:38 ` [PATCH kvmtool v4 3/5] vfio: Destroy memslot when unmapping the associated VAs Andre Przywara
2020-04-23 17:38 ` Andre Przywara
2020-04-23 17:38 ` [PATCH kvmtool v4 4/5] memslot: Add support for READONLY mappings Andre Przywara
2020-04-23 17:38 ` Andre Przywara
2020-04-24 8:41 ` Will Deacon
2020-04-24 8:41 ` Will Deacon
2020-04-23 17:38 ` [PATCH kvmtool v4 5/5] cfi-flash: Add support for mapping flash into guest Andre Przywara
2020-04-23 17:38 ` Andre Przywara
2020-04-23 17:55 ` [PATCH kvmtool v4 0/5] Add CFI flash emulation Ard Biesheuvel
2020-04-23 17:55 ` Ard Biesheuvel
2020-04-23 20:43 ` Ard Biesheuvel
2020-04-23 20:43 ` Ard Biesheuvel
2020-04-23 21:31 ` André Przywara
2020-04-23 21:31 ` André Przywara
2020-04-24 6:45 ` Ard Biesheuvel
2020-04-24 6:45 ` Ard Biesheuvel
2020-04-24 12:08 ` André Przywara
2020-04-24 12:08 ` André Przywara
2020-04-24 12:25 ` Ard Biesheuvel
2020-04-24 12:25 ` Ard Biesheuvel
2020-04-24 8:40 ` Will Deacon [this message]
2020-04-24 8:40 ` Will Deacon
2020-04-24 17:03 ` Will Deacon
2020-04-24 17:03 ` Will Deacon
2020-04-25 15:16 ` Ard Biesheuvel
2020-04-25 15:16 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424084051.GA20801@willie-the-truck \
--to=will@kernel.org \
--cc=Alexandru.Elisei@arm.com \
--cc=andre.przywara@arm.com \
--cc=ardb@kernel.org \
--cc=julien.thierry.kdev@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=raphael.gault@arm.com \
--cc=sami.mujawar@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.