From: Bjorn Helgaas <helgaas@kernel.org> To: Rob Herring <robh@kernel.org> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org Subject: Re: [PATCH] PCI: Use of_node_name_eq for node name comparisons Date: Fri, 24 Apr 2020 18:03:40 -0500 [thread overview] Message-ID: <20200424230340.GA217775@google.com> (raw) In-Reply-To: <20200416215114.7715-1-robh@kernel.org> On Thu, Apr 16, 2020 at 04:51:14PM -0500, Rob Herring wrote: > Convert string compares of DT node names to use of_node_name_eq helper > instead. This removes direct access to the node name pointer. > > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Cc: Paul Mackerras <paulus@samba.org> > Cc: Michael Ellerman <mpe@ellerman.id.au> > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-pci@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> Applied to pci/hotplug for v5.8, thanks! > --- > drivers/pci/hotplug/rpaphp_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/hotplug/rpaphp_core.c b/drivers/pci/hotplug/rpaphp_core.c > index 6504869efabc..9887c9de08c3 100644 > --- a/drivers/pci/hotplug/rpaphp_core.c > +++ b/drivers/pci/hotplug/rpaphp_core.c > @@ -435,7 +435,7 @@ static int rpaphp_drc_add_slot(struct device_node *dn) > */ > int rpaphp_add_slot(struct device_node *dn) > { > - if (!dn->name || strcmp(dn->name, "pci")) > + if (!of_node_name_eq(dn, "pci")) > return 0; > > if (of_find_property(dn, "ibm,drc-info", NULL)) > -- > 2.20.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org> To: Rob Herring <robh@kernel.org> Cc: linux-pci@vger.kernel.org, Paul Mackerras <paulus@samba.org>, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] PCI: Use of_node_name_eq for node name comparisons Date: Fri, 24 Apr 2020 18:03:40 -0500 [thread overview] Message-ID: <20200424230340.GA217775@google.com> (raw) In-Reply-To: <20200416215114.7715-1-robh@kernel.org> On Thu, Apr 16, 2020 at 04:51:14PM -0500, Rob Herring wrote: > Convert string compares of DT node names to use of_node_name_eq helper > instead. This removes direct access to the node name pointer. > > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Cc: Paul Mackerras <paulus@samba.org> > Cc: Michael Ellerman <mpe@ellerman.id.au> > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-pci@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> Applied to pci/hotplug for v5.8, thanks! > --- > drivers/pci/hotplug/rpaphp_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/hotplug/rpaphp_core.c b/drivers/pci/hotplug/rpaphp_core.c > index 6504869efabc..9887c9de08c3 100644 > --- a/drivers/pci/hotplug/rpaphp_core.c > +++ b/drivers/pci/hotplug/rpaphp_core.c > @@ -435,7 +435,7 @@ static int rpaphp_drc_add_slot(struct device_node *dn) > */ > int rpaphp_add_slot(struct device_node *dn) > { > - if (!dn->name || strcmp(dn->name, "pci")) > + if (!of_node_name_eq(dn, "pci")) > return 0; > > if (of_find_property(dn, "ibm,drc-info", NULL)) > -- > 2.20.1 >
next prev parent reply other threads:[~2020-04-24 23:03 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-16 21:51 [PATCH] PCI: Use of_node_name_eq for node name comparisons Rob Herring 2020-04-16 21:51 ` Rob Herring 2020-04-24 23:03 ` Bjorn Helgaas [this message] 2020-04-24 23:03 ` Bjorn Helgaas -- strict thread matches above, loose matches on Subject: below -- 2018-12-05 19:50 Rob Herring 2018-12-05 19:50 ` Rob Herring 2019-01-22 20:20 ` Bjorn Helgaas 2019-01-22 20:20 ` Bjorn Helgaas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200424230340.GA217775@google.com \ --to=helgaas@kernel.org \ --cc=benh@kernel.crashing.org \ --cc=linux-pci@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mpe@ellerman.id.au \ --cc=paulus@samba.org \ --cc=robh@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.