From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jonathan Bakker <xc-racer2@live.ca>
Cc: kgene@kernel.org, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Paweł Chmiel" <pawel.mikolaj.chmiel@gmail.com>
Subject: Re: [PATCH 06/13] arm: dts: s5pv210: aries: Add support for more devices
Date: Tue, 28 Apr 2020 12:20:26 +0200 [thread overview]
Message-ID: <20200428102026.GB23963@kozik-lap> (raw)
In-Reply-To: <BN6PR04MB0660563639D091548BFCCFF2A3AE0@BN6PR04MB0660.namprd04.prod.outlook.com>
On Sun, Apr 26, 2020 at 11:35:57AM -0700, Jonathan Bakker wrote:
> Add support for following devices:
> - touchkeys connected over i2c-gpio
> - s6e63m0 panel connected over spi-gpio
> - fsa9480 microusb switch over i2c-gpio
> - wm8994 over i2c-gpio (no machine driver yet)
> - all common i2c-gpio devices
Please split it per functionality, e.g.:
1. Add sound,
2. Add panel,
3. Add touchkeys (unless part of panel),
4. The remaining i2c-gpio devices without bindings could go as one.
>
> Signed-off-by: Jonathan Bakker <xc-racer2@live.ca>
> Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com>
> ---
> arch/arm/boot/dts/s5pv210-aries.dtsi | 282 ++++++++++++++++++++--
> arch/arm/boot/dts/s5pv210-fascinate4g.dts | 6 +
> 2 files changed, 270 insertions(+), 18 deletions(-)
>
> diff --git a/arch/arm/boot/dts/s5pv210-aries.dtsi b/arch/arm/boot/dts/s5pv210-aries.dtsi
> index f83df426f2b6..ef966d13d83d 100644
> --- a/arch/arm/boot/dts/s5pv210-aries.dtsi
> +++ b/arch/arm/boot/dts/s5pv210-aries.dtsi
> @@ -12,8 +12,14 @@
> compatible = "samsung,aries", "samsung,s5pv210";
>
> aliases {
> + i2c4 = &i2c_sound;
> + i2c5 = &i2c_accel;
> i2c6 = &i2c_pmic;
> + i2c7 = &i2c_musb;
> i2c9 = &i2c_fuel;
> + i2c10 = &i2c_touchkey;
> + i2c11 = &i2c_prox;
> + i2c12 = &i2c_magnetometer;
> };
>
> memory@30000000 {
> @@ -48,6 +54,18 @@
> gpio = <&gpj1 1 GPIO_ACTIVE_HIGH>;
> };
>
> + touchkey_vdd: regulator-fixed-1 {
> + compatible = "regulator-fixed";
> + regulator-name = "VTOUCH_3.3V";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + enable-active-high;
> + gpio = <&gpj3 2 GPIO_ACTIVE_HIGH>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&touchkey_vdd_ena>;
> + };
> +
> wifi_pwrseq: wifi-pwrseq {
> compatible = "mmc-pwrseq-simple";
> reset-gpios = <&gpg1 2 GPIO_ACTIVE_LOW>;
> @@ -57,7 +75,69 @@
> power-off-delay-us = <500>;
> };
>
> - i2c_pmic: i2c-gpio-0 {
> + i2c_sound: i2c-gpio-0 {
> + compatible = "i2c-gpio";
> + sda-gpios = <&mp05 3 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + scl-gpios = <&mp05 2 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + i2c-gpio,delay-us = <2>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&sound_i2c_pins>;
> +
> + wm8994: wm8994@1a {
> + compatible = "wlf,wm8994";
> + reg = <0x1a>;
> +
> + #sound-dai-cells = <0>;
> +
> + gpio-controller;
> + #gpio-cells = <2>;
> +
> + clocks = <&clocks MOUT_CLKOUT>;
> + clock-names = "MCLK1";
> +
> + AVDD2-supply = <&buck3_reg>;
> + DBVDD-supply = <&buck3_reg>;
No such supply, check the bindings.
> + CPVDD-supply = <&buck3_reg>;
> + SPKVDD1-supply = <&buck3_reg>;
> + SPKVDD2-supply = <&buck3_reg>;
> +
> + wlf,gpio-cfg = <0xa101 0x8100 0x0100 0x0100 0x8100
> + 0xa101 0x0100 0x8100 0x0100 0x0100
> + 0x0100>;
> +
> + wlf,ldo1ena = <&gpf3 4 GPIO_ACTIVE_HIGH>;
> + wlf,ldo2ena = <&gpf3 4 GPIO_ACTIVE_HIGH>;
> +
> + wlf,lineout1-se;
> + wlf,lineout2-se;
> +
> + assigned-clocks = <&clocks MOUT_CLKOUT>;
> + assigned-clock-rates = <0>;
> + assigned-clock-parents = <&xusbxti>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&codec_ldo>;
> + };
> + };
> +
> + i2c_accel: i2c-gpio-1 {
> + compatible = "i2c-gpio";
> + sda-gpios = <&gpj3 6 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + scl-gpios = <&gpj3 7 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + i2c-gpio,delay-us = <2>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&accel_i2c_pins>;
> +
> + /* bma023 accelerometer, no mainline binding */
status disabled ... unless you need it for user-space I2C tools?
> + };
> +
> + i2c_pmic: i2c-gpio-2 {
> compatible = "i2c-gpio";
> sda-gpios = <&gpj4 0 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> scl-gpios = <&gpj4 3 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> @@ -137,8 +217,6 @@
> regulator-name = "VLCD_1.8V";
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
> - /* Till we get panel driver */
> - regulator-always-on;
>
> regulator-state-mem {
> regulator-off-in-suspend;
> @@ -237,8 +315,6 @@
> regulator-name = "VCC_3.0V_LCD";
> regulator-min-microvolt = <3000000>;
> regulator-max-microvolt = <3000000>;
> - /* Till we get panel driver */
> - regulator-always-on;
>
> regulator-state-mem {
> regulator-off-in-suspend;
> @@ -309,7 +385,26 @@
> };
> };
>
> - i2c_fuel: i2c-gpio-1 {
> + i2c_musb: i2c-gpio-3 {
> + compatible = "i2c-gpio";
> + sda-gpios = <&gpj3 4 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + scl-gpios = <&gpj3 5 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + i2c-gpio,delay-us = <2>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&musb_i2c_pins>;
> +
> + fsa9480: musb@25 {
> + compatible = "fcs,fsa9480";
> + reg = <0x25>;
> + interrupt-parent = <&gph2>;
> + interrupts = <7 IRQ_TYPE_EDGE_FALLING>;
> + };
> + };
> +
> + i2c_fuel: i2c-gpio-4 {
> compatible = "i2c-gpio";
> sda-gpios = <&mp05 1 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> scl-gpios = <&mp05 0 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> @@ -328,6 +423,60 @@
> };
> };
>
> + i2c_touchkey: i2c-gpio-5 {
> + compatible = "i2c-gpio";
> + sda-gpios = <&gpj3 0 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + scl-gpios = <&gpj3 1 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + i2c-gpio,delay-us = <2>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&touchkey_i2c_pins>;
> +
> + touchkey@20 {
> + compatible = "cypress,aries-touchkey";
> + reg = <0x20>;
> + vdd-supply = <&touchkey_vdd>;
> + vcc-supply = <&buck3_reg>;
> + linux,keycodes = <KEY_MENU KEY_BACK
> + KEY_HOMEPAGE KEY_SEARCH>;
> + interrupt-parent = <&gpj4>;
> + interrupts = <1 IRQ_TYPE_LEVEL_LOW>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&touchkey_irq>;
> + };
> + };
> +
> + i2c_prox: i2c-gpio-6 {
> + compatible = "i2c-gpio";
> + sda-gpios = <&gpg2 2 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + scl-gpios = <&gpg0 2 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + i2c-gpio,delay-us = <2>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&prox_i2c_pins>;
> +
> + /* Sharp gp2a prox/light sensor, incomplete mainline binding */
The same - disable, unless you access it from user-space.
> + };
> +
> + i2c_magnetometer: i2c-gpio-7 {
> + compatible = "i2c-gpio";
> + sda-gpios = <&gpj0 1 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + scl-gpios = <&gpj0 0 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + i2c-gpio,delay-us = <2>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&magnetometer_i2c_pins>;
> +
> + /* Yamaha yas529 magnetometer, no mainline binding */
The same - disable, unless you access it from user-space.
> + };
> +
> vibrator: pwm-vibrator {
> compatible = "pwm-vibrator";
> pwms = <&pwm 1 44642 0>;
> @@ -343,6 +492,39 @@
> offset = <0x681c>; /* PS_HOLD_CONTROL */
> value = <0x5200>;
> };
> +
> + spi_lcd: spi-gpio-0 {
> + compatible = "spi-gpio";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + sck-gpios = <&mp04 1 GPIO_ACTIVE_HIGH>;
> + mosi-gpios = <&mp04 3 GPIO_ACTIVE_HIGH>;
> + cs-gpios = <&mp01 1 GPIO_ACTIVE_HIGH>;
> + num-chipselects = <1>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&lcd_spi_pins>;
> +
> + panel@0 {
> + compatible = "samsung,s6e63m0";
> + reg = <0>;
> + reset-gpios = <&mp05 5 GPIO_ACTIVE_LOW>;
> + vdd3-supply = <&ldo7_reg>;
> + vci-supply = <&ldo17_reg>;
> + spi-cs-high;
> + spi-max-frequency = <1200000>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&panel_rst>;
> +
> + port {
> + lcd_ep: endpoint {
> + remote-endpoint = <&fimd_ep>;
> + };
> + };
> + };
> + };
> };
>
> &fimd {
> @@ -353,18 +535,13 @@
> samsung,invert-vden;
> samsung,invert-vclk;
>
> - display-timings {
> - timing-0 {
> - /* 480x800@60Hz */
> - clock-frequency = <25628040>;
> - hactive = <480>;
> - vactive = <800>;
> - hfront-porch = <16>;
> - hback-porch = <16>;
> - hsync-len = <2>;
> - vfront-porch = <28>;
> - vback-porch = <1>;
> - vsync-len = <2>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@3 {
> + reg = <3>;
> + fimd_ep: endpoint {
> + remote-endpoint = <&lcd_ep>;
> };
> };
> };
> @@ -405,6 +582,19 @@
> samsung,pin-val = <1>;
> };
>
> + codec_ldo: codec-ldo {
> + samsung,pins = "gpf3-4";
> + samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
> + samsung,pin-pud = <S3C64XX_PIN_PULL_NONE>;
> + };
> +
> + prox_i2c_pins: gp2a-i2c-pins {
> + samsung,pins = "gpg0-2", "gpg2-2";
> + samsung,pin-function = <EXYNOS_PIN_FUNC_F>;
> + samsung,pin-pud = <S3C64XX_PIN_PULL_NONE>;
> + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> + };
> +
> wlan_gpio_rst: wlan-gpio-rst {
> samsung,pins = "gpg1-2";
> samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
> @@ -438,6 +628,13 @@
> samsung,pin-pud = <S3C64XX_PIN_PULL_NONE>;
> };
>
> + magnetometer_i2c_pins: yas529-i2c-pins {
> + samsung,pins = "gpj0-0", "gpj0-1";
> + samsung,pin-function = <EXYNOS_PIN_FUNC_F>;
> + samsung,pin-pud = <S3C64XX_PIN_PULL_NONE>;
> + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> + };
> +
> ts_irq: ts-irq {
> samsung,pins = "gpj0-5";
> samsung,pin-function = <EXYNOS_PIN_FUNC_INPUT>;
> @@ -445,17 +642,66 @@
> samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> };
>
> + touchkey_i2c_pins: touchkey-i2c-pins {
> + samsung,pins = "gpj3-0", "gpj3-1";
> + samsung,pin-pud = <S3C64XX_PIN_PULL_NONE>;
> + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> + };
> +
> + touchkey_vdd_ena: touchkey-vdd-ena {
> + samsung,pins = "gpj3-2";
> + samsung,pin-pud = <S3C64XX_PIN_PULL_NONE>;
> + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> + };
> +
> + musb_i2c_pins: musb-i2c-pins {
> + samsung,pins = "gpj3-4", "gpj3-5";
> + samsung,pin-pud = <S3C64XX_PIN_PULL_NONE>;
> + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> + };
> +
> + accel_i2c_pins: accel-i2c-pins {
> + samsung,pins = "gpj3-6", "gpj3-7";
> + samsung,pin-pud = <S3C64XX_PIN_PULL_NONE>;
> + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> + };
> +
> pmic_i2c_pins: pmic-i2c-pins {
> samsung,pins = "gpj4-0", "gpj4-3";
> samsung,pin-pud = <S3C64XX_PIN_PULL_NONE>;
> samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> };
>
> + touchkey_irq: touchkey-irq {
> + samsung,pins = "gpj4-1";
> + samsung,pin-function = <EXYNOS_PIN_FUNC_INPUT>;
> + samsung,pin-pud = <S3C64XX_PIN_PULL_UP>;
> + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> + };
> +
> + lcd_spi_pins: spi-lcd-pins {
> + samsung,pins = "mp01-1", "mp04-1", "mp04-3";
> + samsung,pin-pud = <S3C64XX_PIN_PULL_NONE>;
> + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> + };
> +
> fg_i2c_pins: fg-i2c-pins {
> samsung,pins = "mp05-0", "mp05-1";
> samsung,pin-pud = <S3C64XX_PIN_PULL_NONE>;
> samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> };
> +
> + sound_i2c_pins: sound-i2c-pins {
> + samsung,pins = "mp05-2", "mp05-3";
> + samsung,pin-pud = <S3C64XX_PIN_PULL_NONE>;
> + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> + };
> +
> + panel_rst: panel-rst {
> + samsung,pins = "mp05-5";
> + samsung,pin-pud = <S3C64XX_PIN_PULL_NONE>;
> + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> + };
> };
>
> &pwm {
> diff --git a/arch/arm/boot/dts/s5pv210-fascinate4g.dts b/arch/arm/boot/dts/s5pv210-fascinate4g.dts
> index 94dcb9b64b9a..42e6e2de197d 100644
> --- a/arch/arm/boot/dts/s5pv210-fascinate4g.dts
> +++ b/arch/arm/boot/dts/s5pv210-fascinate4g.dts
> @@ -278,3 +278,9 @@
> PIN_SLP(mp07-7, INPUT, DOWN);
> };
> };
> +
> +&wm8994 {
> + /* GPIO3 (BCLK2) and GPIO4 (LRCLK2) as outputs */
> + wlf,gpio-cfg = <0xa101 0x8100 0x8100 0x8100 0x8100 0xa101
> + 0x0100 0x8100 0x0100 0x0100 0x0100>;
Indent the line till opening <.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jonathan Bakker <xc-racer2@live.ca>
Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
kgene@kernel.org, linux-arm-kernel@lists.infradead.org,
"Paweł Chmiel" <pawel.mikolaj.chmiel@gmail.com>
Subject: Re: [PATCH 06/13] arm: dts: s5pv210: aries: Add support for more devices
Date: Tue, 28 Apr 2020 12:20:26 +0200 [thread overview]
Message-ID: <20200428102026.GB23963@kozik-lap> (raw)
In-Reply-To: <BN6PR04MB0660563639D091548BFCCFF2A3AE0@BN6PR04MB0660.namprd04.prod.outlook.com>
On Sun, Apr 26, 2020 at 11:35:57AM -0700, Jonathan Bakker wrote:
> Add support for following devices:
> - touchkeys connected over i2c-gpio
> - s6e63m0 panel connected over spi-gpio
> - fsa9480 microusb switch over i2c-gpio
> - wm8994 over i2c-gpio (no machine driver yet)
> - all common i2c-gpio devices
Please split it per functionality, e.g.:
1. Add sound,
2. Add panel,
3. Add touchkeys (unless part of panel),
4. The remaining i2c-gpio devices without bindings could go as one.
>
> Signed-off-by: Jonathan Bakker <xc-racer2@live.ca>
> Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com>
> ---
> arch/arm/boot/dts/s5pv210-aries.dtsi | 282 ++++++++++++++++++++--
> arch/arm/boot/dts/s5pv210-fascinate4g.dts | 6 +
> 2 files changed, 270 insertions(+), 18 deletions(-)
>
> diff --git a/arch/arm/boot/dts/s5pv210-aries.dtsi b/arch/arm/boot/dts/s5pv210-aries.dtsi
> index f83df426f2b6..ef966d13d83d 100644
> --- a/arch/arm/boot/dts/s5pv210-aries.dtsi
> +++ b/arch/arm/boot/dts/s5pv210-aries.dtsi
> @@ -12,8 +12,14 @@
> compatible = "samsung,aries", "samsung,s5pv210";
>
> aliases {
> + i2c4 = &i2c_sound;
> + i2c5 = &i2c_accel;
> i2c6 = &i2c_pmic;
> + i2c7 = &i2c_musb;
> i2c9 = &i2c_fuel;
> + i2c10 = &i2c_touchkey;
> + i2c11 = &i2c_prox;
> + i2c12 = &i2c_magnetometer;
> };
>
> memory@30000000 {
> @@ -48,6 +54,18 @@
> gpio = <&gpj1 1 GPIO_ACTIVE_HIGH>;
> };
>
> + touchkey_vdd: regulator-fixed-1 {
> + compatible = "regulator-fixed";
> + regulator-name = "VTOUCH_3.3V";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + enable-active-high;
> + gpio = <&gpj3 2 GPIO_ACTIVE_HIGH>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&touchkey_vdd_ena>;
> + };
> +
> wifi_pwrseq: wifi-pwrseq {
> compatible = "mmc-pwrseq-simple";
> reset-gpios = <&gpg1 2 GPIO_ACTIVE_LOW>;
> @@ -57,7 +75,69 @@
> power-off-delay-us = <500>;
> };
>
> - i2c_pmic: i2c-gpio-0 {
> + i2c_sound: i2c-gpio-0 {
> + compatible = "i2c-gpio";
> + sda-gpios = <&mp05 3 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + scl-gpios = <&mp05 2 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + i2c-gpio,delay-us = <2>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&sound_i2c_pins>;
> +
> + wm8994: wm8994@1a {
> + compatible = "wlf,wm8994";
> + reg = <0x1a>;
> +
> + #sound-dai-cells = <0>;
> +
> + gpio-controller;
> + #gpio-cells = <2>;
> +
> + clocks = <&clocks MOUT_CLKOUT>;
> + clock-names = "MCLK1";
> +
> + AVDD2-supply = <&buck3_reg>;
> + DBVDD-supply = <&buck3_reg>;
No such supply, check the bindings.
> + CPVDD-supply = <&buck3_reg>;
> + SPKVDD1-supply = <&buck3_reg>;
> + SPKVDD2-supply = <&buck3_reg>;
> +
> + wlf,gpio-cfg = <0xa101 0x8100 0x0100 0x0100 0x8100
> + 0xa101 0x0100 0x8100 0x0100 0x0100
> + 0x0100>;
> +
> + wlf,ldo1ena = <&gpf3 4 GPIO_ACTIVE_HIGH>;
> + wlf,ldo2ena = <&gpf3 4 GPIO_ACTIVE_HIGH>;
> +
> + wlf,lineout1-se;
> + wlf,lineout2-se;
> +
> + assigned-clocks = <&clocks MOUT_CLKOUT>;
> + assigned-clock-rates = <0>;
> + assigned-clock-parents = <&xusbxti>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&codec_ldo>;
> + };
> + };
> +
> + i2c_accel: i2c-gpio-1 {
> + compatible = "i2c-gpio";
> + sda-gpios = <&gpj3 6 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + scl-gpios = <&gpj3 7 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + i2c-gpio,delay-us = <2>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&accel_i2c_pins>;
> +
> + /* bma023 accelerometer, no mainline binding */
status disabled ... unless you need it for user-space I2C tools?
> + };
> +
> + i2c_pmic: i2c-gpio-2 {
> compatible = "i2c-gpio";
> sda-gpios = <&gpj4 0 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> scl-gpios = <&gpj4 3 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> @@ -137,8 +217,6 @@
> regulator-name = "VLCD_1.8V";
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
> - /* Till we get panel driver */
> - regulator-always-on;
>
> regulator-state-mem {
> regulator-off-in-suspend;
> @@ -237,8 +315,6 @@
> regulator-name = "VCC_3.0V_LCD";
> regulator-min-microvolt = <3000000>;
> regulator-max-microvolt = <3000000>;
> - /* Till we get panel driver */
> - regulator-always-on;
>
> regulator-state-mem {
> regulator-off-in-suspend;
> @@ -309,7 +385,26 @@
> };
> };
>
> - i2c_fuel: i2c-gpio-1 {
> + i2c_musb: i2c-gpio-3 {
> + compatible = "i2c-gpio";
> + sda-gpios = <&gpj3 4 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + scl-gpios = <&gpj3 5 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + i2c-gpio,delay-us = <2>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&musb_i2c_pins>;
> +
> + fsa9480: musb@25 {
> + compatible = "fcs,fsa9480";
> + reg = <0x25>;
> + interrupt-parent = <&gph2>;
> + interrupts = <7 IRQ_TYPE_EDGE_FALLING>;
> + };
> + };
> +
> + i2c_fuel: i2c-gpio-4 {
> compatible = "i2c-gpio";
> sda-gpios = <&mp05 1 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> scl-gpios = <&mp05 0 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> @@ -328,6 +423,60 @@
> };
> };
>
> + i2c_touchkey: i2c-gpio-5 {
> + compatible = "i2c-gpio";
> + sda-gpios = <&gpj3 0 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + scl-gpios = <&gpj3 1 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + i2c-gpio,delay-us = <2>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&touchkey_i2c_pins>;
> +
> + touchkey@20 {
> + compatible = "cypress,aries-touchkey";
> + reg = <0x20>;
> + vdd-supply = <&touchkey_vdd>;
> + vcc-supply = <&buck3_reg>;
> + linux,keycodes = <KEY_MENU KEY_BACK
> + KEY_HOMEPAGE KEY_SEARCH>;
> + interrupt-parent = <&gpj4>;
> + interrupts = <1 IRQ_TYPE_LEVEL_LOW>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&touchkey_irq>;
> + };
> + };
> +
> + i2c_prox: i2c-gpio-6 {
> + compatible = "i2c-gpio";
> + sda-gpios = <&gpg2 2 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + scl-gpios = <&gpg0 2 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + i2c-gpio,delay-us = <2>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&prox_i2c_pins>;
> +
> + /* Sharp gp2a prox/light sensor, incomplete mainline binding */
The same - disable, unless you access it from user-space.
> + };
> +
> + i2c_magnetometer: i2c-gpio-7 {
> + compatible = "i2c-gpio";
> + sda-gpios = <&gpj0 1 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + scl-gpios = <&gpj0 0 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + i2c-gpio,delay-us = <2>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&magnetometer_i2c_pins>;
> +
> + /* Yamaha yas529 magnetometer, no mainline binding */
The same - disable, unless you access it from user-space.
> + };
> +
> vibrator: pwm-vibrator {
> compatible = "pwm-vibrator";
> pwms = <&pwm 1 44642 0>;
> @@ -343,6 +492,39 @@
> offset = <0x681c>; /* PS_HOLD_CONTROL */
> value = <0x5200>;
> };
> +
> + spi_lcd: spi-gpio-0 {
> + compatible = "spi-gpio";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + sck-gpios = <&mp04 1 GPIO_ACTIVE_HIGH>;
> + mosi-gpios = <&mp04 3 GPIO_ACTIVE_HIGH>;
> + cs-gpios = <&mp01 1 GPIO_ACTIVE_HIGH>;
> + num-chipselects = <1>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&lcd_spi_pins>;
> +
> + panel@0 {
> + compatible = "samsung,s6e63m0";
> + reg = <0>;
> + reset-gpios = <&mp05 5 GPIO_ACTIVE_LOW>;
> + vdd3-supply = <&ldo7_reg>;
> + vci-supply = <&ldo17_reg>;
> + spi-cs-high;
> + spi-max-frequency = <1200000>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&panel_rst>;
> +
> + port {
> + lcd_ep: endpoint {
> + remote-endpoint = <&fimd_ep>;
> + };
> + };
> + };
> + };
> };
>
> &fimd {
> @@ -353,18 +535,13 @@
> samsung,invert-vden;
> samsung,invert-vclk;
>
> - display-timings {
> - timing-0 {
> - /* 480x800@60Hz */
> - clock-frequency = <25628040>;
> - hactive = <480>;
> - vactive = <800>;
> - hfront-porch = <16>;
> - hback-porch = <16>;
> - hsync-len = <2>;
> - vfront-porch = <28>;
> - vback-porch = <1>;
> - vsync-len = <2>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@3 {
> + reg = <3>;
> + fimd_ep: endpoint {
> + remote-endpoint = <&lcd_ep>;
> };
> };
> };
> @@ -405,6 +582,19 @@
> samsung,pin-val = <1>;
> };
>
> + codec_ldo: codec-ldo {
> + samsung,pins = "gpf3-4";
> + samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
> + samsung,pin-pud = <S3C64XX_PIN_PULL_NONE>;
> + };
> +
> + prox_i2c_pins: gp2a-i2c-pins {
> + samsung,pins = "gpg0-2", "gpg2-2";
> + samsung,pin-function = <EXYNOS_PIN_FUNC_F>;
> + samsung,pin-pud = <S3C64XX_PIN_PULL_NONE>;
> + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> + };
> +
> wlan_gpio_rst: wlan-gpio-rst {
> samsung,pins = "gpg1-2";
> samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
> @@ -438,6 +628,13 @@
> samsung,pin-pud = <S3C64XX_PIN_PULL_NONE>;
> };
>
> + magnetometer_i2c_pins: yas529-i2c-pins {
> + samsung,pins = "gpj0-0", "gpj0-1";
> + samsung,pin-function = <EXYNOS_PIN_FUNC_F>;
> + samsung,pin-pud = <S3C64XX_PIN_PULL_NONE>;
> + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> + };
> +
> ts_irq: ts-irq {
> samsung,pins = "gpj0-5";
> samsung,pin-function = <EXYNOS_PIN_FUNC_INPUT>;
> @@ -445,17 +642,66 @@
> samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> };
>
> + touchkey_i2c_pins: touchkey-i2c-pins {
> + samsung,pins = "gpj3-0", "gpj3-1";
> + samsung,pin-pud = <S3C64XX_PIN_PULL_NONE>;
> + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> + };
> +
> + touchkey_vdd_ena: touchkey-vdd-ena {
> + samsung,pins = "gpj3-2";
> + samsung,pin-pud = <S3C64XX_PIN_PULL_NONE>;
> + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> + };
> +
> + musb_i2c_pins: musb-i2c-pins {
> + samsung,pins = "gpj3-4", "gpj3-5";
> + samsung,pin-pud = <S3C64XX_PIN_PULL_NONE>;
> + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> + };
> +
> + accel_i2c_pins: accel-i2c-pins {
> + samsung,pins = "gpj3-6", "gpj3-7";
> + samsung,pin-pud = <S3C64XX_PIN_PULL_NONE>;
> + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> + };
> +
> pmic_i2c_pins: pmic-i2c-pins {
> samsung,pins = "gpj4-0", "gpj4-3";
> samsung,pin-pud = <S3C64XX_PIN_PULL_NONE>;
> samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> };
>
> + touchkey_irq: touchkey-irq {
> + samsung,pins = "gpj4-1";
> + samsung,pin-function = <EXYNOS_PIN_FUNC_INPUT>;
> + samsung,pin-pud = <S3C64XX_PIN_PULL_UP>;
> + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> + };
> +
> + lcd_spi_pins: spi-lcd-pins {
> + samsung,pins = "mp01-1", "mp04-1", "mp04-3";
> + samsung,pin-pud = <S3C64XX_PIN_PULL_NONE>;
> + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> + };
> +
> fg_i2c_pins: fg-i2c-pins {
> samsung,pins = "mp05-0", "mp05-1";
> samsung,pin-pud = <S3C64XX_PIN_PULL_NONE>;
> samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> };
> +
> + sound_i2c_pins: sound-i2c-pins {
> + samsung,pins = "mp05-2", "mp05-3";
> + samsung,pin-pud = <S3C64XX_PIN_PULL_NONE>;
> + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> + };
> +
> + panel_rst: panel-rst {
> + samsung,pins = "mp05-5";
> + samsung,pin-pud = <S3C64XX_PIN_PULL_NONE>;
> + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> + };
> };
>
> &pwm {
> diff --git a/arch/arm/boot/dts/s5pv210-fascinate4g.dts b/arch/arm/boot/dts/s5pv210-fascinate4g.dts
> index 94dcb9b64b9a..42e6e2de197d 100644
> --- a/arch/arm/boot/dts/s5pv210-fascinate4g.dts
> +++ b/arch/arm/boot/dts/s5pv210-fascinate4g.dts
> @@ -278,3 +278,9 @@
> PIN_SLP(mp07-7, INPUT, DOWN);
> };
> };
> +
> +&wm8994 {
> + /* GPIO3 (BCLK2) and GPIO4 (LRCLK2) as outputs */
> + wlf,gpio-cfg = <0xa101 0x8100 0x8100 0x8100 0x8100 0xa101
> + 0x0100 0x8100 0x0100 0x0100 0x0100>;
Indent the line till opening <.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-28 10:20 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200426183604.28494-1-xc-racer2@live.ca>
2020-04-26 18:35 ` [PATCH 01/13] arm: dts: s5pv210: Add helper define for sleep gpio config Jonathan Bakker
2020-04-26 18:35 ` Jonathan Bakker
2020-04-26 18:35 ` [PATCH 02/13] arm: dts: s5pv210: fascinate4g: Add sleep GPIO configuration Jonathan Bakker
2020-04-26 18:35 ` Jonathan Bakker
2020-04-28 10:02 ` Krzysztof Kozlowski
2020-04-28 10:02 ` Krzysztof Kozlowski
2020-04-28 23:49 ` Jonathan Bakker
2020-04-28 23:49 ` Jonathan Bakker
2020-05-01 13:10 ` Krzysztof Kozlowski
2020-05-01 13:10 ` Krzysztof Kozlowski
2020-04-26 18:35 ` [PATCH 03/13] arm: dts: s5pv210: galaxys: " Jonathan Bakker
2020-04-26 18:35 ` Jonathan Bakker
2020-04-26 18:35 ` [PATCH 04/13] arm: dts: s5pv210: aries: Set keep-power-in-suspend for SDHCI1 Jonathan Bakker
2020-04-26 18:35 ` Jonathan Bakker
2020-04-26 18:35 ` [PATCH 05/13] arm: dts: s5pv210: aries: Disable pulls on GPIO i2c adapters Jonathan Bakker
2020-04-26 18:35 ` Jonathan Bakker
2020-04-26 18:35 ` [PATCH 06/13] arm: dts: s5pv210: aries: Add support for more devices Jonathan Bakker
2020-04-26 18:35 ` Jonathan Bakker
2020-04-28 10:20 ` Krzysztof Kozlowski [this message]
2020-04-28 10:20 ` Krzysztof Kozlowski
2020-04-28 23:32 ` Jonathan Bakker
2020-04-28 23:32 ` Jonathan Bakker
2020-05-01 13:31 ` Krzysztof Kozlowski
2020-05-01 13:31 ` Krzysztof Kozlowski
2020-05-01 19:43 ` Jonathan Bakker
2020-05-01 19:43 ` Jonathan Bakker
2020-04-26 18:35 ` [PATCH 07/13] arm: dts: s5pv210: galaxys: Add si470x fmradio Jonathan Bakker
2020-04-26 18:35 ` Jonathan Bakker
2020-04-26 18:35 ` [PATCH 08/13] arm: dts: s5pv210: aries: Disable pull for vibrator ena GPIO Jonathan Bakker
2020-04-26 18:35 ` Jonathan Bakker
2020-04-26 18:36 ` [PATCH 09/13] arm: dts: s5pv210: Add an ADC node Jonathan Bakker
2020-04-26 18:36 ` Jonathan Bakker
2020-04-28 10:26 ` Krzysztof Kozlowski
2020-04-28 10:26 ` Krzysztof Kozlowski
2020-04-28 22:27 ` Jonathan Bakker
2020-04-28 22:27 ` Jonathan Bakker
2020-04-26 18:36 ` [PATCH 10/13] arm: dts: s5pv210: aries: Enable " Jonathan Bakker
2020-04-26 18:36 ` Jonathan Bakker
2020-04-28 10:29 ` Krzysztof Kozlowski
2020-04-28 10:29 ` Krzysztof Kozlowski
2020-04-28 22:26 ` Jonathan Bakker
2020-04-28 22:26 ` Jonathan Bakker
2020-04-26 18:36 ` [PATCH 11/13] arm: dts: s5pv210: Assign clocks to MMC devices Jonathan Bakker
2020-04-26 18:36 ` Jonathan Bakker
2020-04-26 18:36 ` [PATCH 12/13] arm: dts: s5pv210: Correct FIMC definitions Jonathan Bakker
2020-04-26 18:36 ` Jonathan Bakker
2020-04-28 10:32 ` Krzysztof Kozlowski
2020-04-28 10:32 ` Krzysztof Kozlowski
2020-04-28 22:31 ` Jonathan Bakker
2020-04-28 22:31 ` Jonathan Bakker
2020-04-26 18:36 ` [PATCH 13/13] arm: dts: s5pv210: aries: Set MAX8998 GPIO pulls Jonathan Bakker
2020-04-26 18:36 ` Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 00/18] S5PV210 and Aries DTS improvements Jonathan Bakker
2020-05-01 23:50 ` Jonathan Bakker
2020-05-04 15:15 ` Krzysztof Kozlowski
2020-05-04 15:15 ` Krzysztof Kozlowski
[not found] ` <20200501235019.24022-1-xc-racer2@live.ca>
2020-05-01 23:50 ` [PATCH v2 01/18] ARM: dts: s5pv210: Add helper define for sleep gpio config Jonathan Bakker
2020-05-01 23:50 ` Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 02/18] ARM: dts: s5pv210: Add sleep GPIO configuration for fascinate4g Jonathan Bakker
2020-05-01 23:50 ` Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 03/18] ARM: dts: s5pv210: Add sleep GPIO configuration for galaxys Jonathan Bakker
2020-05-01 23:50 ` Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 04/18] ARM: dts: s5pv210: Set keep-power-in-suspend for SDHCI1 on aries Jonathan Bakker
2020-05-01 23:50 ` Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 05/18] ARM: dts: s5pv210: Disable pulls on GPIO i2c adapters for aries Jonathan Bakker
2020-05-01 23:50 ` Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 06/18] ARM: dts: s5pv210: Add WM8994 support to aries boards Jonathan Bakker
2020-05-01 23:50 ` Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 07/18] ARM: dts: s5pv210: Add FSA9480 support to Aries boards Jonathan Bakker
2020-05-01 23:50 ` Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 08/18] ARM: dts: s5pv210: Add touchkey support to aries boards Jonathan Bakker
2020-05-01 23:50 ` Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 09/18] ARM: dts: s5pv210: Add panel " Jonathan Bakker
2020-05-01 23:50 ` Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 10/18] ARM: dts: s5pv210: Add remaining i2c-gpio adapters to aries Jonathan Bakker
2020-05-01 23:50 ` Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 11/18] ARM: dts: s5pv210: Add si470x fmradio to galaxys Jonathan Bakker
2020-05-01 23:50 ` Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 12/18] ARM: dts: s5pv210: Disable pull for vibrator ena GPIO on aries Jonathan Bakker
2020-05-01 23:50 ` Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 13/18] ARM: dts: s5pv210: Add an ADC node Jonathan Bakker
2020-05-01 23:50 ` Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 14/18] ARM: dts: s5pv210: Enable ADC on aries boards Jonathan Bakker
2020-05-01 23:50 ` Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 15/18] ARM: dts: s5pv210: Assign clocks to MMC devices on aries Jonathan Bakker
2020-05-01 23:50 ` Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 16/18] ARM: dts: s5pv210: Correct FIMC definitions Jonathan Bakker
2020-05-01 23:50 ` Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 17/18] ARM: dts: s5pv210: Set MAX8998 GPIO pulls on aries Jonathan Bakker
2020-05-01 23:50 ` Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 18/18] ARM: dts: s5pv210: Correct gpi gpio node name Jonathan Bakker
2020-05-01 23:50 ` Jonathan Bakker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428102026.GB23963@kozik-lap \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=pawel.mikolaj.chmiel@gmail.com \
--cc=robh+dt@kernel.org \
--cc=xc-racer2@live.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.