Re: [PATCH] dt-bindings: thermal: Convert UniPhier thermal monitor to json-schema

From: Rob Herring <robh@kernel.org>
To: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Cc: Zhang Rui <rui.zhang@intel.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Amit Kucheria <amit.kucheria@verdurent.com>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: thermal: Convert UniPhier thermal monitor to json-schema
Date: Tue, 28 Apr 2020 11:20:55 -0500	[thread overview]
Message-ID: <20200428162055.GA27628@bogus> (raw)
In-Reply-To: <1587013935-21760-1-git-send-email-hayashi.kunihiko@socionext.com>

On Thu, Apr 16, 2020 at 02:12:15PM +0900, Kunihiko Hayashi wrote:
> Convert the UniPhier thermal monitor binding to DT schema format.
> 
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
>  .../thermal/socionext,uniphier-thermal.yaml        | 57 +++++++++++++++++++
>  .../bindings/thermal/uniphier-thermal.txt          | 65 ----------------------
>  2 files changed, 57 insertions(+), 65 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml
>  delete mode 100644 Documentation/devicetree/bindings/thermal/uniphier-thermal.txt
> 
> diff --git a/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml b/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml
> new file mode 100644
> index 0000000..bdddc5b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml
> @@ -0,0 +1,57 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/thermal/socionext,uniphier-thermal.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Socionext UniPhier thermal monitor
> +
> +description: |
> +  This describes the devicetree bindings for thermal monitor supported by
> +  PVT(Process, Voltage and Temperature) monitoring unit implemented on
> +  Socionext UniPhier SoCs.
> +
> +maintainers:
> +  - Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - socionext,uniphier-pxs2-thermal
> +      - socionext,uniphier-ld20-thermal
> +      - socionext,uniphier-pxs3-thermal
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  "#thermal-sensor-cells":
> +    const: 0
> +
> +  socionext,tmod-calibration:
> +    $ref: /schemas/types.yaml#/definitions/uint32-array
> +    description:
> +      A pair of calibrated values referred from PVT, in case that the values
> +      aren't set on SoC, like a reference board.

So?:

maxItems: 2

> +
> +required:
> +  - compatible
> +  - interrupts
> +  - "#thermal-sensor-cells"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    // The UniPhier thermal should be a subnode of a "syscon" compatible node.
> +
> +    sysctrl@61840000 {
> +        compatible = "socionext,uniphier-ld20-sysctrl",
> +                     "simple-mfd", "syscon";
> +        reg = <0x61840000 0x10000>;
> +
> +        pvtctl: thermal {
> +                compatible = "socionext,uniphier-ld20-thermal";
> +                interrupts = <0 3 1>;
> +                #thermal-sensor-cells = <0>;
> +        };
> +    };