From: Christoph Hellwig <hch@lst.de>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Arnd Bergmann <arnd@arndb.de>, Christoph Hellwig <hch@lst.de>,
Jeremy Kerr <jk@ozlabs.org>,
linux-kernel@vger.kernel.org,
"Eric W . Biederman" <ebiederm@xmission.com>,
linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org,
Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] fixup! signal: factor copy_siginfo_to_external32 from copy_siginfo_to_user32
Date: Wed, 29 Apr 2020 08:29:33 +0200 [thread overview]
Message-ID: <20200429062933.GB31478@lst.de> (raw)
In-Reply-To: <d00b4436-9a97-5e90-2a6f-e79f90be9736@c-s.fr>
On Wed, Apr 29, 2020 at 08:17:22AM +0200, Christophe Leroy wrote:
>> +#ifndef CONFIG_X86_X32_ABI
>
> Can it be declared __weak instead of enclosing it in an #ifndef ?
I really hate the __weak ifdefs. But my plan was to move to a
CONFIG_ARCH_COPY_SIGINFO_TO_USER32 and have x86 select it.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
"Eric W . Biederman" <ebiederm@xmission.com>,
linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org, Christoph Hellwig <hch@lst.de>,
Jeremy Kerr <jk@ozlabs.org>
Subject: Re: [PATCH] fixup! signal: factor copy_siginfo_to_external32 from copy_siginfo_to_user32
Date: Wed, 29 Apr 2020 08:29:33 +0200 [thread overview]
Message-ID: <20200429062933.GB31478@lst.de> (raw)
In-Reply-To: <d00b4436-9a97-5e90-2a6f-e79f90be9736@c-s.fr>
On Wed, Apr 29, 2020 at 08:17:22AM +0200, Christophe Leroy wrote:
>> +#ifndef CONFIG_X86_X32_ABI
>
> Can it be declared __weak instead of enclosing it in an #ifndef ?
I really hate the __weak ifdefs. But my plan was to move to a
CONFIG_ARCH_COPY_SIGINFO_TO_USER32 and have x86 select it.
next prev parent reply other threads:[~2020-04-29 6:29 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 15:41 remove set_fs calls from the exec and coredump code v3 Christoph Hellwig
2020-04-21 15:41 ` Christoph Hellwig
2020-04-21 15:41 ` [PATCH 1/7] powerpc/spufs: simplify spufs core dumping Christoph Hellwig
2020-04-21 15:41 ` Christoph Hellwig
2020-04-21 18:49 ` Al Viro
2020-04-21 18:49 ` Al Viro
2020-04-21 19:01 ` Christoph Hellwig
2020-04-21 19:01 ` Christoph Hellwig
2020-04-21 19:19 ` Al Viro
2020-04-21 19:19 ` Al Viro
2020-04-21 19:25 ` Al Viro
2020-04-21 19:25 ` Al Viro
2020-04-21 15:41 ` [PATCH 2/7] signal: factor copy_siginfo_to_external32 from copy_siginfo_to_user32 Christoph Hellwig
2020-04-21 15:41 ` Christoph Hellwig
2020-04-26 4:47 ` Andrew Morton
2020-04-26 4:47 ` Andrew Morton
2020-04-26 7:40 ` Christoph Hellwig
2020-04-26 7:40 ` Christoph Hellwig
2020-04-27 22:40 ` Andrew Morton
2020-04-27 22:40 ` Andrew Morton
2020-04-28 7:09 ` Christoph Hellwig
2020-04-28 7:09 ` Christoph Hellwig
2020-04-28 7:45 ` Christophe Leroy
2020-04-28 7:45 ` Christophe Leroy
2020-04-28 7:48 ` Christoph Hellwig
2020-04-28 7:48 ` Christoph Hellwig
2020-04-28 19:56 ` [PATCH] fixup! " Arnd Bergmann
2020-04-28 19:56 ` Arnd Bergmann
2020-04-29 6:17 ` Christophe Leroy
2020-04-29 6:17 ` Christophe Leroy
2020-04-29 6:29 ` Christoph Hellwig [this message]
2020-04-29 6:29 ` Christoph Hellwig
2020-04-29 6:44 ` Christoph Hellwig
2020-04-29 6:44 ` Christoph Hellwig
2020-04-29 8:07 ` Arnd Bergmann
2020-04-29 8:07 ` Arnd Bergmann
2020-04-29 9:42 ` Christoph Hellwig
2020-04-29 9:42 ` Christoph Hellwig
2020-04-29 11:28 ` Arnd Bergmann
2020-04-29 11:28 ` Arnd Bergmann
2020-04-29 11:53 ` Christoph Hellwig
2020-04-29 11:53 ` Christoph Hellwig
2020-04-29 12:34 ` Arnd Bergmann
2020-04-29 12:34 ` Arnd Bergmann
2020-04-21 15:42 ` [PATCH 3/7] binfmt_elf: femove the set_fs in fill_siginfo_note Christoph Hellwig
2020-04-21 15:42 ` Christoph Hellwig
2020-04-21 15:42 ` [PATCH 4/7] binfmt_elf: remove the set_fs(KERNEL_DS) in elf_core_dump Christoph Hellwig
2020-04-21 15:42 ` Christoph Hellwig
2020-04-21 15:42 ` [PATCH 5/7] binfmt_elf_fdpic: remove the set_fs(KERNEL_DS) in elf_fdpic_core_dump Christoph Hellwig
2020-04-21 15:42 ` Christoph Hellwig
2020-04-21 15:42 ` [PATCH 6/7] exec: simplify the copy_strings_kernel calling convention Christoph Hellwig
2020-04-21 15:42 ` Christoph Hellwig
2020-04-21 15:42 ` [PATCH 7/7] exec: open code copy_string_kernel Christoph Hellwig
2020-04-21 15:42 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200429062933.GB31478@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=christophe.leroy@c-s.fr \
--cc=ebiederm@xmission.com \
--cc=jk@ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.