From: Ravi Bangoria <ravi.bangoria@linux.ibm.com> To: mpe@ellerman.id.au, mikey@neuling.org Cc: apopple@linux.ibm.com, paulus@samba.org, npiggin@gmail.com, christophe.leroy@c-s.fr, naveen.n.rao@linux.vnet.ibm.com, peterz@infradead.org, jolsa@kernel.org, oleg@redhat.com, fweisbec@gmail.com, mingo@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, ravi.bangoria@linux.ibm.com Subject: [PATCH v4 08/16] powerpc/watchpoint: Disable all available watchpoints when !dawr_force_enable Date: Thu, 30 Apr 2020 10:04:09 +0530 [thread overview] Message-ID: <20200430043417.30948-9-ravi.bangoria@linux.ibm.com> (raw) In-Reply-To: <20200430043417.30948-1-ravi.bangoria@linux.ibm.com> Instead of disabling only first watchpoint, disable all available watchpoints while clearing dawr_force_enable. Callback function is used only for disabling watchpoint, rename it to disable_dawrs_cb(). And null_brk parameter is not really required while disabling watchpoint, remove it. Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com> Reviewed-by: Michael Neuling <mikey@neuling.org> --- arch/powerpc/kernel/dawr.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/kernel/dawr.c b/arch/powerpc/kernel/dawr.c index 8114ad3a8574..500f52fa4711 100644 --- a/arch/powerpc/kernel/dawr.c +++ b/arch/powerpc/kernel/dawr.c @@ -50,9 +50,13 @@ int set_dawr(int nr, struct arch_hw_breakpoint *brk) return 0; } -static void set_dawr_cb(void *info) +static void disable_dawrs_cb(void *info) { - set_dawr(0, info); + struct arch_hw_breakpoint null_brk = {0}; + int i; + + for (i = 0; i < nr_wp_slots(); i++) + set_dawr(i, &null_brk); } static ssize_t dawr_write_file_bool(struct file *file, @@ -74,7 +78,7 @@ static ssize_t dawr_write_file_bool(struct file *file, /* If we are clearing, make sure all CPUs have the DAWR cleared */ if (!dawr_force_enable) - smp_call_function(set_dawr_cb, &null_brk, 0); + smp_call_function(disable_dawrs_cb, NULL, 0); return rc; } -- 2.21.1
WARNING: multiple messages have this Message-ID (diff)
From: Ravi Bangoria <ravi.bangoria@linux.ibm.com> To: mpe@ellerman.id.au, mikey@neuling.org Cc: apopple@linux.ibm.com, ravi.bangoria@linux.ibm.com, peterz@infradead.org, fweisbec@gmail.com, oleg@redhat.com, npiggin@gmail.com, linux-kernel@vger.kernel.org, paulus@samba.org, jolsa@kernel.org, naveen.n.rao@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org, mingo@kernel.org Subject: [PATCH v4 08/16] powerpc/watchpoint: Disable all available watchpoints when !dawr_force_enable Date: Thu, 30 Apr 2020 10:04:09 +0530 [thread overview] Message-ID: <20200430043417.30948-9-ravi.bangoria@linux.ibm.com> (raw) In-Reply-To: <20200430043417.30948-1-ravi.bangoria@linux.ibm.com> Instead of disabling only first watchpoint, disable all available watchpoints while clearing dawr_force_enable. Callback function is used only for disabling watchpoint, rename it to disable_dawrs_cb(). And null_brk parameter is not really required while disabling watchpoint, remove it. Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com> Reviewed-by: Michael Neuling <mikey@neuling.org> --- arch/powerpc/kernel/dawr.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/kernel/dawr.c b/arch/powerpc/kernel/dawr.c index 8114ad3a8574..500f52fa4711 100644 --- a/arch/powerpc/kernel/dawr.c +++ b/arch/powerpc/kernel/dawr.c @@ -50,9 +50,13 @@ int set_dawr(int nr, struct arch_hw_breakpoint *brk) return 0; } -static void set_dawr_cb(void *info) +static void disable_dawrs_cb(void *info) { - set_dawr(0, info); + struct arch_hw_breakpoint null_brk = {0}; + int i; + + for (i = 0; i < nr_wp_slots(); i++) + set_dawr(i, &null_brk); } static ssize_t dawr_write_file_bool(struct file *file, @@ -74,7 +78,7 @@ static ssize_t dawr_write_file_bool(struct file *file, /* If we are clearing, make sure all CPUs have the DAWR cleared */ if (!dawr_force_enable) - smp_call_function(set_dawr_cb, &null_brk, 0); + smp_call_function(disable_dawrs_cb, NULL, 0); return rc; } -- 2.21.1
next prev parent reply other threads:[~2020-04-30 4:35 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-30 4:34 [PATCH v4 00/16] powerpc/watchpoint: Preparation for more than one watchpoint Ravi Bangoria 2020-04-30 4:34 ` Ravi Bangoria 2020-04-30 4:34 ` [PATCH v4 01/16] powerpc/watchpoint: Rename current DAWR macros Ravi Bangoria 2020-04-30 4:34 ` Ravi Bangoria 2020-04-30 4:34 ` [PATCH v4 02/16] powerpc/watchpoint: Add SPRN macros for second DAWR Ravi Bangoria 2020-04-30 4:34 ` Ravi Bangoria 2020-04-30 4:34 ` [PATCH v4 03/16] powerpc/watchpoint: Introduce function to get nr watchpoints dynamically Ravi Bangoria 2020-04-30 4:34 ` Ravi Bangoria 2020-04-30 4:34 ` [PATCH v4 04/16] powerpc/watchpoint/ptrace: Return actual num of available watchpoints Ravi Bangoria 2020-04-30 4:34 ` Ravi Bangoria 2020-04-30 4:34 ` [PATCH v4 05/16] powerpc/watchpoint: Provide DAWR number to set_dawr Ravi Bangoria 2020-04-30 4:34 ` Ravi Bangoria 2020-04-30 4:34 ` [PATCH v4 06/16] powerpc/watchpoint: Provide DAWR number to __set_breakpoint Ravi Bangoria 2020-04-30 4:34 ` Ravi Bangoria 2020-04-30 4:34 ` [PATCH v4 07/16] powerpc/watchpoint: Get watchpoint count dynamically while disabling them Ravi Bangoria 2020-04-30 4:34 ` Ravi Bangoria 2020-04-30 4:34 ` Ravi Bangoria [this message] 2020-04-30 4:34 ` [PATCH v4 08/16] powerpc/watchpoint: Disable all available watchpoints when !dawr_force_enable Ravi Bangoria 2020-04-30 4:34 ` [PATCH v4 09/16] powerpc/watchpoint: Convert thread_struct->hw_brk to an array Ravi Bangoria 2020-04-30 4:34 ` Ravi Bangoria 2020-04-30 4:34 ` [PATCH v4 10/16] powerpc/watchpoint: Use loop for thread_struct->ptrace_bps Ravi Bangoria 2020-04-30 4:34 ` Ravi Bangoria 2020-04-30 4:34 ` [PATCH v4 11/16] powerpc/watchpoint: Introduce is_ptrace_bp() function Ravi Bangoria 2020-04-30 4:34 ` Ravi Bangoria 2020-04-30 4:34 ` [PATCH v4 12/16] powerpc/watchpoint: Use builtin ALIGN*() macros Ravi Bangoria 2020-04-30 4:34 ` Ravi Bangoria 2020-04-30 4:34 ` [PATCH v4 13/16] powerpc/watchpoint: Prepare handler to handle more than one watcnhpoint Ravi Bangoria 2020-04-30 4:34 ` Ravi Bangoria 2020-04-30 4:34 ` [PATCH v4 14/16] powerpc/watchpoint: Don't allow concurrent perf and ptrace events Ravi Bangoria 2020-04-30 4:34 ` Ravi Bangoria 2020-04-30 4:34 ` [PATCH v4 15/16] powerpc/watchpoint/xmon: Don't allow breakpoint overwriting Ravi Bangoria 2020-04-30 4:34 ` Ravi Bangoria 2020-04-30 4:34 ` [PATCH v4 16/16] powerpc/watchpoint/xmon: Support 2nd dawr Ravi Bangoria 2020-04-30 4:34 ` Ravi Bangoria
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200430043417.30948-9-ravi.bangoria@linux.ibm.com \ --to=ravi.bangoria@linux.ibm.com \ --cc=apopple@linux.ibm.com \ --cc=christophe.leroy@c-s.fr \ --cc=fweisbec@gmail.com \ --cc=jolsa@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mikey@neuling.org \ --cc=mingo@kernel.org \ --cc=mpe@ellerman.id.au \ --cc=naveen.n.rao@linux.vnet.ibm.com \ --cc=npiggin@gmail.com \ --cc=oleg@redhat.com \ --cc=paulus@samba.org \ --cc=peterz@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.