From: David Miller <davem@davemloft.net>
To: weiyongjun1@huawei.com
Cc: grygorii.strashko@ti.com, david@lechnology.com,
linux-omap@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next v2] drivers: net: davinci_mdio: fix potential NULL dereference in davinci_mdio_probe()
Date: Fri, 01 May 2020 15:28:17 -0700 (PDT) [thread overview]
Message-ID: <20200501.152817.688071349221528108.davem@davemloft.net> (raw)
In-Reply-To: <20200429025220.166415-1-weiyongjun1@huawei.com>
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Wed, 29 Apr 2020 02:52:20 +0000
> platform_get_resource() may fail and return NULL, so we should
> better check it's return value to avoid a NULL pointer dereference
> since devm_ioremap() does not check input parameters for null.
>
> This is detected by Coccinelle semantic patch.
>
> @@
> expression pdev, res, n, t, e, e1, e2;
> @@
>
> res = \(platform_get_resource\|platform_get_resource_byname\)(pdev, t, n);
> + if (!res)
> + return -EINVAL;
> ... when != res == NULL
> e = devm_ioremap(e1, res->start, e2);
>
> Fixes: 03f66f067560 ("net: ethernet: ti: davinci_mdio: use devm_ioremap()")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
Applied.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: weiyongjun1@huawei.com
Cc: grygorii.strashko@ti.com, david@lechnology.com,
linux-omap@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next v2] drivers: net: davinci_mdio: fix potential NULL dereference in davinci_mdio_p
Date: Fri, 01 May 2020 22:28:17 +0000 [thread overview]
Message-ID: <20200501.152817.688071349221528108.davem@davemloft.net> (raw)
In-Reply-To: <20200429025220.166415-1-weiyongjun1@huawei.com>
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Wed, 29 Apr 2020 02:52:20 +0000
> platform_get_resource() may fail and return NULL, so we should
> better check it's return value to avoid a NULL pointer dereference
> since devm_ioremap() does not check input parameters for null.
>
> This is detected by Coccinelle semantic patch.
>
> @@
> expression pdev, res, n, t, e, e1, e2;
> @@
>
> res = \(platform_get_resource\|platform_get_resource_byname\)(pdev, t, n);
> + if (!res)
> + return -EINVAL;
> ... when != res = NULL
> e = devm_ioremap(e1, res->start, e2);
>
> Fixes: 03f66f067560 ("net: ethernet: ti: davinci_mdio: use devm_ioremap()")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
Applied.
next prev parent reply other threads:[~2020-05-01 22:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 9:40 [PATCH net-next] drivers: net: davinci_mdio: fix potential NULL dereference in davinci_mdio_probe() Wei Yongjun
2020-04-27 9:40 ` Wei Yongjun
2020-04-27 15:16 ` David Lechner
2020-04-27 15:16 ` [PATCH net-next] drivers: net: davinci_mdio: fix potential NULL dereference in davinci_mdio_prob David Lechner
2020-04-29 2:52 ` [PATCH net-next v2] drivers: net: davinci_mdio: fix potential NULL dereference in davinci_mdio_probe() Wei Yongjun
2020-04-29 2:52 ` [PATCH net-next v2] drivers: net: davinci_mdio: fix potential NULL dereference in davinci_mdio_probe Wei Yongjun
2020-05-01 22:28 ` David Miller [this message]
2020-05-01 22:28 ` [PATCH net-next v2] drivers: net: davinci_mdio: fix potential NULL dereference in davinci_mdio_p David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501.152817.688071349221528108.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david@lechnology.com \
--cc=grygorii.strashko@ti.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.