Re: [PATCH v2 1/2] cpufreq: qoriq: convert to a platform driver

From: Viresh Kumar <viresh.kumar@linaro.org>
To: rjw@rjwysocki.net, Mian Yousaf Kaukab <ykaukab@suse.de>
Cc: linux-pm@vger.kernel.org, andy.tang@nxp.com, sboyd@kernel.org,
	linux-clk@vger.kernel.org, shawnguo@kernel.org,
	leoyang.li@nxp.com, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 1/2] cpufreq: qoriq: convert to a platform driver
Date: Thu, 7 May 2020 10:48:18 +0530	[thread overview]
Message-ID: <20200507051818.xi43yfusjktemd5r@vireshk-i7> (raw)
In-Reply-To: <20200428110125.lobyrsbma6astfmq@vireshk-i7>

On 28-04-20, 16:31, Viresh Kumar wrote:
> On 21-04-20, 10:29, Mian Yousaf Kaukab wrote:
> > The driver has to be manually loaded if it is built as a module. It
> > is neither exporting MODULE_DEVICE_TABLE nor MODULE_ALIAS. Moreover,
> > no platform-device is created (and thus no uevent is sent) for the
> > clockgen nodes it depends on.
> > 
> > Convert the module to a platform driver with its own alias. Moreover,
> > drop whitelisted SOCs. Platform device will be created only for the
> > compatible platforms.
> > 
> > Reviewed-by: Yuantian Tang <andy.tang@nxp.com>
> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> > Signed-off-by: Mian Yousaf Kaukab <ykaukab@suse.de>
> > ---
> > v2:
> >  +Rafael, Stephen, linux-clk
> >  Add Reviewed-by and Acked-by tags
> > 
> >  drivers/cpufreq/qoriq-cpufreq.c | 76 ++++++++++++++++-------------------------
> >  1 file changed, 29 insertions(+), 47 deletions(-)
> 
> @Rafael,
> 
> Though this looks to be PPC stuff, but it is used on both ARM and PPC. Do you
> want to pick them up or should I do that ?

Applied now. Thanks.

-- 
viresh