From: Miquel Raynal <miquel.raynal@bootlin.com> To: "Álvaro Fernández Rojas" <noltari@gmail.com> Cc: computersforpeace@gmail.com, kdasu.kdev@gmail.com, richard@nod.at, vigneshr@ti.com, sumit.semwal@linaro.org, linux-mtd@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org Subject: Re: [PATCH 2/3] nand: brcmnand: fix CS0 layout Date: Mon, 11 May 2020 19:01:56 +0200 [thread overview] Message-ID: <20200511190156.51dcc316@xps13> (raw) In-Reply-To: <20200510151406.2527856-2-noltari@gmail.com> Hi Álvaro, Álvaro Fernández Rojas <noltari@gmail.com> wrote on Sun, 10 May 2020 17:14:05 +0200: > Only v3.3-v5.0 have a different CS0 layout. > v3.3- controllers use the same layout for every CS. I had a hard time what you meant here, just because of the trailing dash. "Controllers before v3.3..." would be more understandable. Also please add a Fixes/Cc: stable tag here. > > Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> > --- > drivers/mtd/nand/raw/brcmnand/brcmnand.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c > index 6a08dd07b058..72b268d8e3a4 100644 > --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c > +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c > @@ -606,8 +606,9 @@ static int brcmnand_revision_init(struct brcmnand_controller *ctrl) > } else { > ctrl->cs_offsets = brcmnand_cs_offsets; > > - /* v5.0 and earlier has a different CS0 offset layout */ > - if (ctrl->nand_version <= 0x0500) > + /* v3.3-5.0 have a different CS0 offset layout */ > + if (ctrl->nand_version >= 0x0303 && > + ctrl->nand_version <= 0x0500) > ctrl->cs0_offsets = brcmnand_cs_offsets_cs0; > } > Thanks, Miquèl
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com> To: "Álvaro Fernández Rojas" <noltari@gmail.com> Cc: vigneshr@ti.com, kdasu.kdev@gmail.com, richard@nod.at, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-mtd@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, computersforpeace@gmail.com, sumit.semwal@linaro.org, linux-media@vger.kernel.org Subject: Re: [PATCH 2/3] nand: brcmnand: fix CS0 layout Date: Mon, 11 May 2020 19:01:56 +0200 [thread overview] Message-ID: <20200511190156.51dcc316@xps13> (raw) In-Reply-To: <20200510151406.2527856-2-noltari@gmail.com> Hi Álvaro, Álvaro Fernández Rojas <noltari@gmail.com> wrote on Sun, 10 May 2020 17:14:05 +0200: > Only v3.3-v5.0 have a different CS0 layout. > v3.3- controllers use the same layout for every CS. I had a hard time what you meant here, just because of the trailing dash. "Controllers before v3.3..." would be more understandable. Also please add a Fixes/Cc: stable tag here. > > Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> > --- > drivers/mtd/nand/raw/brcmnand/brcmnand.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c > index 6a08dd07b058..72b268d8e3a4 100644 > --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c > +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c > @@ -606,8 +606,9 @@ static int brcmnand_revision_init(struct brcmnand_controller *ctrl) > } else { > ctrl->cs_offsets = brcmnand_cs_offsets; > > - /* v5.0 and earlier has a different CS0 offset layout */ > - if (ctrl->nand_version <= 0x0500) > + /* v3.3-5.0 have a different CS0 offset layout */ > + if (ctrl->nand_version >= 0x0303 && > + ctrl->nand_version <= 0x0500) > ctrl->cs0_offsets = brcmnand_cs_offsets_cs0; > } > Thanks, Miquèl ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-05-11 17:02 UTC|newest] Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-10 15:14 [PATCH 1/3] nand: brcmnand: rename v4 registers Álvaro Fernández Rojas 2020-05-10 15:14 ` Álvaro Fernández Rojas 2020-05-10 15:14 ` Álvaro Fernández Rojas 2020-05-10 15:14 ` [PATCH 2/3] nand: brcmnand: fix CS0 layout Álvaro Fernández Rojas 2020-05-10 15:14 ` Álvaro Fernández Rojas 2020-05-10 15:14 ` Álvaro Fernández Rojas 2020-05-11 17:01 ` Miquel Raynal [this message] 2020-05-11 17:01 ` Miquel Raynal 2020-05-10 15:14 ` [PATCH 3/3] nand: brcmnand: support v2.1-v2.2 controllers Álvaro Fernández Rojas 2020-05-10 15:14 ` Álvaro Fernández Rojas 2020-05-10 15:14 ` Álvaro Fernández Rojas 2020-05-10 15:39 ` Florian Fainelli 2020-05-10 15:39 ` Florian Fainelli 2020-05-10 15:39 ` Florian Fainelli 2020-05-11 17:44 ` Miquel Raynal 2020-05-11 17:44 ` Miquel Raynal 2020-05-11 17:03 ` [PATCH 1/3] nand: brcmnand: rename v4 registers Miquel Raynal 2020-05-11 17:03 ` Miquel Raynal 2020-05-11 17:40 ` Miquel Raynal 2020-05-11 17:40 ` Miquel Raynal 2020-05-12 7:33 ` [PATCH v2 0/5] mtd: rawnand: brcmnand: support v2.1-v2.2 controllers Álvaro Fernández Rojas 2020-05-12 7:33 ` Álvaro Fernández Rojas 2020-05-12 7:33 ` Álvaro Fernández Rojas 2020-05-12 7:33 ` [PATCH v2 1/5] mtd: rawnand: brcmnand: rename v4 registers Álvaro Fernández Rojas 2020-05-12 7:33 ` Álvaro Fernández Rojas 2020-05-12 7:33 ` Álvaro Fernández Rojas 2020-05-12 7:33 ` [PATCH v2 2/5] mtd: rawnand: brcmnand: fix CS0 layout Álvaro Fernández Rojas 2020-05-12 7:33 ` Álvaro Fernández Rojas 2020-05-12 7:33 ` Álvaro Fernández Rojas 2020-05-12 7:33 ` [PATCH v2 3/5] mtd: rawnand: brcmnand: rename page sizes Álvaro Fernández Rojas 2020-05-12 7:33 ` Álvaro Fernández Rojas 2020-05-12 7:33 ` Álvaro Fernández Rojas 2020-05-12 7:33 ` [PATCH v2 4/5] dt: bindings: brcmnand: add v2.1 and v2.2 support Álvaro Fernández Rojas 2020-05-12 7:33 ` Álvaro Fernández Rojas 2020-05-12 7:33 ` Álvaro Fernández Rojas 2020-05-12 7:33 ` [PATCH v2 5/5] mtd: rawnand: brcmnand: support v2.1-v2.2 controllers Álvaro Fernández Rojas 2020-05-12 7:33 ` Álvaro Fernández Rojas 2020-05-12 7:33 ` Álvaro Fernández Rojas 2020-05-22 7:25 ` [PATCH v3 0/5] " Álvaro Fernández Rojas 2020-05-22 7:25 ` Álvaro Fernández Rojas 2020-05-22 7:25 ` Álvaro Fernández Rojas 2020-05-22 7:25 ` [PATCH v3 1/5] mtd: rawnand: brcmnand: rename v4 registers Álvaro Fernández Rojas 2020-05-22 7:25 ` Álvaro Fernández Rojas 2020-05-22 7:25 ` Álvaro Fernández Rojas 2020-05-22 7:25 ` [PATCH v3 2/5] mtd: rawnand: brcmnand: fix CS0 layout Álvaro Fernández Rojas 2020-05-22 7:25 ` Álvaro Fernández Rojas 2020-05-22 7:25 ` Álvaro Fernández Rojas 2020-05-22 7:25 ` [PATCH v3 3/5] mtd: rawnand: brcmnand: rename page sizes Álvaro Fernández Rojas 2020-05-22 7:25 ` Álvaro Fernández Rojas 2020-05-22 7:25 ` Álvaro Fernández Rojas 2020-05-22 7:25 ` [PATCH v3 4/5] dt: bindings: brcmnand: add v2.1 and v2.2 support Álvaro Fernández Rojas 2020-05-22 7:25 ` Álvaro Fernández Rojas 2020-05-22 7:25 ` Álvaro Fernández Rojas 2020-05-22 7:25 ` [PATCH v3 5/5] nand: brcmnand: support v2.1-v2.2 controllers Álvaro Fernández Rojas 2020-05-22 7:25 ` Álvaro Fernández Rojas 2020-05-22 7:25 ` Álvaro Fernández Rojas 2020-05-22 11:22 ` Miquel Raynal 2020-05-22 11:22 ` Miquel Raynal 2020-05-22 11:22 ` Miquel Raynal 2020-05-22 12:09 ` Álvaro Fernández Rojas 2020-05-22 12:09 ` Álvaro Fernández Rojas 2020-05-22 12:09 ` Álvaro Fernández Rojas 2020-05-22 12:15 ` [PATCH v4 0/5] mtd: rawnand: " Álvaro Fernández Rojas 2020-05-22 12:15 ` Álvaro Fernández Rojas 2020-05-22 12:15 ` Álvaro Fernández Rojas 2020-05-22 12:15 ` [PATCH v4 1/5] mtd: rawnand: brcmnand: rename v4 registers Álvaro Fernández Rojas 2020-05-22 12:15 ` Álvaro Fernández Rojas 2020-05-22 12:15 ` Álvaro Fernández Rojas 2020-05-22 15:33 ` Florian Fainelli 2020-05-22 15:33 ` Florian Fainelli 2020-05-22 15:33 ` Florian Fainelli 2020-05-24 19:26 ` Miquel Raynal 2020-05-24 19:26 ` Miquel Raynal 2020-05-24 19:26 ` Miquel Raynal 2020-05-22 12:15 ` [PATCH v4 2/5] mtd: rawnand: brcmnand: fix CS0 layout Álvaro Fernández Rojas 2020-05-22 12:15 ` Álvaro Fernández Rojas 2020-05-22 12:15 ` Álvaro Fernández Rojas 2020-05-22 15:35 ` Florian Fainelli 2020-05-22 15:35 ` Florian Fainelli 2020-05-22 15:35 ` Florian Fainelli 2020-05-24 19:26 ` Miquel Raynal 2020-05-24 19:26 ` Miquel Raynal 2020-05-24 19:26 ` Miquel Raynal 2020-05-22 12:15 ` [PATCH v4 3/5] mtd: rawnand: brcmnand: rename page sizes Álvaro Fernández Rojas 2020-05-22 12:15 ` Álvaro Fernández Rojas 2020-05-22 12:15 ` Álvaro Fernández Rojas 2020-05-22 15:35 ` Florian Fainelli 2020-05-22 15:35 ` Florian Fainelli 2020-05-22 15:35 ` Florian Fainelli 2020-05-24 19:26 ` Miquel Raynal 2020-05-24 19:26 ` Miquel Raynal 2020-05-24 19:26 ` Miquel Raynal 2020-05-22 12:15 ` [PATCH v4 4/5] dt: bindings: brcmnand: add v2.1 and v2.2 support Álvaro Fernández Rojas 2020-05-22 12:15 ` Álvaro Fernández Rojas 2020-05-22 12:15 ` Álvaro Fernández Rojas 2020-05-22 15:36 ` Florian Fainelli 2020-05-22 15:36 ` Florian Fainelli 2020-05-22 15:36 ` Florian Fainelli 2020-05-24 19:25 ` Miquel Raynal 2020-05-24 19:25 ` Miquel Raynal 2020-05-24 19:25 ` Miquel Raynal 2020-05-24 19:27 ` Miquel Raynal 2020-05-24 19:27 ` Miquel Raynal 2020-05-24 19:27 ` Miquel Raynal 2020-05-24 21:13 ` Álvaro Fernández Rojas 2020-05-24 22:06 ` Miquel Raynal 2020-05-24 22:06 ` Miquel Raynal 2020-05-24 22:06 ` Miquel Raynal 2020-05-22 12:15 ` [PATCH v4 5/5] mtd: rawnand: brcmnand: support v2.1-v2.2 controllers Álvaro Fernández Rojas 2020-05-22 12:15 ` Álvaro Fernández Rojas 2020-05-22 12:15 ` Álvaro Fernández Rojas 2020-05-22 15:37 ` Florian Fainelli 2020-05-22 15:37 ` Florian Fainelli 2020-05-22 15:37 ` Florian Fainelli 2020-05-24 22:06 ` Miquel Raynal 2020-05-24 22:06 ` Miquel Raynal 2020-05-24 22:06 ` Miquel Raynal
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200511190156.51dcc316@xps13 \ --to=miquel.raynal@bootlin.com \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=computersforpeace@gmail.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=kdasu.kdev@gmail.com \ --cc=linaro-mm-sig@lists.linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=noltari@gmail.com \ --cc=richard@nod.at \ --cc=sumit.semwal@linaro.org \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.