All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: brgl@bgdev.pl
Cc: robh+dt@kernel.org, matthias.bgg@gmail.com, john@phrozen.org,
	sean.wang@mediatek.com, Mark-MC.Lee@mediatek.com,
	kuba@kernel.org, arnd@arndb.de, fparent@baylibre.com,
	hkallweit1@gmail.com, edwin.peer@broadcom.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	stephane.leprovost@mediatek.com, pedro.tsai@mediatek.com,
	andrew.perepech@mediatek.com, bgolaszewski@baylibre.com
Subject: Re: [PATCH v2 05/14] net: core: provide priv_to_netdev()
Date: Tue, 12 May 2020 12:30:46 -0700 (PDT)	[thread overview]
Message-ID: <20200512.123046.2245363690581586050.davem@davemloft.net> (raw)
In-Reply-To: <CAMRc=MdUCkgCo8UndDbhQRZt_tXJJjtR4uM2g05N5ti7Hw1f2w@mail.gmail.com>

From: Bartosz Golaszewski <brgl@bgdev.pl>
Date: Tue, 12 May 2020 08:04:39 +0200

> I will if you insist but would you mind sharing some details on why it
> was removed? To me it still makes more sense than storing the pointer
> to a structure in *that* structure.

Flexibility in implementation of where the private data is located
and how it is allocated.

And yes, I do insist.

WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: brgl@bgdev.pl
Cc: edwin.peer@broadcom.com, devicetree@vger.kernel.org,
	stephane.leprovost@mediatek.com, arnd@arndb.de,
	bgolaszewski@baylibre.com, netdev@vger.kernel.org,
	sean.wang@mediatek.com, linux-kernel@vger.kernel.org,
	pedro.tsai@mediatek.com, fparent@baylibre.com,
	robh+dt@kernel.org, linux-mediatek@lists.infradead.org,
	andrew.perepech@mediatek.com, john@phrozen.org,
	matthias.bgg@gmail.com, kuba@kernel.org,
	Mark-MC.Lee@mediatek.com, linux-arm-kernel@lists.infradead.org,
	hkallweit1@gmail.com
Subject: Re: [PATCH v2 05/14] net: core: provide priv_to_netdev()
Date: Tue, 12 May 2020 12:30:46 -0700 (PDT)	[thread overview]
Message-ID: <20200512.123046.2245363690581586050.davem@davemloft.net> (raw)
In-Reply-To: <CAMRc=MdUCkgCo8UndDbhQRZt_tXJJjtR4uM2g05N5ti7Hw1f2w@mail.gmail.com>

From: Bartosz Golaszewski <brgl@bgdev.pl>
Date: Tue, 12 May 2020 08:04:39 +0200

> I will if you insist but would you mind sharing some details on why it
> was removed? To me it still makes more sense than storing the pointer
> to a structure in *that* structure.

Flexibility in implementation of where the private data is located
and how it is allocated.

And yes, I do insist.

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: brgl@bgdev.pl
Cc: edwin.peer@broadcom.com, devicetree@vger.kernel.org,
	stephane.leprovost@mediatek.com, arnd@arndb.de,
	bgolaszewski@baylibre.com, netdev@vger.kernel.org,
	sean.wang@mediatek.com, linux-kernel@vger.kernel.org,
	pedro.tsai@mediatek.com, fparent@baylibre.com,
	robh+dt@kernel.org, linux-mediatek@lists.infradead.org,
	andrew.perepech@mediatek.com, john@phrozen.org,
	matthias.bgg@gmail.com, kuba@kernel.org,
	Mark-MC.Lee@mediatek.com, linux-arm-kernel@lists.infradead.org,
	hkallweit1@gmail.com
Subject: Re: [PATCH v2 05/14] net: core: provide priv_to_netdev()
Date: Tue, 12 May 2020 12:30:46 -0700 (PDT)	[thread overview]
Message-ID: <20200512.123046.2245363690581586050.davem@davemloft.net> (raw)
In-Reply-To: <CAMRc=MdUCkgCo8UndDbhQRZt_tXJJjtR4uM2g05N5ti7Hw1f2w@mail.gmail.com>

From: Bartosz Golaszewski <brgl@bgdev.pl>
Date: Tue, 12 May 2020 08:04:39 +0200

> I will if you insist but would you mind sharing some details on why it
> was removed? To me it still makes more sense than storing the pointer
> to a structure in *that* structure.

Flexibility in implementation of where the private data is located
and how it is allocated.

And yes, I do insist.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-05-12 19:30 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-11 15:07 [PATCH v2 00/14] mediatek: add support for MediaTek Ethernet MAC Bartosz Golaszewski
2020-05-11 15:07 ` Bartosz Golaszewski
2020-05-11 15:07 ` Bartosz Golaszewski
2020-05-11 15:07 ` [PATCH v2 01/14] dt-bindings: arm: add a binding document for MediaTek PERICFG controller Bartosz Golaszewski
2020-05-11 15:07   ` Bartosz Golaszewski
2020-05-11 15:07   ` Bartosz Golaszewski
2020-05-19 18:28   ` Rob Herring
2020-05-19 18:28     ` Rob Herring
2020-05-19 18:28     ` Rob Herring
2020-05-20  9:19     ` Bartosz Golaszewski
2020-05-20  9:19       ` Bartosz Golaszewski
2020-05-20  9:19       ` Bartosz Golaszewski
2020-05-11 15:07 ` [PATCH v2 02/14] dt-bindings: net: add a binding document for MediaTek Ethernet MAC Bartosz Golaszewski
2020-05-11 15:07   ` Bartosz Golaszewski
2020-05-11 15:07   ` Bartosz Golaszewski
2020-05-11 15:07 ` [PATCH v2 03/14] net: ethernet: mediatek: rename Kconfig prompt Bartosz Golaszewski
2020-05-11 15:07   ` Bartosz Golaszewski
2020-05-11 15:07   ` Bartosz Golaszewski
2020-05-11 15:07 ` [PATCH v2 04/14] net: ethernet: mediatek: remove unnecessary spaces from Makefile Bartosz Golaszewski
2020-05-11 15:07   ` Bartosz Golaszewski
2020-05-11 15:07   ` Bartosz Golaszewski
2020-05-11 15:07 ` [PATCH v2 05/14] net: core: provide priv_to_netdev() Bartosz Golaszewski
2020-05-11 15:07   ` Bartosz Golaszewski
2020-05-11 15:07   ` Bartosz Golaszewski
2020-05-11 16:39   ` Andrew Lunn
2020-05-11 16:39     ` Andrew Lunn
2020-05-11 16:39     ` Andrew Lunn
2020-05-11 20:41   ` David Miller
2020-05-11 20:41     ` David Miller
2020-05-11 20:41     ` David Miller
2020-05-12  6:04     ` Bartosz Golaszewski
2020-05-12  6:04       ` Bartosz Golaszewski
2020-05-12  6:04       ` Bartosz Golaszewski
2020-05-12 19:30       ` David Miller [this message]
2020-05-12 19:30         ` David Miller
2020-05-12 19:30         ` David Miller
2020-05-11 15:07 ` [PATCH v2 06/14] net: move devres helpers into a separate source file Bartosz Golaszewski
2020-05-11 15:07   ` Bartosz Golaszewski
2020-05-11 15:07   ` Bartosz Golaszewski
2020-05-11 15:07 ` [PATCH v2 07/14] net: devres: define a separate devres structure for devm_alloc_etherdev() Bartosz Golaszewski
2020-05-11 15:07   ` Bartosz Golaszewski
2020-05-11 15:07   ` Bartosz Golaszewski
2020-05-11 15:07 ` [PATCH v2 08/14] net: devres: provide devm_register_netdev() Bartosz Golaszewski
2020-05-11 15:07   ` Bartosz Golaszewski
2020-05-11 15:07   ` Bartosz Golaszewski
2020-05-11 15:07 ` [PATCH v2 09/14] net: ethernet: mtk-eth-mac: new driver Bartosz Golaszewski
2020-05-11 15:07   ` Bartosz Golaszewski
2020-05-11 15:07   ` Bartosz Golaszewski
2020-05-11 19:24   ` Florian Fainelli
2020-05-11 19:24     ` Florian Fainelli
2020-05-11 19:24     ` Florian Fainelli
2020-05-12  6:35     ` Bartosz Golaszewski
2020-05-12  6:35       ` Bartosz Golaszewski
2020-05-12  6:35       ` Bartosz Golaszewski
2020-05-11 15:07 ` [PATCH v2 10/14] ARM64: dts: mediatek: add pericfg syscon to mt8516.dtsi Bartosz Golaszewski
2020-05-11 15:07   ` Bartosz Golaszewski
2020-05-11 15:07   ` Bartosz Golaszewski
2020-05-11 15:07 ` [PATCH v2 11/14] ARM64: dts: mediatek: add the ethernet node " Bartosz Golaszewski
2020-05-11 15:07   ` Bartosz Golaszewski
2020-05-11 15:07   ` Bartosz Golaszewski
2020-05-11 15:07 ` [PATCH v2 12/14] ARM64: dts: mediatek: add an alias for ethernet0 for pumpkin boards Bartosz Golaszewski
2020-05-11 15:07   ` Bartosz Golaszewski
2020-05-11 15:07   ` Bartosz Golaszewski
2020-05-11 15:07 ` [PATCH v2 13/14] ARM64: dts: mediatek: add ethernet pins " Bartosz Golaszewski
2020-05-11 15:07   ` Bartosz Golaszewski
2020-05-11 15:07   ` Bartosz Golaszewski
2020-05-11 15:07 ` [PATCH v2 14/14] ARM64: dts: mediatek: enable ethernet on " Bartosz Golaszewski
2020-05-11 15:07   ` Bartosz Golaszewski
2020-05-11 15:07   ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200512.123046.2245363690581586050.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Mark-MC.Lee@mediatek.com \
    --cc=andrew.perepech@mediatek.com \
    --cc=arnd@arndb.de \
    --cc=bgolaszewski@baylibre.com \
    --cc=brgl@bgdev.pl \
    --cc=devicetree@vger.kernel.org \
    --cc=edwin.peer@broadcom.com \
    --cc=fparent@baylibre.com \
    --cc=hkallweit1@gmail.com \
    --cc=john@phrozen.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pedro.tsai@mediatek.com \
    --cc=robh+dt@kernel.org \
    --cc=sean.wang@mediatek.com \
    --cc=stephane.leprovost@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.