From: Brian Foster <bfoster@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
linux-xfs@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] xfs: fix error code in xfs_iflush_cluster()
Date: Wed, 13 May 2020 09:29:04 -0400 [thread overview]
Message-ID: <20200513132904.GE44225@bfoster> (raw)
In-Reply-To: <20200513094803.GF347693@mwanda>
On Wed, May 13, 2020 at 12:48:03PM +0300, Dan Carpenter wrote:
> Originally this function used to always return -EFSCORRUPTED on error
> but now we're trying to return more informative error codes.
> Unfortunately, there was one error path missed. If this kmem_alloc()
> allocation fails then we need to return -ENOMEM instead of success.
>
> Fixes: f20192991d79 ("xfs: simplify inode flush error handling")
This logic predates that patch, and I think it may be by design. Inode
cluster flushing is an optimization to flush other dirty inodes in the
same cluster we're about to queue for writeback. If the cluster flush
fails due to an operational error such as memory allocation failure, we
don't want to report an error because that would shutdown the fs when
otherwise the side effect would be that the other inodes in the cluster
would be flushed individually. This is distinct from failing to flush a
particular inode due to corruption, which is a fatal filesystem error.
Brian
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> fs/xfs/xfs_inode.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
> index ab31a5dec7aab..63aeda7cbafb0 100644
> --- a/fs/xfs/xfs_inode.c
> +++ b/fs/xfs/xfs_inode.c
> @@ -3505,8 +3505,10 @@ xfs_iflush_cluster(
>
> cilist_size = igeo->inodes_per_cluster * sizeof(struct xfs_inode *);
> cilist = kmem_alloc(cilist_size, KM_MAYFAIL|KM_NOFS);
> - if (!cilist)
> + if (!cilist) {
> + error = -ENOMEM;
> goto out_put;
> + }
>
> mask = ~(igeo->inodes_per_cluster - 1);
> first_index = XFS_INO_TO_AGINO(mp, ip->i_ino) & mask;
> --
> 2.26.2
>
WARNING: multiple messages have this Message-ID (diff)
From: Brian Foster <bfoster@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
linux-xfs@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] xfs: fix error code in xfs_iflush_cluster()
Date: Wed, 13 May 2020 13:29:04 +0000 [thread overview]
Message-ID: <20200513132904.GE44225@bfoster> (raw)
In-Reply-To: <20200513094803.GF347693@mwanda>
On Wed, May 13, 2020 at 12:48:03PM +0300, Dan Carpenter wrote:
> Originally this function used to always return -EFSCORRUPTED on error
> but now we're trying to return more informative error codes.
> Unfortunately, there was one error path missed. If this kmem_alloc()
> allocation fails then we need to return -ENOMEM instead of success.
>
> Fixes: f20192991d79 ("xfs: simplify inode flush error handling")
This logic predates that patch, and I think it may be by design. Inode
cluster flushing is an optimization to flush other dirty inodes in the
same cluster we're about to queue for writeback. If the cluster flush
fails due to an operational error such as memory allocation failure, we
don't want to report an error because that would shutdown the fs when
otherwise the side effect would be that the other inodes in the cluster
would be flushed individually. This is distinct from failing to flush a
particular inode due to corruption, which is a fatal filesystem error.
Brian
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> fs/xfs/xfs_inode.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
> index ab31a5dec7aab..63aeda7cbafb0 100644
> --- a/fs/xfs/xfs_inode.c
> +++ b/fs/xfs/xfs_inode.c
> @@ -3505,8 +3505,10 @@ xfs_iflush_cluster(
>
> cilist_size = igeo->inodes_per_cluster * sizeof(struct xfs_inode *);
> cilist = kmem_alloc(cilist_size, KM_MAYFAIL|KM_NOFS);
> - if (!cilist)
> + if (!cilist) {
> + error = -ENOMEM;
> goto out_put;
> + }
>
> mask = ~(igeo->inodes_per_cluster - 1);
> first_index = XFS_INO_TO_AGINO(mp, ip->i_ino) & mask;
> --
> 2.26.2
>
next prev parent reply other threads:[~2020-05-13 13:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 9:48 [PATCH] xfs: fix error code in xfs_iflush_cluster() Dan Carpenter
2020-05-13 9:48 ` Dan Carpenter
2020-05-13 13:29 ` Brian Foster [this message]
2020-05-13 13:29 ` Brian Foster
2020-05-13 13:39 ` Dan Carpenter
2020-05-13 13:39 ` Dan Carpenter
2020-05-13 15:17 ` Darrick J. Wong
2020-05-13 15:17 ` Darrick J. Wong
2020-05-13 21:09 ` Dave Chinner
2020-05-13 21:09 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200513132904.GE44225@bfoster \
--to=bfoster@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=darrick.wong@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.