All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
To: kvm@vger.kernel.org
Cc: linux-remoteproc@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	sound-open-firmware@alsa-project.org,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Liam Girdwood <liam.r.girdwood@linux.intel.com>
Subject: [PATCH 2/6] vhost: (cosmetic) remove a superfluous variable initialisation
Date: Sat, 16 May 2020 12:11:05 +0200	[thread overview]
Message-ID: <20200516101109.2624-3-guennadi.liakhovetski@linux.intel.com> (raw)
In-Reply-To: <20200516101109.2624-1-guennadi.liakhovetski@linux.intel.com>

Even the compiler is able to figure out that in this case the
initialisation is superfluous.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
---
 drivers/vhost/vhost.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 47060d8..e22d4a9 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -895,7 +895,7 @@ static inline void __user *__vhost_get_user(struct vhost_virtqueue *vq,
 
 #define vhost_put_user(vq, x, ptr)		\
 ({ \
-	int ret = -EFAULT; \
+	int ret; \
 	if (!vq->iotlb) { \
 		ret = __put_user(x, ptr); \
 	} else { \
-- 
1.9.3


WARNING: multiple messages have this Message-ID (diff)
From: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
To: kvm@vger.kernel.org
Cc: Liam Girdwood <liam.r.girdwood@linux.intel.com>,
	sound-open-firmware@alsa-project.org,
	linux-remoteproc@vger.kernel.org,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	virtualization@lists.linux-foundation.org
Subject: [PATCH 2/6] vhost: (cosmetic) remove a superfluous variable initialisation
Date: Sat, 16 May 2020 12:11:05 +0200	[thread overview]
Message-ID: <20200516101109.2624-3-guennadi.liakhovetski@linux.intel.com> (raw)
In-Reply-To: <20200516101109.2624-1-guennadi.liakhovetski@linux.intel.com>

Even the compiler is able to figure out that in this case the
initialisation is superfluous.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
---
 drivers/vhost/vhost.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 47060d8..e22d4a9 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -895,7 +895,7 @@ static inline void __user *__vhost_get_user(struct vhost_virtqueue *vq,
 
 #define vhost_put_user(vq, x, ptr)		\
 ({ \
-	int ret = -EFAULT; \
+	int ret; \
 	if (!vq->iotlb) { \
 		ret = __put_user(x, ptr); \
 	} else { \
-- 
1.9.3

  parent reply	other threads:[~2020-05-16 10:11 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-16 10:11 [PATCH 0/6] Add a vhost RPMsg API Guennadi Liakhovetski
2020-05-16 10:11 ` Guennadi Liakhovetski
2020-05-16 10:11 ` [PATCH 1/6] vhost: convert VHOST_VSOCK_SET_RUNNING to a generic ioctl Guennadi Liakhovetski
2020-05-16 10:11   ` Guennadi Liakhovetski
2020-05-16 10:11 ` Guennadi Liakhovetski [this message]
2020-05-16 10:11   ` [PATCH 2/6] vhost: (cosmetic) remove a superfluous variable initialisation Guennadi Liakhovetski
2020-05-16 10:11 ` [PATCH 3/6] rpmsg: move common structures and defines to headers Guennadi Liakhovetski
2020-05-16 10:11   ` Guennadi Liakhovetski
2020-05-16 10:11 ` [PATCH 4/6] rpmsg: update documentation Guennadi Liakhovetski
2020-05-16 10:11   ` Guennadi Liakhovetski
2020-05-16 10:11 ` [PATCH 5/6] vhost: add an rpmsg API Guennadi Liakhovetski
2020-05-16 17:00   ` [Sound-open-firmware] " Pierre-Louis Bossart
2020-05-25 13:53     ` Guennadi Liakhovetski
2020-05-26 18:30       ` Pierre-Louis Bossart
2020-05-26 18:55         ` Guennadi Liakhovetski
2020-05-26 18:55           ` Guennadi Liakhovetski
2020-05-26 20:09           ` Pierre-Louis Bossart
2020-05-16 10:11 ` [PATCH 6/6] rpmsg: add a device ID to also bind to the ADSP device Guennadi Liakhovetski
2020-05-16 11:26   ` kbuild test robot
2020-05-16 11:26     ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200516101109.2624-3-guennadi.liakhovetski@linux.intel.com \
    --to=guennadi.liakhovetski@linux.intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=sound-open-firmware@alsa-project.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.