From: Oleksij Rempel <o.rempel@pengutronix.de> To: Bin Liu <b-liu@ti.com>, Michael Grzeschik <m.grzeschik@pengutronix.de>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Pengutronix Kernel Team <kernel@pengutronix.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-usb@vger.kernel.org, russell@personaltelco.net, fercerpav@gmail.com Subject: Re: [PATCH v1] usb: musb: dsps: set MUSB_DA8XX quirk for AM335x Date: Wed, 20 May 2020 06:49:34 +0200 [thread overview] Message-ID: <20200520044934.hyngdg774ibqai46@pengutronix.de> (raw) In-Reply-To: <20200519221851.GA15845@iaqt7> [-- Attachment #1: Type: text/plain, Size: 4279 bytes --] On Tue, May 19, 2020 at 05:18:51PM -0500, Bin Liu wrote: > Hi, > > On Fri, Mar 27, 2020 at 06:38:49AM +0100, Oleksij Rempel wrote: > > Beagle Bone Black has different memory corruptions if kernel is > > configured with USB_TI_CPPI41_DMA=y. This issue is reproducible with > > ath9k-htc driver (ar9271 based wifi usb controller): > > > > root@AccessBox:~ iw dev wlan0 set monitor fcsfail otherbss > > root@AccessBox:~ ip l s dev wlan0 up > > kmemleak: Cannot insert 0xda577e40 into the object search tree (overlaps existing) > > CPU: 0 PID: 176 Comm: ip Not tainted 5.5.0 #7 > > Hardware name: Generic AM33XX (Flattened Device Tree) > > [<c0112c14>] (unwind_backtrace) from [<c010dc98>] (show_stack+0x18/0x1c) > > [<c010dc98>] (show_stack) from [<c08c7c2c>] (dump_stack+0x84/0x98) > > [<c08c7c2c>] (dump_stack) from [<c02c75a8>] (create_object+0x2f8/0x324) > > [<c02c75a8>] (create_object) from [<c02b8928>] (kmem_cache_alloc+0x1a8/0x39c) > > [<c02b8928>] (kmem_cache_alloc) from [<c072fb68>] (__alloc_skb+0x60/0x174) > > [<c072fb68>] (__alloc_skb) from [<bf0c5c58>] (ath9k_wmi_cmd+0x50/0x184 [ath9k_htc]) > > [<bf0c5c58>] (ath9k_wmi_cmd [ath9k_htc]) from [<bf0cb410>] (ath9k_regwrite_multi+0x54/0x84 [ath9k_htc]) > > [<bf0cb410>] (ath9k_regwrite_multi [ath9k_htc]) from [<bf0cb7fc>] (ath9k_regwrite+0xf0/0xfc [ath9k_htc]) > > [<bf0cb7fc>] (ath9k_regwrite [ath9k_htc]) from [<bf1aca78>] (ar5008_hw_process_ini+0x280/0x6c0 [ath9k_hw]) > > [<bf1aca78>] (ar5008_hw_process_ini [ath9k_hw]) from [<bf1a66ac>] (ath9k_hw_reset+0x270/0x1458 [ath9k_hw]) > > [<bf1a66ac>] (ath9k_hw_reset [ath9k_hw]) from [<bf0c9588>] (ath9k_htc_start+0xb0/0x22c [ath9k_htc]) > > [<bf0c9588>] (ath9k_htc_start [ath9k_htc]) from [<bf0eb3c0>] (drv_start+0x4c/0x1e8 [mac80211]) > > [<bf0eb3c0>] (drv_start [mac80211]) from [<bf104a84>] (ieee80211_do_open+0x480/0x954 [mac80211]) > > [<bf104a84>] (ieee80211_do_open [mac80211]) from [<c075127c>] (__dev_open+0xdc/0x160) > > [<c075127c>] (__dev_open) from [<c07516a8>] (__dev_change_flags+0x1a4/0x204) > > [<c07516a8>] (__dev_change_flags) from [<c0751728>] (dev_change_flags+0x20/0x50) > > [<c0751728>] (dev_change_flags) from [<c076971c>] (do_setlink+0x2ac/0x978) > > > > After applying this patch, the system is running in monitor mode without > > noticeable issues. > > > > Suggested-by: Michael Grzeschik <m.grzeschik@pengutronix.de> > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > > --- > > drivers/usb/musb/musb_dsps.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c > > index 88923175f71e..c01f9e9e69f5 100644 > > --- a/drivers/usb/musb/musb_dsps.c > > +++ b/drivers/usb/musb/musb_dsps.c > > @@ -690,7 +690,7 @@ static void dsps_dma_controller_resume(struct dsps_glue *glue) {} > > #endif /* CONFIG_USB_TI_CPPI41_DMA */ > > > > static struct musb_platform_ops dsps_ops = { > > - .quirks = MUSB_DMA_CPPI41 | MUSB_INDEXED_EP, > > + .quirks = MUSB_DMA_CPPI41 | MUSB_INDEXED_EP | MUSB_DA8XX, > > The MUSB_DA8XX flag cannot be simply applied to MUSB_DSPS, at least the > teardown and autoreq register offsets are different as show in > cppi41_dma_controller_create(). ok > Do you understand what exactly caused the issue? No. Disabling DMA support "solve" this issue as well. Beside, with DMA support, there remains one more crash with different symptoms. I can workaround it by disabling CPU Freq governor, or setting it to performance. > The kernel trace above doesn't provide enuough information. Do you have any suggestions how to instrument the kernel to get needed information? Or, should I try to capture USB traffic before the crash? If it helps, ath9k_htc is a usb wifi adapter. It generates a lot of USB traffic on multiple endpoints. Bulk with data packets and Interrupt with register accesses, LED blinking... etc. Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Oleksij Rempel <o.rempel@pengutronix.de> To: Bin Liu <b-liu@ti.com>, Michael Grzeschik <m.grzeschik@pengutronix.de>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Pengutronix Kernel Team <kernel@pengutronix.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-usb@vger.kernel.org, russell@personaltelco.net, fercerpav@gmail.com Subject: Re: [PATCH v1] usb: musb: dsps: set MUSB_DA8XX quirk for AM335x Date: Wed, 20 May 2020 06:49:34 +0200 [thread overview] Message-ID: <20200520044934.hyngdg774ibqai46@pengutronix.de> (raw) In-Reply-To: <20200519221851.GA15845@iaqt7> [-- Attachment #1.1: Type: text/plain, Size: 4279 bytes --] On Tue, May 19, 2020 at 05:18:51PM -0500, Bin Liu wrote: > Hi, > > On Fri, Mar 27, 2020 at 06:38:49AM +0100, Oleksij Rempel wrote: > > Beagle Bone Black has different memory corruptions if kernel is > > configured with USB_TI_CPPI41_DMA=y. This issue is reproducible with > > ath9k-htc driver (ar9271 based wifi usb controller): > > > > root@AccessBox:~ iw dev wlan0 set monitor fcsfail otherbss > > root@AccessBox:~ ip l s dev wlan0 up > > kmemleak: Cannot insert 0xda577e40 into the object search tree (overlaps existing) > > CPU: 0 PID: 176 Comm: ip Not tainted 5.5.0 #7 > > Hardware name: Generic AM33XX (Flattened Device Tree) > > [<c0112c14>] (unwind_backtrace) from [<c010dc98>] (show_stack+0x18/0x1c) > > [<c010dc98>] (show_stack) from [<c08c7c2c>] (dump_stack+0x84/0x98) > > [<c08c7c2c>] (dump_stack) from [<c02c75a8>] (create_object+0x2f8/0x324) > > [<c02c75a8>] (create_object) from [<c02b8928>] (kmem_cache_alloc+0x1a8/0x39c) > > [<c02b8928>] (kmem_cache_alloc) from [<c072fb68>] (__alloc_skb+0x60/0x174) > > [<c072fb68>] (__alloc_skb) from [<bf0c5c58>] (ath9k_wmi_cmd+0x50/0x184 [ath9k_htc]) > > [<bf0c5c58>] (ath9k_wmi_cmd [ath9k_htc]) from [<bf0cb410>] (ath9k_regwrite_multi+0x54/0x84 [ath9k_htc]) > > [<bf0cb410>] (ath9k_regwrite_multi [ath9k_htc]) from [<bf0cb7fc>] (ath9k_regwrite+0xf0/0xfc [ath9k_htc]) > > [<bf0cb7fc>] (ath9k_regwrite [ath9k_htc]) from [<bf1aca78>] (ar5008_hw_process_ini+0x280/0x6c0 [ath9k_hw]) > > [<bf1aca78>] (ar5008_hw_process_ini [ath9k_hw]) from [<bf1a66ac>] (ath9k_hw_reset+0x270/0x1458 [ath9k_hw]) > > [<bf1a66ac>] (ath9k_hw_reset [ath9k_hw]) from [<bf0c9588>] (ath9k_htc_start+0xb0/0x22c [ath9k_htc]) > > [<bf0c9588>] (ath9k_htc_start [ath9k_htc]) from [<bf0eb3c0>] (drv_start+0x4c/0x1e8 [mac80211]) > > [<bf0eb3c0>] (drv_start [mac80211]) from [<bf104a84>] (ieee80211_do_open+0x480/0x954 [mac80211]) > > [<bf104a84>] (ieee80211_do_open [mac80211]) from [<c075127c>] (__dev_open+0xdc/0x160) > > [<c075127c>] (__dev_open) from [<c07516a8>] (__dev_change_flags+0x1a4/0x204) > > [<c07516a8>] (__dev_change_flags) from [<c0751728>] (dev_change_flags+0x20/0x50) > > [<c0751728>] (dev_change_flags) from [<c076971c>] (do_setlink+0x2ac/0x978) > > > > After applying this patch, the system is running in monitor mode without > > noticeable issues. > > > > Suggested-by: Michael Grzeschik <m.grzeschik@pengutronix.de> > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > > --- > > drivers/usb/musb/musb_dsps.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c > > index 88923175f71e..c01f9e9e69f5 100644 > > --- a/drivers/usb/musb/musb_dsps.c > > +++ b/drivers/usb/musb/musb_dsps.c > > @@ -690,7 +690,7 @@ static void dsps_dma_controller_resume(struct dsps_glue *glue) {} > > #endif /* CONFIG_USB_TI_CPPI41_DMA */ > > > > static struct musb_platform_ops dsps_ops = { > > - .quirks = MUSB_DMA_CPPI41 | MUSB_INDEXED_EP, > > + .quirks = MUSB_DMA_CPPI41 | MUSB_INDEXED_EP | MUSB_DA8XX, > > The MUSB_DA8XX flag cannot be simply applied to MUSB_DSPS, at least the > teardown and autoreq register offsets are different as show in > cppi41_dma_controller_create(). ok > Do you understand what exactly caused the issue? No. Disabling DMA support "solve" this issue as well. Beside, with DMA support, there remains one more crash with different symptoms. I can workaround it by disabling CPU Freq governor, or setting it to performance. > The kernel trace above doesn't provide enuough information. Do you have any suggestions how to instrument the kernel to get needed information? Or, should I try to capture USB traffic before the crash? If it helps, ath9k_htc is a usb wifi adapter. It generates a lot of USB traffic on multiple endpoints. Bulk with data packets and Interrupt with register accesses, LED blinking... etc. Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-20 4:49 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-27 5:38 [PATCH v1] usb: musb: dsps: set MUSB_DA8XX quirk for AM335x Oleksij Rempel 2020-03-27 5:38 ` Oleksij Rempel 2020-04-28 11:46 ` Oleksij Rempel 2020-04-28 11:46 ` Oleksij Rempel 2020-05-19 22:18 ` Bin Liu 2020-05-19 22:18 ` Bin Liu 2020-05-20 4:49 ` Oleksij Rempel [this message] 2020-05-20 4:49 ` Oleksij Rempel 2020-05-20 14:55 ` Bin Liu 2020-05-20 14:55 ` Bin Liu 2020-05-22 6:21 ` Oleksij Rempel 2020-05-22 6:21 ` Oleksij Rempel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200520044934.hyngdg774ibqai46@pengutronix.de \ --to=o.rempel@pengutronix.de \ --cc=b-liu@ti.com \ --cc=fercerpav@gmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=m.grzeschik@pengutronix.de \ --cc=russell@personaltelco.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.