Re: [PATCH] x86/shadow: Reposition sh_remove_write_access_from_sl1p()

From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
	Tim Deegan <tim@xen.org>, Wei Liu <wl@xen.org>,
	Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH] x86/shadow: Reposition sh_remove_write_access_from_sl1p()
Date: Thu, 21 May 2020 14:22:52 +0200	[thread overview]
Message-ID: <20200521111441.GS54375@Air-de-Roger> (raw)
In-Reply-To: <91c7f537-1d0e-4a9d-16a8-c02fa30d2d80@citrix.com>

On Thu, May 21, 2020 at 11:32:04AM +0100, Andrew Cooper wrote:
> On 21/05/2020 11:26, Roger Pau Monné wrote:
> > On Thu, May 21, 2020 at 10:04:28AM +0100, Andrew Cooper wrote:
> >> +static int sh_remove_write_access_from_sl1p(struct domain *d, mfn_t gmfn,
> >> +                                            mfn_t smfn, unsigned long off)
> >> +{
> >> +    struct page_info *sp = mfn_to_page(smfn);
> >> +
> >> +    ASSERT(mfn_valid(smfn));
> >> +    ASSERT(mfn_valid(gmfn));
> >> +
> >> +    if ( sp->u.sh.type == SH_type_l1_32_shadow ||
> >> +         sp->u.sh.type == SH_type_fl1_32_shadow )
> > Using a switch would also be nice IMO and would avoid some of the code
> > churn.
> 
> Good point.  Happy to do that if Tim agrees (but I won't bother sending
> a v2 just now).

Sure, feel free to keep my RB after that.

Roger.