From: Tim Deegan <tim@xen.org>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
"Wei Liu" <wl@xen.org>, "Jan Beulich" <JBeulich@suse.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH] x86/shadow: Reposition sh_remove_write_access_from_sl1p()
Date: Sun, 24 May 2020 12:52:44 +0100 [thread overview]
Message-ID: <20200524115244.GA4663@deinos.phlegethon.org> (raw)
In-Reply-To: <20200521090428.11425-1-andrew.cooper3@citrix.com>
At 10:04 +0100 on 21 May (1590055468), Andrew Cooper wrote:
> When compiling with SHOPT_OUT_OF_SYNC disabled, the build fails with:
>
> common.c:41:12: error: ‘sh_remove_write_access_from_sl1p’ declared ‘static’ but never defined [-Werror=unused-function]
> static int sh_remove_write_access_from_sl1p(struct domain *d, mfn_t gmfn,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> due to an unguarded forward declaration.
>
> It turns out there is no need to forward declare
> sh_remove_write_access_from_sl1p() to begin with, so move it to just ahead of
> its first users, which is within a larger #ifdef'd SHOPT_OUT_OF_SYNC block.
>
> Fix up for style while moving it. No functional change.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Thank you! This is fine, either as-is or with the suggested change to
a switch.
Reviewed-by: Tim Deegan <tim@xen.org>
prev parent reply other threads:[~2020-05-24 11:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 9:04 [PATCH] x86/shadow: Reposition sh_remove_write_access_from_sl1p() Andrew Cooper
2020-05-21 10:12 ` Paul Durrant
2020-05-21 10:26 ` Andrew Cooper
2020-05-21 10:26 ` Roger Pau Monné
2020-05-21 10:32 ` Andrew Cooper
2020-05-21 12:22 ` Roger Pau Monné
2020-05-24 11:52 ` Tim Deegan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200524115244.GA4663@deinos.phlegethon.org \
--to=tim@xen.org \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.