From: Richard Cochran <richardcochran@gmail.com>
To: Jianyong Wu <jianyong.wu@arm.com>
Cc: netdev@vger.kernel.org, yangbo.lu@nxp.com,
john.stultz@linaro.org, tglx@linutronix.de, pbonzini@redhat.com,
sean.j.christopherson@intel.com, maz@kernel.org,
Mark.Rutland@arm.com, will@kernel.org, suzuki.poulose@arm.com,
steven.price@arm.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
Steve.Capper@arm.com, Kaly.Xin@arm.com, justin.he@arm.com,
Wei.Chen@arm.com, nd@arm.com
Subject: Re: [RFC PATCH v12 09/11] ptp: extend input argument for getcrosstimestamp API
Date: Sat, 23 May 2020 18:42:20 -0700 [thread overview]
Message-ID: <20200524014220.GA335@localhost> (raw)
In-Reply-To: <20200522083724.38182-10-jianyong.wu@arm.com>
On Fri, May 22, 2020 at 04:37:22PM +0800, Jianyong Wu wrote:
> sometimes we may need tell getcrosstimestamp call back how to perform
> itself. Extending input arguments for getcrosstimestamp API to offer more
> exquisite control for the operation.
This text does not offer any justification for the change in API.
> diff --git a/include/linux/ptp_clock_kernel.h b/include/linux/ptp_clock_kernel.h
> index c602670bbffb..ba765647e54b 100644
> --- a/include/linux/ptp_clock_kernel.h
> +++ b/include/linux/ptp_clock_kernel.h
> @@ -133,7 +133,8 @@ struct ptp_clock_info {
> int (*gettimex64)(struct ptp_clock_info *ptp, struct timespec64 *ts,
> struct ptp_system_timestamp *sts);
> int (*getcrosststamp)(struct ptp_clock_info *ptp,
> - struct system_device_crosststamp *cts);
> + struct system_device_crosststamp *cts,
> + long *flag);
Well, you ignored the kernel doc completely. But in any case, I must
NAK this completely opaque and mysterious change. You want to add a
random pointer to some flag? I don't think so.
Thanks,
Richard
WARNING: multiple messages have this Message-ID (diff)
From: Richard Cochran <richardcochran@gmail.com>
To: Jianyong Wu <jianyong.wu@arm.com>
Cc: maz@kernel.org, justin.he@arm.com, Wei.Chen@arm.com,
kvm@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, sean.j.christopherson@intel.com,
steven.price@arm.com, john.stultz@linaro.org, yangbo.lu@nxp.com,
pbonzini@redhat.com, tglx@linutronix.de, nd@arm.com,
will@kernel.org, kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH v12 09/11] ptp: extend input argument for getcrosstimestamp API
Date: Sat, 23 May 2020 18:42:20 -0700 [thread overview]
Message-ID: <20200524014220.GA335@localhost> (raw)
In-Reply-To: <20200522083724.38182-10-jianyong.wu@arm.com>
On Fri, May 22, 2020 at 04:37:22PM +0800, Jianyong Wu wrote:
> sometimes we may need tell getcrosstimestamp call back how to perform
> itself. Extending input arguments for getcrosstimestamp API to offer more
> exquisite control for the operation.
This text does not offer any justification for the change in API.
> diff --git a/include/linux/ptp_clock_kernel.h b/include/linux/ptp_clock_kernel.h
> index c602670bbffb..ba765647e54b 100644
> --- a/include/linux/ptp_clock_kernel.h
> +++ b/include/linux/ptp_clock_kernel.h
> @@ -133,7 +133,8 @@ struct ptp_clock_info {
> int (*gettimex64)(struct ptp_clock_info *ptp, struct timespec64 *ts,
> struct ptp_system_timestamp *sts);
> int (*getcrosststamp)(struct ptp_clock_info *ptp,
> - struct system_device_crosststamp *cts);
> + struct system_device_crosststamp *cts,
> + long *flag);
Well, you ignored the kernel doc completely. But in any case, I must
NAK this completely opaque and mysterious change. You want to add a
random pointer to some flag? I don't think so.
Thanks,
Richard
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Richard Cochran <richardcochran@gmail.com>
To: Jianyong Wu <jianyong.wu@arm.com>
Cc: Mark.Rutland@arm.com, maz@kernel.org, justin.he@arm.com,
Wei.Chen@arm.com, kvm@vger.kernel.org, suzuki.poulose@arm.com,
netdev@vger.kernel.org, Steve.Capper@arm.com,
linux-kernel@vger.kernel.org, sean.j.christopherson@intel.com,
steven.price@arm.com, Kaly.Xin@arm.com, john.stultz@linaro.org,
yangbo.lu@nxp.com, pbonzini@redhat.com, tglx@linutronix.de,
nd@arm.com, will@kernel.org, kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH v12 09/11] ptp: extend input argument for getcrosstimestamp API
Date: Sat, 23 May 2020 18:42:20 -0700 [thread overview]
Message-ID: <20200524014220.GA335@localhost> (raw)
In-Reply-To: <20200522083724.38182-10-jianyong.wu@arm.com>
On Fri, May 22, 2020 at 04:37:22PM +0800, Jianyong Wu wrote:
> sometimes we may need tell getcrosstimestamp call back how to perform
> itself. Extending input arguments for getcrosstimestamp API to offer more
> exquisite control for the operation.
This text does not offer any justification for the change in API.
> diff --git a/include/linux/ptp_clock_kernel.h b/include/linux/ptp_clock_kernel.h
> index c602670bbffb..ba765647e54b 100644
> --- a/include/linux/ptp_clock_kernel.h
> +++ b/include/linux/ptp_clock_kernel.h
> @@ -133,7 +133,8 @@ struct ptp_clock_info {
> int (*gettimex64)(struct ptp_clock_info *ptp, struct timespec64 *ts,
> struct ptp_system_timestamp *sts);
> int (*getcrosststamp)(struct ptp_clock_info *ptp,
> - struct system_device_crosststamp *cts);
> + struct system_device_crosststamp *cts,
> + long *flag);
Well, you ignored the kernel doc completely. But in any case, I must
NAK this completely opaque and mysterious change. You want to add a
random pointer to some flag? I don't think so.
Thanks,
Richard
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-24 1:42 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 8:37 [RFC PATCH v12 0/11] Enable ptp_kvm for arm64 Jianyong Wu
2020-05-22 8:37 ` Jianyong Wu
2020-05-22 8:37 ` Jianyong Wu
2020-05-22 8:37 ` [RFC PATCH v12 01/11] arm64: Probe for the presence of KVM hypervisor services during boot Jianyong Wu
2020-05-22 8:37 ` Jianyong Wu
2020-05-22 8:37 ` Jianyong Wu
2020-05-22 8:37 ` [RFC PATCH v12 02/11] arm/arm64: KVM: Advertise KVM UID to guests via SMCCC Jianyong Wu
2020-05-22 8:37 ` Jianyong Wu
2020-05-22 8:37 ` Jianyong Wu
2020-05-22 8:37 ` [RFC PATCH v12 03/11] psci: export smccc conduit get helper Jianyong Wu
2020-05-22 8:37 ` Jianyong Wu
2020-05-22 8:37 ` Jianyong Wu
2020-05-22 13:12 ` Sudeep Holla
2020-05-22 13:12 ` Sudeep Holla
2020-05-22 13:12 ` Sudeep Holla
2020-05-25 1:37 ` Jianyong Wu
2020-05-25 1:37 ` Jianyong Wu
2020-05-25 1:37 ` Jianyong Wu
2020-05-26 10:10 ` Sudeep Holla
2020-05-26 10:10 ` Sudeep Holla
2020-05-26 10:10 ` Sudeep Holla
2020-05-27 1:18 ` Jianyong Wu
2020-05-27 1:18 ` Jianyong Wu
2020-05-27 1:18 ` Jianyong Wu
2020-05-22 8:37 ` [RFC PATCH v12 04/11] ptp: Reorganize ptp_kvm modules to make it arch-independent Jianyong Wu
2020-05-22 8:37 ` Jianyong Wu
2020-05-22 8:37 ` Jianyong Wu
2020-05-22 8:37 ` [RFC PATCH v12 05/11] time: Add mechanism to recognize clocksource in time_get_snapshot Jianyong Wu
2020-05-22 8:37 ` Jianyong Wu
2020-05-22 8:37 ` Jianyong Wu
2020-05-23 3:35 ` kbuild test robot
2020-05-28 16:36 ` Thomas Gleixner
2020-05-28 16:36 ` Thomas Gleixner
2020-05-28 16:36 ` Thomas Gleixner
2020-05-29 1:05 ` Jianyong Wu
2020-05-29 1:05 ` Jianyong Wu
2020-05-29 1:05 ` Jianyong Wu
2020-05-22 8:37 ` [RFC PATCH v12 06/11] clocksource: Add clocksource id for arm arch counter Jianyong Wu
2020-05-22 8:37 ` Jianyong Wu
2020-05-22 8:37 ` Jianyong Wu
2020-05-22 8:37 ` [RFC PATCH v12 07/11] psci: Add hypercall service for kvm ptp Jianyong Wu
2020-05-22 8:37 ` Jianyong Wu
2020-05-22 8:37 ` Jianyong Wu
2020-05-22 14:18 ` Steven Price
2020-05-22 14:18 ` Steven Price
2020-05-22 14:18 ` Steven Price
2020-05-25 2:11 ` Jianyong Wu
2020-05-25 2:11 ` Jianyong Wu
2020-05-25 2:11 ` Jianyong Wu
2020-05-26 11:02 ` Steven Price
2020-05-26 11:02 ` Steven Price
2020-05-26 11:02 ` Steven Price
2020-05-27 6:06 ` Jianyong Wu
2020-05-27 6:06 ` Jianyong Wu
2020-05-27 6:06 ` Jianyong Wu
2020-05-22 8:37 ` [RFC PATCH v12 08/11] ptp: arm64: Enable ptp_kvm for arm/arm64 Jianyong Wu
2020-05-22 8:37 ` Jianyong Wu
2020-05-22 8:37 ` Jianyong Wu
2020-05-26 14:24 ` kbuild test robot
2020-05-22 8:37 ` [RFC PATCH v12 09/11] ptp: extend input argument for getcrosstimestamp API Jianyong Wu
2020-05-22 8:37 ` Jianyong Wu
2020-05-22 8:37 ` Jianyong Wu
2020-05-24 1:42 ` Richard Cochran [this message]
2020-05-24 1:42 ` Richard Cochran
2020-05-24 1:42 ` Richard Cochran
2020-05-22 8:37 ` [RFC PATCH v12 10/11] arm64: add mechanism to let user choose which counter to return Jianyong Wu
2020-05-22 8:37 ` Jianyong Wu
2020-05-22 8:37 ` Jianyong Wu
2020-05-24 1:47 ` Richard Cochran
2020-05-24 1:47 ` Richard Cochran
2020-05-24 1:47 ` Richard Cochran
2020-05-24 2:11 ` Richard Cochran
2020-05-24 2:11 ` Richard Cochran
2020-05-24 2:11 ` Richard Cochran
2020-05-25 4:50 ` Jianyong Wu
2020-05-25 4:50 ` Jianyong Wu
2020-05-25 4:50 ` Jianyong Wu
2020-05-25 6:16 ` Richard Cochran
2020-05-25 6:16 ` Richard Cochran
2020-05-25 6:16 ` Richard Cochran
2020-05-25 6:29 ` Jianyong Wu
2020-05-25 6:29 ` Jianyong Wu
2020-05-25 6:29 ` Jianyong Wu
2020-05-25 9:17 ` Marc Zyngier
2020-05-25 9:17 ` Marc Zyngier
2020-05-25 9:17 ` Marc Zyngier
2020-05-25 14:18 ` Jianyong Wu
2020-05-25 14:18 ` Jianyong Wu
2020-05-25 14:18 ` Jianyong Wu
2020-05-25 15:28 ` Marc Zyngier
2020-05-25 15:28 ` Marc Zyngier
2020-05-25 15:28 ` Marc Zyngier
2020-05-22 8:37 ` [RFC PATCH v12 11/11] arm64: Add kvm capability check extension for ptp_kvm Jianyong Wu
2020-05-22 8:37 ` Jianyong Wu
2020-05-22 8:37 ` Jianyong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200524014220.GA335@localhost \
--to=richardcochran@gmail.com \
--cc=Kaly.Xin@arm.com \
--cc=Mark.Rutland@arm.com \
--cc=Steve.Capper@arm.com \
--cc=Wei.Chen@arm.com \
--cc=jianyong.wu@arm.com \
--cc=john.stultz@linaro.org \
--cc=justin.he@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=nd@arm.com \
--cc=netdev@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=steven.price@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.