All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Tudor Ambarus <Tudor.Ambarus@microchip.com>,
	<linux-mtd@lists.infradead.org>, Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>, <devicetree@vger.kernel.org>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Paul Cercueil <paul@crapouillou.net>,
	Chuanhong Guo <gch981213@gmail.com>,
	Weijie Gao <weijie.gao@mediatek.com>,
	<linux-arm-kernel@lists.infradead.org>,
	Mason Yang <masonccyang@mxic.com.tw>,
	Julien Su <juliensu@mxic.com.tw>
Subject: Re: [PATCH v6 01/18] dt-bindings: mtd: Document nand-ecc-placement
Date: Thu, 28 May 2020 14:02:01 +0200	[thread overview]
Message-ID: <20200528140201.33b7a08e@collabora.com> (raw)
In-Reply-To: <20200528113113.9166-2-miquel.raynal@bootlin.com>

On Thu, 28 May 2020 13:30:56 +0200
Miquel Raynal <miquel.raynal@bootlin.com> wrote:

> This optional property defines where the ECC bytes are expected to be
> stored. No value defaults to an unknown location, while these
> locations can be explicitly set to OOB or interleaved depending if
> the ECC bytes are entirely stored in the OOB area or mixed with
> regular data in the main area (also sometimes referred as
> "syndrome").
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>

> ---
>  .../devicetree/bindings/mtd/nand-controller.yaml       | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/nand-controller.yaml b/Documentation/devicetree/bindings/mtd/nand-controller.yaml
> index d261b7096c69..4a0798247d2d 100644
> --- a/Documentation/devicetree/bindings/mtd/nand-controller.yaml
> +++ b/Documentation/devicetree/bindings/mtd/nand-controller.yaml
> @@ -56,6 +56,16 @@ patternProperties:
>            (Linux will handle the calculations). soft_bch is deprecated
>            and should be replaced by soft and nand-ecc-algo.
>  
> +      nand-ecc-placement:
> +        allOf:
> +          - $ref: /schemas/types.yaml#/definitions/string
> +          - enum: [ oob, interleaved ]
> +        description:
> +          Location of the ECC bytes. This location is unknown by default
> +          but can be explicitly set to "oob", if all ECC bytes are
> +          known to be stored in the OOB area, or "interleaved" if ECC
> +          bytes will be interleaved with regular data in the main area.
> +
>        nand-ecc-algo:
>          allOf:
>            - $ref: /schemas/types.yaml#/definitions/string


WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Vignesh Raghavendra <vigneshr@ti.com>,
	Tudor Ambarus <Tudor.Ambarus@microchip.com>,
	Julien Su <juliensu@mxic.com.tw>,
	Richard Weinberger <richard@nod.at>,
	Weijie Gao <weijie.gao@mediatek.com>,
	Paul Cercueil <paul@crapouillou.net>,
	Rob Herring <robh+dt@kernel.org>,
	linux-mtd@lists.infradead.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Mason Yang <masonccyang@mxic.com.tw>,
	Chuanhong Guo <gch981213@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 01/18] dt-bindings: mtd: Document nand-ecc-placement
Date: Thu, 28 May 2020 14:02:01 +0200	[thread overview]
Message-ID: <20200528140201.33b7a08e@collabora.com> (raw)
In-Reply-To: <20200528113113.9166-2-miquel.raynal@bootlin.com>

On Thu, 28 May 2020 13:30:56 +0200
Miquel Raynal <miquel.raynal@bootlin.com> wrote:

> This optional property defines where the ECC bytes are expected to be
> stored. No value defaults to an unknown location, while these
> locations can be explicitly set to OOB or interleaved depending if
> the ECC bytes are entirely stored in the OOB area or mixed with
> regular data in the main area (also sometimes referred as
> "syndrome").
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>

> ---
>  .../devicetree/bindings/mtd/nand-controller.yaml       | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/nand-controller.yaml b/Documentation/devicetree/bindings/mtd/nand-controller.yaml
> index d261b7096c69..4a0798247d2d 100644
> --- a/Documentation/devicetree/bindings/mtd/nand-controller.yaml
> +++ b/Documentation/devicetree/bindings/mtd/nand-controller.yaml
> @@ -56,6 +56,16 @@ patternProperties:
>            (Linux will handle the calculations). soft_bch is deprecated
>            and should be replaced by soft and nand-ecc-algo.
>  
> +      nand-ecc-placement:
> +        allOf:
> +          - $ref: /schemas/types.yaml#/definitions/string
> +          - enum: [ oob, interleaved ]
> +        description:
> +          Location of the ECC bytes. This location is unknown by default
> +          but can be explicitly set to "oob", if all ECC bytes are
> +          known to be stored in the OOB area, or "interleaved" if ECC
> +          bytes will be interleaved with regular data in the main area.
> +
>        nand-ecc-algo:
>          allOf:
>            - $ref: /schemas/types.yaml#/definitions/string


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Vignesh Raghavendra <vigneshr@ti.com>,
	Tudor Ambarus <Tudor.Ambarus@microchip.com>,
	Julien Su <juliensu@mxic.com.tw>,
	Richard Weinberger <richard@nod.at>,
	Weijie Gao <weijie.gao@mediatek.com>,
	Paul Cercueil <paul@crapouillou.net>,
	Rob Herring <robh+dt@kernel.org>,
	linux-mtd@lists.infradead.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Mason Yang <masonccyang@mxic.com.tw>,
	Chuanhong Guo <gch981213@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 01/18] dt-bindings: mtd: Document nand-ecc-placement
Date: Thu, 28 May 2020 14:02:01 +0200	[thread overview]
Message-ID: <20200528140201.33b7a08e@collabora.com> (raw)
In-Reply-To: <20200528113113.9166-2-miquel.raynal@bootlin.com>

On Thu, 28 May 2020 13:30:56 +0200
Miquel Raynal <miquel.raynal@bootlin.com> wrote:

> This optional property defines where the ECC bytes are expected to be
> stored. No value defaults to an unknown location, while these
> locations can be explicitly set to OOB or interleaved depending if
> the ECC bytes are entirely stored in the OOB area or mixed with
> regular data in the main area (also sometimes referred as
> "syndrome").
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>

> ---
>  .../devicetree/bindings/mtd/nand-controller.yaml       | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/nand-controller.yaml b/Documentation/devicetree/bindings/mtd/nand-controller.yaml
> index d261b7096c69..4a0798247d2d 100644
> --- a/Documentation/devicetree/bindings/mtd/nand-controller.yaml
> +++ b/Documentation/devicetree/bindings/mtd/nand-controller.yaml
> @@ -56,6 +56,16 @@ patternProperties:
>            (Linux will handle the calculations). soft_bch is deprecated
>            and should be replaced by soft and nand-ecc-algo.
>  
> +      nand-ecc-placement:
> +        allOf:
> +          - $ref: /schemas/types.yaml#/definitions/string
> +          - enum: [ oob, interleaved ]
> +        description:
> +          Location of the ECC bytes. This location is unknown by default
> +          but can be explicitly set to "oob", if all ECC bytes are
> +          known to be stored in the OOB area, or "interleaved" if ECC
> +          bytes will be interleaved with regular data in the main area.
> +
>        nand-ecc-algo:
>          allOf:
>            - $ref: /schemas/types.yaml#/definitions/string


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-05-28 12:02 UTC|newest]

Thread overview: 138+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-28 11:30 [PATCH v6 00/18] Introduce the generic ECC engine abstraction Miquel Raynal
2020-05-28 11:30 ` Miquel Raynal
2020-05-28 11:30 ` Miquel Raynal
2020-05-28 11:30 ` [PATCH v6 01/18] dt-bindings: mtd: Document nand-ecc-placement Miquel Raynal
2020-05-28 11:30   ` Miquel Raynal
2020-05-28 11:30   ` Miquel Raynal
2020-05-28 12:02   ` Boris Brezillon [this message]
2020-05-28 12:02     ` Boris Brezillon
2020-05-28 12:02     ` Boris Brezillon
2020-05-28 11:30 ` [PATCH v6 02/18] mtd: rawnand: Create a new enumeration to describe OOB placement Miquel Raynal
2020-05-28 11:30   ` Miquel Raynal
2020-05-28 11:30   ` Miquel Raynal
2020-05-28 12:08   ` Boris Brezillon
2020-05-28 12:08     ` Boris Brezillon
2020-05-28 12:08     ` Boris Brezillon
2020-05-28 14:10     ` Miquel Raynal
2020-05-28 14:10       ` Miquel Raynal
2020-05-28 14:10       ` Miquel Raynal
2020-05-28 11:30 ` [PATCH v6 03/18] mtd: rawnand: Separate the ECC engine type and the " Miquel Raynal
2020-05-28 11:30   ` Miquel Raynal
2020-05-28 11:30   ` Miquel Raynal
2020-05-28 14:14   ` Boris Brezillon
2020-05-28 14:14     ` Boris Brezillon
2020-05-28 14:14     ` Boris Brezillon
2020-05-28 11:30 ` [PATCH v6 04/18] mtd: rawnand: Create a helper to retrieve the ECC placement Miquel Raynal
2020-05-28 11:30   ` Miquel Raynal
2020-05-28 11:30   ` Miquel Raynal
2020-05-28 14:22   ` Boris Brezillon
2020-05-28 14:22     ` Boris Brezillon
2020-05-28 14:22     ` Boris Brezillon
2020-05-28 11:31 ` [PATCH v6 05/18] mtd: rawnand: Add a kernel doc to the ECC algorithm enumeration Miquel Raynal
2020-05-28 11:31   ` Miquel Raynal
2020-05-28 11:31   ` Miquel Raynal
2020-05-28 14:26   ` Boris Brezillon
2020-05-28 14:26     ` Boris Brezillon
2020-05-28 14:26     ` Boris Brezillon
2020-05-28 11:31 ` [PATCH v6 06/18] mtd: rawnand: Rename the ECC algorithm enumeration items Miquel Raynal
2020-05-28 11:31   ` Miquel Raynal
2020-05-28 11:31   ` Miquel Raynal
2020-05-28 14:26   ` Boris Brezillon
2020-05-28 14:26     ` Boris Brezillon
2020-05-28 14:26     ` Boris Brezillon
2020-05-28 11:31 ` [PATCH v6 07/18] mtd: rawnand: Create a new enumeration to describe properly ECC types Miquel Raynal
2020-05-28 11:31   ` Miquel Raynal
2020-05-28 11:31   ` Miquel Raynal
2020-05-28 11:31 ` [PATCH v6 08/18] mtd: rawnand: Use the new ECC engine type enumeration Miquel Raynal
2020-05-28 11:31   ` Miquel Raynal
2020-05-28 11:31   ` Miquel Raynal
2020-05-28 14:31   ` Boris Brezillon
2020-05-28 14:31     ` Boris Brezillon
2020-05-28 14:31     ` Boris Brezillon
2020-05-28 14:45     ` Miquel Raynal
2020-05-28 14:45       ` Miquel Raynal
2020-05-28 14:45       ` Miquel Raynal
2020-05-28 11:31 ` [PATCH v6 09/18] mtd: nand: Move nand_device forward declaration to the top Miquel Raynal
2020-05-28 11:31   ` Miquel Raynal
2020-05-28 11:31   ` Miquel Raynal
2020-05-28 11:31 ` [PATCH v6 10/18] mtd: nand: Add an extra level in the Kconfig hierarchy Miquel Raynal
2020-05-28 11:31   ` Miquel Raynal
2020-05-28 11:31   ` Miquel Raynal
2020-05-28 11:31 ` [PATCH v6 11/18] mtd: nand: Drop useless 'depends on' in Kconfig Miquel Raynal
2020-05-28 11:31   ` Miquel Raynal
2020-05-28 11:31   ` Miquel Raynal
2020-05-28 11:31 ` [PATCH v6 12/18] mtd: nand: Add a NAND page I/O request type Miquel Raynal
2020-05-28 11:31   ` Miquel Raynal
2020-05-28 11:31   ` Miquel Raynal
2020-05-28 11:31 ` [PATCH v6 13/18] mtd: nand: Rename a core structure Miquel Raynal
2020-05-28 11:31   ` Miquel Raynal
2020-05-28 11:31   ` Miquel Raynal
2020-05-28 11:31 ` [PATCH v6 14/18] mtd: nand: Add more parameters to the nand_ecc_props structure Miquel Raynal
2020-05-28 11:31   ` Miquel Raynal
2020-05-28 11:31   ` Miquel Raynal
2020-05-28 14:34   ` Boris Brezillon
2020-05-28 14:34     ` Boris Brezillon
2020-05-28 14:34     ` Boris Brezillon
2020-05-28 14:57     ` Miquel Raynal
2020-05-28 14:57       ` Miquel Raynal
2020-05-28 14:57       ` Miquel Raynal
2020-05-28 15:00       ` Boris Brezillon
2020-05-28 15:00         ` Boris Brezillon
2020-05-28 15:00         ` Boris Brezillon
2020-05-28 15:02         ` Miquel Raynal
2020-05-28 15:02           ` Miquel Raynal
2020-05-28 15:02           ` Miquel Raynal
2020-05-28 11:31 ` [PATCH v6 15/18] mtd: nand: Introduce the ECC engine abstraction Miquel Raynal
2020-05-28 11:31   ` Miquel Raynal
2020-05-28 11:31   ` Miquel Raynal
2020-05-28 18:52   ` Boris Brezillon
2020-05-28 18:52     ` Boris Brezillon
2020-05-28 18:52     ` Boris Brezillon
2020-05-28 23:46     ` Miquel Raynal
2020-05-28 23:46       ` Miquel Raynal
2020-05-28 23:46       ` Miquel Raynal
2020-05-28 11:31 ` [PATCH v6 16/18] mtd: nand: Convert generic NAND bits to use the ECC framework Miquel Raynal
2020-05-28 11:31   ` Miquel Raynal
2020-05-28 11:31   ` Miquel Raynal
2020-05-28 14:39   ` Boris Brezillon
2020-05-28 14:39     ` Boris Brezillon
2020-05-28 14:39     ` Boris Brezillon
2020-05-28 14:49     ` Miquel Raynal
2020-05-28 14:49       ` Miquel Raynal
2020-05-28 14:49       ` Miquel Raynal
2020-05-28 14:52       ` Boris Brezillon
2020-05-28 14:52         ` Boris Brezillon
2020-05-28 14:52         ` Boris Brezillon
2020-05-28 15:04         ` Miquel Raynal
2020-05-28 15:04           ` Miquel Raynal
2020-05-28 15:04           ` Miquel Raynal
2020-05-28 16:00   ` Boris Brezillon
2020-05-28 16:00     ` Boris Brezillon
2020-05-28 16:00     ` Boris Brezillon
2020-05-28 23:48     ` Miquel Raynal
2020-05-28 23:48       ` Miquel Raynal
2020-05-28 23:48       ` Miquel Raynal
2020-05-28 11:31 ` [PATCH v6 17/18] mtd: rawnand: Write a compatibility layer Miquel Raynal
2020-05-28 11:31   ` Miquel Raynal
2020-05-28 11:31   ` Miquel Raynal
2020-05-28 14:42   ` Boris Brezillon
2020-05-28 14:42     ` Boris Brezillon
2020-05-28 14:42     ` Boris Brezillon
2020-05-28 14:53     ` Miquel Raynal
2020-05-28 14:53       ` Miquel Raynal
2020-05-28 14:53       ` Miquel Raynal
2020-05-28 11:31 ` [PATCH v6 18/18] mtd: rawnand: Move generic bits to the ECC framework Miquel Raynal
2020-05-28 11:31   ` Miquel Raynal
2020-05-28 11:31   ` Miquel Raynal
2020-05-28 14:45   ` Boris Brezillon
2020-05-28 14:45     ` Boris Brezillon
2020-05-28 14:45     ` Boris Brezillon
2020-05-28 15:55   ` Boris Brezillon
2020-05-28 15:55     ` Boris Brezillon
2020-05-28 15:55     ` Boris Brezillon
2020-05-28 15:56   ` Boris Brezillon
2020-05-28 15:56     ` Boris Brezillon
2020-05-28 15:56     ` Boris Brezillon
2020-05-28 23:55     ` Miquel Raynal
2020-05-28 23:55       ` Miquel Raynal
2020-05-28 23:55       ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200528140201.33b7a08e@collabora.com \
    --to=boris.brezillon@collabora.com \
    --cc=Tudor.Ambarus@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gch981213@gmail.com \
    --cc=juliensu@mxic.com.tw \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=masonccyang@mxic.com.tw \
    --cc=miquel.raynal@bootlin.com \
    --cc=paul@crapouillou.net \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vigneshr@ti.com \
    --cc=weijie.gao@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.