From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>,
git@vger.kernel.org, hji@dyntopia.com
Subject: Re: [PATCH] t: avoid alternation (not POSIX) in grep's BRE
Date: Thu, 28 May 2020 11:43:49 -0400 [thread overview]
Message-ID: <20200528154349.GA1215380@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqo8q83x3v.fsf@gitster.c.googlers.com>
On Thu, May 28, 2020 at 08:20:04AM -0700, Junio C Hamano wrote:
> > [1] https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap09.html#tag_09_03
> >
> > Fixes: f1e3df3169 (t: increase test coverage of signature verification
> > output, 2020-03-04)
>
> I do appreciate the information recorded in the log message, but not
> like this. Does everybody's tool understand the "folding" the above
> two physical lines require to be able to handle it correctly?
If you use any of the Git tools, they support an "unfold" option like:
git log --format='%(trailers:unfold)'
that normalizes this. However, I would not be at all surprised if people
use custom readers. I think it may be a good policy to stick to the
simplest machine-readable formats for trailers. Likewise I'd suggest
using the full sha1-hex for future-proofing in this context.
-Peff
next prev parent reply other threads:[~2020-05-28 15:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 8:37 [PATCH] t: avoid alternation (not POSIX) in grep's BRE Carlo Marcelo Arenas Belón
2020-05-28 15:20 ` Junio C Hamano
2020-05-28 15:43 ` Jeff King [this message]
2020-05-28 15:51 ` Junio C Hamano
2020-05-28 16:52 ` Jeff King
2020-05-28 19:20 ` Junio C Hamano
2020-05-28 20:35 ` Jeff King
2020-05-29 3:18 ` digging into historical commit references Jeff King
2020-05-29 3:39 ` [PATCH] t: avoid alternation (not POSIX) in grep's BRE Torsten Bögershausen
2020-05-29 8:20 ` [PATCH v2] " Carlo Marcelo Arenas Belón
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528154349.GA1215380@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hji@dyntopia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.