Re: [PATCH] t: avoid alternation (not POSIX) in grep's BRE

From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>,
	git@vger.kernel.org, hji@dyntopia.com
Subject: Re: [PATCH] t: avoid alternation (not POSIX) in grep's BRE
Date: Thu, 28 May 2020 12:52:45 -0400	[thread overview]
Message-ID: <20200528165245.GA1223396@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqh7w03vnq.fsf@gitster.c.googlers.com>

On Thu, May 28, 2020 at 08:51:21AM -0700, Junio C Hamano wrote:

> > I think it may be a good policy to stick to the
> > simplest machine-readable formats for trailers. Likewise I'd suggest
> > using the full sha1-hex for future-proofing in this context.
> 
> Yes, or just roll it into prose like we often do.  Anybody can spot
> many examples from "git log --no-merges" ;-)

Yeah, I was sort of working under the assumption that people found
utility in putting that data in a trailer (in which case I'd really
suggest doing both; a prose one with subject meant for readers, and a
machine-readable annotation).

But I haven't really found a use for "Fixes" in machine-readable format.
I don't _mind_ people doing it if they do have a use (and I'd even
consider doing it myself if I were shown that it was useful). In the
meantime, I don't know if we want to state a project preference against
it.

-Peff