From: James Morse <james.morse@arm.com> To: kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Cc: Marc Zyngier <maz@kernel.org> Subject: [PATCH v2 0/3] KVM: arm64: aarch32 ACTLR accesses Date: Fri, 29 May 2020 15:06:53 +0000 [thread overview] Message-ID: <20200529150656.7339-1-james.morse@arm.com> (raw) Hello! Changes since v1: * Patches 2 & 3 have been swapped. * Copy access_vm_reg() to swizzle 32bit offets back to 64bit * Peek at the encoding to tell ACTLR and ACTLR2 apart... I didn't pick up the suggestion to remove the ACTLR_EL1 storage from sys_regs[] as this turns out to break migration. Fixing it would require a get_user() helper, which has a different prototype to access_actlr(), would be noisier overall. ~ Patch 1 fixes an issue where the 32bit and 64bit indexes into copro[] and sys_regs[] are muddled. Patch 2 adds support for aarch32 accessing the top 32bits of ACTLR_EL1 via ACTLR2. Support for this register is advertised in ID_MMFR4.AC2, which doesn't get removed by cpufeature. The register is mandatory from v8.2, but imp-def before then. Patch 3 stops the sys_regs[] value we use for emulation being save/restored. I think Patch 1 is stable material, I'm not sure about 2&3. Thanks, James Morse (3): KVM: arm64: Stop writing aarch32's CSSELR into ACTLR KVM: arm64: Add emulation for 32bit guests accessing ACTLR2 KVM: arm64: Stop save/restoring ACTLR_EL1 arch/arm64/kvm/hyp/sysreg-sr.c | 2 -- arch/arm64/kvm/sys_regs.c | 12 ++++++++---- arch/arm64/kvm/sys_regs_generic_v8.c | 10 ++++++++++ 3 files changed, 18 insertions(+), 6 deletions(-) -- 2.20.1 _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: James Morse <james.morse@arm.com> To: kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Cc: Marc Zyngier <maz@kernel.org>, Julien Thierry <julien.thierry.kdev@gmail.com>, Suzuki K Poulose <suzuki.poulose@arm.com> Subject: [PATCH v2 0/3] KVM: arm64: aarch32 ACTLR accesses Date: Fri, 29 May 2020 15:06:53 +0000 [thread overview] Message-ID: <20200529150656.7339-1-james.morse@arm.com> (raw) Hello! Changes since v1: * Patches 2 & 3 have been swapped. * Copy access_vm_reg() to swizzle 32bit offets back to 64bit * Peek at the encoding to tell ACTLR and ACTLR2 apart... I didn't pick up the suggestion to remove the ACTLR_EL1 storage from sys_regs[] as this turns out to break migration. Fixing it would require a get_user() helper, which has a different prototype to access_actlr(), would be noisier overall. ~ Patch 1 fixes an issue where the 32bit and 64bit indexes into copro[] and sys_regs[] are muddled. Patch 2 adds support for aarch32 accessing the top 32bits of ACTLR_EL1 via ACTLR2. Support for this register is advertised in ID_MMFR4.AC2, which doesn't get removed by cpufeature. The register is mandatory from v8.2, but imp-def before then. Patch 3 stops the sys_regs[] value we use for emulation being save/restored. I think Patch 1 is stable material, I'm not sure about 2&3. Thanks, James Morse (3): KVM: arm64: Stop writing aarch32's CSSELR into ACTLR KVM: arm64: Add emulation for 32bit guests accessing ACTLR2 KVM: arm64: Stop save/restoring ACTLR_EL1 arch/arm64/kvm/hyp/sysreg-sr.c | 2 -- arch/arm64/kvm/sys_regs.c | 12 ++++++++---- arch/arm64/kvm/sys_regs_generic_v8.c | 10 ++++++++++ 3 files changed, 18 insertions(+), 6 deletions(-) -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2020-05-29 15:07 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-29 15:06 James Morse [this message] 2020-05-29 15:06 ` [PATCH v2 0/3] KVM: arm64: aarch32 ACTLR accesses James Morse 2020-05-29 15:06 ` [PATCH v2 1/3] KVM: arm64: Stop writing aarch32's CSSELR into ACTLR James Morse 2020-05-29 15:06 ` James Morse 2020-05-29 15:06 ` [PATCH v2 2/3] KVM: arm64: Add emulation for 32bit guests accessing ACTLR2 James Morse 2020-05-29 15:06 ` James Morse 2020-05-29 15:06 ` [PATCH v2 3/3] KVM: arm64: Stop save/restoring ACTLR_EL1 James Morse 2020-05-29 15:06 ` James Morse 2020-06-10 13:17 ` [PATCH v2 0/3] KVM: arm64: aarch32 ACTLR accesses Marc Zyngier 2020-06-10 13:17 ` Marc Zyngier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200529150656.7339-1-james.morse@arm.com \ --to=james.morse@arm.com \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=maz@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.