From: kbuild test robot <lkp@intel.com>
To: Tetsuhiro Kohada <kohada.t2@gmail.com>
Cc: kbuild-all@lists.01.org,
kohada.tetsuhiro@dc.mitsubishielectric.co.jp,
mori.takahiro@ab.mitsubishielectric.co.jp,
motai.hirotaka@aj.mitsubishielectric.co.jp,
Namjae Jeon <namjae.jeon@samsung.com>,
Sungjong Seo <sj1557.seo@samsung.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] exfat: add boot region verification
Date: Sat, 30 May 2020 00:51:03 +0800 [thread overview]
Message-ID: <202005300054.hMI2cUvl%lkp@intel.com> (raw)
In-Reply-To: <20200525115052.19243-3-kohada.t2@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3329 bytes --]
Hi Tetsuhiro,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on next-20200519]
[cannot apply to linus/master v5.7-rc7 v5.7-rc6 v5.7-rc5 v5.7-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Tetsuhiro-Kohada/exfat-redefine-PBR-as-boot_sector/20200525-195329
base: fb57b1fabcb28f358901b2df90abd2b48abc1ca8
config: c6x-randconfig-s032-20200529 (attached as .config)
compiler: c6x-elf-gcc (GCC) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
# save the attached .config to linux build tree
make W=1 C=1 ARCH=c6x CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> fs/exfat/super.c:485:29: sparse: sparse: cast to restricted __le32
>> fs/exfat/super.c:485:29: sparse: sparse: cast to restricted __le32
>> fs/exfat/super.c:485:29: sparse: sparse: cast to restricted __le32
>> fs/exfat/super.c:485:29: sparse: sparse: cast to restricted __le32
>> fs/exfat/super.c:485:29: sparse: sparse: cast to restricted __le32
>> fs/exfat/super.c:485:29: sparse: sparse: cast to restricted __le32
fs/exfat/super.c:504:21: sparse: sparse: cast to restricted __le32
fs/exfat/super.c:504:21: sparse: sparse: cast to restricted __le32
fs/exfat/super.c:504:21: sparse: sparse: cast to restricted __le32
fs/exfat/super.c:504:21: sparse: sparse: cast to restricted __le32
fs/exfat/super.c:504:21: sparse: sparse: cast to restricted __le32
fs/exfat/super.c:504:21: sparse: sparse: cast to restricted __le32
vim +485 fs/exfat/super.c
469
470 static int exfat_verify_boot_region(struct super_block *sb)
471 {
472 struct buffer_head *bh = NULL;
473 u32 chksum = 0, *p_sig, *p_chksum;
474 int sn, i;
475
476 /* read boot sector sub-regions */
477 for (sn = 0; sn < 11; sn++) {
478 bh = sb_bread(sb, sn);
479 if (!bh)
480 return -EIO;
481
482 if (sn != 0 && sn <= 8) {
483 /* extended boot sector sub-regions */
484 p_sig = (u32 *)&bh->b_data[sb->s_blocksize - 4];
> 485 if (le32_to_cpu(*p_sig) != EXBOOT_SIGNATURE) {
486 exfat_err(sb, "no exboot-signature");
487 brelse(bh);
488 return -EINVAL;
489 }
490 }
491
492 chksum = exfat_calc_chksum32(bh->b_data, sb->s_blocksize,
493 chksum, sn ? CS_DEFAULT : CS_BOOT_SECTOR);
494 brelse(bh);
495 }
496
497 /* boot checksum sub-regions */
498 bh = sb_bread(sb, sn);
499 if (!bh)
500 return -EIO;
501
502 for (i = 0; i < sb->s_blocksize; i += sizeof(u32)) {
503 p_chksum = (u32 *)&bh->b_data[i];
504 if (le32_to_cpu(*p_chksum) != chksum) {
505 exfat_err(sb, "mismatch checksum");
506 brelse(bh);
507 return -EINVAL;
508 }
509 }
510 brelse(bh);
511 return 0;
512 }
513
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28873 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 3/4] exfat: add boot region verification
Date: Sat, 30 May 2020 00:51:03 +0800 [thread overview]
Message-ID: <202005300054.hMI2cUvl%lkp@intel.com> (raw)
In-Reply-To: <20200525115052.19243-3-kohada.t2@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3421 bytes --]
Hi Tetsuhiro,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on next-20200519]
[cannot apply to linus/master v5.7-rc7 v5.7-rc6 v5.7-rc5 v5.7-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Tetsuhiro-Kohada/exfat-redefine-PBR-as-boot_sector/20200525-195329
base: fb57b1fabcb28f358901b2df90abd2b48abc1ca8
config: c6x-randconfig-s032-20200529 (attached as .config)
compiler: c6x-elf-gcc (GCC) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
# save the attached .config to linux build tree
make W=1 C=1 ARCH=c6x CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> fs/exfat/super.c:485:29: sparse: sparse: cast to restricted __le32
>> fs/exfat/super.c:485:29: sparse: sparse: cast to restricted __le32
>> fs/exfat/super.c:485:29: sparse: sparse: cast to restricted __le32
>> fs/exfat/super.c:485:29: sparse: sparse: cast to restricted __le32
>> fs/exfat/super.c:485:29: sparse: sparse: cast to restricted __le32
>> fs/exfat/super.c:485:29: sparse: sparse: cast to restricted __le32
fs/exfat/super.c:504:21: sparse: sparse: cast to restricted __le32
fs/exfat/super.c:504:21: sparse: sparse: cast to restricted __le32
fs/exfat/super.c:504:21: sparse: sparse: cast to restricted __le32
fs/exfat/super.c:504:21: sparse: sparse: cast to restricted __le32
fs/exfat/super.c:504:21: sparse: sparse: cast to restricted __le32
fs/exfat/super.c:504:21: sparse: sparse: cast to restricted __le32
vim +485 fs/exfat/super.c
469
470 static int exfat_verify_boot_region(struct super_block *sb)
471 {
472 struct buffer_head *bh = NULL;
473 u32 chksum = 0, *p_sig, *p_chksum;
474 int sn, i;
475
476 /* read boot sector sub-regions */
477 for (sn = 0; sn < 11; sn++) {
478 bh = sb_bread(sb, sn);
479 if (!bh)
480 return -EIO;
481
482 if (sn != 0 && sn <= 8) {
483 /* extended boot sector sub-regions */
484 p_sig = (u32 *)&bh->b_data[sb->s_blocksize - 4];
> 485 if (le32_to_cpu(*p_sig) != EXBOOT_SIGNATURE) {
486 exfat_err(sb, "no exboot-signature");
487 brelse(bh);
488 return -EINVAL;
489 }
490 }
491
492 chksum = exfat_calc_chksum32(bh->b_data, sb->s_blocksize,
493 chksum, sn ? CS_DEFAULT : CS_BOOT_SECTOR);
494 brelse(bh);
495 }
496
497 /* boot checksum sub-regions */
498 bh = sb_bread(sb, sn);
499 if (!bh)
500 return -EIO;
501
502 for (i = 0; i < sb->s_blocksize; i += sizeof(u32)) {
503 p_chksum = (u32 *)&bh->b_data[i];
504 if (le32_to_cpu(*p_chksum) != chksum) {
505 exfat_err(sb, "mismatch checksum");
506 brelse(bh);
507 return -EINVAL;
508 }
509 }
510 brelse(bh);
511 return 0;
512 }
513
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 28873 bytes --]
next prev parent reply other threads:[~2020-05-29 16:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200525115110epcas1p491bfb477b12825536e81e376f34c7a02@epcas1p4.samsung.com>
2020-05-25 11:50 ` [PATCH 1/4] exfat: redefine PBR as boot_sector Tetsuhiro Kohada
2020-05-25 11:50 ` [PATCH 2/4] exfat: separate the boot sector analysis Tetsuhiro Kohada
2020-05-25 11:50 ` [PATCH 3/4] exfat: add boot region verification Tetsuhiro Kohada
2020-05-26 7:23 ` Namjae Jeon
2020-05-29 16:51 ` kbuild test robot [this message]
2020-05-29 16:51 ` kbuild test robot
2020-05-25 11:50 ` [PATCH 4/4] exfat: standardize checksum calculation Tetsuhiro Kohada
2020-05-26 7:32 ` Namjae Jeon
2020-05-27 7:39 ` Tetsuhiro Kohada
2020-05-27 11:28 ` Namjae Jeon
2020-05-28 2:00 ` Tetsuhiro Kohada
2020-05-28 5:03 ` Namjae Jeon
2020-05-28 10:09 ` Tetsuhiro Kohada
2020-05-28 11:30 ` Namjae Jeon
2020-05-28 5:31 ` [PATCH 1/4] exfat: redefine PBR as boot_sector Sungjong Seo
2020-05-28 12:27 ` Tetsuhiro Kohada
2020-05-29 5:28 ` Sungjong Seo
2020-05-29 6:32 ` Tetsuhiro Kohada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202005300054.hMI2cUvl%lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=kohada.t2@gmail.com \
--cc=kohada.tetsuhiro@dc.mitsubishielectric.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mori.takahiro@ab.mitsubishielectric.co.jp \
--cc=motai.hirotaka@aj.mitsubishielectric.co.jp \
--cc=namjae.jeon@samsung.com \
--cc=sj1557.seo@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.