From: Dan Carpenter <dan.carpenter@oracle.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: aisheng.dong@nxp.com, festevam@gmail.com, shawnguo@kernel.org,
stefan@agner.ch, kernel@pengutronix.de, linus.walleij@linaro.org,
s.hauer@pengutronix.de, linux-imx@nxp.com,
gary.bisson@boundarydevices.com, linux-gpio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] pinctrl: freescale: imx: Fix an error handling path in 'imx_pinctrl_probe()'
Date: Tue, 2 Jun 2020 13:13:46 +0300 [thread overview]
Message-ID: <20200602101346.GW30374@kadam> (raw)
In-Reply-To: <20200530204955.588962-1-christophe.jaillet@wanadoo.fr>
On Sat, May 30, 2020 at 10:49:55PM +0200, Christophe JAILLET wrote:
> 'pinctrl_unregister()' should not be called to undo
> 'devm_pinctrl_register_and_init()', it is already handled by the framework.
>
> This simplifies the error handling paths of the probe function.
> The 'imx_free_resources()' can be removed as well.
>
> Fixes: a51c158bf0f7 ("pinctrl: imx: use radix trees for groups and functions")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
You didn't introduce this but the:
ipctl->input_sel_base = of_iomap(np, 0);
should be changed to devm_of_iomap().
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: aisheng.dong@nxp.com, festevam@gmail.com,
linus.walleij@linaro.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, stefan@agner.ch,
gary.bisson@boundarydevices.com, linux-gpio@vger.kernel.org,
linux-imx@nxp.com, kernel@pengutronix.de, shawnguo@kernel.org,
s.hauer@pengutronix.de, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pinctrl: freescale: imx: Fix an error handling path in 'imx_pinctrl_probe()'
Date: Tue, 02 Jun 2020 10:13:46 +0000 [thread overview]
Message-ID: <20200602101346.GW30374@kadam> (raw)
In-Reply-To: <20200530204955.588962-1-christophe.jaillet@wanadoo.fr>
On Sat, May 30, 2020 at 10:49:55PM +0200, Christophe JAILLET wrote:
> 'pinctrl_unregister()' should not be called to undo
> 'devm_pinctrl_register_and_init()', it is already handled by the framework.
>
> This simplifies the error handling paths of the probe function.
> The 'imx_free_resources()' can be removed as well.
>
> Fixes: a51c158bf0f7 ("pinctrl: imx: use radix trees for groups and functions")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
You didn't introduce this but the:
ipctl->input_sel_base = of_iomap(np, 0);
should be changed to devm_of_iomap().
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: aisheng.dong@nxp.com, festevam@gmail.com,
linus.walleij@linaro.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, stefan@agner.ch,
gary.bisson@boundarydevices.com, linux-gpio@vger.kernel.org,
linux-imx@nxp.com, kernel@pengutronix.de, shawnguo@kernel.org,
s.hauer@pengutronix.de, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pinctrl: freescale: imx: Fix an error handling path in 'imx_pinctrl_probe()'
Date: Tue, 2 Jun 2020 13:13:46 +0300 [thread overview]
Message-ID: <20200602101346.GW30374@kadam> (raw)
In-Reply-To: <20200530204955.588962-1-christophe.jaillet@wanadoo.fr>
On Sat, May 30, 2020 at 10:49:55PM +0200, Christophe JAILLET wrote:
> 'pinctrl_unregister()' should not be called to undo
> 'devm_pinctrl_register_and_init()', it is already handled by the framework.
>
> This simplifies the error handling paths of the probe function.
> The 'imx_free_resources()' can be removed as well.
>
> Fixes: a51c158bf0f7 ("pinctrl: imx: use radix trees for groups and functions")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
You didn't introduce this but the:
ipctl->input_sel_base = of_iomap(np, 0);
should be changed to devm_of_iomap().
regards,
dan carpenter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-02 10:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-30 20:49 [PATCH] pinctrl: freescale: imx: Fix an error handling path in 'imx_pinctrl_probe()' Christophe JAILLET
2020-05-30 20:49 ` Christophe JAILLET
2020-05-30 20:49 ` Christophe JAILLET
2020-06-01 10:16 ` Aisheng Dong
2020-06-01 10:16 ` Aisheng Dong
2020-06-01 10:16 ` Aisheng Dong
2020-06-02 10:13 ` Dan Carpenter [this message]
2020-06-02 10:13 ` Dan Carpenter
2020-06-02 10:13 ` Dan Carpenter
2020-06-02 20:08 ` Christophe JAILLET
2020-06-02 20:08 ` Christophe JAILLET
2020-06-02 20:08 ` Christophe JAILLET
2020-06-03 12:34 ` Linus Walleij
2020-06-03 12:34 ` Linus Walleij
2020-06-03 12:34 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602101346.GW30374@kadam \
--to=dan.carpenter@oracle.com \
--cc=aisheng.dong@nxp.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=festevam@gmail.com \
--cc=gary.bisson@boundarydevices.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.