From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Mark Brown <broonie@kernel.org>
Cc: Chris Brandt <chris.brandt@renesas.com>,
linux-spi@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-sh@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH 1/8] spi: rspi: Remove useless .set_config_register() check
Date: Mon, 08 Jun 2020 09:59:33 +0000 [thread overview]
Message-ID: <20200608095940.30516-2-geert+renesas@glider.be> (raw)
In-Reply-To: <20200608095940.30516-1-geert+renesas@glider.be>
Not implementing spi_ops.set_config_register() is a driver bug that
would prevent the driver from working at all.
Hence remove the run-time check.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/spi/spi-rspi.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/spi/spi-rspi.c b/drivers/spi/spi-rspi.c
index 06192c9ea8132911..0e786af546c9f513 100644
--- a/drivers/spi/spi-rspi.c
+++ b/drivers/spi/spi-rspi.c
@@ -1247,13 +1247,6 @@ static int rspi_probe(struct platform_device *pdev)
ctlr->num_chipselect = 2; /* default */
}
- /* ops parameter check */
- if (!ops->set_config_register) {
- dev_err(&pdev->dev, "there is no set_config_register\n");
- ret = -ENODEV;
- goto error1;
- }
-
rspi = spi_controller_get_devdata(ctlr);
platform_set_drvdata(pdev, rspi);
rspi->ops = ops;
--
2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Mark Brown <broonie@kernel.org>
Cc: Chris Brandt <chris.brandt@renesas.com>,
linux-spi@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-sh@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH 1/8] spi: rspi: Remove useless .set_config_register() check
Date: Mon, 8 Jun 2020 11:59:33 +0200 [thread overview]
Message-ID: <20200608095940.30516-2-geert+renesas@glider.be> (raw)
In-Reply-To: <20200608095940.30516-1-geert+renesas@glider.be>
Not implementing spi_ops.set_config_register() is a driver bug that
would prevent the driver from working at all.
Hence remove the run-time check.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/spi/spi-rspi.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/spi/spi-rspi.c b/drivers/spi/spi-rspi.c
index 06192c9ea8132911..0e786af546c9f513 100644
--- a/drivers/spi/spi-rspi.c
+++ b/drivers/spi/spi-rspi.c
@@ -1247,13 +1247,6 @@ static int rspi_probe(struct platform_device *pdev)
ctlr->num_chipselect = 2; /* default */
}
- /* ops parameter check */
- if (!ops->set_config_register) {
- dev_err(&pdev->dev, "there is no set_config_register\n");
- ret = -ENODEV;
- goto error1;
- }
-
rspi = spi_controller_get_devdata(ctlr);
platform_set_drvdata(pdev, rspi);
rspi->ops = ops;
--
2.17.1
next prev parent reply other threads:[~2020-06-08 9:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 9:59 [PATCH 0/8] spi: rspi: Bit rate improvements Geert Uytterhoeven
2020-06-08 9:59 ` Geert Uytterhoeven
2020-06-08 9:59 ` Geert Uytterhoeven [this message]
2020-06-08 9:59 ` [PATCH 1/8] spi: rspi: Remove useless .set_config_register() check Geert Uytterhoeven
2020-06-08 9:59 ` [PATCH 2/8] spi: rspi: Use requested instead of maximum bit rate Geert Uytterhoeven
2020-06-08 9:59 ` Geert Uytterhoeven
2020-06-08 9:59 ` [PATCH 3/8] spi: rspi: Clean up Bit Rate Division Setting handling Geert Uytterhoeven
2020-06-08 9:59 ` Geert Uytterhoeven
2020-06-08 9:59 ` [PATCH 4/8] spi: rspi: Increase bit rate accuracy on RZ/A Geert Uytterhoeven
2020-06-08 9:59 ` Geert Uytterhoeven
2020-06-08 9:59 ` [PATCH 5/8] spi: rspi: Increase bit rate range for RSPI on SH Geert Uytterhoeven
2020-06-08 9:59 ` Geert Uytterhoeven
2020-06-08 9:59 ` [PATCH 6/8] spi: rspi: Increase bit rate range for QSPI Geert Uytterhoeven
2020-06-08 9:59 ` Geert Uytterhoeven
2020-06-08 9:59 ` [PATCH 7/8] spi: rspi: Fill in spi_transfer.effective_speed_hz Geert Uytterhoeven
2020-06-08 9:59 ` Geert Uytterhoeven
2020-06-08 9:59 ` [PATCH 8/8] spi: rspi: Fill in controller speed limits Geert Uytterhoeven
2020-06-08 9:59 ` Geert Uytterhoeven
2020-06-09 12:54 ` [PATCH 0/8] spi: rspi: Bit rate improvements Mark Brown
2020-06-09 12:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200608095940.30516-2-geert+renesas@glider.be \
--to=geert+renesas@glider.be \
--cc=broonie@kernel.org \
--cc=chris.brandt@renesas.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.