Re: [RFC 12/12] rpmsg: add a device ID to also bind to the ADSP device

From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Cc: kvm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	sound-open-firmware@alsa-project.org,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Liam Girdwood <liam.r.girdwood@linux.intel.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	Ohad Ben-Cohen <ohad@wizery.com>,
	Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [RFC 12/12] rpmsg: add a device ID to also bind to the ADSP device
Date: Mon, 8 Jun 2020 10:17:57 -0600	[thread overview]
Message-ID: <20200608161757.GA32518@xps15> (raw)
In-Reply-To: <20200605064659.GC32302@ubuntu>

On Fri, Jun 05, 2020 at 08:46:59AM +0200, Guennadi Liakhovetski wrote:
> Hi Mathieu,
> 
> On Thu, Jun 04, 2020 at 02:01:56PM -0600, Mathieu Poirier wrote:
> > On Fri, May 29, 2020 at 09:37:22AM +0200, Guennadi Liakhovetski wrote:
> > > The ADSP device uses the RPMsg API to connect vhost and VirtIO SOF
> > > Audio DSP drivers on KVM host and guest.
> > > 
> > > Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
> > > ---
> > >  drivers/rpmsg/virtio_rpmsg_bus.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c
> > > index f3bd050..ebe3f19 100644
> > > --- a/drivers/rpmsg/virtio_rpmsg_bus.c
> > > +++ b/drivers/rpmsg/virtio_rpmsg_bus.c
> > > @@ -949,6 +949,7 @@ static void rpmsg_remove(struct virtio_device *vdev)
> > >  
> > >  static struct virtio_device_id id_table[] = {
> > >  	{ VIRTIO_ID_RPMSG, VIRTIO_DEV_ANY_ID },
> > > +	{ VIRTIO_ID_ADSP, VIRTIO_DEV_ANY_ID },
> > 
> > I am fine with this patch but won't add an RB because of the (many) checkpatch
> > errors.  Based on the comment I made on the previous set seeing those was
> > unexpected.
> 
> Are you using "--strict?" Sorry, I don't see any checkpatch errors, only warnings. 

No, plane checkpatch on the rproc-next branch.

> Most of them are "over 80 characters" which as we now know is no more an issue,

There is a thread discussing the matter but I have not seen a clear resolution
yet.

> I just haven't updated my tree yet. Most others are really minor IMHO. Maybe one

Minor or not, if checkpatch complains then it is important enough to address.  I
am willing to overlook the lines over 80 characters but everything else needs to
be dealt with.

Thanks,
Mathieu

> of them I actually would want to fix - using "help" instead of "---help---" in 
> Kconfig. What errors are you seeing in your checks?
> 
> Thanks
> Guennadi
> 
> > Thanks,
> > Mathieu
> > 
> > >  	{ 0 },
> > >  };
> > >  
> > > -- 
> > > 1.9.3
> > > 