From: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com> To: Mathieu Poirier <mathieu.poirier@linaro.org> Cc: kvm@vger.kernel.org, linux-remoteproc@vger.kernel.org, virtualization@lists.linux-foundation.org, sound-open-firmware@alsa-project.org, Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, Liam Girdwood <liam.r.girdwood@linux.intel.com>, "Michael S. Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>, Ohad Ben-Cohen <ohad@wizery.com>, Bjorn Andersson <bjorn.andersson@linaro.org> Subject: Re: [RFC 12/12] rpmsg: add a device ID to also bind to the ADSP device Date: Mon, 8 Jun 2020 19:02:27 +0200 [thread overview] Message-ID: <20200608170227.GG10562@ubuntu> (raw) In-Reply-To: <20200608161757.GA32518@xps15> Hi Mathieu, On Mon, Jun 08, 2020 at 10:17:57AM -0600, Mathieu Poirier wrote: > On Fri, Jun 05, 2020 at 08:46:59AM +0200, Guennadi Liakhovetski wrote: > > Hi Mathieu, > > > > On Thu, Jun 04, 2020 at 02:01:56PM -0600, Mathieu Poirier wrote: > > > On Fri, May 29, 2020 at 09:37:22AM +0200, Guennadi Liakhovetski wrote: > > > > The ADSP device uses the RPMsg API to connect vhost and VirtIO SOF > > > > Audio DSP drivers on KVM host and guest. > > > > > > > > Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com> > > > > --- > > > > drivers/rpmsg/virtio_rpmsg_bus.c | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c > > > > index f3bd050..ebe3f19 100644 > > > > --- a/drivers/rpmsg/virtio_rpmsg_bus.c > > > > +++ b/drivers/rpmsg/virtio_rpmsg_bus.c > > > > @@ -949,6 +949,7 @@ static void rpmsg_remove(struct virtio_device *vdev) > > > > > > > > static struct virtio_device_id id_table[] = { > > > > { VIRTIO_ID_RPMSG, VIRTIO_DEV_ANY_ID }, > > > > + { VIRTIO_ID_ADSP, VIRTIO_DEV_ANY_ID }, > > > > > > I am fine with this patch but won't add an RB because of the (many) checkpatch > > > errors. Based on the comment I made on the previous set seeing those was > > > unexpected. > > > > Are you using "--strict?" Sorry, I don't see any checkpatch errors, only warnings. > > No, plane checkpatch on the rproc-next branch. > > > Most of them are "over 80 characters" which as we now know is no more an issue, > > There is a thread discussing the matter but I have not seen a clear resolution > yet. I think the resolution is pretty clear as defined by Linus, but maybe it has changed again since I last checked. > > I just haven't updated my tree yet. Most others are really minor IMHO. Maybe one > > Minor or not, if checkpatch complains then it is important enough to address. I > am willing to overlook the lines over 80 characters but everything else needs to > be dealt with. Sure, checkpatch should be run before each patch submission and whatever it reports should be considered. As Documentation/process/submitting-patches.rst clearly states: "Check your patches with the patch style checker prior to submission (scripts/checkpatch.pl). Note, though, that the style checker should be viewed as a guide, not as a replacement for human judgment. If your code looks better with a violation then its probably best left alone." So, yes, I checked all what checkepatch reported and used my judgement to decide which recommendations to take and which to ignore. Thanks Guennadi > Thanks, > Mathieu > > > of them I actually would want to fix - using "help" instead of "---help---" in > > Kconfig. What errors are you seeing in your checks? > > > > Thanks > > Guennadi > > > > > Thanks, > > > Mathieu > > > > > > > { 0 }, > > > > }; > > > > > > > > -- > > > > 1.9.3 > > > >
WARNING: multiple messages have this Message-ID (diff)
From: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com> To: Mathieu Poirier <mathieu.poirier@linaro.org> Cc: Ohad Ben-Cohen <ohad@wizery.com>, kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>, linux-remoteproc@vger.kernel.org, Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, virtualization@lists.linux-foundation.org, Liam Girdwood <liam.r.girdwood@linux.intel.com>, Bjorn Andersson <bjorn.andersson@linaro.org>, sound-open-firmware@alsa-project.org Subject: Re: [RFC 12/12] rpmsg: add a device ID to also bind to the ADSP device Date: Mon, 8 Jun 2020 19:02:27 +0200 [thread overview] Message-ID: <20200608170227.GG10562@ubuntu> (raw) In-Reply-To: <20200608161757.GA32518@xps15> Hi Mathieu, On Mon, Jun 08, 2020 at 10:17:57AM -0600, Mathieu Poirier wrote: > On Fri, Jun 05, 2020 at 08:46:59AM +0200, Guennadi Liakhovetski wrote: > > Hi Mathieu, > > > > On Thu, Jun 04, 2020 at 02:01:56PM -0600, Mathieu Poirier wrote: > > > On Fri, May 29, 2020 at 09:37:22AM +0200, Guennadi Liakhovetski wrote: > > > > The ADSP device uses the RPMsg API to connect vhost and VirtIO SOF > > > > Audio DSP drivers on KVM host and guest. > > > > > > > > Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com> > > > > --- > > > > drivers/rpmsg/virtio_rpmsg_bus.c | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c > > > > index f3bd050..ebe3f19 100644 > > > > --- a/drivers/rpmsg/virtio_rpmsg_bus.c > > > > +++ b/drivers/rpmsg/virtio_rpmsg_bus.c > > > > @@ -949,6 +949,7 @@ static void rpmsg_remove(struct virtio_device *vdev) > > > > > > > > static struct virtio_device_id id_table[] = { > > > > { VIRTIO_ID_RPMSG, VIRTIO_DEV_ANY_ID }, > > > > + { VIRTIO_ID_ADSP, VIRTIO_DEV_ANY_ID }, > > > > > > I am fine with this patch but won't add an RB because of the (many) checkpatch > > > errors. Based on the comment I made on the previous set seeing those was > > > unexpected. > > > > Are you using "--strict?" Sorry, I don't see any checkpatch errors, only warnings. > > No, plane checkpatch on the rproc-next branch. > > > Most of them are "over 80 characters" which as we now know is no more an issue, > > There is a thread discussing the matter but I have not seen a clear resolution > yet. I think the resolution is pretty clear as defined by Linus, but maybe it has changed again since I last checked. > > I just haven't updated my tree yet. Most others are really minor IMHO. Maybe one > > Minor or not, if checkpatch complains then it is important enough to address. I > am willing to overlook the lines over 80 characters but everything else needs to > be dealt with. Sure, checkpatch should be run before each patch submission and whatever it reports should be considered. As Documentation/process/submitting-patches.rst clearly states: "Check your patches with the patch style checker prior to submission (scripts/checkpatch.pl). Note, though, that the style checker should be viewed as a guide, not as a replacement for human judgment. If your code looks better with a violation then its probably best left alone." So, yes, I checked all what checkepatch reported and used my judgement to decide which recommendations to take and which to ignore. Thanks Guennadi > Thanks, > Mathieu > > > of them I actually would want to fix - using "help" instead of "---help---" in > > Kconfig. What errors are you seeing in your checks? > > > > Thanks > > Guennadi > > > > > Thanks, > > > Mathieu > > > > > > > { 0 }, > > > > }; > > > > > > > > -- > > > > 1.9.3 > > > >
next prev parent reply other threads:[~2020-06-08 17:02 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-29 7:37 [RFC 00/12] Audio DSP VirtIO and vhost drivers Guennadi Liakhovetski 2020-05-29 7:37 ` [RFC 01/12] ASoC: add function parameters to enable forced path pruning Guennadi Liakhovetski 2020-05-29 7:37 ` Guennadi Liakhovetski 2020-05-29 7:37 ` [RFC 02/12] ASoC: SOF: extract firmware-related operation into a function Guennadi Liakhovetski 2020-05-29 7:37 ` [RFC 03/12] ASoC: SOF: support IPC with immediate response Guennadi Liakhovetski 2020-05-29 7:37 ` Guennadi Liakhovetski 2020-05-29 7:37 ` [RFC 04/12] ASoC: SOF: add a power status IPC Guennadi Liakhovetski 2020-05-29 7:37 ` Guennadi Liakhovetski 2020-05-29 7:37 ` [RFC 05/12] ASoC: SOF: add two helper lookup functions Guennadi Liakhovetski 2020-05-29 7:37 ` Guennadi Liakhovetski 2020-05-29 7:37 ` [RFC 06/12] ASoC: SOF: add an RPMsg VirtIO DSP driver Guennadi Liakhovetski 2020-05-29 7:37 ` Guennadi Liakhovetski 2020-05-29 7:37 ` [RFC 07/12] ASoC: SOF: use a macro instead of a hard-coded value Guennadi Liakhovetski 2020-05-29 7:37 ` Guennadi Liakhovetski 2020-05-29 7:37 ` [RFC 08/12] ASoC: SOF: add a vhost driver: sound part Guennadi Liakhovetski 2020-05-29 7:37 ` Guennadi Liakhovetski 2020-05-29 7:37 ` [RFC 09/12] ASoC: SOF: VirtIO: free guest pipelines upon termination Guennadi Liakhovetski 2020-05-29 7:37 ` Guennadi Liakhovetski 2020-05-29 7:37 ` [RFC 10/12] vhost: add an SOF Audio DSP driver Guennadi Liakhovetski 2020-05-29 7:37 ` Guennadi Liakhovetski 2020-05-29 7:37 ` [RFC 11/12] rpmsg: increase buffer size and reduce buffer number Guennadi Liakhovetski 2020-05-29 7:37 ` Guennadi Liakhovetski 2020-06-04 19:58 ` Mathieu Poirier 2020-06-05 6:37 ` Guennadi Liakhovetski 2020-05-29 7:37 ` [RFC 12/12] rpmsg: add a device ID to also bind to the ADSP device Guennadi Liakhovetski 2020-05-29 7:37 ` Guennadi Liakhovetski 2020-06-04 20:01 ` Mathieu Poirier 2020-06-05 6:46 ` Guennadi Liakhovetski 2020-06-08 16:17 ` Mathieu Poirier 2020-06-08 17:02 ` Guennadi Liakhovetski [this message] 2020-06-08 17:02 ` Guennadi Liakhovetski 2020-06-09 16:26 ` Mathieu Poirier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200608170227.GG10562@ubuntu \ --to=guennadi.liakhovetski@linux.intel.com \ --cc=bjorn.andersson@linaro.org \ --cc=jasowang@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=liam.r.girdwood@linux.intel.com \ --cc=linux-remoteproc@vger.kernel.org \ --cc=mathieu.poirier@linaro.org \ --cc=mst@redhat.com \ --cc=ohad@wizery.com \ --cc=pierre-louis.bossart@linux.intel.com \ --cc=sound-open-firmware@alsa-project.org \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.