From: refactormyself@gmail.com To: helgaas@kernel.org Cc: Bolarinwa Olayemi Saheed <refactormyself@gmail.com>, bjorn@helgaas.com, linux-pci@vger.kernel.org, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 8/8] PCI: Align return values of PCIe capability and PCI accessors Date: Mon, 15 Jun 2020 09:32:25 +0200 [thread overview] Message-ID: <20200615073225.24061-9-refactormyself@gmail.com> (raw) In-Reply-To: <20200615073225.24061-1-refactormyself@gmail.com> From: Bolarinwa Olayemi Saheed <refactormyself@gmail.com> The PCIe capability accessors can return 0, -EINVAL, or any PCIBIOS_ error code. PCIBIOS_ error codes have positive values. The PCI accessor on the other hand can only return 0 or any PCIBIOS_ error code. This inconsistency among these accessor makes it harder for callers to check for errors. Return PCIBIOS_BAD_REGISTER_NUMBER instead of -EINVAL in all PCIe capability accessors. Suggested-by: Bjorn Helgaas <bjorn@helgaas.com> Signed-off-by: Bolarinwa Olayemi Saheed <refactormyself@gmail.com> --- drivers/pci/access.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pci/access.c b/drivers/pci/access.c index 79c4a2ef269a..cbb3804903a0 100644 --- a/drivers/pci/access.c +++ b/drivers/pci/access.c @@ -409,7 +409,7 @@ int pcie_capability_read_word(struct pci_dev *dev, int pos, u16 *val) *val = 0; if (pos & 1) - return -EINVAL; + return PCIBIOS_BAD_REGISTER_NUMBER; if (pcie_capability_reg_implemented(dev, pos)) { ret = pci_read_config_word(dev, pci_pcie_cap(dev) + pos, val); @@ -444,7 +444,7 @@ int pcie_capability_read_dword(struct pci_dev *dev, int pos, u32 *val) *val = 0; if (pos & 3) - return -EINVAL; + return PCIBIOS_BAD_REGISTER_NUMBER; if (pcie_capability_reg_implemented(dev, pos)) { ret = pci_read_config_dword(dev, pci_pcie_cap(dev) + pos, val); @@ -469,7 +469,7 @@ EXPORT_SYMBOL(pcie_capability_read_dword); int pcie_capability_write_word(struct pci_dev *dev, int pos, u16 val) { if (pos & 1) - return -EINVAL; + return PCIBIOS_BAD_REGISTER_NUMBER; if (!pcie_capability_reg_implemented(dev, pos)) return 0; @@ -481,7 +481,7 @@ EXPORT_SYMBOL(pcie_capability_write_word); int pcie_capability_write_dword(struct pci_dev *dev, int pos, u32 val) { if (pos & 3) - return -EINVAL; + return PCIBIOS_BAD_REGISTER_NUMBER; if (!pcie_capability_reg_implemented(dev, pos)) return 0; -- 2.18.2
WARNING: multiple messages have this Message-ID (diff)
From: refactormyself@gmail.com To: helgaas@kernel.org Cc: Bolarinwa Olayemi Saheed <refactormyself@gmail.com>, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: [Linux-kernel-mentees] [PATCH v2 8/8] PCI: Align return values of PCIe capability and PCI accessors Date: Mon, 15 Jun 2020 09:32:25 +0200 [thread overview] Message-ID: <20200615073225.24061-9-refactormyself@gmail.com> (raw) In-Reply-To: <20200615073225.24061-1-refactormyself@gmail.com> From: Bolarinwa Olayemi Saheed <refactormyself@gmail.com> The PCIe capability accessors can return 0, -EINVAL, or any PCIBIOS_ error code. PCIBIOS_ error codes have positive values. The PCI accessor on the other hand can only return 0 or any PCIBIOS_ error code. This inconsistency among these accessor makes it harder for callers to check for errors. Return PCIBIOS_BAD_REGISTER_NUMBER instead of -EINVAL in all PCIe capability accessors. Suggested-by: Bjorn Helgaas <bjorn@helgaas.com> Signed-off-by: Bolarinwa Olayemi Saheed <refactormyself@gmail.com> --- drivers/pci/access.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pci/access.c b/drivers/pci/access.c index 79c4a2ef269a..cbb3804903a0 100644 --- a/drivers/pci/access.c +++ b/drivers/pci/access.c @@ -409,7 +409,7 @@ int pcie_capability_read_word(struct pci_dev *dev, int pos, u16 *val) *val = 0; if (pos & 1) - return -EINVAL; + return PCIBIOS_BAD_REGISTER_NUMBER; if (pcie_capability_reg_implemented(dev, pos)) { ret = pci_read_config_word(dev, pci_pcie_cap(dev) + pos, val); @@ -444,7 +444,7 @@ int pcie_capability_read_dword(struct pci_dev *dev, int pos, u32 *val) *val = 0; if (pos & 3) - return -EINVAL; + return PCIBIOS_BAD_REGISTER_NUMBER; if (pcie_capability_reg_implemented(dev, pos)) { ret = pci_read_config_dword(dev, pci_pcie_cap(dev) + pos, val); @@ -469,7 +469,7 @@ EXPORT_SYMBOL(pcie_capability_read_dword); int pcie_capability_write_word(struct pci_dev *dev, int pos, u16 val) { if (pos & 1) - return -EINVAL; + return PCIBIOS_BAD_REGISTER_NUMBER; if (!pcie_capability_reg_implemented(dev, pos)) return 0; @@ -481,7 +481,7 @@ EXPORT_SYMBOL(pcie_capability_write_word); int pcie_capability_write_dword(struct pci_dev *dev, int pos, u32 val) { if (pos & 3) - return -EINVAL; + return PCIBIOS_BAD_REGISTER_NUMBER; if (!pcie_capability_reg_implemented(dev, pos)) return 0; -- 2.18.2 _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-06-15 8:32 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-15 7:32 [PATCH 0/8 v2] PCI: Align return values of PCIe capability and PCI accessors refactormyself 2020-06-15 7:32 ` [Linux-kernel-mentees] " refactormyself 2020-06-15 7:32 ` refactormyself 2020-06-15 7:32 ` [PATCH v2 1/8] dmaengine: ioatdma: Convert PCIBIOS_* errors to generic -E* errors refactormyself 2020-06-15 7:32 ` [Linux-kernel-mentees] " refactormyself 2020-06-15 7:32 ` [PATCH v2 2/8] IB/hfi1: " refactormyself 2020-06-15 7:32 ` [Linux-kernel-mentees] " refactormyself 2020-06-29 20:09 ` Dennis Dalessandro 2020-06-29 20:09 ` [Linux-kernel-mentees] " Dennis Dalessandro 2020-06-15 7:32 ` [PATCH v2 3/8] " refactormyself 2020-06-15 7:32 ` [Linux-kernel-mentees] " refactormyself 2020-06-29 20:22 ` Dennis Dalessandro 2020-06-29 20:22 ` [Linux-kernel-mentees] " Dennis Dalessandro 2020-06-15 7:32 ` [PATCH v2 4/8] PCI: " refactormyself 2020-06-15 7:32 ` [Linux-kernel-mentees] " refactormyself 2020-06-15 7:32 ` [PATCH v2 5/8] scsi: smartpqi: " refactormyself 2020-06-15 7:32 ` [Linux-kernel-mentees] " refactormyself 2020-06-15 7:32 ` [PATCH v2 6/8] PCI/AER: " refactormyself 2020-06-15 7:32 ` [Linux-kernel-mentees] " refactormyself 2020-06-15 7:32 ` refactormyself 2020-06-15 7:32 ` [PATCH v2 7/8] " refactormyself 2020-06-15 7:32 ` [Linux-kernel-mentees] " refactormyself 2020-06-15 7:32 ` refactormyself 2020-06-15 7:32 ` refactormyself [this message] 2020-06-15 7:32 ` [Linux-kernel-mentees] [PATCH v2 8/8] PCI: Align return values of PCIe capability and PCI accessors refactormyself 2020-06-15 13:46 ` [PATCH 0/8 v2] " Jason Gunthorpe 2020-06-15 13:46 ` [Linux-kernel-mentees] " Jason Gunthorpe 2020-06-15 13:46 ` Jason Gunthorpe 2020-06-26 18:52 ` Bjorn Helgaas 2020-06-26 18:52 ` [Linux-kernel-mentees] " Bjorn Helgaas 2020-06-26 18:52 ` Bjorn Helgaas 2020-06-30 16:24 ` Jason Gunthorpe 2020-06-30 16:24 ` [Linux-kernel-mentees] " Jason Gunthorpe 2020-06-30 16:24 ` Jason Gunthorpe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200615073225.24061-9-refactormyself@gmail.com \ --to=refactormyself@gmail.com \ --cc=bjorn@helgaas.com \ --cc=helgaas@kernel.org \ --cc=linux-kernel-mentees@lists.linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=skhan@linuxfoundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.