From: Tony Lindgren <tony@atomide.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>,
linux-omap@vger.kernel.org, "Andrew F . Davis" <afd@ti.com>,
Dave Gerlach <d-gerlach@ti.com>, Faiz Abbas <faiz_abbas@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Keerthy <j-keerthy@ti.com>, Nishanth Menon <nm@ti.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Roger Quadros <rogerq@ti.com>, Suman Anna <s-anna@ti.com>,
Tero Kristo <t-kristo@ti.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH 1/5] drm/omap: Fix suspend resume regression after platform data removal
Date: Tue, 16 Jun 2020 08:30:42 -0700 [thread overview]
Message-ID: <20200616153042.GZ37466@atomide.com> (raw)
In-Reply-To: <592501c9-2d94-b266-ae76-e383d3bffa29@ti.com>
* Tomi Valkeinen <tomi.valkeinen@ti.com> [200616 13:02]:
> On 11/06/2020 17:00, Grygorii Strashko wrote:
> > I think, suspend might be fixed if all devices, which are now child of ti-sysc, will do
> > pm_runtime_force_xxx() calls at noirq suspend stage by adding:
> >
> > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
> > pm_runtime_force_resume)
> >
> > Am I missing smth?
>
> Isn't this almost exactly the same my patch does? I just used suspend_late
> and resume_early. Is noirq phase better than late & early?
Well up to you as far as I'm concerned. The noirq phase comes with serious
limitations, for let's say i2c bus usage if needed. Probably also harder
to debug for suspend and resume.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Nishanth Menon <nm@ti.com>, Tero Kristo <t-kristo@ti.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Dave Gerlach <d-gerlach@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
"Andrew F . Davis" <afd@ti.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Faiz Abbas <faiz_abbas@ti.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Keerthy <j-keerthy@ti.com>, Suman Anna <s-anna@ti.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Roger Quadros <rogerq@ti.com>
Subject: Re: [PATCH 1/5] drm/omap: Fix suspend resume regression after platform data removal
Date: Tue, 16 Jun 2020 08:30:42 -0700 [thread overview]
Message-ID: <20200616153042.GZ37466@atomide.com> (raw)
In-Reply-To: <592501c9-2d94-b266-ae76-e383d3bffa29@ti.com>
* Tomi Valkeinen <tomi.valkeinen@ti.com> [200616 13:02]:
> On 11/06/2020 17:00, Grygorii Strashko wrote:
> > I think, suspend might be fixed if all devices, which are now child of ti-sysc, will do
> > pm_runtime_force_xxx() calls at noirq suspend stage by adding:
> >
> > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
> > pm_runtime_force_resume)
> >
> > Am I missing smth?
>
> Isn't this almost exactly the same my patch does? I just used suspend_late
> and resume_early. Is noirq phase better than late & early?
Well up to you as far as I'm concerned. The noirq phase comes with serious
limitations, for let's say i2c bus usage if needed. Probably also harder
to debug for suspend and resume.
Regards,
Tony
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Nishanth Menon <nm@ti.com>, Tero Kristo <t-kristo@ti.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Dave Gerlach <d-gerlach@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
"Andrew F . Davis" <afd@ti.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Faiz Abbas <faiz_abbas@ti.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Keerthy <j-keerthy@ti.com>, Suman Anna <s-anna@ti.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Roger Quadros <rogerq@ti.com>
Subject: Re: [PATCH 1/5] drm/omap: Fix suspend resume regression after platform data removal
Date: Tue, 16 Jun 2020 08:30:42 -0700 [thread overview]
Message-ID: <20200616153042.GZ37466@atomide.com> (raw)
In-Reply-To: <592501c9-2d94-b266-ae76-e383d3bffa29@ti.com>
* Tomi Valkeinen <tomi.valkeinen@ti.com> [200616 13:02]:
> On 11/06/2020 17:00, Grygorii Strashko wrote:
> > I think, suspend might be fixed if all devices, which are now child of ti-sysc, will do
> > pm_runtime_force_xxx() calls at noirq suspend stage by adding:
> >
> > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
> > pm_runtime_force_resume)
> >
> > Am I missing smth?
>
> Isn't this almost exactly the same my patch does? I just used suspend_late
> and resume_early. Is noirq phase better than late & early?
Well up to you as far as I'm concerned. The noirq phase comes with serious
limitations, for let's say i2c bus usage if needed. Probably also harder
to debug for suspend and resume.
Regards,
Tony
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-06-16 15:30 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-31 19:39 [PATCH 0/5] Suspend and resume fixes for omapdrm pdata removal Tony Lindgren
2020-05-31 19:39 ` Tony Lindgren
2020-05-31 19:39 ` Tony Lindgren
2020-05-31 19:39 ` [PATCH 1/5] drm/omap: Fix suspend resume regression after platform data removal Tony Lindgren
2020-05-31 19:39 ` Tony Lindgren
2020-05-31 19:39 ` Tony Lindgren
2020-06-03 12:33 ` Tomi Valkeinen
2020-06-03 12:33 ` Tomi Valkeinen
2020-06-03 12:33 ` Tomi Valkeinen
2020-06-03 14:06 ` Tony Lindgren
2020-06-03 14:06 ` Tony Lindgren
2020-06-03 14:06 ` Tony Lindgren
2020-06-09 7:04 ` Tomi Valkeinen
2020-06-09 7:04 ` Tomi Valkeinen
2020-06-09 7:04 ` Tomi Valkeinen
2020-06-09 15:19 ` Tony Lindgren
2020-06-09 15:19 ` Tony Lindgren
2020-06-09 15:19 ` Tony Lindgren
2020-06-09 15:26 ` Tomi Valkeinen
2020-06-09 15:26 ` Tomi Valkeinen
2020-06-09 15:26 ` Tomi Valkeinen
2020-06-09 16:52 ` Tony Lindgren
2020-06-09 16:52 ` Tony Lindgren
2020-06-09 16:52 ` Tony Lindgren
2020-06-09 17:10 ` Tony Lindgren
2020-06-09 17:10 ` Tony Lindgren
2020-06-09 17:10 ` Tony Lindgren
2020-06-09 17:26 ` Tony Lindgren
2020-06-09 17:26 ` Tony Lindgren
2020-06-09 17:26 ` Tony Lindgren
2020-06-10 11:47 ` Tomi Valkeinen
2020-06-10 11:47 ` Tomi Valkeinen
2020-06-10 11:47 ` Tomi Valkeinen
2020-06-10 22:41 ` Tony Lindgren
2020-06-10 22:41 ` Tony Lindgren
2020-06-10 22:41 ` Tony Lindgren
2020-06-11 14:00 ` Grygorii Strashko
2020-06-11 14:00 ` Grygorii Strashko
2020-06-11 14:00 ` Grygorii Strashko
2020-06-11 14:32 ` Tony Lindgren
2020-06-11 14:32 ` Tony Lindgren
2020-06-11 14:32 ` Tony Lindgren
2020-06-16 13:01 ` Tomi Valkeinen
2020-06-16 13:01 ` Tomi Valkeinen
2020-06-16 13:01 ` Tomi Valkeinen
2020-06-16 15:30 ` Tony Lindgren [this message]
2020-06-16 15:30 ` Tony Lindgren
2020-06-16 15:30 ` Tony Lindgren
2020-06-16 16:56 ` Grygorii Strashko
2020-06-16 16:56 ` Grygorii Strashko
2020-06-16 16:56 ` Grygorii Strashko
2020-06-17 6:04 ` Tomi Valkeinen
2020-06-17 6:04 ` Tomi Valkeinen
2020-06-17 6:04 ` Tomi Valkeinen
2020-06-17 12:49 ` Grygorii Strashko
2020-06-17 12:49 ` Grygorii Strashko
2020-06-17 12:49 ` Grygorii Strashko
2020-05-31 19:39 ` [PATCH 2/5] bus: ti-sysc: Use optional clocks on for enable and wait for softreset bit Tony Lindgren
2020-05-31 19:39 ` Tony Lindgren
2020-05-31 19:39 ` Tony Lindgren
2020-06-01 2:19 ` kbuild test robot
2020-06-01 2:19 ` kbuild test robot
2020-06-01 15:01 ` Tony Lindgren
2020-06-01 15:01 ` Tony Lindgren
2020-05-31 19:39 ` [PATCH 3/5] bus: ti-sysc: Ignore clockactivity unless specified as a quirk Tony Lindgren
2020-05-31 19:39 ` Tony Lindgren
2020-05-31 19:39 ` Tony Lindgren
2020-05-31 19:39 ` [PATCH 4/5] bus: ti-sysc: Fix uninitialized framedonetv_irq Tony Lindgren
2020-05-31 19:39 ` Tony Lindgren
2020-05-31 19:39 ` Tony Lindgren
2020-05-31 19:39 ` [PATCH 5/5] ARM: OMAP2+: Fix legacy mode dss_reset Tony Lindgren
2020-05-31 19:39 ` Tony Lindgren
2020-05-31 19:39 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616153042.GZ37466@atomide.com \
--to=tony@atomide.com \
--cc=afd@ti.com \
--cc=d-gerlach@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=faiz_abbas@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=grygorii.strashko@ti.com \
--cc=j-keerthy@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=rogerq@ti.com \
--cc=s-anna@ti.com \
--cc=t-kristo@ti.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.