From: Keith Busch <kbusch@kernel.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: "Keith Busch" <keith.busch@wdc.com>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
"Damien Le Moal" <damien.lemoal@wdc.com>,
"Matias Bjørling" <matias.bjorling@wdc.com>,
"Christoph Hellwig" <hch@lst.de>,
"Sagi Grimberg" <sagi@grimberg.me>,
"Jens Axboe" <axboe@kernel.dk>,
"Niklas Cassel" <niklas.cassel@wdc.com>
Subject: Re: [PATCH 3/5] nvme: implement I/O Command Sets Command Set support
Date: Tue, 16 Jun 2020 10:01:35 -0700 [thread overview]
Message-ID: <20200616170135.GC521206@dhcp-10-100-145-180.wdl.wdc.com> (raw)
In-Reply-To: <yq1ftavm29u.fsf@ca-mkp.ca.oracle.com>
On Tue, Jun 16, 2020 at 11:58:59AM -0400, Martin K. Petersen wrote:
> > @@ -1113,8 +1126,9 @@ static int nvme_identify_ns_descs(struct nvme_ctrl *ctrl, unsigned nsid,
> > status = nvme_submit_sync_cmd(ctrl->admin_q, &c, data,
> > NVME_IDENTIFY_DATA_SIZE);
> > if (status) {
> > - dev_warn(ctrl->device,
> > - "Identify Descriptors failed (%d)\n", status);
> > + if (ctrl->vs >= NVME_VS(1, 3, 0))
> > + dev_warn(ctrl->device,
> > + "Identify Descriptors failed (%d)\n", status);
>
> Not a biggie but maybe this should be a separate patch?
Actually I think we can just get rid of this check before the warning.
We only call this function if the version is >= 1.3 or if multi-css was
selected. Both of those require this identification be supported.
> > @@ -1808,7 +1828,8 @@ static bool nvme_ns_ids_equal(struct
> > nvme_ns_ids *a, struct nvme_ns_ids *b) { return uuid_equal(&a->uuid,
> > &b->uuid) && memcmp(&a->nguid, &b->nguid, sizeof(a->nguid)) == 0 &&
> > - memcmp(&a->eui64, &b->eui64, sizeof(a->eui64)) == 0; +
> > memcmp(&a->eui64, &b->eui64, sizeof(a->eui64)) == 0 && +
> > a->csi == b->csi; }
>
> No objection to defensive programming. But wouldn't this be a broken
> device?
It could be a broken device, but I think it's checking against mistaken
identify, like if we're racing with namespace management commands
deleting and recreating namespaces that the driver is still bound to.
WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <kbusch@kernel.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: "Jens Axboe" <axboe@kernel.dk>,
"Niklas Cassel" <niklas.cassel@wdc.com>,
"Damien Le Moal" <damien.lemoal@wdc.com>,
"Sagi Grimberg" <sagi@grimberg.me>,
"Keith Busch" <keith.busch@wdc.com>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
"Christoph Hellwig" <hch@lst.de>,
"Matias Bjørling" <matias.bjorling@wdc.com>
Subject: Re: [PATCH 3/5] nvme: implement I/O Command Sets Command Set support
Date: Tue, 16 Jun 2020 10:01:35 -0700 [thread overview]
Message-ID: <20200616170135.GC521206@dhcp-10-100-145-180.wdl.wdc.com> (raw)
In-Reply-To: <yq1ftavm29u.fsf@ca-mkp.ca.oracle.com>
On Tue, Jun 16, 2020 at 11:58:59AM -0400, Martin K. Petersen wrote:
> > @@ -1113,8 +1126,9 @@ static int nvme_identify_ns_descs(struct nvme_ctrl *ctrl, unsigned nsid,
> > status = nvme_submit_sync_cmd(ctrl->admin_q, &c, data,
> > NVME_IDENTIFY_DATA_SIZE);
> > if (status) {
> > - dev_warn(ctrl->device,
> > - "Identify Descriptors failed (%d)\n", status);
> > + if (ctrl->vs >= NVME_VS(1, 3, 0))
> > + dev_warn(ctrl->device,
> > + "Identify Descriptors failed (%d)\n", status);
>
> Not a biggie but maybe this should be a separate patch?
Actually I think we can just get rid of this check before the warning.
We only call this function if the version is >= 1.3 or if multi-css was
selected. Both of those require this identification be supported.
> > @@ -1808,7 +1828,8 @@ static bool nvme_ns_ids_equal(struct
> > nvme_ns_ids *a, struct nvme_ns_ids *b) { return uuid_equal(&a->uuid,
> > &b->uuid) && memcmp(&a->nguid, &b->nguid, sizeof(a->nguid)) == 0 &&
> > - memcmp(&a->eui64, &b->eui64, sizeof(a->eui64)) == 0; +
> > memcmp(&a->eui64, &b->eui64, sizeof(a->eui64)) == 0 && +
> > a->csi == b->csi; }
>
> No objection to defensive programming. But wouldn't this be a broken
> device?
It could be a broken device, but I think it's checking against mistaken
identify, like if we're racing with namespace management commands
deleting and recreating namespaces that the driver is still bound to.
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-06-16 17:01 UTC|newest]
Thread overview: 192+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 23:34 [PATCH 0/5] nvme support for zoned namespace command set Keith Busch
2020-06-15 23:34 ` Keith Busch
2020-06-15 23:34 ` [PATCH 1/5] block: add capacity field to zone descriptors Keith Busch
2020-06-15 23:34 ` Keith Busch
2020-06-15 23:49 ` Chaitanya Kulkarni
2020-06-15 23:49 ` Chaitanya Kulkarni
2020-06-16 10:28 ` Javier González
2020-06-16 10:28 ` Javier González
2020-06-16 13:47 ` Daniel Wagner
2020-06-16 13:47 ` Daniel Wagner
2020-06-16 13:54 ` Johannes Thumshirn
2020-06-16 13:54 ` Johannes Thumshirn
2020-06-16 15:41 ` Martin K. Petersen
2020-06-16 15:41 ` Martin K. Petersen
2020-06-15 23:34 ` [PATCH 2/5] null_blk: introduce zone capacity for zoned device Keith Busch
2020-06-15 23:34 ` Keith Busch
2020-06-15 23:46 ` Chaitanya Kulkarni
2020-06-15 23:46 ` Chaitanya Kulkarni
2020-06-16 14:18 ` Daniel Wagner
2020-06-16 14:18 ` Daniel Wagner
2020-06-16 15:48 ` Martin K. Petersen
2020-06-16 15:48 ` Martin K. Petersen
2020-06-15 23:34 ` [PATCH 3/5] nvme: implement I/O Command Sets Command Set support Keith Busch
2020-06-15 23:34 ` Keith Busch
2020-06-16 10:33 ` Javier González
2020-06-16 10:33 ` Javier González
2020-06-16 17:14 ` Niklas Cassel
2020-06-16 17:14 ` Niklas Cassel
2020-06-16 15:58 ` Martin K. Petersen
2020-06-16 15:58 ` Martin K. Petersen
2020-06-16 17:01 ` Keith Busch [this message]
2020-06-16 17:01 ` Keith Busch
2020-06-17 9:50 ` Niklas Cassel
2020-06-17 9:50 ` Niklas Cassel
2020-06-16 17:06 ` Niklas Cassel
2020-06-16 17:06 ` Niklas Cassel
2020-06-17 2:01 ` Martin K. Petersen
2020-06-17 2:01 ` Martin K. Petersen
2020-06-15 23:34 ` [PATCH 4/5] nvme: support for multi-command set effects Keith Busch
2020-06-15 23:34 ` Keith Busch
2020-06-16 10:34 ` Javier González
2020-06-16 10:34 ` Javier González
2020-06-16 16:03 ` Martin K. Petersen
2020-06-16 16:03 ` Martin K. Petersen
2020-06-15 23:34 ` [PATCH 5/5] nvme: support for zoned namespaces Keith Busch
2020-06-15 23:34 ` Keith Busch
2020-06-16 10:41 ` Javier González
2020-06-16 10:41 ` Javier González
2020-06-16 11:18 ` Matias Bjørling
2020-06-16 11:18 ` Matias Bjørling
2020-06-16 12:00 ` Javier González
2020-06-16 12:00 ` Javier González
2020-06-16 12:06 ` Matias Bjørling
2020-06-16 12:06 ` Matias Bjørling
2020-06-16 12:24 ` Javier González
2020-06-16 12:24 ` Javier González
2020-06-16 12:27 ` Matias Bjørling
2020-06-16 12:27 ` Matias Bjørling
2020-06-16 12:35 ` Damien Le Moal
2020-06-16 12:35 ` Damien Le Moal
[not found] ` <CGME20200616130815uscas1p1be34e5fceaa548eac31fb30790a689d4@uscas1p1.samsung.com>
2020-06-16 13:08 ` Judy Brock
2020-06-16 13:08 ` Judy Brock
2020-06-16 13:32 ` Matias Bjørling
2020-06-16 13:32 ` Matias Bjørling
2020-06-16 13:34 ` Damien Le Moal
2020-06-16 13:34 ` Damien Le Moal
2020-06-16 14:16 ` Javier González
2020-06-16 14:16 ` Javier González
2020-06-16 14:42 ` Damien Le Moal
2020-06-16 14:42 ` Damien Le Moal
2020-06-16 15:02 ` Javier González
2020-06-16 15:02 ` Javier González
2020-06-16 15:20 ` Matias Bjørling
2020-06-16 15:20 ` Matias Bjørling
2020-06-16 16:03 ` Javier González
2020-06-16 16:03 ` Javier González
2020-06-16 16:07 ` Matias Bjorling
2020-06-16 16:07 ` Matias Bjorling
2020-06-16 16:21 ` Javier González
2020-06-16 16:21 ` Javier González
2020-06-16 16:25 ` Matias Bjørling
2020-06-16 16:25 ` Matias Bjørling
2020-06-16 15:48 ` Keith Busch
2020-06-16 15:48 ` Keith Busch
2020-06-16 15:55 ` Javier González
2020-06-16 15:55 ` Javier González
2020-06-16 16:04 ` Matias Bjorling
2020-06-16 16:04 ` Matias Bjorling
2020-06-16 16:07 ` Keith Busch
2020-06-16 16:07 ` Keith Busch
2020-06-16 16:13 ` Javier González
2020-06-16 16:13 ` Javier González
2020-06-17 0:38 ` Damien Le Moal
2020-06-17 0:38 ` Damien Le Moal
2020-06-17 6:18 ` Javier González
2020-06-17 6:18 ` Javier González
2020-06-17 6:54 ` Damien Le Moal
2020-06-17 6:54 ` Damien Le Moal
2020-06-17 7:11 ` Javier González
2020-06-17 7:11 ` Javier González
2020-06-17 7:29 ` Damien Le Moal
2020-06-17 7:29 ` Damien Le Moal
2020-06-17 7:34 ` Javier González
2020-06-17 7:34 ` Javier González
2020-06-17 0:14 ` Damien Le Moal
2020-06-17 0:14 ` Damien Le Moal
2020-06-17 6:09 ` Javier González
2020-06-17 6:09 ` Javier González
2020-06-17 6:47 ` Damien Le Moal
2020-06-17 6:47 ` Damien Le Moal
2020-06-17 7:02 ` Javier González
2020-06-17 7:02 ` Javier González
2020-06-17 7:24 ` Damien Le Moal
2020-06-17 7:24 ` Damien Le Moal
2020-06-17 7:29 ` Javier González
2020-06-17 7:29 ` Javier González
[not found] ` <CGME20200616123503uscas1p22ce22054a1b4152a20437b5abdd55119@uscas1p2.samsung.com>
2020-06-16 12:35 ` Judy Brock
2020-06-16 12:35 ` Judy Brock
2020-06-16 12:37 ` Damien Le Moal
2020-06-16 12:37 ` Damien Le Moal
2020-06-16 12:37 ` Matias Bjørling
2020-06-16 12:37 ` Matias Bjørling
2020-06-16 13:12 ` Judy Brock
2020-06-16 13:12 ` Judy Brock
2020-06-16 13:18 ` Judy Brock
2020-06-16 13:18 ` Judy Brock
2020-06-16 13:32 ` Judy Brock
2020-06-16 13:32 ` Judy Brock
2020-06-16 13:39 ` Damien Le Moal
2020-06-16 13:39 ` Damien Le Moal
2020-06-17 7:43 ` Christoph Hellwig
2020-06-17 7:43 ` Christoph Hellwig
2020-06-17 12:01 ` Martin K. Petersen
2020-06-17 12:01 ` Martin K. Petersen
2020-06-17 15:00 ` Javier González
2020-06-17 15:00 ` Javier González
2020-06-17 14:42 ` Javier González
2020-06-17 14:42 ` Javier González
2020-06-17 17:57 ` Matias Bjørling
2020-06-17 17:57 ` Matias Bjørling
2020-06-17 18:28 ` Javier González
2020-06-17 18:28 ` Javier González
2020-06-17 18:55 ` Matias Bjorling
2020-06-17 18:55 ` Matias Bjorling
2020-06-17 19:09 ` Javier González
2020-06-17 19:09 ` Javier González
2020-06-17 19:23 ` Matias Bjørling
2020-06-17 19:23 ` Matias Bjørling
2020-06-17 19:40 ` Javier González
2020-06-17 19:40 ` Javier González
2020-06-17 23:44 ` Heiner Litz
2020-06-17 23:44 ` Heiner Litz
2020-06-18 1:55 ` Keith Busch
2020-06-18 1:55 ` Keith Busch
2020-06-18 4:24 ` Heiner Litz
2020-06-18 4:24 ` Heiner Litz
2020-06-18 5:15 ` Damien Le Moal
2020-06-18 5:15 ` Damien Le Moal
2020-06-18 20:47 ` Heiner Litz
2020-06-18 20:47 ` Heiner Litz
2020-06-18 21:04 ` Matias Bjorling
2020-06-18 21:04 ` Matias Bjorling
2020-06-18 21:19 ` Keith Busch
2020-06-18 21:19 ` Keith Busch
2020-06-18 22:05 ` Heiner Litz
2020-06-18 22:05 ` Heiner Litz
2020-06-19 0:57 ` Damien Le Moal
2020-06-19 0:57 ` Damien Le Moal
2020-06-19 10:29 ` Matias Bjorling
2020-06-19 10:29 ` Matias Bjorling
2020-06-19 18:08 ` Heiner Litz
2020-06-19 18:08 ` Heiner Litz
2020-06-19 18:10 ` Keith Busch
2020-06-19 18:10 ` Keith Busch
2020-06-19 18:17 ` Heiner Litz
2020-06-19 18:17 ` Heiner Litz
2020-06-19 18:22 ` Keith Busch
2020-06-19 18:22 ` Keith Busch
2020-06-19 18:25 ` Matias Bjørling
2020-06-19 18:25 ` Matias Bjørling
2020-06-19 18:40 ` Heiner Litz
2020-06-19 18:40 ` Heiner Litz
2020-06-19 18:18 ` Matias Bjørling
2020-06-19 18:18 ` Matias Bjørling
2020-06-20 6:33 ` Christoph Hellwig
2020-06-20 6:33 ` Christoph Hellwig
2020-06-20 17:52 ` Heiner Litz
2020-06-20 17:52 ` Heiner Litz
2020-06-22 14:01 ` Christoph Hellwig
2022-03-02 21:11 ` Luis Chamberlain
2020-06-17 2:08 ` Martin K. Petersen
2020-06-17 2:08 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616170135.GC521206@dhcp-10-100-145-180.wdl.wdc.com \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=hch@lst.de \
--cc=keith.busch@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=matias.bjorling@wdc.com \
--cc=niklas.cassel@wdc.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.