From: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com> To: linuxppc-dev@lists.ozlabs.org Cc: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>, linux-kernel@vger.kernel.org, Michael Ellerman <mpe@ellerman.id.au>, Thiago Jung Bauermann <bauerman@linux.ibm.com>, Ram Pai <linuxram@us.ibm.com>, Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>, Laurent Dufour <ldufour@linux.ibm.com> Subject: [PATCH V2] powerpc/pseries/svm: Remove unwanted check for shared_lppaca_size Date: Fri, 19 Jun 2020 12:31:13 +0530 [thread overview] Message-ID: <20200619070113.16696-1-sathnaga@linux.vnet.ibm.com> (raw) Early secure guest boot hits the below crash while booting with vcpus numbers aligned with page boundary for PAGE size of 64k and LPPACA size of 1k i.e 64, 128 etc, due to the BUG_ON assert for shared_lppaca_total_size equal to shared_lppaca_size, [ 0.000000] Partition configured for 64 cpus. [ 0.000000] CPU maps initialized for 1 thread per core [ 0.000000] ------------[ cut here ]------------ [ 0.000000] kernel BUG at arch/powerpc/kernel/paca.c:89! [ 0.000000] Oops: Exception in kernel mode, sig: 5 [#1] [ 0.000000] LE PAGE_SIZE=64K MMU=Radix SMP NR_CPUS=2048 NUMA pSeries which is not necessary, let's remove it. Fixes: bd104e6db6f0 ("powerpc/pseries/svm: Use shared memory for LPPACA structures") Cc: linux-kernel@vger.kernel.org Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Thiago Jung Bauermann <bauerman@linux.ibm.com> Cc: Ram Pai <linuxram@us.ibm.com> Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com> Cc: Laurent Dufour <ldufour@linux.ibm.com> Reviewed-by: Laurent Dufour <ldufour@linux.ibm.com> Reviewed-by: Thiago Jung Bauermann <bauerman@linux.ibm.com> Signed-off-by: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com> --- V2: Added Reviewed by Thiago and Laurent. Added Fixes tag as per Thiago suggest. V1: https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20200609105731.14032-1-sathnaga@linux.vnet.ibm.com/ --- arch/powerpc/kernel/paca.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/paca.c b/arch/powerpc/kernel/paca.c index 2168372b792d..74da65aacbc9 100644 --- a/arch/powerpc/kernel/paca.c +++ b/arch/powerpc/kernel/paca.c @@ -87,7 +87,7 @@ static void *__init alloc_shared_lppaca(unsigned long size, unsigned long align, * This is very early in boot, so no harm done if the kernel crashes at * this point. */ - BUG_ON(shared_lppaca_size >= shared_lppaca_total_size); + BUG_ON(shared_lppaca_size > shared_lppaca_total_size); return ptr; } -- 2.26.2
WARNING: multiple messages have this Message-ID (diff)
From: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com> To: linuxppc-dev@lists.ozlabs.org Cc: Laurent Dufour <ldufour@linux.ibm.com>, Ram Pai <linuxram@us.ibm.com>, linux-kernel@vger.kernel.org, Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>, Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>, Thiago Jung Bauermann <bauerman@linux.ibm.com> Subject: [PATCH V2] powerpc/pseries/svm: Remove unwanted check for shared_lppaca_size Date: Fri, 19 Jun 2020 12:31:13 +0530 [thread overview] Message-ID: <20200619070113.16696-1-sathnaga@linux.vnet.ibm.com> (raw) Early secure guest boot hits the below crash while booting with vcpus numbers aligned with page boundary for PAGE size of 64k and LPPACA size of 1k i.e 64, 128 etc, due to the BUG_ON assert for shared_lppaca_total_size equal to shared_lppaca_size, [ 0.000000] Partition configured for 64 cpus. [ 0.000000] CPU maps initialized for 1 thread per core [ 0.000000] ------------[ cut here ]------------ [ 0.000000] kernel BUG at arch/powerpc/kernel/paca.c:89! [ 0.000000] Oops: Exception in kernel mode, sig: 5 [#1] [ 0.000000] LE PAGE_SIZE=64K MMU=Radix SMP NR_CPUS=2048 NUMA pSeries which is not necessary, let's remove it. Fixes: bd104e6db6f0 ("powerpc/pseries/svm: Use shared memory for LPPACA structures") Cc: linux-kernel@vger.kernel.org Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Thiago Jung Bauermann <bauerman@linux.ibm.com> Cc: Ram Pai <linuxram@us.ibm.com> Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com> Cc: Laurent Dufour <ldufour@linux.ibm.com> Reviewed-by: Laurent Dufour <ldufour@linux.ibm.com> Reviewed-by: Thiago Jung Bauermann <bauerman@linux.ibm.com> Signed-off-by: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com> --- V2: Added Reviewed by Thiago and Laurent. Added Fixes tag as per Thiago suggest. V1: https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20200609105731.14032-1-sathnaga@linux.vnet.ibm.com/ --- arch/powerpc/kernel/paca.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/paca.c b/arch/powerpc/kernel/paca.c index 2168372b792d..74da65aacbc9 100644 --- a/arch/powerpc/kernel/paca.c +++ b/arch/powerpc/kernel/paca.c @@ -87,7 +87,7 @@ static void *__init alloc_shared_lppaca(unsigned long size, unsigned long align, * This is very early in boot, so no harm done if the kernel crashes at * this point. */ - BUG_ON(shared_lppaca_size >= shared_lppaca_total_size); + BUG_ON(shared_lppaca_size > shared_lppaca_total_size); return ptr; } -- 2.26.2
next reply other threads:[~2020-06-19 7:02 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-19 7:01 Satheesh Rajendran [this message] 2020-06-19 7:01 ` [PATCH V2] powerpc/pseries/svm: Remove unwanted check for shared_lppaca_size Satheesh Rajendran 2020-07-16 12:47 ` Michael Ellerman 2020-07-16 12:47 ` Michael Ellerman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200619070113.16696-1-sathnaga@linux.vnet.ibm.com \ --to=sathnaga@linux.vnet.ibm.com \ --cc=bauerman@linux.ibm.com \ --cc=ldufour@linux.ibm.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=linuxram@us.ibm.com \ --cc=mpe@ellerman.id.au \ --cc=sukadev@linux.vnet.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.