From: Christoph Hellwig <hch@infradead.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Andreas Gruenbacher <agruenba@redhat.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
linux-xfs@vger.kernel.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Bob Peterson <rpeterso@redhat.com>
Subject: Re: [PATCH] iomap: Make sure iomap_end is called after iomap_begin
Date: Fri, 19 Jun 2020 06:18:16 -0700 [thread overview]
Message-ID: <20200619131816.GB15982@infradead.org> (raw)
In-Reply-To: <20200618151523.GQ8681@bombadil.infradead.org>
On Thu, Jun 18, 2020 at 08:15:23AM -0700, Matthew Wilcox wrote:
> Thinking about it, wouldn't the second test be better replaced with:
>
> if (WARN_ON(iomap.offset + iomap.length <= pos))
>
> in case the filesystem returns an extent which finishes before pos?
> This would be a superset of the test for length being 0.
The idea was to tell what is wrong. Both with the initial iomap work
and later the COW support I had all kinds of weird scenarious during
bringup where an obvious error has been very helpful.
prev parent reply other threads:[~2020-06-19 13:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 16:02 [PATCH] iomap: Make sure iomap_end is called after iomap_begin Andreas Gruenbacher
2020-06-15 23:32 ` Dave Chinner
2020-06-15 23:44 ` Matthew Wilcox
2020-06-16 0:39 ` Dave Chinner
2020-06-16 12:17 ` Bob Peterson
2020-06-16 13:23 ` Matthew Wilcox
2020-06-16 13:57 ` Andreas Gruenbacher
2020-06-16 16:25 ` Darrick J. Wong
2020-06-16 16:34 ` Andreas Grünbacher
2020-06-16 16:38 ` Bob Peterson
2020-06-17 23:44 ` Dave Chinner
2020-06-18 1:39 ` Darrick J. Wong
2020-06-18 12:21 ` Andreas Gruenbacher
2020-06-18 12:32 ` Matthew Wilcox
2020-06-18 12:37 ` Andreas Gruenbacher
2020-06-18 13:56 ` Christoph Hellwig
2020-06-18 15:15 ` Matthew Wilcox
2020-06-19 13:18 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200619131816.GB15982@infradead.org \
--to=hch@infradead.org \
--cc=agruenba@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=rpeterso@redhat.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.