From: Bob Peterson <rpeterso@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Andreas Gruenbacher <agruenba@redhat.com>,
Matthew Wilcox <willy@infradead.org>,
Dave Chinner <david@fromorbit.com>,
Christoph Hellwig <hch@infradead.org>,
linux-xfs@vger.kernel.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] iomap: Make sure iomap_end is called after iomap_begin
Date: Tue, 16 Jun 2020 12:38:38 -0400 (EDT) [thread overview]
Message-ID: <700590041.34131118.1592325518407.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20200616162539.GN11245@magnolia>
----- Original Message -----
> So... you found this through code inspection, and not because you
> actually hit this on gfs2, or any of the other iomap users?
>
> I generally think this looks ok, but I want to know if I should be
> looking deeper. :)
>
> --D
Correct. Code-inspection only. I never actually hit the problem.
If those errors are really so unusual and catastrophic, perhaps
we should just change them to BUG_ONs or something instead.
Why bother unlocking if we're already 1.9 meters underground?
Bob Peterson
next prev parent reply other threads:[~2020-06-16 16:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 16:02 [PATCH] iomap: Make sure iomap_end is called after iomap_begin Andreas Gruenbacher
2020-06-15 23:32 ` Dave Chinner
2020-06-15 23:44 ` Matthew Wilcox
2020-06-16 0:39 ` Dave Chinner
2020-06-16 12:17 ` Bob Peterson
2020-06-16 13:23 ` Matthew Wilcox
2020-06-16 13:57 ` Andreas Gruenbacher
2020-06-16 16:25 ` Darrick J. Wong
2020-06-16 16:34 ` Andreas Grünbacher
2020-06-16 16:38 ` Bob Peterson [this message]
2020-06-17 23:44 ` Dave Chinner
2020-06-18 1:39 ` Darrick J. Wong
2020-06-18 12:21 ` Andreas Gruenbacher
2020-06-18 12:32 ` Matthew Wilcox
2020-06-18 12:37 ` Andreas Gruenbacher
2020-06-18 13:56 ` Christoph Hellwig
2020-06-18 15:15 ` Matthew Wilcox
2020-06-19 13:18 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=700590041.34131118.1592325518407.JavaMail.zimbra@redhat.com \
--to=rpeterso@redhat.com \
--cc=agruenba@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.