From: Sam Ravnborg <sam@ravnborg.org> To: Enric Balletbo i Serra <enric.balletbo@collabora.com> Cc: linux-kernel@vger.kernel.org, Collabora Kernel ML <kernel@collabora.com>, Chun-Kuang Hu <chunkuang.hu@kernel.org>, Jernej Skrabec <jernej.skrabec@siol.net>, drinkcat@chromium.org, Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>, Thomas Zimmermann <tzimmermann@suse.de>, dri-devel@lists.freedesktop.org, Neil Armstrong <narmstrong@baylibre.com>, Andrzej Hajda <a.hajda@samsung.com>, linux-mediatek@lists.infradead.org, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, hsinyi@chromium.org, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org Subject: Re: [RESEND PATCH v4 0/7] Convert mtk-dsi to drm_bridge API and get EDID for ps8640 bridge Date: Sat, 20 Jun 2020 23:33:02 +0200 [thread overview] Message-ID: <20200620213302.GC74146@ravnborg.org> (raw) In-Reply-To: <20200615203108.786083-1-enric.balletbo@collabora.com> Hi Enric On Mon, Jun 15, 2020 at 10:31:01PM +0200, Enric Balletbo i Serra wrote: > (This resend is to fix some trivial conflicts due the merge window) > > The PS8640 dsi-to-eDP bridge driver is using the panel bridge API, > however, not all the components in the chain have been ported to the > drm_bridge API. Actually, when a panel is attached the default panel's mode > is used, but in some cases we can't get display up if mode getting from > eDP control EDID is not chosen. > > This series address that problem, first implements the .get_edid() > callback in the PS8640 driver (which is not used until the conversion is > done) and then, converts the Mediatek DSI driver to use the drm_bridge > API. > > As far as I know, we're the only users of the mediatek dsi driver in > mainline, so should be safe to switch to the new chain of drm_bridge API > unconditionally. > > The patches has been tested on a Acer Chromebook R13 (Elm) running a > Chrome OS userspace and checking that the valid EDID mode reported by > the bridge is selected. > > Changes in v4: > - Remove double call to drm_encoder_init(). (Chun-Kuang Hu) > - Cleanup the encoder in mtk_dsi_unbind(). (Chun-Kuang Hu) > > Changes in v3: > - Replace s/bridge/next bridge/ for comment. (Laurent Pinchart) > - Add the bridge.type. (Laurent Pinchart) > - Use next_bridge field to store the panel bridge. (Laurent Pinchart) > - Add the bridge.type field. (Laurent Pinchart) > - This patch requires https://lkml.org/lkml/2020/4/16/2080 to work > properly. > - Move the bridge.type line to the patch that adds drm_bridge support. (Laurent Pinchart) > > Changes in v2: > - Do not set connector_type for panel here. (Sam Ravnborg) > > Enric Balletbo i Serra (7): > drm/bridge: ps8640: Get the EDID from eDP control > drm/bridge_connector: Set default status connected for eDP connectors > drm/mediatek: mtk_dsi: Rename bridge to next_bridge > drm/mediatek: mtk_dsi: Convert to bridge driver > drm/mediatek: mtk_dsi: Use simple encoder > drm/mediatek: mtk_dsi: Use the drm_panel_bridge API > drm/mediatek: mtk_dsi: Create connector for bridges Patch seems ready to apply. Will they be applied to a mediatek tree or to drm-misc-next? Or shall we take the first two patches via drm-misc-next, and the remaning via a mediatek tree? (I hope not) Sam > > drivers/gpu/drm/bridge/parade-ps8640.c | 12 ++ > drivers/gpu/drm/drm_bridge_connector.c | 1 + > drivers/gpu/drm/mediatek/mtk_dsi.c | 269 ++++++++----------------- > 3 files changed, 97 insertions(+), 185 deletions(-) > > -- > 2.27.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org> To: Enric Balletbo i Serra <enric.balletbo@collabora.com> Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>, Jernej Skrabec <jernej.skrabec@siol.net>, drinkcat@chromium.org, Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>, Neil Armstrong <narmstrong@baylibre.com>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Andrzej Hajda <a.hajda@samsung.com>, linux-mediatek@lists.infradead.org, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Thomas Zimmermann <tzimmermann@suse.de>, hsinyi@chromium.org, matthias.bgg@gmail.com, Collabora Kernel ML <kernel@collabora.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [RESEND PATCH v4 0/7] Convert mtk-dsi to drm_bridge API and get EDID for ps8640 bridge Date: Sat, 20 Jun 2020 23:33:02 +0200 [thread overview] Message-ID: <20200620213302.GC74146@ravnborg.org> (raw) In-Reply-To: <20200615203108.786083-1-enric.balletbo@collabora.com> Hi Enric On Mon, Jun 15, 2020 at 10:31:01PM +0200, Enric Balletbo i Serra wrote: > (This resend is to fix some trivial conflicts due the merge window) > > The PS8640 dsi-to-eDP bridge driver is using the panel bridge API, > however, not all the components in the chain have been ported to the > drm_bridge API. Actually, when a panel is attached the default panel's mode > is used, but in some cases we can't get display up if mode getting from > eDP control EDID is not chosen. > > This series address that problem, first implements the .get_edid() > callback in the PS8640 driver (which is not used until the conversion is > done) and then, converts the Mediatek DSI driver to use the drm_bridge > API. > > As far as I know, we're the only users of the mediatek dsi driver in > mainline, so should be safe to switch to the new chain of drm_bridge API > unconditionally. > > The patches has been tested on a Acer Chromebook R13 (Elm) running a > Chrome OS userspace and checking that the valid EDID mode reported by > the bridge is selected. > > Changes in v4: > - Remove double call to drm_encoder_init(). (Chun-Kuang Hu) > - Cleanup the encoder in mtk_dsi_unbind(). (Chun-Kuang Hu) > > Changes in v3: > - Replace s/bridge/next bridge/ for comment. (Laurent Pinchart) > - Add the bridge.type. (Laurent Pinchart) > - Use next_bridge field to store the panel bridge. (Laurent Pinchart) > - Add the bridge.type field. (Laurent Pinchart) > - This patch requires https://lkml.org/lkml/2020/4/16/2080 to work > properly. > - Move the bridge.type line to the patch that adds drm_bridge support. (Laurent Pinchart) > > Changes in v2: > - Do not set connector_type for panel here. (Sam Ravnborg) > > Enric Balletbo i Serra (7): > drm/bridge: ps8640: Get the EDID from eDP control > drm/bridge_connector: Set default status connected for eDP connectors > drm/mediatek: mtk_dsi: Rename bridge to next_bridge > drm/mediatek: mtk_dsi: Convert to bridge driver > drm/mediatek: mtk_dsi: Use simple encoder > drm/mediatek: mtk_dsi: Use the drm_panel_bridge API > drm/mediatek: mtk_dsi: Create connector for bridges Patch seems ready to apply. Will they be applied to a mediatek tree or to drm-misc-next? Or shall we take the first two patches via drm-misc-next, and the remaning via a mediatek tree? (I hope not) Sam > > drivers/gpu/drm/bridge/parade-ps8640.c | 12 ++ > drivers/gpu/drm/drm_bridge_connector.c | 1 + > drivers/gpu/drm/mediatek/mtk_dsi.c | 269 ++++++++----------------- > 3 files changed, 97 insertions(+), 185 deletions(-) > > -- > 2.27.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-06-20 21:33 UTC|newest] Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-15 20:31 [RESEND PATCH v4 0/7] Convert mtk-dsi to drm_bridge API and get EDID for ps8640 bridge Enric Balletbo i Serra 2020-06-15 20:31 ` Enric Balletbo i Serra 2020-06-15 20:31 ` Enric Balletbo i Serra 2020-06-15 20:31 ` Enric Balletbo i Serra 2020-06-15 20:31 ` [RESEND PATCH v4 1/7] drm/bridge: ps8640: Get the EDID from eDP control Enric Balletbo i Serra 2020-06-15 20:31 ` Enric Balletbo i Serra 2020-06-15 20:31 ` [RESEND PATCH v4 2/7] drm/bridge_connector: Set default status connected for eDP connectors Enric Balletbo i Serra 2020-06-15 20:31 ` Enric Balletbo i Serra 2020-06-15 20:31 ` [RESEND PATCH v4 3/7] drm/mediatek: mtk_dsi: Rename bridge to next_bridge Enric Balletbo i Serra 2020-06-15 20:31 ` Enric Balletbo i Serra 2020-06-15 20:31 ` Enric Balletbo i Serra 2020-06-15 20:31 ` Enric Balletbo i Serra 2020-07-04 23:20 ` Chun-Kuang Hu 2020-07-04 23:20 ` Chun-Kuang Hu 2020-07-04 23:20 ` Chun-Kuang Hu 2020-07-04 23:20 ` Chun-Kuang Hu 2020-06-15 20:31 ` [RESEND PATCH v4 4/7] drm/mediatek: mtk_dsi: Convert to bridge driver Enric Balletbo i Serra 2020-06-15 20:31 ` Enric Balletbo i Serra 2020-06-15 20:31 ` Enric Balletbo i Serra 2020-06-15 20:31 ` Enric Balletbo i Serra 2020-07-04 23:34 ` Chun-Kuang Hu 2020-07-04 23:34 ` Chun-Kuang Hu 2020-07-04 23:34 ` Chun-Kuang Hu 2020-07-04 23:34 ` Chun-Kuang Hu 2020-06-15 20:31 ` [RESEND PATCH v4 5/7] drm/mediatek: mtk_dsi: Use simple encoder Enric Balletbo i Serra 2020-06-15 20:31 ` Enric Balletbo i Serra 2020-06-15 20:31 ` Enric Balletbo i Serra 2020-06-15 20:31 ` Enric Balletbo i Serra 2020-07-04 23:42 ` Chun-Kuang Hu 2020-07-04 23:42 ` Chun-Kuang Hu 2020-07-04 23:42 ` Chun-Kuang Hu 2020-07-04 23:42 ` Chun-Kuang Hu 2020-06-15 20:31 ` [RESEND PATCH v4 6/7] drm/mediatek: mtk_dsi: Use the drm_panel_bridge API Enric Balletbo i Serra 2020-06-15 20:31 ` Enric Balletbo i Serra 2020-06-15 20:31 ` Enric Balletbo i Serra 2020-06-15 20:31 ` Enric Balletbo i Serra 2020-07-04 23:57 ` Chun-Kuang Hu 2020-07-04 23:57 ` Chun-Kuang Hu 2020-07-04 23:57 ` Chun-Kuang Hu 2020-07-04 23:57 ` Chun-Kuang Hu 2020-06-15 20:31 ` [RESEND PATCH v4 7/7] drm/mediatek: mtk_dsi: Create connector for bridges Enric Balletbo i Serra 2020-06-15 20:31 ` Enric Balletbo i Serra 2020-06-15 20:31 ` Enric Balletbo i Serra 2020-06-15 20:31 ` Enric Balletbo i Serra 2020-07-05 0:15 ` Chun-Kuang Hu 2020-07-05 0:15 ` Chun-Kuang Hu 2020-07-05 0:15 ` Chun-Kuang Hu 2020-07-05 0:15 ` Chun-Kuang Hu 2020-06-20 21:33 ` Sam Ravnborg [this message] 2020-06-20 21:33 ` [RESEND PATCH v4 0/7] Convert mtk-dsi to drm_bridge API and get EDID for ps8640 bridge Sam Ravnborg 2020-06-30 14:33 ` Enric Balletbo i Serra 2020-06-30 14:33 ` Enric Balletbo i Serra 2020-06-30 14:33 ` Enric Balletbo i Serra 2020-06-30 14:33 ` Enric Balletbo i Serra 2020-06-30 16:26 ` Chun-Kuang Hu 2020-06-30 16:26 ` Chun-Kuang Hu 2020-06-30 16:26 ` Chun-Kuang Hu 2020-06-30 16:26 ` Chun-Kuang Hu 2020-06-30 21:02 ` Enric Balletbo i Serra 2020-06-30 21:02 ` Enric Balletbo i Serra 2020-06-30 21:02 ` Enric Balletbo i Serra 2020-06-30 21:02 ` Enric Balletbo i Serra 2020-06-30 23:02 ` Chun-Kuang Hu 2020-06-30 23:02 ` Chun-Kuang Hu 2020-06-30 23:02 ` Chun-Kuang Hu 2020-06-30 23:02 ` Chun-Kuang Hu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200620213302.GC74146@ravnborg.org \ --to=sam@ravnborg.org \ --cc=Laurent.pinchart@ideasonboard.com \ --cc=a.hajda@samsung.com \ --cc=airlied@linux.ie \ --cc=chunkuang.hu@kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=drinkcat@chromium.org \ --cc=enric.balletbo@collabora.com \ --cc=hsinyi@chromium.org \ --cc=jernej.skrabec@siol.net \ --cc=jonas@kwiboo.se \ --cc=kernel@collabora.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=matthias.bgg@gmail.com \ --cc=narmstrong@baylibre.com \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.