From: Christian Brauner <christian.brauner@ubuntu.com>
To: David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
arnd@arndb.de, guoren@kernel.org, linux-csky@vger.kernel.org,
sparclinux@vger.kernel.org
Subject: Re: [PATCH 02/17] sparc64: enable HAVE_COPY_THREAD_TLS
Date: Tue, 23 Jun 2020 10:42:28 +0200 [thread overview]
Message-ID: <20200623084228.jpufvn5mn3lhjc36@wittgenstein> (raw)
In-Reply-To: <20200622.203516.1857672250009821997.davem@davemloft.net>
On Mon, Jun 22, 2020 at 08:35:16PM -0700, David Miller wrote:
> From: Christian Brauner <christian.brauner@ubuntu.com>
> Date: Tue, 23 Jun 2020 01:43:11 +0200
>
> > diff --git a/arch/sparc/kernel/syscalls.S b/arch/sparc/kernel/syscalls.S
> > index db42b4fb3708..192f3a28a2b7 100644
> > --- a/arch/sparc/kernel/syscalls.S
> > +++ b/arch/sparc/kernel/syscalls.S
> > @@ -86,19 +86,22 @@ sys32_rt_sigreturn:
> > * during system calls...
> > */
> > .align 32
> > -sys_vfork: /* Under Linux, vfork and fork are just special cases of clone. */
> > - sethi %hi(0x4000 | 0x0100 | SIGCHLD), %o0
> > - or %o0, %lo(0x4000 | 0x0100 | SIGCHLD), %o0
> > - ba,pt %xcc, sys_clone
> > +sys_vfork:
> > + flushw
> > + ba,pt %xcc, sparc_vfork
> > + add %sp, PTREGS_OFF, %o0
>
> Please indent branch delay slot instructions with one extra space, as
> was done in the code you are changing.
>
> > + ba,pt %xcc, sparc_fork
> > + add %sp, PTREGS_OFF, %o0
>
> Likewise.
>
> > + ba,pt %xcc, sparc_clone
> > + add %sp, PTREGS_OFF, %o0
>
> Likewise.
Fixed, thanks for taking a look again! This somehow slipped past me when
applying.
Christian
WARNING: multiple messages have this Message-ID (diff)
From: Christian Brauner <christian.brauner@ubuntu.com>
To: David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
arnd@arndb.de, guoren@kernel.org, linux-csky@vger.kernel.org,
sparclinux@vger.kernel.org
Subject: Re: [PATCH 02/17] sparc64: enable HAVE_COPY_THREAD_TLS
Date: Tue, 23 Jun 2020 08:42:28 +0000 [thread overview]
Message-ID: <20200623084228.jpufvn5mn3lhjc36@wittgenstein> (raw)
In-Reply-To: <20200622.203516.1857672250009821997.davem@davemloft.net>
On Mon, Jun 22, 2020 at 08:35:16PM -0700, David Miller wrote:
> From: Christian Brauner <christian.brauner@ubuntu.com>
> Date: Tue, 23 Jun 2020 01:43:11 +0200
>
> > diff --git a/arch/sparc/kernel/syscalls.S b/arch/sparc/kernel/syscalls.S
> > index db42b4fb3708..192f3a28a2b7 100644
> > --- a/arch/sparc/kernel/syscalls.S
> > +++ b/arch/sparc/kernel/syscalls.S
> > @@ -86,19 +86,22 @@ sys32_rt_sigreturn:
> > * during system calls...
> > */
> > .align 32
> > -sys_vfork: /* Under Linux, vfork and fork are just special cases of clone. */
> > - sethi %hi(0x4000 | 0x0100 | SIGCHLD), %o0
> > - or %o0, %lo(0x4000 | 0x0100 | SIGCHLD), %o0
> > - ba,pt %xcc, sys_clone
> > +sys_vfork:
> > + flushw
> > + ba,pt %xcc, sparc_vfork
> > + add %sp, PTREGS_OFF, %o0
>
> Please indent branch delay slot instructions with one extra space, as
> was done in the code you are changing.
>
> > + ba,pt %xcc, sparc_fork
> > + add %sp, PTREGS_OFF, %o0
>
> Likewise.
>
> > + ba,pt %xcc, sparc_clone
> > + add %sp, PTREGS_OFF, %o0
>
> Likewise.
Fixed, thanks for taking a look again! This somehow slipped past me when
applying.
Christian
next prev parent reply other threads:[~2020-06-23 8:42 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 23:43 [PATCH 00/17] arch: remove do_fork() and HAVE_COPY_THREAD_TLS Christian Brauner
2020-06-22 23:43 ` [PATCH 01/17] fork: fold legacy_clone_args_valid() into _do_fork() Christian Brauner
2020-06-27 8:27 ` [fork] 11689456e6: ltp.clone302.fail kernel test robot
2020-06-27 12:23 ` Christian Brauner
2020-06-22 23:43 ` [PATCH 02/17] sparc64: enable HAVE_COPY_THREAD_TLS Christian Brauner
2020-06-22 23:43 ` Christian Brauner
2020-06-23 3:35 ` David Miller
2020-06-23 3:35 ` David Miller
2020-06-23 8:42 ` Christian Brauner [this message]
2020-06-23 8:42 ` Christian Brauner
2020-06-22 23:43 ` [PATCH 03/17] sparc: share process creation helpers between sparc and sparc64 Christian Brauner
2020-06-22 23:43 ` Christian Brauner
2020-06-22 23:43 ` [PATCH 04/17] sparc: unconditionally enable HAVE_COPY_THREAD_TLS Christian Brauner
2020-06-22 23:43 ` Christian Brauner
2020-06-22 23:43 ` [PATCH 05/17] ia64: enable HAVE_COPY_THREAD_TLS, switch to kernel_clone_args Christian Brauner
2020-06-22 23:43 ` Christian Brauner
2020-06-22 23:43 ` [PATCH 06/17] nios2: " Christian Brauner
2020-06-22 23:43 ` [PATCH 07/17] h8300: select " Christian Brauner
2020-06-22 23:43 ` [PATCH 08/17] fork: remove do_fork() Christian Brauner
2020-06-22 23:43 ` [PATCH 09/17] alpha: switch to copy_thread_tls() Christian Brauner
2020-06-22 23:43 ` [PATCH 10/17] c6x: " Christian Brauner
2020-06-22 23:43 ` [PATCH 11/17] hexagon: " Christian Brauner
2020-06-23 16:11 ` Brian Cain
2020-06-23 16:11 ` Brian Cain
2020-06-22 23:43 ` [PATCH 12/17] microblaze: " Christian Brauner
2020-06-22 23:43 ` [PATCH 13/17] nds32: " Christian Brauner
2020-06-22 23:43 ` [PATCH 14/17] sh: " Christian Brauner
2020-06-22 23:43 ` Christian Brauner
2020-06-22 23:43 ` [PATCH 15/17] unicore: " Christian Brauner
2020-06-22 23:43 ` [PATCH 16/17] arch: remove HAVE_COPY_THREAD_TLS Christian Brauner
2020-06-22 23:43 ` Christian Brauner
2020-06-22 23:43 ` Christian Brauner
2020-06-22 23:43 ` [OpenRISC] " Christian Brauner
2020-06-23 0:44 ` Kees Cook
2020-06-23 0:44 ` Kees Cook
2020-06-23 0:44 ` Kees Cook
2020-06-23 0:44 ` [OpenRISC] " Kees Cook
2020-06-23 7:37 ` Geert Uytterhoeven
2020-06-23 7:37 ` Geert Uytterhoeven
2020-06-23 7:37 ` Geert Uytterhoeven
2020-06-23 7:37 ` [OpenRISC] " Geert Uytterhoeven
2020-06-25 8:25 ` Thomas Bogendoerfer
2020-06-25 8:25 ` Thomas Bogendoerfer
2020-06-25 8:25 ` Thomas Bogendoerfer
2020-06-25 8:25 ` [OpenRISC] " Thomas Bogendoerfer
2020-06-25 8:25 ` Thomas Bogendoerfer
2020-06-25 8:25 ` Thomas Bogendoerfer
2020-06-27 3:06 ` Greentime Hu
2020-06-27 3:06 ` Greentime Hu
2020-06-27 3:06 ` Greentime Hu
2020-06-27 3:06 ` [OpenRISC] " Greentime Hu
2020-06-27 3:06 ` Greentime Hu
2020-06-27 3:06 ` Greentime Hu
2020-06-22 23:43 ` [PATCH 17/17] arch: rename copy_thread_tls() back to copy_thread() Christian Brauner
2020-06-22 23:43 ` Christian Brauner
2020-06-22 23:43 ` Christian Brauner
2020-06-22 23:43 ` [OpenRISC] " Christian Brauner
2020-06-23 0:46 ` Kees Cook
2020-06-23 0:46 ` Kees Cook
2020-06-23 0:46 ` Kees Cook
2020-06-23 0:46 ` [OpenRISC] " Kees Cook
2020-06-23 7:38 ` Geert Uytterhoeven
2020-06-23 7:38 ` Geert Uytterhoeven
2020-06-23 7:38 ` Geert Uytterhoeven
2020-06-23 7:38 ` [OpenRISC] " Geert Uytterhoeven
2020-06-25 8:26 ` Thomas Bogendoerfer
2020-06-25 8:26 ` Thomas Bogendoerfer
2020-06-25 8:26 ` Thomas Bogendoerfer
2020-06-25 8:26 ` [OpenRISC] " Thomas Bogendoerfer
2020-06-25 8:26 ` Thomas Bogendoerfer
2020-06-25 8:26 ` Thomas Bogendoerfer
2020-06-25 21:17 ` Stafford Horne
2020-06-25 21:17 ` Stafford Horne
2020-06-25 21:17 ` Stafford Horne
2020-06-25 21:17 ` [OpenRISC] " Stafford Horne
2020-06-25 21:17 ` Stafford Horne
2020-06-25 21:17 ` Stafford Horne
2020-07-04 16:10 ` Christian Brauner
2020-07-04 16:11 ` [OpenRISC] " Christian Brauner
2020-07-04 16:10 ` Christian Brauner
2020-07-04 16:10 ` Christian Brauner
2020-07-04 16:10 ` Christian Brauner
2020-07-04 16:10 ` Christian Brauner
2020-06-27 3:10 ` Greentime Hu
2020-06-27 3:10 ` Greentime Hu
2020-06-27 3:10 ` Greentime Hu
2020-06-27 3:10 ` [OpenRISC] " Greentime Hu
2020-06-27 3:10 ` Greentime Hu
2020-06-27 3:10 ` Greentime Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200623084228.jpufvn5mn3lhjc36@wittgenstein \
--to=christian.brauner@ubuntu.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=guoren@kernel.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.