All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Ard Biesheuvel <ardb@kernel.org>, linux-crypto@vger.kernel.org
Cc: kbuild-all@lists.01.org, linux-arm-kernel@lists.infradead.org,
	linux-omap@vger.kernel.org, linux-amlogic@lists.infradead.org,
	Ard Biesheuvel <ardb@kernel.org>,
	Corentin Labbe <clabbe.montjoie@gmail.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH 07/12] crypto: ccp - permit asynchronous skcipher as fallback
Date: Fri, 26 Jun 2020 00:24:07 +0800	[thread overview]
Message-ID: <202006260032.V8hwzVw0%lkp@intel.com> (raw)
In-Reply-To: <20200625124253.1906557-8-ardb@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 2731 bytes --]

Hi Ard,

I love your patch! Yet something to improve:

[auto build test ERROR on cryptodev/master]
[also build test ERROR on crypto/master sunxi/sunxi/for-next v5.8-rc2 next-20200625]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Ard-Biesheuvel/crypto-permit-asynchronous-skciphers-as-driver-fallbacks/20200625-204707
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
config: x86_64-rhel-7.6 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/crypto/ccp/ccp-crypto-aes-xts.c: In function 'ccp_aes_xts_exit_tfm':
>> drivers/crypto/ccp/ccp-crypto-aes-xts.c:223:38: error: passing argument 1 of 'crypto_free_sync_skcipher' from incompatible pointer type [-Werror=incompatible-pointer-types]
     223 |  crypto_free_sync_skcipher(ctx->u.aes.tfm_skcipher);
         |                            ~~~~~~~~~~^~~~~~~~~~~~~
         |                                      |
         |                                      struct crypto_skcipher *
   In file included from include/crypto/internal/skcipher.h:12,
                    from include/crypto/xts.h:6,
                    from drivers/crypto/ccp/ccp-crypto-aes-xts.c:16:
   include/crypto/skcipher.h:205:75: note: expected 'struct crypto_sync_skcipher *' but argument is of type 'struct crypto_skcipher *'
     205 | static inline void crypto_free_sync_skcipher(struct crypto_sync_skcipher *tfm)
         |                                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
   cc1: some warnings being treated as errors

vim +/crypto_free_sync_skcipher +223 drivers/crypto/ccp/ccp-crypto-aes-xts.c

1d6b8a6f64076a Tom Lendacky   2013-11-12  218  
be9fe620af63e7 Ard Biesheuvel 2019-11-09  219  static void ccp_aes_xts_exit_tfm(struct crypto_skcipher *tfm)
1d6b8a6f64076a Tom Lendacky   2013-11-12  220  {
be9fe620af63e7 Ard Biesheuvel 2019-11-09  221  	struct ccp_ctx *ctx = crypto_skcipher_ctx(tfm);
1d6b8a6f64076a Tom Lendacky   2013-11-12  222  
7f28615df88a63 Kees Cook      2018-09-18 @223  	crypto_free_sync_skcipher(ctx->u.aes.tfm_skcipher);
1d6b8a6f64076a Tom Lendacky   2013-11-12  224  }
1d6b8a6f64076a Tom Lendacky   2013-11-12  225  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 49250 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Ard Biesheuvel <ardb@kernel.org>, linux-crypto@vger.kernel.org
Cc: Tom Lendacky <thomas.lendacky@amd.com>,
	kbuild-all@lists.01.org, Herbert Xu <herbert@gondor.apana.org.au>,
	Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Corentin Labbe <clabbe.montjoie@gmail.com>,
	linux-amlogic@lists.infradead.org, linux-omap@vger.kernel.org,
	Ard Biesheuvel <ardb@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 07/12] crypto: ccp - permit asynchronous skcipher as fallback
Date: Fri, 26 Jun 2020 00:24:07 +0800	[thread overview]
Message-ID: <202006260032.V8hwzVw0%lkp@intel.com> (raw)
In-Reply-To: <20200625124253.1906557-8-ardb@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 2731 bytes --]

Hi Ard,

I love your patch! Yet something to improve:

[auto build test ERROR on cryptodev/master]
[also build test ERROR on crypto/master sunxi/sunxi/for-next v5.8-rc2 next-20200625]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Ard-Biesheuvel/crypto-permit-asynchronous-skciphers-as-driver-fallbacks/20200625-204707
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
config: x86_64-rhel-7.6 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/crypto/ccp/ccp-crypto-aes-xts.c: In function 'ccp_aes_xts_exit_tfm':
>> drivers/crypto/ccp/ccp-crypto-aes-xts.c:223:38: error: passing argument 1 of 'crypto_free_sync_skcipher' from incompatible pointer type [-Werror=incompatible-pointer-types]
     223 |  crypto_free_sync_skcipher(ctx->u.aes.tfm_skcipher);
         |                            ~~~~~~~~~~^~~~~~~~~~~~~
         |                                      |
         |                                      struct crypto_skcipher *
   In file included from include/crypto/internal/skcipher.h:12,
                    from include/crypto/xts.h:6,
                    from drivers/crypto/ccp/ccp-crypto-aes-xts.c:16:
   include/crypto/skcipher.h:205:75: note: expected 'struct crypto_sync_skcipher *' but argument is of type 'struct crypto_skcipher *'
     205 | static inline void crypto_free_sync_skcipher(struct crypto_sync_skcipher *tfm)
         |                                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
   cc1: some warnings being treated as errors

vim +/crypto_free_sync_skcipher +223 drivers/crypto/ccp/ccp-crypto-aes-xts.c

1d6b8a6f64076a Tom Lendacky   2013-11-12  218  
be9fe620af63e7 Ard Biesheuvel 2019-11-09  219  static void ccp_aes_xts_exit_tfm(struct crypto_skcipher *tfm)
1d6b8a6f64076a Tom Lendacky   2013-11-12  220  {
be9fe620af63e7 Ard Biesheuvel 2019-11-09  221  	struct ccp_ctx *ctx = crypto_skcipher_ctx(tfm);
1d6b8a6f64076a Tom Lendacky   2013-11-12  222  
7f28615df88a63 Kees Cook      2018-09-18 @223  	crypto_free_sync_skcipher(ctx->u.aes.tfm_skcipher);
1d6b8a6f64076a Tom Lendacky   2013-11-12  224  }
1d6b8a6f64076a Tom Lendacky   2013-11-12  225  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 49250 bytes --]

[-- Attachment #3: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Ard Biesheuvel <ardb@kernel.org>, linux-crypto@vger.kernel.org
Cc: Tom Lendacky <thomas.lendacky@amd.com>,
	kbuild-all@lists.01.org, Herbert Xu <herbert@gondor.apana.org.au>,
	Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Corentin Labbe <clabbe.montjoie@gmail.com>,
	linux-amlogic@lists.infradead.org, linux-omap@vger.kernel.org,
	Ard Biesheuvel <ardb@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 07/12] crypto: ccp - permit asynchronous skcipher as fallback
Date: Fri, 26 Jun 2020 00:24:07 +0800	[thread overview]
Message-ID: <202006260032.V8hwzVw0%lkp@intel.com> (raw)
In-Reply-To: <20200625124253.1906557-8-ardb@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 2731 bytes --]

Hi Ard,

I love your patch! Yet something to improve:

[auto build test ERROR on cryptodev/master]
[also build test ERROR on crypto/master sunxi/sunxi/for-next v5.8-rc2 next-20200625]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Ard-Biesheuvel/crypto-permit-asynchronous-skciphers-as-driver-fallbacks/20200625-204707
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
config: x86_64-rhel-7.6 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/crypto/ccp/ccp-crypto-aes-xts.c: In function 'ccp_aes_xts_exit_tfm':
>> drivers/crypto/ccp/ccp-crypto-aes-xts.c:223:38: error: passing argument 1 of 'crypto_free_sync_skcipher' from incompatible pointer type [-Werror=incompatible-pointer-types]
     223 |  crypto_free_sync_skcipher(ctx->u.aes.tfm_skcipher);
         |                            ~~~~~~~~~~^~~~~~~~~~~~~
         |                                      |
         |                                      struct crypto_skcipher *
   In file included from include/crypto/internal/skcipher.h:12,
                    from include/crypto/xts.h:6,
                    from drivers/crypto/ccp/ccp-crypto-aes-xts.c:16:
   include/crypto/skcipher.h:205:75: note: expected 'struct crypto_sync_skcipher *' but argument is of type 'struct crypto_skcipher *'
     205 | static inline void crypto_free_sync_skcipher(struct crypto_sync_skcipher *tfm)
         |                                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
   cc1: some warnings being treated as errors

vim +/crypto_free_sync_skcipher +223 drivers/crypto/ccp/ccp-crypto-aes-xts.c

1d6b8a6f64076a Tom Lendacky   2013-11-12  218  
be9fe620af63e7 Ard Biesheuvel 2019-11-09  219  static void ccp_aes_xts_exit_tfm(struct crypto_skcipher *tfm)
1d6b8a6f64076a Tom Lendacky   2013-11-12  220  {
be9fe620af63e7 Ard Biesheuvel 2019-11-09  221  	struct ccp_ctx *ctx = crypto_skcipher_ctx(tfm);
1d6b8a6f64076a Tom Lendacky   2013-11-12  222  
7f28615df88a63 Kees Cook      2018-09-18 @223  	crypto_free_sync_skcipher(ctx->u.aes.tfm_skcipher);
1d6b8a6f64076a Tom Lendacky   2013-11-12  224  }
1d6b8a6f64076a Tom Lendacky   2013-11-12  225  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 49250 bytes --]

[-- Attachment #3: Type: text/plain, Size: 167 bytes --]

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 07/12] crypto: ccp - permit asynchronous skcipher as fallback
Date: Fri, 26 Jun 2020 00:24:07 +0800	[thread overview]
Message-ID: <202006260032.V8hwzVw0%lkp@intel.com> (raw)
In-Reply-To: <20200625124253.1906557-8-ardb@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 2784 bytes --]

Hi Ard,

I love your patch! Yet something to improve:

[auto build test ERROR on cryptodev/master]
[also build test ERROR on crypto/master sunxi/sunxi/for-next v5.8-rc2 next-20200625]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Ard-Biesheuvel/crypto-permit-asynchronous-skciphers-as-driver-fallbacks/20200625-204707
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
config: x86_64-rhel-7.6 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/crypto/ccp/ccp-crypto-aes-xts.c: In function 'ccp_aes_xts_exit_tfm':
>> drivers/crypto/ccp/ccp-crypto-aes-xts.c:223:38: error: passing argument 1 of 'crypto_free_sync_skcipher' from incompatible pointer type [-Werror=incompatible-pointer-types]
     223 |  crypto_free_sync_skcipher(ctx->u.aes.tfm_skcipher);
         |                            ~~~~~~~~~~^~~~~~~~~~~~~
         |                                      |
         |                                      struct crypto_skcipher *
   In file included from include/crypto/internal/skcipher.h:12,
                    from include/crypto/xts.h:6,
                    from drivers/crypto/ccp/ccp-crypto-aes-xts.c:16:
   include/crypto/skcipher.h:205:75: note: expected 'struct crypto_sync_skcipher *' but argument is of type 'struct crypto_skcipher *'
     205 | static inline void crypto_free_sync_skcipher(struct crypto_sync_skcipher *tfm)
         |                                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
   cc1: some warnings being treated as errors

vim +/crypto_free_sync_skcipher +223 drivers/crypto/ccp/ccp-crypto-aes-xts.c

1d6b8a6f64076a Tom Lendacky   2013-11-12  218  
be9fe620af63e7 Ard Biesheuvel 2019-11-09  219  static void ccp_aes_xts_exit_tfm(struct crypto_skcipher *tfm)
1d6b8a6f64076a Tom Lendacky   2013-11-12  220  {
be9fe620af63e7 Ard Biesheuvel 2019-11-09  221  	struct ccp_ctx *ctx = crypto_skcipher_ctx(tfm);
1d6b8a6f64076a Tom Lendacky   2013-11-12  222  
7f28615df88a63 Kees Cook      2018-09-18 @223  	crypto_free_sync_skcipher(ctx->u.aes.tfm_skcipher);
1d6b8a6f64076a Tom Lendacky   2013-11-12  224  }
1d6b8a6f64076a Tom Lendacky   2013-11-12  225  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 49250 bytes --]

  reply	other threads:[~2020-06-25 16:51 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-25 12:42 [PATCH 00/12] crypto: permit asynchronous skciphers as driver fallbacks Ard Biesheuvel
2020-06-25 12:42 ` Ard Biesheuvel
2020-06-25 12:42 ` Ard Biesheuvel
2020-06-25 12:42 ` [PATCH 01/12] crypto: amlogic-gxl - default to build as module Ard Biesheuvel
2020-06-25 12:42   ` Ard Biesheuvel
2020-06-25 12:42   ` Ard Biesheuvel
2020-06-25 12:42 ` [PATCH 02/12] crypto: amlogic-gxl - permit async skcipher as fallback Ard Biesheuvel
2020-06-25 12:42   ` Ard Biesheuvel
2020-06-25 12:42   ` Ard Biesheuvel
2020-06-25 12:42 ` [PATCH 03/12] crypto: omap-aes - permit asynchronous " Ard Biesheuvel
2020-06-25 12:42   ` Ard Biesheuvel
2020-06-25 12:42   ` Ard Biesheuvel
2020-06-25 12:42 ` [PATCH 04/12] crypto: sun4i " Ard Biesheuvel
2020-06-25 12:42   ` Ard Biesheuvel
2020-06-25 12:42   ` Ard Biesheuvel
2020-06-25 12:42 ` [PATCH 05/12] crypto: sun8i-ce " Ard Biesheuvel
2020-06-25 12:42   ` Ard Biesheuvel
2020-06-25 12:42   ` Ard Biesheuvel
2020-06-25 12:42 ` [PATCH 06/12] crypto: sun8i-ss " Ard Biesheuvel
2020-06-25 12:42   ` Ard Biesheuvel
2020-06-25 12:42   ` Ard Biesheuvel
2020-06-25 12:42 ` [PATCH 07/12] crypto: ccp " Ard Biesheuvel
2020-06-25 12:42   ` Ard Biesheuvel
2020-06-25 12:42   ` Ard Biesheuvel
2020-06-25 16:24   ` kernel test robot [this message]
2020-06-25 16:24     ` kernel test robot
2020-06-25 16:24     ` kernel test robot
2020-06-25 16:24     ` kernel test robot
2020-06-25 20:04   ` kernel test robot
2020-06-25 20:04     ` kernel test robot
2020-06-25 12:42 ` [PATCH 08/12] crypto: chelsio " Ard Biesheuvel
2020-06-25 12:42   ` Ard Biesheuvel
2020-06-25 12:42   ` Ard Biesheuvel
2020-06-25 12:42 ` [PATCH 09/12] crypto: mxs-dcp " Ard Biesheuvel
2020-06-25 12:42   ` Ard Biesheuvel
2020-06-25 12:42   ` Ard Biesheuvel
2020-06-25 12:42 ` [PATCH 10/12] crypto: picoxcell " Ard Biesheuvel
2020-06-25 12:42   ` Ard Biesheuvel
2020-06-25 12:42   ` Ard Biesheuvel
2020-06-25 12:42 ` [PATCH 11/12] crypto: qce " Ard Biesheuvel
2020-06-25 12:42   ` Ard Biesheuvel
2020-06-25 12:42   ` Ard Biesheuvel
2020-06-25 12:42 ` [PATCH 12/12] crypto: sahara " Ard Biesheuvel
2020-06-25 12:42   ` Ard Biesheuvel
2020-06-25 12:42   ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202006260032.V8hwzVw0%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=ardb@kernel.org \
    --cc=clabbe.montjoie@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mripard@kernel.org \
    --cc=thomas.lendacky@amd.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.