From: Alexandre Belloni <alexandre.belloni@bootlin.com> To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>, Arnd Bergmann <arnd@arndb.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Ludovic Desroches <ludovic.desroches@microchip.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] misc: atmel-ssc: lock with mutex instead of spinlock Date: Tue, 30 Jun 2020 00:30:04 +0200 [thread overview] Message-ID: <20200629223004.GC3800@piout.net> (raw) In-Reply-To: <50f0d7fa107f318296afb49477c3571e4d6978c5.1592998403.git.mirq-linux@rere.qmqm.pl> On 24/06/2020 13:35:41+0200, Michał Mirosław wrote: > Uninterruptible context is not needed in the driver and causes lockdep > warning because of mutex taken in of_alias_get_id(). Convert the lock to > mutex to avoid the issue. > > Cc: stable@vger.kernel.org > Fixes: 099343c64e16 ("ARM: at91: atmel-ssc: add device tree support") > Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > --- > v2: rebased onto v5.7.5, added Fixes tag > --- > drivers/misc/atmel-ssc.c | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c > index ab4144ea1f11..d6cd5537126c 100644 > --- a/drivers/misc/atmel-ssc.c > +++ b/drivers/misc/atmel-ssc.c > @@ -10,7 +10,7 @@ > #include <linux/clk.h> > #include <linux/err.h> > #include <linux/io.h> > -#include <linux/spinlock.h> > +#include <linux/mutex.h> > #include <linux/atmel-ssc.h> > #include <linux/slab.h> > #include <linux/module.h> > @@ -20,7 +20,7 @@ > #include "../../sound/soc/atmel/atmel_ssc_dai.h" > > /* Serialize access to ssc_list and user count */ > -static DEFINE_SPINLOCK(user_lock); > +static DEFINE_MUTEX(user_lock); > static LIST_HEAD(ssc_list); > > struct ssc_device *ssc_request(unsigned int ssc_num) > @@ -28,7 +28,7 @@ struct ssc_device *ssc_request(unsigned int ssc_num) > int ssc_valid = 0; > struct ssc_device *ssc; > > - spin_lock(&user_lock); > + mutex_lock(&user_lock); > list_for_each_entry(ssc, &ssc_list, list) { > if (ssc->pdev->dev.of_node) { > if (of_alias_get_id(ssc->pdev->dev.of_node, "ssc") > @@ -44,18 +44,18 @@ struct ssc_device *ssc_request(unsigned int ssc_num) > } > > if (!ssc_valid) { > - spin_unlock(&user_lock); > + mutex_unlock(&user_lock); > pr_err("ssc: ssc%d platform device is missing\n", ssc_num); > return ERR_PTR(-ENODEV); > } > > if (ssc->user) { > - spin_unlock(&user_lock); > + mutex_unlock(&user_lock); > dev_dbg(&ssc->pdev->dev, "module busy\n"); > return ERR_PTR(-EBUSY); > } > ssc->user++; > - spin_unlock(&user_lock); > + mutex_unlock(&user_lock); > > clk_prepare(ssc->clk); > > @@ -67,14 +67,14 @@ void ssc_free(struct ssc_device *ssc) > { > bool disable_clk = true; > > - spin_lock(&user_lock); > + mutex_lock(&user_lock); > if (ssc->user) > ssc->user--; > else { > disable_clk = false; > dev_dbg(&ssc->pdev->dev, "device already free\n"); > } > - spin_unlock(&user_lock); > + mutex_unlock(&user_lock); > > if (disable_clk) > clk_unprepare(ssc->clk); > @@ -237,9 +237,9 @@ static int ssc_probe(struct platform_device *pdev) > return -ENXIO; > } > > - spin_lock(&user_lock); > + mutex_lock(&user_lock); > list_add_tail(&ssc->list, &ssc_list); > - spin_unlock(&user_lock); > + mutex_unlock(&user_lock); > > platform_set_drvdata(pdev, ssc); > > @@ -258,9 +258,9 @@ static int ssc_remove(struct platform_device *pdev) > > ssc_sound_dai_remove(ssc); > > - spin_lock(&user_lock); > + mutex_lock(&user_lock); > list_del(&ssc->list); > - spin_unlock(&user_lock); > + mutex_unlock(&user_lock); > > return 0; > } > -- > 2.20.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@bootlin.com> To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl> Cc: Arnd Bergmann <arnd@arndb.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-kernel@vger.kernel.org, Ludovic Desroches <ludovic.desroches@microchip.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] misc: atmel-ssc: lock with mutex instead of spinlock Date: Tue, 30 Jun 2020 00:30:04 +0200 [thread overview] Message-ID: <20200629223004.GC3800@piout.net> (raw) In-Reply-To: <50f0d7fa107f318296afb49477c3571e4d6978c5.1592998403.git.mirq-linux@rere.qmqm.pl> On 24/06/2020 13:35:41+0200, Michał Mirosław wrote: > Uninterruptible context is not needed in the driver and causes lockdep > warning because of mutex taken in of_alias_get_id(). Convert the lock to > mutex to avoid the issue. > > Cc: stable@vger.kernel.org > Fixes: 099343c64e16 ("ARM: at91: atmel-ssc: add device tree support") > Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > --- > v2: rebased onto v5.7.5, added Fixes tag > --- > drivers/misc/atmel-ssc.c | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c > index ab4144ea1f11..d6cd5537126c 100644 > --- a/drivers/misc/atmel-ssc.c > +++ b/drivers/misc/atmel-ssc.c > @@ -10,7 +10,7 @@ > #include <linux/clk.h> > #include <linux/err.h> > #include <linux/io.h> > -#include <linux/spinlock.h> > +#include <linux/mutex.h> > #include <linux/atmel-ssc.h> > #include <linux/slab.h> > #include <linux/module.h> > @@ -20,7 +20,7 @@ > #include "../../sound/soc/atmel/atmel_ssc_dai.h" > > /* Serialize access to ssc_list and user count */ > -static DEFINE_SPINLOCK(user_lock); > +static DEFINE_MUTEX(user_lock); > static LIST_HEAD(ssc_list); > > struct ssc_device *ssc_request(unsigned int ssc_num) > @@ -28,7 +28,7 @@ struct ssc_device *ssc_request(unsigned int ssc_num) > int ssc_valid = 0; > struct ssc_device *ssc; > > - spin_lock(&user_lock); > + mutex_lock(&user_lock); > list_for_each_entry(ssc, &ssc_list, list) { > if (ssc->pdev->dev.of_node) { > if (of_alias_get_id(ssc->pdev->dev.of_node, "ssc") > @@ -44,18 +44,18 @@ struct ssc_device *ssc_request(unsigned int ssc_num) > } > > if (!ssc_valid) { > - spin_unlock(&user_lock); > + mutex_unlock(&user_lock); > pr_err("ssc: ssc%d platform device is missing\n", ssc_num); > return ERR_PTR(-ENODEV); > } > > if (ssc->user) { > - spin_unlock(&user_lock); > + mutex_unlock(&user_lock); > dev_dbg(&ssc->pdev->dev, "module busy\n"); > return ERR_PTR(-EBUSY); > } > ssc->user++; > - spin_unlock(&user_lock); > + mutex_unlock(&user_lock); > > clk_prepare(ssc->clk); > > @@ -67,14 +67,14 @@ void ssc_free(struct ssc_device *ssc) > { > bool disable_clk = true; > > - spin_lock(&user_lock); > + mutex_lock(&user_lock); > if (ssc->user) > ssc->user--; > else { > disable_clk = false; > dev_dbg(&ssc->pdev->dev, "device already free\n"); > } > - spin_unlock(&user_lock); > + mutex_unlock(&user_lock); > > if (disable_clk) > clk_unprepare(ssc->clk); > @@ -237,9 +237,9 @@ static int ssc_probe(struct platform_device *pdev) > return -ENXIO; > } > > - spin_lock(&user_lock); > + mutex_lock(&user_lock); > list_add_tail(&ssc->list, &ssc_list); > - spin_unlock(&user_lock); > + mutex_unlock(&user_lock); > > platform_set_drvdata(pdev, ssc); > > @@ -258,9 +258,9 @@ static int ssc_remove(struct platform_device *pdev) > > ssc_sound_dai_remove(ssc); > > - spin_lock(&user_lock); > + mutex_lock(&user_lock); > list_del(&ssc->list); > - spin_unlock(&user_lock); > + mutex_unlock(&user_lock); > > return 0; > } > -- > 2.20.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-29 22:30 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-24 11:35 [PATCH v2] misc: atmel-ssc: lock with mutex instead of spinlock Michał Mirosław 2020-06-24 11:35 ` Michał Mirosław 2020-06-29 22:30 ` Alexandre Belloni [this message] 2020-06-29 22:30 ` Alexandre Belloni
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200629223004.GC3800@piout.net \ --to=alexandre.belloni@bootlin.com \ --cc=arnd@arndb.de \ --cc=gregkh@linuxfoundation.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=ludovic.desroches@microchip.com \ --cc=mirq-linux@rere.qmqm.pl \ --cc=nicolas.ferre@microchip.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.