Re: [PATCH v6 08/12] device core: Introduce DMA range map, supplanting dma_pfn_offset

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v6 08/12] device core: Introduce DMA range map, supplanting dma_pfn_offset
Date: Thu, 02 Jul 2020 13:21:58 +0800	[thread overview]
Message-ID: <202007021323.Yi95rDJ9%lkp@intel.com> (raw)
In-Reply-To: <20200701212155.37830-9-james.quinlan@broadcom.com>

[-- Attachment #1: Type: text/plain, Size: 2821 bytes --]

Hi Jim,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on pci/next]
[also build test ERROR on robh/for-next linuxtv-media/master usb/usb-testing linus/master v5.8-rc3 next-20200701]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jim-Quinlan/PCI-brcmstb-enable-PCIe-for-STB-chips/20200702-053156
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project c8f1d442d0858f66fd4128fde6f67eb5202fa2b1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c:902:32: error: use of undeclared identifier 'dev'; did you mean 'sdev'?
           ret = dma_attach_offset_range(dev->dev, PHYS_OFFSET, 0, SIZE_MAX);
                                         ^~~
                                         sdev
   drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c:892:24: note: 'sdev' declared here
           struct sun6i_csi_dev *sdev;
                                 ^
   1 error generated.

vim +902 drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c

   889	
   890	static int sun6i_csi_probe(struct platform_device *pdev)
   891	{
   892		struct sun6i_csi_dev *sdev;
   893		int ret;
   894	
   895		sdev = devm_kzalloc(&pdev->dev, sizeof(*sdev), GFP_KERNEL);
   896		if (!sdev)
   897			return -ENOMEM;
   898	
   899		sdev->dev = &pdev->dev;
   900		/* The DMA bus has the memory mapped at 0 */
   901		/* FIXME: Need better bounds for the DMA region */
 > 902		ret = dma_attach_offset_range(dev->dev, PHYS_OFFSET, 0, SIZE_MAX);
   903		if (ret)
   904			return ret;
   905	
   906		ret = sun6i_csi_resource_request(sdev, pdev);
   907		if (ret)
   908			return ret;
   909	
   910		platform_set_drvdata(pdev, sdev);
   911	
   912		sdev->csi.dev = &pdev->dev;
   913		return sun6i_csi_v4l2_init(&sdev->csi);
   914	}
   915	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 75309 bytes --]