From: Sam Ravnborg <sam@ravnborg.org>
To: "Ondřej Jirman" <megous@megous.com>,
"Rob Herring" <robh@kernel.org>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Guido Günther" <agx@sigxcpu.org>,
linux-kernel@vger.kernel.org,
"Purism Kernel Team" <kernel@puri.sm>,
"Chen-Yu Tsai" <wens@csie.org>,
"Samuel Holland" <samuel@sholland.org>,
devicetree@vger.kernel.org, "Bhushan Shah" <bshah@kde.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
linux-sunxi@googlegroups.com, "Luca Weiss" <luca@z3ntu.xyz>,
"Martijn Braam" <martijn@brixit.nl>,
"Icenowy Zheng" <icenowy@aosc.io>,
"Maxime Ripard" <mripard@kernel.org>,
linux-arm-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org,
"Linus Walleij" <linus.walleij@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>
Subject: Re: [PATCH v7 02/13] dt-bindings: panel: Convert rocktech, jh057n00900 to yaml
Date: Fri, 3 Jul 2020 07:11:55 +0200 [thread overview]
Message-ID: <20200703051155.GA1685118@ravnborg.org> (raw)
In-Reply-To: <20200702210354.562wkzpdmyrlwojx@core.my.home>
Hi Ondrej.
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: '#address-cells', '#size-cells', 'port@0' do not match any of the regexes: 'pinctrl-[0-9]+'
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'vcc-supply' is a required property
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'iovcc-supply' is a required property
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'reset-gpios' is a required property
>
> Paths look bogus ^^^^
>
> It should be .../rocktech,jh057n00900.yaml: ...
The example in nwl-dsi.yaml contains:
compatible = "rocktech,jh057n00900";
So the example is checked against your updated binding.
And the binding check fails because the example is no longer valid.
This needs to be fixed as we do not wat to introduce new errors.
Either the example or the binding needs the fix.
Sam
>
> regards,
> o.
>
> >
> > See https://patchwork.ozlabs.org/patch/1320690
> >
> > If you already ran 'make dt_binding_check' and didn't see the above
> > error(s), then make sure dt-schema is up to date:
> >
> > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
> >
> > Please check and re-submit.
> >
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: "Ondřej Jirman" <megous@megous.com>,
"Rob Herring" <robh@kernel.org>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Guido Günther" <agx@sigxcpu.org>,
linux-kernel@vger.kernel.org,
"Purism Kernel Team" <kernel@puri.sm>,
"Chen-Yu Tsai" <wens@csie.org>,
"Samuel Holland" <samuel@sholland.org>,
devicetree@vger.kernel.org, "Bhushan Shah" <bshah@kde.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
linux-sunxi@googlegroups.com, "Luca Weiss" <luca@z3ntu.xyz>,
"Martijn Braam" <martijn@brixit.nl>,
"Icenowy Zheng" <icenowy@aosc.io>,
"Maxime Ripard" <mripard@kernel.org>,
linux-arm-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org,
"Linus Walleij" <linus.walleij@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>
Subject: Re: [PATCH v7 02/13] dt-bindings: panel: Convert rocktech, jh057n00900 to yaml
Date: Fri, 3 Jul 2020 07:11:55 +0200 [thread overview]
Message-ID: <20200703051155.GA1685118@ravnborg.org> (raw)
In-Reply-To: <20200702210354.562wkzpdmyrlwojx@core.my.home>
Hi Ondrej.
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: '#address-cells', '#size-cells', 'port@0' do not match any of the regexes: 'pinctrl-[0-9]+'
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'vcc-supply' is a required property
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'iovcc-supply' is a required property
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'reset-gpios' is a required property
>
> Paths look bogus ^^^^
>
> It should be .../rocktech,jh057n00900.yaml: ...
The example in nwl-dsi.yaml contains:
compatible = "rocktech,jh057n00900";
So the example is checked against your updated binding.
And the binding check fails because the example is no longer valid.
This needs to be fixed as we do not wat to introduce new errors.
Either the example or the binding needs the fix.
Sam
>
> regards,
> o.
>
> >
> > See https://patchwork.ozlabs.org/patch/1320690
> >
> > If you already ran 'make dt_binding_check' and didn't see the above
> > error(s), then make sure dt-schema is up to date:
> >
> > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
> >
> > Please check and re-submit.
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: "Ondřej Jirman" <megous@megous.com>,
"Rob Herring" <robh@kernel.org>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Guido Günther" <agx@sigxcpu.org>,
linux-kernel@vger.kernel.org,
"Purism Kernel Team" <kernel@puri.sm>,
"Chen-Yu Tsai" <wens@csie.org>,
"Samuel Holland" <samuel@sholland.org>,
devicetree@vger.kernel.org, "Bhushan Shah" <bshah@kde.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
linux-sunxi@googlegroups.com, "Luca Weiss" <luca@z3ntu.xyz>,
"Martijn Braam" <martijn@brixit.nl>,
"Icenowy Zheng" <icenowy@aosc.io>,
"Maxime Ripard" <mripard@kernel.org>,
linux-arm-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org,
"Linus Walleij" <linus.walleij@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>
Subject: Re: [PATCH v7 02/13] dt-bindings: panel: Convert rocktech, jh057n00900 to yaml
Date: Fri, 3 Jul 2020 07:11:55 +0200 [thread overview]
Message-ID: <20200703051155.GA1685118@ravnborg.org> (raw)
In-Reply-To: <20200702210354.562wkzpdmyrlwojx@core.my.home>
Hi Ondrej.
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: '#address-cells', '#size-cells', 'port@0' do not match any of the regexes: 'pinctrl-[0-9]+'
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'vcc-supply' is a required property
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'iovcc-supply' is a required property
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'reset-gpios' is a required property
>
> Paths look bogus ^^^^
>
> It should be .../rocktech,jh057n00900.yaml: ...
The example in nwl-dsi.yaml contains:
compatible = "rocktech,jh057n00900";
So the example is checked against your updated binding.
And the binding check fails because the example is no longer valid.
This needs to be fixed as we do not wat to introduce new errors.
Either the example or the binding needs the fix.
Sam
>
> regards,
> o.
>
> >
> > See https://patchwork.ozlabs.org/patch/1320690
> >
> > If you already ran 'make dt_binding_check' and didn't see the above
> > error(s), then make sure dt-schema is up to date:
> >
> > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
> >
> > Please check and re-submit.
> >
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-07-03 5:12 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 16:29 [PATCH v7 00/13] Add support for PinePhone LCD panel Ondrej Jirman
2020-07-01 16:29 ` Ondrej Jirman
2020-07-01 16:29 ` Ondrej Jirman
2020-07-01 16:29 ` [PATCH v7 01/13] dt-bindings: vendor-prefixes: Add Xingbangda Ondrej Jirman
2020-07-01 16:29 ` Ondrej Jirman
2020-07-01 16:29 ` Ondrej Jirman
2020-07-01 16:29 ` [PATCH v7 02/13] dt-bindings: panel: Convert rocktech,jh057n00900 to yaml Ondrej Jirman
2020-07-01 16:29 ` [PATCH v7 02/13] dt-bindings: panel: Convert rocktech, jh057n00900 " Ondrej Jirman
2020-07-01 16:29 ` Ondrej Jirman
2020-07-02 20:51 ` Rob Herring
2020-07-02 20:51 ` Rob Herring
2020-07-02 20:51 ` Rob Herring
2020-07-02 21:03 ` Ondřej Jirman
2020-07-02 21:03 ` Ondřej Jirman
2020-07-02 21:03 ` Ondřej Jirman
2020-07-03 5:11 ` Sam Ravnborg [this message]
2020-07-03 5:11 ` Sam Ravnborg
2020-07-03 5:11 ` Sam Ravnborg
2020-07-03 10:44 ` Ondřej Jirman
2020-07-03 10:44 ` Ondřej Jirman
2020-07-03 10:44 ` Ondřej Jirman
2020-07-03 11:13 ` Ondřej Jirman
2020-07-03 11:13 ` Ondřej Jirman
2020-07-03 11:13 ` Ondřej Jirman
2020-07-01 16:29 ` [PATCH v7 03/13] dt-bindings: panel: Add compatible for Xingbangda XBD599 panel Ondrej Jirman
2020-07-01 16:29 ` Ondrej Jirman
2020-07-01 16:29 ` Ondrej Jirman
2020-07-01 16:29 ` [PATCH v7 04/13] drm/panel: rocktech-jh057n00900: Rename the driver to st7703 Ondrej Jirman
2020-07-01 16:29 ` Ondrej Jirman
2020-07-01 16:29 ` Ondrej Jirman
2020-07-01 16:29 ` [PATCH v7 05/13] drm/panel: st7703: Rename functions from jh057n prefix " Ondrej Jirman
2020-07-01 16:29 ` Ondrej Jirman
2020-07-01 16:29 ` Ondrej Jirman
2020-07-01 16:29 ` [PATCH v7 06/13] drm/panel: st7703: Prepare for supporting multiple panels Ondrej Jirman
2020-07-01 16:29 ` Ondrej Jirman
2020-07-01 16:29 ` Ondrej Jirman
2020-07-01 16:29 ` [PATCH v7 07/13] drm/panel: st7703: Move code specific to jh057n closer together Ondrej Jirman
2020-07-01 16:29 ` Ondrej Jirman
2020-07-01 16:29 ` Ondrej Jirman
2020-07-01 16:29 ` [PATCH v7 08/13] drm/panel: st7703: Move generic part of init sequence to enable callback Ondrej Jirman
2020-07-01 16:29 ` Ondrej Jirman
2020-07-01 16:29 ` Ondrej Jirman
2020-07-01 16:29 ` [PATCH v7 09/13] drm/panel: st7703: Add support for Xingbangda XBD599 Ondrej Jirman
2020-07-01 16:29 ` Ondrej Jirman
2020-07-01 16:29 ` Ondrej Jirman
2020-07-01 16:29 ` [PATCH v7 10/13] drm/panel: st7703: Enter sleep after display off Ondrej Jirman
2020-07-01 16:29 ` Ondrej Jirman
2020-07-01 16:29 ` Ondrej Jirman
2020-07-01 16:29 ` [PATCH v7 11/13] drm/panel: st7703: Assert reset prior to powering down the regulators Ondrej Jirman
2020-07-01 16:29 ` Ondrej Jirman
2020-07-01 16:29 ` Ondrej Jirman
2020-07-01 16:29 ` [PATCH v7 12/13] arm64: dts: sun50i-a64-pinephone: Enable LCD support on PinePhone Ondrej Jirman
2020-07-01 16:29 ` Ondrej Jirman
2020-07-01 16:29 ` Ondrej Jirman
2020-07-02 7:46 ` Maxime Ripard
2020-07-02 7:46 ` Maxime Ripard
2020-07-02 7:46 ` Maxime Ripard
2020-07-01 16:29 ` [PATCH v7 13/13] arm64: dts: sun50i-a64-pinephone: Add touchscreen support Ondrej Jirman
2020-07-01 16:29 ` Ondrej Jirman
2020-07-01 16:29 ` Ondrej Jirman
2020-07-01 17:30 ` [PATCH v7 00/13] Add support for PinePhone LCD panel Sam Ravnborg
2020-07-01 17:30 ` Sam Ravnborg
2020-07-01 17:30 ` Sam Ravnborg
2020-07-01 18:48 ` Ondřej Jirman
2020-07-01 18:48 ` Ondřej Jirman
2020-07-01 18:48 ` Ondřej Jirman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200703051155.GA1685118@ravnborg.org \
--to=sam@ravnborg.org \
--cc=agx@sigxcpu.org \
--cc=airlied@linux.ie \
--cc=bshah@kde.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=icenowy@aosc.io \
--cc=kernel@puri.sm \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=luca@z3ntu.xyz \
--cc=martijn@brixit.nl \
--cc=megous@megous.com \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=samuel@sholland.org \
--cc=thierry.reding@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.