From: Lee Jones <lee.jones@linaro.org>
To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
Lee Jones <lee.jones@linaro.org>,
zhong jiang <zhongjiang@huawei.com>,
Ola Lilja <ola.o.lilja@stericsson.com>,
Roger Nilsson <roger.xr.nilsson@stericsson.com>,
Sandeep Kaushik <sandeep.kaushik@st.com>
Subject: [PATCH 19/28] ASoC: ux500: ux500_msp_i2s: Remove unused variables 'reg_val_DR' and 'reg_val_TSTDR'
Date: Tue, 7 Jul 2020 11:16:33 +0100 [thread overview]
Message-ID: <20200707101642.1747944-20-lee.jones@linaro.org> (raw)
In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org>
Looks like these have been unchecked since the driver's inception in 2012.
Fixes the following W=1 kernel build warning(s):
sound/soc/ux500/ux500_msp_i2s.c: In function ‘flush_fifo_rx’:
sound/soc/ux500/ux500_msp_i2s.c:398:6: warning: variable ‘reg_val_DR’ set but not used [-Wunused-but-set-variable]
sound/soc/ux500/ux500_msp_i2s.c: In function ‘flush_fifo_tx’:
sound/soc/ux500/ux500_msp_i2s.c:415:6: warning: variable ‘reg_val_TSTDR’ set but not used [-Wunused-but-set-variable]
Cc: zhong jiang <zhongjiang@huawei.com>
Cc: Ola Lilja <ola.o.lilja@stericsson.com>
Cc: Roger Nilsson <roger.xr.nilsson@stericsson.com>
Cc: Sandeep Kaushik <sandeep.kaushik@st.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
sound/soc/ux500/ux500_msp_i2s.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/ux500/ux500_msp_i2s.c b/sound/soc/ux500/ux500_msp_i2s.c
index 394d8b2a4a161..fd0b88bb79212 100644
--- a/sound/soc/ux500/ux500_msp_i2s.c
+++ b/sound/soc/ux500/ux500_msp_i2s.c
@@ -395,7 +395,7 @@ static int enable_msp(struct ux500_msp *msp, struct ux500_msp_config *config)
static void flush_fifo_rx(struct ux500_msp *msp)
{
- u32 reg_val_DR, reg_val_GCR, reg_val_FLR;
+ u32 reg_val_GCR, reg_val_FLR;
u32 limit = 32;
reg_val_GCR = readl(msp->registers + MSP_GCR);
@@ -403,7 +403,7 @@ static void flush_fifo_rx(struct ux500_msp *msp)
reg_val_FLR = readl(msp->registers + MSP_FLR);
while (!(reg_val_FLR & RX_FIFO_EMPTY) && limit--) {
- reg_val_DR = readl(msp->registers + MSP_DR);
+ readl(msp->registers + MSP_DR);
reg_val_FLR = readl(msp->registers + MSP_FLR);
}
@@ -412,7 +412,7 @@ static void flush_fifo_rx(struct ux500_msp *msp)
static void flush_fifo_tx(struct ux500_msp *msp)
{
- u32 reg_val_TSTDR, reg_val_GCR, reg_val_FLR;
+ u32 reg_val_GCR, reg_val_FLR;
u32 limit = 32;
reg_val_GCR = readl(msp->registers + MSP_GCR);
@@ -421,7 +421,7 @@ static void flush_fifo_tx(struct ux500_msp *msp)
reg_val_FLR = readl(msp->registers + MSP_FLR);
while (!(reg_val_FLR & TX_FIFO_EMPTY) && limit--) {
- reg_val_TSTDR = readl(msp->registers + MSP_TSTDR);
+ readl(msp->registers + MSP_TSTDR);
reg_val_FLR = readl(msp->registers + MSP_FLR);
}
writel(0x0, msp->registers + MSP_ITCR);
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com
Cc: Ola Lilja <ola.o.lilja@stericsson.com>,
alsa-devel@alsa-project.org,
Roger Nilsson <roger.xr.nilsson@stericsson.com>,
Lee Jones <lee.jones@linaro.org>,
linux-kernel@vger.kernel.org,
Sandeep Kaushik <sandeep.kaushik@st.com>,
zhong jiang <zhongjiang@huawei.com>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 19/28] ASoC: ux500: ux500_msp_i2s: Remove unused variables 'reg_val_DR' and 'reg_val_TSTDR'
Date: Tue, 7 Jul 2020 11:16:33 +0100 [thread overview]
Message-ID: <20200707101642.1747944-20-lee.jones@linaro.org> (raw)
In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org>
Looks like these have been unchecked since the driver's inception in 2012.
Fixes the following W=1 kernel build warning(s):
sound/soc/ux500/ux500_msp_i2s.c: In function ‘flush_fifo_rx’:
sound/soc/ux500/ux500_msp_i2s.c:398:6: warning: variable ‘reg_val_DR’ set but not used [-Wunused-but-set-variable]
sound/soc/ux500/ux500_msp_i2s.c: In function ‘flush_fifo_tx’:
sound/soc/ux500/ux500_msp_i2s.c:415:6: warning: variable ‘reg_val_TSTDR’ set but not used [-Wunused-but-set-variable]
Cc: zhong jiang <zhongjiang@huawei.com>
Cc: Ola Lilja <ola.o.lilja@stericsson.com>
Cc: Roger Nilsson <roger.xr.nilsson@stericsson.com>
Cc: Sandeep Kaushik <sandeep.kaushik@st.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
sound/soc/ux500/ux500_msp_i2s.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/ux500/ux500_msp_i2s.c b/sound/soc/ux500/ux500_msp_i2s.c
index 394d8b2a4a161..fd0b88bb79212 100644
--- a/sound/soc/ux500/ux500_msp_i2s.c
+++ b/sound/soc/ux500/ux500_msp_i2s.c
@@ -395,7 +395,7 @@ static int enable_msp(struct ux500_msp *msp, struct ux500_msp_config *config)
static void flush_fifo_rx(struct ux500_msp *msp)
{
- u32 reg_val_DR, reg_val_GCR, reg_val_FLR;
+ u32 reg_val_GCR, reg_val_FLR;
u32 limit = 32;
reg_val_GCR = readl(msp->registers + MSP_GCR);
@@ -403,7 +403,7 @@ static void flush_fifo_rx(struct ux500_msp *msp)
reg_val_FLR = readl(msp->registers + MSP_FLR);
while (!(reg_val_FLR & RX_FIFO_EMPTY) && limit--) {
- reg_val_DR = readl(msp->registers + MSP_DR);
+ readl(msp->registers + MSP_DR);
reg_val_FLR = readl(msp->registers + MSP_FLR);
}
@@ -412,7 +412,7 @@ static void flush_fifo_rx(struct ux500_msp *msp)
static void flush_fifo_tx(struct ux500_msp *msp)
{
- u32 reg_val_TSTDR, reg_val_GCR, reg_val_FLR;
+ u32 reg_val_GCR, reg_val_FLR;
u32 limit = 32;
reg_val_GCR = readl(msp->registers + MSP_GCR);
@@ -421,7 +421,7 @@ static void flush_fifo_tx(struct ux500_msp *msp)
reg_val_FLR = readl(msp->registers + MSP_FLR);
while (!(reg_val_FLR & TX_FIFO_EMPTY) && limit--) {
- reg_val_TSTDR = readl(msp->registers + MSP_TSTDR);
+ readl(msp->registers + MSP_TSTDR);
reg_val_FLR = readl(msp->registers + MSP_FLR);
}
writel(0x0, msp->registers + MSP_ITCR);
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com
Cc: Ola Lilja <ola.o.lilja@stericsson.com>,
alsa-devel@alsa-project.org,
Roger Nilsson <roger.xr.nilsson@stericsson.com>,
Lee Jones <lee.jones@linaro.org>,
linux-kernel@vger.kernel.org,
Sandeep Kaushik <sandeep.kaushik@st.com>,
zhong jiang <zhongjiang@huawei.com>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 19/28] ASoC: ux500: ux500_msp_i2s: Remove unused variables 'reg_val_DR' and 'reg_val_TSTDR'
Date: Tue, 7 Jul 2020 11:16:33 +0100 [thread overview]
Message-ID: <20200707101642.1747944-20-lee.jones@linaro.org> (raw)
In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org>
Looks like these have been unchecked since the driver's inception in 2012.
Fixes the following W=1 kernel build warning(s):
sound/soc/ux500/ux500_msp_i2s.c: In function ‘flush_fifo_rx’:
sound/soc/ux500/ux500_msp_i2s.c:398:6: warning: variable ‘reg_val_DR’ set but not used [-Wunused-but-set-variable]
sound/soc/ux500/ux500_msp_i2s.c: In function ‘flush_fifo_tx’:
sound/soc/ux500/ux500_msp_i2s.c:415:6: warning: variable ‘reg_val_TSTDR’ set but not used [-Wunused-but-set-variable]
Cc: zhong jiang <zhongjiang@huawei.com>
Cc: Ola Lilja <ola.o.lilja@stericsson.com>
Cc: Roger Nilsson <roger.xr.nilsson@stericsson.com>
Cc: Sandeep Kaushik <sandeep.kaushik@st.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
sound/soc/ux500/ux500_msp_i2s.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/ux500/ux500_msp_i2s.c b/sound/soc/ux500/ux500_msp_i2s.c
index 394d8b2a4a161..fd0b88bb79212 100644
--- a/sound/soc/ux500/ux500_msp_i2s.c
+++ b/sound/soc/ux500/ux500_msp_i2s.c
@@ -395,7 +395,7 @@ static int enable_msp(struct ux500_msp *msp, struct ux500_msp_config *config)
static void flush_fifo_rx(struct ux500_msp *msp)
{
- u32 reg_val_DR, reg_val_GCR, reg_val_FLR;
+ u32 reg_val_GCR, reg_val_FLR;
u32 limit = 32;
reg_val_GCR = readl(msp->registers + MSP_GCR);
@@ -403,7 +403,7 @@ static void flush_fifo_rx(struct ux500_msp *msp)
reg_val_FLR = readl(msp->registers + MSP_FLR);
while (!(reg_val_FLR & RX_FIFO_EMPTY) && limit--) {
- reg_val_DR = readl(msp->registers + MSP_DR);
+ readl(msp->registers + MSP_DR);
reg_val_FLR = readl(msp->registers + MSP_FLR);
}
@@ -412,7 +412,7 @@ static void flush_fifo_rx(struct ux500_msp *msp)
static void flush_fifo_tx(struct ux500_msp *msp)
{
- u32 reg_val_TSTDR, reg_val_GCR, reg_val_FLR;
+ u32 reg_val_GCR, reg_val_FLR;
u32 limit = 32;
reg_val_GCR = readl(msp->registers + MSP_GCR);
@@ -421,7 +421,7 @@ static void flush_fifo_tx(struct ux500_msp *msp)
reg_val_FLR = readl(msp->registers + MSP_FLR);
while (!(reg_val_FLR & TX_FIFO_EMPTY) && limit--) {
- reg_val_TSTDR = readl(msp->registers + MSP_TSTDR);
+ readl(msp->registers + MSP_TSTDR);
reg_val_FLR = readl(msp->registers + MSP_FLR);
}
writel(0x0, msp->registers + MSP_ITCR);
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-07 10:18 UTC|newest]
Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 10:16 [PATCH 00/28] Clean-up ASoC's W=1 build warnings Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` [PATCH 01/28] ASoC: atmel: atmel-pcm-dma: Demote function header which is clearly not kerneldoc Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` [PATCH 02/28] ASoC: atmel: atmel_ssc_dai: " Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` [PATCH 03/28] ASoC: fsl: fsl-asoc-card: Use correct format when providing struct documentation Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` [PATCH 04/28] ASoC: fsl: fsl_asrc: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` [PATCH 05/28] ASoC: fsl: fsl_ssi: " Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` [PATCH 06/28] ASoC: fsl: fsl_ssi_dbg: " Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` [PATCH 07/28] ASoC: fsl: fsl_spdif: Use correct formatting when denoting struct documentation Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` [PATCH 08/28] ASoC: fsl: fsl_spdif: Update 'struct fsl_spdif_priv's descriptions Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` [PATCH 09/28] ASoC: fsl: fsl_esai: Fix a bunch of kerneldoc issues Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` [PATCH 10/28] ASoC: fsl: fsl_esai: Add descriptions for 'tx_mask' and 'rx_mask' to 'fsl_esai' Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` [PATCH 11/28] ASoC: pxa: pxa-ssp: Demote seemingly unintentional kerneldoc header Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` [PATCH 12/28] ASoC: codecs: ak4458: Remove set but never checked variable 'ret' Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` [PATCH 13/28] ASoC: qcom: qdsp6: q6asm: Provide documentation for WMA 'codec_profile' Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 15:35 ` Vinod Koul
2020-07-07 15:35 ` Vinod Koul
2020-07-07 15:35 ` Vinod Koul
2020-07-07 10:16 ` [PATCH 14/28] ASoC: samsung: pcm: Demote half-documented kerneldoc header Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` [PATCH 15/28] ASoC: samsung: spdif: Fix 3 misspelled struct properties Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` [PATCH 16/28] ASoC: sunxi: sun4i-i2s: Demote half-documented kerneldoc header Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` [PATCH 17/28] ASoC: uniphier: aio-core: Fix incorrectly named struct property and remove another Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:59 ` Masahiro Yamada
2020-07-07 10:59 ` Masahiro Yamada
2020-07-07 10:59 ` Masahiro Yamada
2020-07-07 10:16 ` [PATCH 18/28] ASoC: sunxi: sun4i-spdif: Fix misspelling of 'reg_dac_txdata' Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` Lee Jones [this message]
2020-07-07 10:16 ` [PATCH 19/28] ASoC: ux500: ux500_msp_i2s: Remove unused variables 'reg_val_DR' and 'reg_val_TSTDR' Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` [PATCH 20/28] ASoC: sti: uniperif: Mark 'uni_tdm_hw' as __maybe_unused Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` [PATCH 21/28] ASoC: ti: omap-mcbsp-st: Remove set, but unused variable 'w' Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:48 ` Peter Ujfalusi
2020-07-07 10:48 ` Peter Ujfalusi
2020-07-07 10:48 ` Peter Ujfalusi
2020-07-07 10:16 ` [PATCH 22/28] ASoC: codecs: da7210: Fix formatting issues in da7210_set_dai_pll() header Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` [PATCH 23/28] ASoC: soc-ac97: Demote seemingly unintentional kerneldoc header Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` [PATCH 24/28] ASoC: codecs: jz4770: Remove defined but never used variable 'mic_boost_tlv' Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:40 ` Paul Cercueil
2020-07-07 10:40 ` Paul Cercueil
2020-07-07 10:40 ` Paul Cercueil
2020-07-07 10:16 ` [PATCH 25/28] ASoC: codecs: rt5631: Demote misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` [PATCH 26/28] ASoC: codecs: rt5659: Remove many unused const variables Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` [PATCH 27/28] ASoC: codecs: tlv320aic26: Demote seemingly unintentional kerneldoc header Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` [PATCH 28/28] ASoC: codecs: wm8400: Remove a bunch of unused variables Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:19 ` [PATCH 00/28] Clean-up ASoC's W=1 build warnings Mark Brown
2020-07-07 10:19 ` Mark Brown
2020-07-07 10:19 ` Mark Brown
2020-07-07 10:37 ` Lee Jones
2020-07-07 10:37 ` Lee Jones
2020-07-07 10:37 ` Lee Jones
2020-07-07 10:40 ` Mark Brown
2020-07-07 10:40 ` Mark Brown
2020-07-07 10:40 ` Mark Brown
2020-07-07 15:44 ` Pierre-Louis Bossart
2020-07-07 15:44 ` Pierre-Louis Bossart
2020-07-07 15:44 ` Pierre-Louis Bossart
2020-07-07 19:04 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707101642.1747944-20-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ola.o.lilja@stericsson.com \
--cc=perex@perex.cz \
--cc=roger.xr.nilsson@stericsson.com \
--cc=sandeep.kaushik@st.com \
--cc=tiwai@suse.com \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.