From: Mark Brown <broonie@kernel.org>
To: Akshu Agrawal <akshu.agrawal@amd.com>
Cc: Oder Chiou <oder_chiou@realtek.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
"moderated list:SOUND" <alsa-devel@alsa-project.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: rt5682: Add fmw property to get name of mclk
Date: Tue, 7 Jul 2020 11:30:53 +0100 [thread overview]
Message-ID: <20200707103053.GF4870@sirena.org.uk> (raw)
In-Reply-To: <20200707100825.24792-1-akshu.agrawal@amd.com>
[-- Attachment #1: Type: text/plain, Size: 597 bytes --]
On Tue, Jul 07, 2020 at 03:38:25PM +0530, Akshu Agrawal wrote:
> Non-dts based systems can use ACPI DSDT to pass on the mclk.
> Thus add fmw property mclk-name to get the name of the system clk
> and link it to rt5682 mclk.
ACPI doesn't support clocks at all, you need to add a clock binding to
ACPI first. The idiomatic way to do this would be to have board
specific quirks.
> + device_property_read_string(dev, "realtek,mclk-name", &rt5682->pdata.mclk_name);
> +
No, this is not at all OK - you're adding this via a device property
which means that this will show up in the DT bindings too.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Akshu Agrawal <akshu.agrawal@amd.com>
Cc: Oder Chiou <oder_chiou@realtek.com>,
"moderated list:SOUND" <alsa-devel@alsa-project.org>,
open list <linux-kernel@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH] ASoC: rt5682: Add fmw property to get name of mclk
Date: Tue, 7 Jul 2020 11:30:53 +0100 [thread overview]
Message-ID: <20200707103053.GF4870@sirena.org.uk> (raw)
In-Reply-To: <20200707100825.24792-1-akshu.agrawal@amd.com>
[-- Attachment #1: Type: text/plain, Size: 597 bytes --]
On Tue, Jul 07, 2020 at 03:38:25PM +0530, Akshu Agrawal wrote:
> Non-dts based systems can use ACPI DSDT to pass on the mclk.
> Thus add fmw property mclk-name to get the name of the system clk
> and link it to rt5682 mclk.
ACPI doesn't support clocks at all, you need to add a clock binding to
ACPI first. The idiomatic way to do this would be to have board
specific quirks.
> + device_property_read_string(dev, "realtek,mclk-name", &rt5682->pdata.mclk_name);
> +
No, this is not at all OK - you're adding this via a device property
which means that this will show up in the DT bindings too.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-07-07 10:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 10:08 [PATCH] ASoC: rt5682: Add fmw property to get name of mclk Akshu Agrawal
2020-07-07 10:08 ` Akshu Agrawal
2020-07-07 10:30 ` Mark Brown [this message]
2020-07-07 10:30 ` Mark Brown
2020-07-13 1:16 ` Agrawal, Akshu
2020-07-13 1:16 ` Agrawal, Akshu
2020-07-13 10:52 ` Mark Brown
2020-07-13 10:52 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707103053.GF4870@sirena.org.uk \
--to=broonie@kernel.org \
--cc=akshu.agrawal@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.