From: Mike Rapoport <rppt@linux.ibm.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Jia He <justin.he@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Baoquan He <bhe@redhat.com>, Chuhong Yuan <hslester96@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-nvdimm@lists.01.org, Kaly Xin <Kaly.Xin@arm.com>
Subject: Re: [PATCH v2 1/3] arm64/numa: export memory_add_physaddr_to_nid as EXPORT_SYMBOL_GPL
Date: Tue, 7 Jul 2020 15:13:02 +0300 [thread overview]
Message-ID: <20200707121302.GB9411@linux.ibm.com> (raw)
In-Reply-To: <20200707115454.GN5913@dhcp22.suse.cz>
On Tue, Jul 07, 2020 at 01:54:54PM +0200, Michal Hocko wrote:
> On Tue 07-07-20 13:59:15, Jia He wrote:
> > This exports memory_add_physaddr_to_nid() for module driver to use.
> >
> > memory_add_physaddr_to_nid() is a fallback option to get the nid in case
> > NUMA_NO_NID is detected.
> >
> > Suggested-by: David Hildenbrand <david@redhat.com>
> > Signed-off-by: Jia He <justin.he@arm.com>
> > ---
> > arch/arm64/mm/numa.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/mm/numa.c b/arch/arm64/mm/numa.c
> > index aafcee3e3f7e..7eeb31740248 100644
> > --- a/arch/arm64/mm/numa.c
> > +++ b/arch/arm64/mm/numa.c
> > @@ -464,10 +464,11 @@ void __init arm64_numa_init(void)
> >
> > /*
> > * We hope that we will be hotplugging memory on nodes we already know about,
> > - * such that acpi_get_node() succeeds and we never fall back to this...
> > + * such that acpi_get_node() succeeds. But when SRAT is not present, the node
> > + * id may be probed as NUMA_NO_NODE by acpi, Here provide a fallback option.
> > */
> > int memory_add_physaddr_to_nid(u64 addr)
> > {
> > - pr_warn("Unknown node for memory at 0x%llx, assuming node 0\n", addr);
> > return 0;
> > }
> > +EXPORT_SYMBOL_GPL(memory_add_physaddr_to_nid);
>
> Does it make sense to export a noop function? Wouldn't make more sense
> to simply make it static inline somewhere in a header? I haven't checked
> whether there is an easy way to do that sanely bu this just hit my eyes.
We'll need to either add a CONFIG_ option or arch specific callback to
make both non-empty (x86, powerpc, ia64) and empty (arm64, sh)
implementations coexist ...
> --
> Michal Hocko
> SUSE Labs
--
Sincerely yours,
Mike.
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: Mike Rapoport <rppt@linux.ibm.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Jia He <justin.he@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Baoquan He <bhe@redhat.com>, Chuhong Yuan <hslester96@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-nvdimm@lists.01.org, Kaly Xin <Kaly.Xin@arm.com>
Subject: Re: [PATCH v2 1/3] arm64/numa: export memory_add_physaddr_to_nid as EXPORT_SYMBOL_GPL
Date: Tue, 7 Jul 2020 15:13:02 +0300 [thread overview]
Message-ID: <20200707121302.GB9411@linux.ibm.com> (raw)
In-Reply-To: <20200707115454.GN5913@dhcp22.suse.cz>
On Tue, Jul 07, 2020 at 01:54:54PM +0200, Michal Hocko wrote:
> On Tue 07-07-20 13:59:15, Jia He wrote:
> > This exports memory_add_physaddr_to_nid() for module driver to use.
> >
> > memory_add_physaddr_to_nid() is a fallback option to get the nid in case
> > NUMA_NO_NID is detected.
> >
> > Suggested-by: David Hildenbrand <david@redhat.com>
> > Signed-off-by: Jia He <justin.he@arm.com>
> > ---
> > arch/arm64/mm/numa.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/mm/numa.c b/arch/arm64/mm/numa.c
> > index aafcee3e3f7e..7eeb31740248 100644
> > --- a/arch/arm64/mm/numa.c
> > +++ b/arch/arm64/mm/numa.c
> > @@ -464,10 +464,11 @@ void __init arm64_numa_init(void)
> >
> > /*
> > * We hope that we will be hotplugging memory on nodes we already know about,
> > - * such that acpi_get_node() succeeds and we never fall back to this...
> > + * such that acpi_get_node() succeeds. But when SRAT is not present, the node
> > + * id may be probed as NUMA_NO_NODE by acpi, Here provide a fallback option.
> > */
> > int memory_add_physaddr_to_nid(u64 addr)
> > {
> > - pr_warn("Unknown node for memory at 0x%llx, assuming node 0\n", addr);
> > return 0;
> > }
> > +EXPORT_SYMBOL_GPL(memory_add_physaddr_to_nid);
>
> Does it make sense to export a noop function? Wouldn't make more sense
> to simply make it static inline somewhere in a header? I haven't checked
> whether there is an easy way to do that sanely bu this just hit my eyes.
We'll need to either add a CONFIG_ option or arch specific callback to
make both non-empty (x86, powerpc, ia64) and empty (arm64, sh)
implementations coexist ...
> --
> Michal Hocko
> SUSE Labs
--
Sincerely yours,
Mike.
WARNING: multiple messages have this Message-ID (diff)
From: Mike Rapoport <rppt@linux.ibm.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Kaly Xin <Kaly.Xin@arm.com>, Dave Jiang <dave.jiang@intel.com>,
Baoquan He <bhe@redhat.com>,
linux-nvdimm@lists.01.org,
Catalin Marinas <catalin.marinas@arm.com>,
Chuhong Yuan <hslester96@gmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Vishal Verma <vishal.l.verma@intel.com>,
Jia He <justin.he@arm.com>,
Dan Williams <dan.j.williams@intel.com>,
Will Deacon <will@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/3] arm64/numa: export memory_add_physaddr_to_nid as EXPORT_SYMBOL_GPL
Date: Tue, 7 Jul 2020 15:13:02 +0300 [thread overview]
Message-ID: <20200707121302.GB9411@linux.ibm.com> (raw)
In-Reply-To: <20200707115454.GN5913@dhcp22.suse.cz>
On Tue, Jul 07, 2020 at 01:54:54PM +0200, Michal Hocko wrote:
> On Tue 07-07-20 13:59:15, Jia He wrote:
> > This exports memory_add_physaddr_to_nid() for module driver to use.
> >
> > memory_add_physaddr_to_nid() is a fallback option to get the nid in case
> > NUMA_NO_NID is detected.
> >
> > Suggested-by: David Hildenbrand <david@redhat.com>
> > Signed-off-by: Jia He <justin.he@arm.com>
> > ---
> > arch/arm64/mm/numa.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/mm/numa.c b/arch/arm64/mm/numa.c
> > index aafcee3e3f7e..7eeb31740248 100644
> > --- a/arch/arm64/mm/numa.c
> > +++ b/arch/arm64/mm/numa.c
> > @@ -464,10 +464,11 @@ void __init arm64_numa_init(void)
> >
> > /*
> > * We hope that we will be hotplugging memory on nodes we already know about,
> > - * such that acpi_get_node() succeeds and we never fall back to this...
> > + * such that acpi_get_node() succeeds. But when SRAT is not present, the node
> > + * id may be probed as NUMA_NO_NODE by acpi, Here provide a fallback option.
> > */
> > int memory_add_physaddr_to_nid(u64 addr)
> > {
> > - pr_warn("Unknown node for memory at 0x%llx, assuming node 0\n", addr);
> > return 0;
> > }
> > +EXPORT_SYMBOL_GPL(memory_add_physaddr_to_nid);
>
> Does it make sense to export a noop function? Wouldn't make more sense
> to simply make it static inline somewhere in a header? I haven't checked
> whether there is an easy way to do that sanely bu this just hit my eyes.
We'll need to either add a CONFIG_ option or arch specific callback to
make both non-empty (x86, powerpc, ia64) and empty (arm64, sh)
implementations coexist ...
> --
> Michal Hocko
> SUSE Labs
--
Sincerely yours,
Mike.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-07 12:13 UTC|newest]
Thread overview: 162+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 5:59 [PATCH v2 0/3] Fix and enable pmem as RAM device on arm64 Jia He
2020-07-07 5:59 ` Jia He
2020-07-07 5:59 ` Jia He
2020-07-07 5:59 ` [PATCH v2 1/3] arm64/numa: export memory_add_physaddr_to_nid as EXPORT_SYMBOL_GPL Jia He
2020-07-07 5:59 ` Jia He
2020-07-07 5:59 ` Jia He
2020-07-07 11:35 ` David Hildenbrand
2020-07-07 11:35 ` David Hildenbrand
2020-07-07 11:35 ` David Hildenbrand
2020-07-07 11:54 ` Michal Hocko
2020-07-07 11:54 ` Michal Hocko
2020-07-07 11:54 ` Michal Hocko
2020-07-07 12:13 ` Mike Rapoport [this message]
2020-07-07 12:13 ` Mike Rapoport
2020-07-07 12:13 ` Mike Rapoport
2020-07-07 12:26 ` David Hildenbrand
2020-07-07 12:26 ` David Hildenbrand
2020-07-07 12:26 ` David Hildenbrand
2020-07-07 18:00 ` Mike Rapoport
2020-07-07 18:00 ` Mike Rapoport
2020-07-07 18:00 ` Mike Rapoport
2020-07-07 22:05 ` Dan Williams
2020-07-07 22:05 ` Dan Williams
2020-07-07 22:05 ` Dan Williams
2020-07-07 22:05 ` Dan Williams
2020-07-08 5:27 ` Mike Rapoport
2020-07-08 5:27 ` Mike Rapoport
2020-07-08 5:27 ` Mike Rapoport
2020-07-08 7:21 ` David Hildenbrand
2020-07-08 7:21 ` David Hildenbrand
2020-07-08 7:21 ` David Hildenbrand
2020-07-08 7:38 ` Mike Rapoport
2020-07-08 7:38 ` Mike Rapoport
2020-07-08 7:38 ` Mike Rapoport
2020-07-08 7:40 ` David Hildenbrand
2020-07-08 7:40 ` David Hildenbrand
2020-07-08 7:40 ` David Hildenbrand
2020-07-08 7:50 ` Dan Williams
2020-07-08 7:50 ` Dan Williams
2020-07-08 7:50 ` Dan Williams
2020-07-08 7:50 ` Dan Williams
2020-07-08 8:26 ` David Hildenbrand
2020-07-08 8:26 ` David Hildenbrand
2020-07-08 8:26 ` David Hildenbrand
2020-07-08 8:39 ` Mike Rapoport
2020-07-08 8:39 ` Mike Rapoport
2020-07-08 8:39 ` Mike Rapoport
2020-07-08 8:45 ` David Hildenbrand
2020-07-08 8:45 ` David Hildenbrand
2020-07-08 8:45 ` David Hildenbrand
2020-07-08 9:15 ` Mike Rapoport
2020-07-08 9:15 ` Mike Rapoport
2020-07-08 9:15 ` Mike Rapoport
2020-07-08 9:25 ` David Hildenbrand
2020-07-08 9:25 ` David Hildenbrand
2020-07-08 9:25 ` David Hildenbrand
2020-07-08 9:45 ` Mike Rapoport
2020-07-08 9:45 ` Mike Rapoport
2020-07-08 9:45 ` Mike Rapoport
2020-07-08 10:04 ` David Hildenbrand
2020-07-08 10:04 ` David Hildenbrand
2020-07-08 10:04 ` David Hildenbrand
2020-07-08 15:50 ` Dan Williams
2020-07-08 15:50 ` Dan Williams
2020-07-08 15:50 ` Dan Williams
2020-07-08 15:50 ` Dan Williams
2020-07-08 16:10 ` David Hildenbrand
2020-07-08 16:10 ` David Hildenbrand
2020-07-08 16:10 ` David Hildenbrand
2020-07-08 16:47 ` Mike Rapoport
2020-07-08 16:47 ` Mike Rapoport
2020-07-08 16:47 ` Mike Rapoport
2020-07-08 2:20 ` Justin He
2020-07-08 2:20 ` Justin He
2020-07-08 2:20 ` Justin He
2020-07-08 2:20 ` Justin He
2020-07-08 3:56 ` Dan Williams
2020-07-08 3:56 ` Dan Williams
2020-07-08 3:56 ` Dan Williams
2020-07-08 3:56 ` Dan Williams
2020-07-08 4:08 ` Justin He
2020-07-08 4:08 ` Justin He
2020-07-08 4:08 ` Justin He
2020-07-08 4:08 ` Justin He
2020-07-08 4:27 ` Dan Williams
2020-07-08 4:27 ` Dan Williams
2020-07-08 4:27 ` Dan Williams
2020-07-08 4:27 ` Dan Williams
2020-07-08 6:22 ` Mike Rapoport
2020-07-08 6:22 ` Mike Rapoport
2020-07-08 6:22 ` Mike Rapoport
2020-07-08 6:22 ` Mike Rapoport
2020-07-08 6:53 ` Dan Williams
2020-07-08 6:53 ` Dan Williams
2020-07-08 6:53 ` Dan Williams
2020-07-08 6:53 ` Dan Williams
2020-07-08 6:59 ` David Hildenbrand
2020-07-08 6:59 ` David Hildenbrand
2020-07-08 6:59 ` David Hildenbrand
2020-07-08 6:59 ` David Hildenbrand
2020-07-08 7:04 ` Dan Williams
2020-07-08 7:04 ` Dan Williams
2020-07-08 7:04 ` Dan Williams
2020-07-08 7:04 ` Dan Williams
2020-07-08 7:16 ` David Hildenbrand
2020-07-08 7:16 ` David Hildenbrand
2020-07-08 7:16 ` David Hildenbrand
2020-07-08 7:16 ` David Hildenbrand
2020-07-08 7:43 ` Mike Rapoport
2020-07-08 7:43 ` Mike Rapoport
2020-07-08 7:43 ` Mike Rapoport
2020-07-08 7:43 ` Mike Rapoport
2020-07-08 5:32 ` Mike Rapoport
2020-07-08 5:32 ` Mike Rapoport
2020-07-08 5:32 ` Mike Rapoport
2020-07-08 5:32 ` Mike Rapoport
2020-07-08 5:48 ` Dan Williams
2020-07-08 5:48 ` Dan Williams
2020-07-08 5:48 ` Dan Williams
2020-07-08 5:48 ` Dan Williams
2020-07-08 6:19 ` Mike Rapoport
2020-07-08 6:19 ` Mike Rapoport
2020-07-08 6:19 ` Mike Rapoport
2020-07-08 6:19 ` Mike Rapoport
2020-07-08 6:44 ` Dan Williams
2020-07-08 6:44 ` Dan Williams
2020-07-08 6:44 ` Dan Williams
2020-07-08 6:44 ` Dan Williams
2020-07-08 6:56 ` Justin He
2020-07-08 6:56 ` Justin He
2020-07-08 6:56 ` Justin He
2020-07-08 6:56 ` Justin He
2020-07-08 7:00 ` David Hildenbrand
2020-07-08 7:00 ` David Hildenbrand
2020-07-08 7:00 ` David Hildenbrand
2020-07-08 7:00 ` David Hildenbrand
2020-07-07 5:59 ` [RFC PATCH v2 2/3] device-dax: use fallback nid when numa_node is invalid Jia He
2020-07-07 5:59 ` Jia He
2020-07-07 5:59 ` Jia He
2020-07-07 6:08 ` Justin He
2020-07-07 6:08 ` Justin He
2020-07-07 6:08 ` Justin He
2020-07-07 6:08 ` Justin He
2020-07-07 11:34 ` David Hildenbrand
2020-07-07 11:34 ` David Hildenbrand
2020-07-07 11:34 ` David Hildenbrand
2020-07-08 1:41 ` Justin He
2020-07-08 1:41 ` Justin He
2020-07-08 1:41 ` Justin He
2020-07-08 1:41 ` Justin He
2020-07-07 13:53 ` kernel test robot
2020-07-08 7:07 ` kernel test robot
2020-07-07 5:59 ` [PATCH v2 3/3] mm/memory_hotplug: fix unpaired mem_hotplug_begin/done Jia He
2020-07-07 5:59 ` Jia He
2020-07-07 5:59 ` Jia He
2020-07-07 10:06 ` Michal Hocko
2020-07-07 10:06 ` Michal Hocko
2020-07-07 10:06 ` Michal Hocko
2020-07-07 11:31 ` David Hildenbrand
2020-07-07 11:31 ` David Hildenbrand
2020-07-07 11:31 ` David Hildenbrand
2020-07-10 14:02 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707121302.GB9411@linux.ibm.com \
--to=rppt@linux.ibm.com \
--cc=Kaly.Xin@arm.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=hslester96@gmail.com \
--cc=justin.he@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mhocko@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.