From: Ravi Bangoria <ravi.bangoria@linux.ibm.com> To: mpe@ellerman.id.au, mikey@neuling.org Cc: ravi.bangoria@linux.ibm.com, apopple@linux.ibm.com, paulus@samba.org, npiggin@gmail.com, christophe.leroy@c-s.fr, naveen.n.rao@linux.vnet.ibm.com, peterz@infradead.org, jolsa@kernel.org, oleg@redhat.com, fweisbec@gmail.com, mingo@kernel.org, pedromfc@br.ibm.com, miltonm@us.ibm.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 9/9] powerpc/watchpoint: Remove 512 byte boundary Date: Wed, 8 Jul 2020 10:20:46 +0530 [thread overview] Message-ID: <20200708045046.135702-10-ravi.bangoria@linux.ibm.com> (raw) In-Reply-To: <20200708045046.135702-1-ravi.bangoria@linux.ibm.com> Power10 has removed 512 bytes boundary from match criteria. i.e. The watch range can cross 512 bytes boundary. Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com> --- arch/powerpc/kernel/hw_breakpoint.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/hw_breakpoint.c b/arch/powerpc/kernel/hw_breakpoint.c index 7a66c370a105..270fbb4d01ce 100644 --- a/arch/powerpc/kernel/hw_breakpoint.c +++ b/arch/powerpc/kernel/hw_breakpoint.c @@ -418,8 +418,9 @@ static int hw_breakpoint_validate_len(struct arch_hw_breakpoint *hw) if (dawr_enabled()) { max_len = DAWR_MAX_LEN; - /* DAWR region can't cross 512 bytes boundary */ - if (ALIGN_DOWN(start_addr, SZ_512) != ALIGN_DOWN(end_addr - 1, SZ_512)) + /* DAWR region can't cross 512 bytes boundary on p10 predecessors */ + if (!cpu_has_feature(CPU_FTR_ARCH_31) && + (ALIGN_DOWN(start_addr, SZ_512) != ALIGN_DOWN(end_addr - 1, SZ_512))) return -EINVAL; } else if (IS_ENABLED(CONFIG_PPC_8xx)) { /* 8xx can setup a range without limitation */ -- 2.26.2
WARNING: multiple messages have this Message-ID (diff)
From: Ravi Bangoria <ravi.bangoria@linux.ibm.com> To: mpe@ellerman.id.au, mikey@neuling.org Cc: christophe.leroy@c-s.fr, ravi.bangoria@linux.ibm.com, apopple@linux.ibm.com, peterz@infradead.org, fweisbec@gmail.com, miltonm@us.ibm.com, oleg@redhat.com, npiggin@gmail.com, linux-kernel@vger.kernel.org, paulus@samba.org, jolsa@kernel.org, pedromfc@br.ibm.com, naveen.n.rao@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org, mingo@kernel.org Subject: [PATCH v3 9/9] powerpc/watchpoint: Remove 512 byte boundary Date: Wed, 8 Jul 2020 10:20:46 +0530 [thread overview] Message-ID: <20200708045046.135702-10-ravi.bangoria@linux.ibm.com> (raw) In-Reply-To: <20200708045046.135702-1-ravi.bangoria@linux.ibm.com> Power10 has removed 512 bytes boundary from match criteria. i.e. The watch range can cross 512 bytes boundary. Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com> --- arch/powerpc/kernel/hw_breakpoint.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/hw_breakpoint.c b/arch/powerpc/kernel/hw_breakpoint.c index 7a66c370a105..270fbb4d01ce 100644 --- a/arch/powerpc/kernel/hw_breakpoint.c +++ b/arch/powerpc/kernel/hw_breakpoint.c @@ -418,8 +418,9 @@ static int hw_breakpoint_validate_len(struct arch_hw_breakpoint *hw) if (dawr_enabled()) { max_len = DAWR_MAX_LEN; - /* DAWR region can't cross 512 bytes boundary */ - if (ALIGN_DOWN(start_addr, SZ_512) != ALIGN_DOWN(end_addr - 1, SZ_512)) + /* DAWR region can't cross 512 bytes boundary on p10 predecessors */ + if (!cpu_has_feature(CPU_FTR_ARCH_31) && + (ALIGN_DOWN(start_addr, SZ_512) != ALIGN_DOWN(end_addr - 1, SZ_512))) return -EINVAL; } else if (IS_ENABLED(CONFIG_PPC_8xx)) { /* 8xx can setup a range without limitation */ -- 2.26.2
next prev parent reply other threads:[~2020-07-08 4:52 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-08 4:50 [PATCH v3 0/9] powerpc/watchpoint: Enable 2nd DAWR on baremetal and powervm Ravi Bangoria 2020-07-08 4:50 ` Ravi Bangoria 2020-07-08 4:50 ` [PATCH v3 1/9] powerpc/watchpoint: Fix 512 byte boundary limit Ravi Bangoria 2020-07-08 4:50 ` Ravi Bangoria 2020-07-08 7:44 ` Jordan Niethe 2020-07-08 7:44 ` Jordan Niethe 2020-07-08 7:52 ` Christophe Leroy 2020-07-08 7:52 ` Christophe Leroy 2020-07-15 1:01 ` Jordan Niethe 2020-07-15 1:01 ` Jordan Niethe 2020-07-08 4:50 ` [PATCH v3 2/9] powerpc/watchpoint: Fix DAWR exception constraint Ravi Bangoria 2020-07-08 4:50 ` Ravi Bangoria 2020-07-15 2:19 ` Jordan Niethe 2020-07-15 2:19 ` Jordan Niethe 2020-07-15 4:08 ` Ravi Bangoria 2020-07-15 4:08 ` Ravi Bangoria 2020-07-08 4:50 ` [PATCH v3 3/9] powerpc/watchpoint: Enable watchpoint functionality on power10 guest Ravi Bangoria 2020-07-08 4:50 ` Ravi Bangoria 2020-07-08 4:50 ` [PATCH v3 4/9] powerpc/dt_cpu_ftrs: Add feature for 2nd DAWR Ravi Bangoria 2020-07-08 4:50 ` Ravi Bangoria 2020-07-08 4:50 ` [PATCH v3 5/9] powerpc/watchpoint: Set CPU_FTR_DAWR1 based on pa-features bit Ravi Bangoria 2020-07-08 4:50 ` Ravi Bangoria 2020-07-08 4:50 ` [PATCH v3 6/9] powerpc/watchpoint: Rename current H_SET_MODE DAWR macro Ravi Bangoria 2020-07-08 4:50 ` Ravi Bangoria 2020-07-08 4:50 ` [PATCH v3 7/9] powerpc/watchpoint: Guest support for 2nd DAWR hcall Ravi Bangoria 2020-07-08 4:50 ` Ravi Bangoria 2020-07-08 4:50 ` [PATCH v3 8/9] powerpc/watchpoint: Return available watchpoints dynamically Ravi Bangoria 2020-07-08 4:50 ` Ravi Bangoria 2020-07-08 4:50 ` Ravi Bangoria [this message] 2020-07-08 4:50 ` [PATCH v3 9/9] powerpc/watchpoint: Remove 512 byte boundary Ravi Bangoria
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200708045046.135702-10-ravi.bangoria@linux.ibm.com \ --to=ravi.bangoria@linux.ibm.com \ --cc=apopple@linux.ibm.com \ --cc=christophe.leroy@c-s.fr \ --cc=fweisbec@gmail.com \ --cc=jolsa@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mikey@neuling.org \ --cc=miltonm@us.ibm.com \ --cc=mingo@kernel.org \ --cc=mpe@ellerman.id.au \ --cc=naveen.n.rao@linux.vnet.ibm.com \ --cc=npiggin@gmail.com \ --cc=oleg@redhat.com \ --cc=paulus@samba.org \ --cc=pedromfc@br.ibm.com \ --cc=peterz@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.