From: kernel test robot <lkp@intel.com>
To: Sam Ravnborg <sam@ravnborg.org>,
dri-devel@lists.freedesktop.org,
Jingoo Han <jingoohan1@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>
Cc: kbuild-all@lists.01.org, linux-pwm@vger.kernel.org,
Support Opensource <support.opensource@diasemi.com>,
Michael Hennerich <michael.hennerich@analog.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH v4 20/20] backlight: make of_find_backlight_by_node() static
Date: Wed, 8 Jul 2020 05:46:54 +0800 [thread overview]
Message-ID: <202007080515.xYGH5THV%lkp@intel.com> (raw)
In-Reply-To: <20200703184546.144664-21-sam@ravnborg.org>
[-- Attachment #1: Type: text/plain, Size: 7798 bytes --]
Hi Sam,
I love your patch! Yet something to improve:
[auto build test ERROR on backlight/for-backlight-next]
[also build test ERROR on tegra-drm/drm/tegra/for-next pwm/for-next linus/master v5.8-rc4]
[cannot apply to next-20200707]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Sam-Ravnborg/backlight-backlight-updates/20200704-024949
base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git for-backlight-next
config: arm-randconfig-r034-20200707 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/gpu/drm/tilcdc/tilcdc_panel.c: In function 'panel_probe':
>> drivers/gpu/drm/tilcdc/tilcdc_panel.c:320:26: error: implicit declaration of function 'of_find_backlight_by_node'; did you mean 'of_find_i2c_adapter_by_node'? [-Werror=implicit-function-declaration]
320 | panel_mod->backlight = of_find_backlight_by_node(bl_node);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
| of_find_i2c_adapter_by_node
>> drivers/gpu/drm/tilcdc/tilcdc_panel.c:320:24: error: assignment to 'struct backlight_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
320 | panel_mod->backlight = of_find_backlight_by_node(bl_node);
| ^
cc1: all warnings being treated as errors
vim +320 drivers/gpu/drm/tilcdc/tilcdc_panel.c
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 299
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 300 static int panel_probe(struct platform_device *pdev)
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 301 {
18c44db8cafe9b Ezequiel Garcia 2014-09-02 302 struct device_node *bl_node, *node = pdev->dev.of_node;
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 303 struct panel_module *panel_mod;
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 304 struct tilcdc_module *mod;
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 305 struct pinctrl *pinctrl;
12778fc14301cf Ezequiel Garcia 2014-09-02 306 int ret;
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 307
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 308 /* bail out early if no DT data: */
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 309 if (!node) {
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 310 dev_err(&pdev->dev, "device-tree data is missing\n");
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 311 return -ENXIO;
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 312 }
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 313
971645d1fd734b Ezequiel Garcia 2014-09-02 314 panel_mod = devm_kzalloc(&pdev->dev, sizeof(*panel_mod), GFP_KERNEL);
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 315 if (!panel_mod)
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 316 return -ENOMEM;
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 317
18c44db8cafe9b Ezequiel Garcia 2014-09-02 318 bl_node = of_parse_phandle(node, "backlight", 0);
18c44db8cafe9b Ezequiel Garcia 2014-09-02 319 if (bl_node) {
18c44db8cafe9b Ezequiel Garcia 2014-09-02 @320 panel_mod->backlight = of_find_backlight_by_node(bl_node);
18c44db8cafe9b Ezequiel Garcia 2014-09-02 321 of_node_put(bl_node);
18c44db8cafe9b Ezequiel Garcia 2014-09-02 322
18c44db8cafe9b Ezequiel Garcia 2014-09-02 323 if (!panel_mod->backlight)
18c44db8cafe9b Ezequiel Garcia 2014-09-02 324 return -EPROBE_DEFER;
18c44db8cafe9b Ezequiel Garcia 2014-09-02 325
18c44db8cafe9b Ezequiel Garcia 2014-09-02 326 dev_info(&pdev->dev, "found backlight\n");
18c44db8cafe9b Ezequiel Garcia 2014-09-02 327 }
18c44db8cafe9b Ezequiel Garcia 2014-09-02 328
26a5bd26499fba Uwe Kleine-König 2015-02-11 329 panel_mod->enable_gpio = devm_gpiod_get_optional(&pdev->dev, "enable",
26a5bd26499fba Uwe Kleine-König 2015-02-11 330 GPIOD_OUT_LOW);
d898ce03675fc0 Ezequiel Garcia 2014-09-02 331 if (IS_ERR(panel_mod->enable_gpio)) {
d898ce03675fc0 Ezequiel Garcia 2014-09-02 332 ret = PTR_ERR(panel_mod->enable_gpio);
d898ce03675fc0 Ezequiel Garcia 2014-09-02 333 dev_err(&pdev->dev, "failed to request enable GPIO\n");
d898ce03675fc0 Ezequiel Garcia 2014-09-02 334 goto fail_backlight;
d898ce03675fc0 Ezequiel Garcia 2014-09-02 335 }
d898ce03675fc0 Ezequiel Garcia 2014-09-02 336
26a5bd26499fba Uwe Kleine-König 2015-02-11 337 if (panel_mod->enable_gpio)
d898ce03675fc0 Ezequiel Garcia 2014-09-02 338 dev_info(&pdev->dev, "found enable GPIO\n");
d898ce03675fc0 Ezequiel Garcia 2014-09-02 339
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 340 mod = &panel_mod->base;
7cdcce9f8b4c15 Guido Martínez 2014-06-17 341 pdev->dev.platform_data = mod;
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 342
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 343 tilcdc_module_init(mod, "panel", &panel_module_ops);
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 344
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 345 pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 346 if (IS_ERR(pinctrl))
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 347 dev_warn(&pdev->dev, "pins are not configured\n");
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 348
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 349 panel_mod->timings = of_get_display_timings(node);
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 350 if (!panel_mod->timings) {
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 351 dev_err(&pdev->dev, "could not get panel timings\n");
12778fc14301cf Ezequiel Garcia 2014-09-02 352 ret = -EINVAL;
7cdcce9f8b4c15 Guido Martínez 2014-06-17 353 goto fail_free;
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 354 }
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 355
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 356 panel_mod->info = of_get_panel_info(node);
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 357 if (!panel_mod->info) {
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 358 dev_err(&pdev->dev, "could not get panel info\n");
12778fc14301cf Ezequiel Garcia 2014-09-02 359 ret = -EINVAL;
7cdcce9f8b4c15 Guido Martínez 2014-06-17 360 goto fail_timings;
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 361 }
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 362
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 363 return 0;
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 364
7cdcce9f8b4c15 Guido Martínez 2014-06-17 365 fail_timings:
7cdcce9f8b4c15 Guido Martínez 2014-06-17 366 display_timings_release(panel_mod->timings);
7cdcce9f8b4c15 Guido Martínez 2014-06-17 367
7cdcce9f8b4c15 Guido Martínez 2014-06-17 368 fail_free:
7cdcce9f8b4c15 Guido Martínez 2014-06-17 369 tilcdc_module_cleanup(mod);
d898ce03675fc0 Ezequiel Garcia 2014-09-02 370
d898ce03675fc0 Ezequiel Garcia 2014-09-02 371 fail_backlight:
18c44db8cafe9b Ezequiel Garcia 2014-09-02 372 if (panel_mod->backlight)
18c44db8cafe9b Ezequiel Garcia 2014-09-02 373 put_device(&panel_mod->backlight->dev);
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 374 return ret;
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 375 }
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 376
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30913 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Sam Ravnborg <sam@ravnborg.org>,
dri-devel@lists.freedesktop.org,
Jingoo Han <jingoohan1@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>
Cc: linux-pwm@vger.kernel.org, kbuild-all@lists.01.org,
Support Opensource <support.opensource@diasemi.com>,
Michael Hennerich <michael.hennerich@analog.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH v4 20/20] backlight: make of_find_backlight_by_node() static
Date: Wed, 8 Jul 2020 05:46:54 +0800 [thread overview]
Message-ID: <202007080515.xYGH5THV%lkp@intel.com> (raw)
In-Reply-To: <20200703184546.144664-21-sam@ravnborg.org>
[-- Attachment #1: Type: text/plain, Size: 7798 bytes --]
Hi Sam,
I love your patch! Yet something to improve:
[auto build test ERROR on backlight/for-backlight-next]
[also build test ERROR on tegra-drm/drm/tegra/for-next pwm/for-next linus/master v5.8-rc4]
[cannot apply to next-20200707]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Sam-Ravnborg/backlight-backlight-updates/20200704-024949
base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git for-backlight-next
config: arm-randconfig-r034-20200707 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/gpu/drm/tilcdc/tilcdc_panel.c: In function 'panel_probe':
>> drivers/gpu/drm/tilcdc/tilcdc_panel.c:320:26: error: implicit declaration of function 'of_find_backlight_by_node'; did you mean 'of_find_i2c_adapter_by_node'? [-Werror=implicit-function-declaration]
320 | panel_mod->backlight = of_find_backlight_by_node(bl_node);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
| of_find_i2c_adapter_by_node
>> drivers/gpu/drm/tilcdc/tilcdc_panel.c:320:24: error: assignment to 'struct backlight_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
320 | panel_mod->backlight = of_find_backlight_by_node(bl_node);
| ^
cc1: all warnings being treated as errors
vim +320 drivers/gpu/drm/tilcdc/tilcdc_panel.c
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 299
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 300 static int panel_probe(struct platform_device *pdev)
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 301 {
18c44db8cafe9b Ezequiel Garcia 2014-09-02 302 struct device_node *bl_node, *node = pdev->dev.of_node;
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 303 struct panel_module *panel_mod;
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 304 struct tilcdc_module *mod;
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 305 struct pinctrl *pinctrl;
12778fc14301cf Ezequiel Garcia 2014-09-02 306 int ret;
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 307
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 308 /* bail out early if no DT data: */
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 309 if (!node) {
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 310 dev_err(&pdev->dev, "device-tree data is missing\n");
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 311 return -ENXIO;
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 312 }
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 313
971645d1fd734b Ezequiel Garcia 2014-09-02 314 panel_mod = devm_kzalloc(&pdev->dev, sizeof(*panel_mod), GFP_KERNEL);
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 315 if (!panel_mod)
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 316 return -ENOMEM;
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 317
18c44db8cafe9b Ezequiel Garcia 2014-09-02 318 bl_node = of_parse_phandle(node, "backlight", 0);
18c44db8cafe9b Ezequiel Garcia 2014-09-02 319 if (bl_node) {
18c44db8cafe9b Ezequiel Garcia 2014-09-02 @320 panel_mod->backlight = of_find_backlight_by_node(bl_node);
18c44db8cafe9b Ezequiel Garcia 2014-09-02 321 of_node_put(bl_node);
18c44db8cafe9b Ezequiel Garcia 2014-09-02 322
18c44db8cafe9b Ezequiel Garcia 2014-09-02 323 if (!panel_mod->backlight)
18c44db8cafe9b Ezequiel Garcia 2014-09-02 324 return -EPROBE_DEFER;
18c44db8cafe9b Ezequiel Garcia 2014-09-02 325
18c44db8cafe9b Ezequiel Garcia 2014-09-02 326 dev_info(&pdev->dev, "found backlight\n");
18c44db8cafe9b Ezequiel Garcia 2014-09-02 327 }
18c44db8cafe9b Ezequiel Garcia 2014-09-02 328
26a5bd26499fba Uwe Kleine-König 2015-02-11 329 panel_mod->enable_gpio = devm_gpiod_get_optional(&pdev->dev, "enable",
26a5bd26499fba Uwe Kleine-König 2015-02-11 330 GPIOD_OUT_LOW);
d898ce03675fc0 Ezequiel Garcia 2014-09-02 331 if (IS_ERR(panel_mod->enable_gpio)) {
d898ce03675fc0 Ezequiel Garcia 2014-09-02 332 ret = PTR_ERR(panel_mod->enable_gpio);
d898ce03675fc0 Ezequiel Garcia 2014-09-02 333 dev_err(&pdev->dev, "failed to request enable GPIO\n");
d898ce03675fc0 Ezequiel Garcia 2014-09-02 334 goto fail_backlight;
d898ce03675fc0 Ezequiel Garcia 2014-09-02 335 }
d898ce03675fc0 Ezequiel Garcia 2014-09-02 336
26a5bd26499fba Uwe Kleine-König 2015-02-11 337 if (panel_mod->enable_gpio)
d898ce03675fc0 Ezequiel Garcia 2014-09-02 338 dev_info(&pdev->dev, "found enable GPIO\n");
d898ce03675fc0 Ezequiel Garcia 2014-09-02 339
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 340 mod = &panel_mod->base;
7cdcce9f8b4c15 Guido Martínez 2014-06-17 341 pdev->dev.platform_data = mod;
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 342
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 343 tilcdc_module_init(mod, "panel", &panel_module_ops);
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 344
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 345 pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 346 if (IS_ERR(pinctrl))
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 347 dev_warn(&pdev->dev, "pins are not configured\n");
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 348
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 349 panel_mod->timings = of_get_display_timings(node);
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 350 if (!panel_mod->timings) {
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 351 dev_err(&pdev->dev, "could not get panel timings\n");
12778fc14301cf Ezequiel Garcia 2014-09-02 352 ret = -EINVAL;
7cdcce9f8b4c15 Guido Martínez 2014-06-17 353 goto fail_free;
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 354 }
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 355
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 356 panel_mod->info = of_get_panel_info(node);
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 357 if (!panel_mod->info) {
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 358 dev_err(&pdev->dev, "could not get panel info\n");
12778fc14301cf Ezequiel Garcia 2014-09-02 359 ret = -EINVAL;
7cdcce9f8b4c15 Guido Martínez 2014-06-17 360 goto fail_timings;
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 361 }
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 362
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 363 return 0;
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 364
7cdcce9f8b4c15 Guido Martínez 2014-06-17 365 fail_timings:
7cdcce9f8b4c15 Guido Martínez 2014-06-17 366 display_timings_release(panel_mod->timings);
7cdcce9f8b4c15 Guido Martínez 2014-06-17 367
7cdcce9f8b4c15 Guido Martínez 2014-06-17 368 fail_free:
7cdcce9f8b4c15 Guido Martínez 2014-06-17 369 tilcdc_module_cleanup(mod);
d898ce03675fc0 Ezequiel Garcia 2014-09-02 370
d898ce03675fc0 Ezequiel Garcia 2014-09-02 371 fail_backlight:
18c44db8cafe9b Ezequiel Garcia 2014-09-02 372 if (panel_mod->backlight)
18c44db8cafe9b Ezequiel Garcia 2014-09-02 373 put_device(&panel_mod->backlight->dev);
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 374 return ret;
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 375 }
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 376
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30913 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v4 20/20] backlight: make of_find_backlight_by_node() static
Date: Wed, 08 Jul 2020 05:46:54 +0800 [thread overview]
Message-ID: <202007080515.xYGH5THV%lkp@intel.com> (raw)
In-Reply-To: <20200703184546.144664-21-sam@ravnborg.org>
[-- Attachment #1: Type: text/plain, Size: 7931 bytes --]
Hi Sam,
I love your patch! Yet something to improve:
[auto build test ERROR on backlight/for-backlight-next]
[also build test ERROR on tegra-drm/drm/tegra/for-next pwm/for-next linus/master v5.8-rc4]
[cannot apply to next-20200707]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Sam-Ravnborg/backlight-backlight-updates/20200704-024949
base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git for-backlight-next
config: arm-randconfig-r034-20200707 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/gpu/drm/tilcdc/tilcdc_panel.c: In function 'panel_probe':
>> drivers/gpu/drm/tilcdc/tilcdc_panel.c:320:26: error: implicit declaration of function 'of_find_backlight_by_node'; did you mean 'of_find_i2c_adapter_by_node'? [-Werror=implicit-function-declaration]
320 | panel_mod->backlight = of_find_backlight_by_node(bl_node);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
| of_find_i2c_adapter_by_node
>> drivers/gpu/drm/tilcdc/tilcdc_panel.c:320:24: error: assignment to 'struct backlight_device *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
320 | panel_mod->backlight = of_find_backlight_by_node(bl_node);
| ^
cc1: all warnings being treated as errors
vim +320 drivers/gpu/drm/tilcdc/tilcdc_panel.c
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 299
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 300 static int panel_probe(struct platform_device *pdev)
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 301 {
18c44db8cafe9b Ezequiel Garcia 2014-09-02 302 struct device_node *bl_node, *node = pdev->dev.of_node;
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 303 struct panel_module *panel_mod;
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 304 struct tilcdc_module *mod;
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 305 struct pinctrl *pinctrl;
12778fc14301cf Ezequiel Garcia 2014-09-02 306 int ret;
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 307
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 308 /* bail out early if no DT data: */
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 309 if (!node) {
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 310 dev_err(&pdev->dev, "device-tree data is missing\n");
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 311 return -ENXIO;
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 312 }
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 313
971645d1fd734b Ezequiel Garcia 2014-09-02 314 panel_mod = devm_kzalloc(&pdev->dev, sizeof(*panel_mod), GFP_KERNEL);
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 315 if (!panel_mod)
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 316 return -ENOMEM;
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 317
18c44db8cafe9b Ezequiel Garcia 2014-09-02 318 bl_node = of_parse_phandle(node, "backlight", 0);
18c44db8cafe9b Ezequiel Garcia 2014-09-02 319 if (bl_node) {
18c44db8cafe9b Ezequiel Garcia 2014-09-02 @320 panel_mod->backlight = of_find_backlight_by_node(bl_node);
18c44db8cafe9b Ezequiel Garcia 2014-09-02 321 of_node_put(bl_node);
18c44db8cafe9b Ezequiel Garcia 2014-09-02 322
18c44db8cafe9b Ezequiel Garcia 2014-09-02 323 if (!panel_mod->backlight)
18c44db8cafe9b Ezequiel Garcia 2014-09-02 324 return -EPROBE_DEFER;
18c44db8cafe9b Ezequiel Garcia 2014-09-02 325
18c44db8cafe9b Ezequiel Garcia 2014-09-02 326 dev_info(&pdev->dev, "found backlight\n");
18c44db8cafe9b Ezequiel Garcia 2014-09-02 327 }
18c44db8cafe9b Ezequiel Garcia 2014-09-02 328
26a5bd26499fba Uwe Kleine-König 2015-02-11 329 panel_mod->enable_gpio = devm_gpiod_get_optional(&pdev->dev, "enable",
26a5bd26499fba Uwe Kleine-König 2015-02-11 330 GPIOD_OUT_LOW);
d898ce03675fc0 Ezequiel Garcia 2014-09-02 331 if (IS_ERR(panel_mod->enable_gpio)) {
d898ce03675fc0 Ezequiel Garcia 2014-09-02 332 ret = PTR_ERR(panel_mod->enable_gpio);
d898ce03675fc0 Ezequiel Garcia 2014-09-02 333 dev_err(&pdev->dev, "failed to request enable GPIO\n");
d898ce03675fc0 Ezequiel Garcia 2014-09-02 334 goto fail_backlight;
d898ce03675fc0 Ezequiel Garcia 2014-09-02 335 }
d898ce03675fc0 Ezequiel Garcia 2014-09-02 336
26a5bd26499fba Uwe Kleine-König 2015-02-11 337 if (panel_mod->enable_gpio)
d898ce03675fc0 Ezequiel Garcia 2014-09-02 338 dev_info(&pdev->dev, "found enable GPIO\n");
d898ce03675fc0 Ezequiel Garcia 2014-09-02 339
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 340 mod = &panel_mod->base;
7cdcce9f8b4c15 Guido Martínez 2014-06-17 341 pdev->dev.platform_data = mod;
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 342
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 343 tilcdc_module_init(mod, "panel", &panel_module_ops);
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 344
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 345 pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 346 if (IS_ERR(pinctrl))
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 347 dev_warn(&pdev->dev, "pins are not configured\n");
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 348
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 349 panel_mod->timings = of_get_display_timings(node);
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 350 if (!panel_mod->timings) {
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 351 dev_err(&pdev->dev, "could not get panel timings\n");
12778fc14301cf Ezequiel Garcia 2014-09-02 352 ret = -EINVAL;
7cdcce9f8b4c15 Guido Martínez 2014-06-17 353 goto fail_free;
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 354 }
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 355
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 356 panel_mod->info = of_get_panel_info(node);
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 357 if (!panel_mod->info) {
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 358 dev_err(&pdev->dev, "could not get panel info\n");
12778fc14301cf Ezequiel Garcia 2014-09-02 359 ret = -EINVAL;
7cdcce9f8b4c15 Guido Martínez 2014-06-17 360 goto fail_timings;
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 361 }
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 362
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 363 return 0;
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 364
7cdcce9f8b4c15 Guido Martínez 2014-06-17 365 fail_timings:
7cdcce9f8b4c15 Guido Martínez 2014-06-17 366 display_timings_release(panel_mod->timings);
7cdcce9f8b4c15 Guido Martínez 2014-06-17 367
7cdcce9f8b4c15 Guido Martínez 2014-06-17 368 fail_free:
7cdcce9f8b4c15 Guido Martínez 2014-06-17 369 tilcdc_module_cleanup(mod);
d898ce03675fc0 Ezequiel Garcia 2014-09-02 370
d898ce03675fc0 Ezequiel Garcia 2014-09-02 371 fail_backlight:
18c44db8cafe9b Ezequiel Garcia 2014-09-02 372 if (panel_mod->backlight)
18c44db8cafe9b Ezequiel Garcia 2014-09-02 373 put_device(&panel_mod->backlight->dev);
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 374 return ret;
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 375 }
0d4bbaf9f3e5b9 Rob Clark 2012-12-18 376
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 30913 bytes --]
next prev parent reply other threads:[~2020-07-07 21:47 UTC|newest]
Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 18:45 [PATCH v4 0/20] backlight: backlight updates Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-03 18:45 ` [PATCH v4 01/20] backlight: refactor fb_notifier_callback() Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-03 18:45 ` [PATCH v4 02/20] backlight: add backlight_is_blank() Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-07 5:42 ` Daniel Vetter
2020-07-07 5:42 ` Daniel Vetter
2020-07-07 5:42 ` Daniel Vetter
2020-07-03 18:45 ` [PATCH v4 03/20] backlight: improve backlight_ops documentation Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-03 18:45 ` [PATCH v4 04/20] backlight: improve backlight_properties documentation Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-03 18:45 ` [PATCH v4 05/20] backlight: improve backlight_device documentation Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-08 10:23 ` Daniel Thompson
2020-07-08 10:23 ` Daniel Thompson
2020-07-08 10:23 ` Daniel Thompson
2020-07-16 14:39 ` Lee Jones
2020-07-16 14:39 ` Lee Jones
2020-07-16 14:39 ` Lee Jones
2020-07-16 15:00 ` Sam Ravnborg
2020-07-16 15:00 ` Sam Ravnborg
2020-07-16 15:00 ` Sam Ravnborg
2020-07-16 15:09 ` Lee Jones
2020-07-16 15:09 ` Lee Jones
2020-07-16 15:09 ` Lee Jones
2020-07-18 5:18 ` Jingoo Han
2020-07-18 5:18 ` Jingoo Han
2020-07-18 5:18 ` Jingoo Han
2020-07-18 6:00 ` Sam Ravnborg
2020-07-18 6:00 ` Sam Ravnborg
2020-07-18 6:00 ` Sam Ravnborg
2020-07-03 18:45 ` [PATCH v4 06/20] backlight: document inline functions in backlight.h Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-03 18:45 ` [PATCH v4 07/20] backlight: document enums " Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-03 18:45 ` [PATCH v4 08/20] backlight: remove the unused backlight_bl driver Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-03 18:45 ` [PATCH v4 09/20] backlight: drop extern from prototypes Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-03 18:45 ` [PATCH v4 10/20] backlight: add overview and update existing doc Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-03 18:45 ` [PATCH v4 11/20] backlight: wire up kernel-doc documentation Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-03 18:45 ` [PATCH v4 12/20] backlight: introduce backlight_get_brightness() Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-08 10:27 ` Daniel Thompson
2020-07-08 10:27 ` Daniel Thompson
2020-07-08 10:27 ` Daniel Thompson
2020-07-03 18:45 ` [PATCH v4 13/20] backlight: as3711_bl: simplify update_status Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-03 18:45 ` [PATCH v4 14/20] backlight: cr_bllcd: introduce backlight_is_blank() Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-08 11:06 ` Daniel Thompson
2020-07-08 11:06 ` Daniel Thompson
2020-07-08 11:06 ` Daniel Thompson
2020-07-03 18:45 ` [PATCH v4 15/20] backlight: gpio_backlight: simplify update_status() Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-08 11:07 ` Daniel Thompson
2020-07-08 11:07 ` Daniel Thompson
2020-07-08 11:07 ` Daniel Thompson
2020-07-03 18:45 ` [PATCH v4 16/20] backlight: jornada720_bl: introduce backlight_is_blank() Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-08 11:12 ` Daniel Thompson
2020-07-08 11:12 ` Daniel Thompson
2020-07-08 11:12 ` Daniel Thompson
2020-07-03 18:45 ` [PATCH v4 17/20] backlight: use backligt_get_brightness() Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-07 5:48 ` Daniel Vetter
2020-07-07 5:48 ` Daniel Vetter
2020-07-07 5:48 ` Daniel Vetter
2020-07-07 19:59 ` Sam Ravnborg
2020-07-07 19:59 ` Sam Ravnborg
2020-07-07 19:59 ` Sam Ravnborg
2020-07-07 20:15 ` Daniel Vetter
2020-07-07 20:15 ` Daniel Vetter
2020-07-07 20:15 ` Daniel Vetter
2020-07-07 20:23 ` Sam Ravnborg
2020-07-07 20:23 ` Sam Ravnborg
2020-07-07 20:23 ` Sam Ravnborg
2020-07-08 11:14 ` Daniel Thompson
2020-07-08 11:14 ` Daniel Thompson
2020-07-08 11:14 ` Daniel Thompson
2020-07-03 18:45 ` [PATCH v4 18/20] backlight: drop backlight_put() Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-03 18:45 ` [PATCH v4 19/20] backlight: make of_find_backlight static Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-08 11:17 ` Daniel Thompson
2020-07-08 11:17 ` Daniel Thompson
2020-07-08 11:17 ` Daniel Thompson
2020-07-03 18:45 ` [PATCH v4 20/20] backlight: make of_find_backlight_by_node() static Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-03 18:45 ` Sam Ravnborg
2020-07-07 21:46 ` kernel test robot [this message]
2020-07-07 21:46 ` kernel test robot
2020-07-07 21:46 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202007080515.xYGH5THV%lkp@intel.com \
--to=lkp@intel.com \
--cc=airlied@linux.ie \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.thompson@linaro.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=lee.jones@linaro.org \
--cc=linux-pwm@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=sam@ravnborg.org \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.