From: Helmut Grohne <helmut.grohne@intenta.de>
To: Michal Simek <michal.simek@xilinx.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>,
"Jan Kiszka" <jan.kiszka@web.de>, <linux-serial@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] tty: xilinx_uartps: Really fix id assignment
Date: Mon, 13 Jul 2020 09:11:25 +0200 [thread overview]
Message-ID: <20200713071123.GA1994@laureti-dev> (raw)
In-Reply-To: <a3b9df28-8142-fc04-317f-44d65a24f38e@xilinx.com>
Hi Michal,
On Fri, Jul 10, 2020 at 01:45:21PM +0200, Michal Simek wrote:
> Thanks for the patch. I think that it will be very useful to list out
> all testcases to make sure that we test all that scenarios and finally
> get over it.
> We are testing scenarios and likely we are missing some that we are not
> able catch all issues before we submit a patch.
Let me try to enumerate those I know:
uart0 | uart1 | console | remark
---------+----------+---------+----------
serial0 | serial1 | ttyPS0 | regular case
serial0 | serial1 | ttyPS1 | normal assignment, second console
serial1 | serial0 | ttyPS0 | -> Jan Kiszka, broken since revert
disabled | serial0 | ttyPS0 | use only uart1 as serial0
serial0 | disabled | ttyPS0 | regular case with uart1 disabled
Out of these, I'm actively using configurations 3 and 4.
Which of these scenarios do you test already?
Helmut
WARNING: multiple messages have this Message-ID (diff)
From: Helmut Grohne <helmut.grohne@intenta.de>
To: Michal Simek <michal.simek@xilinx.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>,
Jan Kiszka <jan.kiszka@web.de>,
linux-serial@vger.kernel.org, Jiri Slaby <jslaby@suse.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] tty: xilinx_uartps: Really fix id assignment
Date: Mon, 13 Jul 2020 09:11:25 +0200 [thread overview]
Message-ID: <20200713071123.GA1994@laureti-dev> (raw)
In-Reply-To: <a3b9df28-8142-fc04-317f-44d65a24f38e@xilinx.com>
Hi Michal,
On Fri, Jul 10, 2020 at 01:45:21PM +0200, Michal Simek wrote:
> Thanks for the patch. I think that it will be very useful to list out
> all testcases to make sure that we test all that scenarios and finally
> get over it.
> We are testing scenarios and likely we are missing some that we are not
> able catch all issues before we submit a patch.
Let me try to enumerate those I know:
uart0 | uart1 | console | remark
---------+----------+---------+----------
serial0 | serial1 | ttyPS0 | regular case
serial0 | serial1 | ttyPS1 | normal assignment, second console
serial1 | serial0 | ttyPS0 | -> Jan Kiszka, broken since revert
disabled | serial0 | ttyPS0 | use only uart1 as serial0
serial0 | disabled | ttyPS0 | regular case with uart1 disabled
Out of these, I'm actively using configurations 3 and 4.
Which of these scenarios do you test already?
Helmut
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-13 7:11 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 8:11 [PATCH] Revert "tty: xilinx_uartps: Fix missing id assignment to the console" Jan Kiszka
2020-06-18 8:11 ` Jan Kiszka
2020-06-18 8:17 ` Michal Simek
2020-06-18 8:17 ` Michal Simek
2020-07-09 7:48 ` [PATCH] tty: xilinx_uartps: Really fix id assignment Helmut Grohne
2020-07-09 7:48 ` Helmut Grohne
2020-07-10 11:45 ` Michal Simek
2020-07-10 11:45 ` Michal Simek
2020-07-13 7:11 ` Helmut Grohne [this message]
2020-07-13 7:11 ` Helmut Grohne
2020-07-13 11:49 ` Michal Simek
2020-07-13 11:49 ` Michal Simek
2020-07-13 12:10 ` Helmut Grohne
2020-07-13 12:10 ` Helmut Grohne
2020-07-13 16:08 ` Maarten Brock
2020-07-13 16:08 ` Maarten Brock
2020-07-22 7:18 ` Michal Simek
2020-07-22 7:18 ` Michal Simek
2020-07-22 16:50 ` Maarten Brock
2020-07-22 16:50 ` Maarten Brock
2020-07-24 9:19 ` Michal Simek
2020-07-24 9:19 ` Michal Simek
2020-07-22 7:14 ` Michal Simek
2020-07-23 9:50 ` Helmut Grohne
2020-07-23 9:50 ` Helmut Grohne
2020-07-24 8:43 ` Michal Simek
2020-07-24 8:43 ` Michal Simek
2020-07-10 12:45 ` Greg Kroah-Hartman
2020-07-10 12:45 ` Greg Kroah-Hartman
2020-07-13 7:32 ` [PATCH v2] " Helmut Grohne
2020-07-13 7:32 ` Helmut Grohne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713071123.GA1994@laureti-dev \
--to=helmut.grohne@intenta.de \
--cc=gregkh@linuxfoundation.org \
--cc=jan.kiszka@web.de \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=shubhrajyoti.datta@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.