From: "Saheed O. Bolarinwa" <refactormyself@gmail.com> To: helgaas@kernel.org, Russell King <linux@armlinux.org.uk> Cc: "Saheed O. Bolarinwa" <refactormyself@gmail.com>, bjorn@helgaas.com, skhan@linuxfoundation.org, linux-pci@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH 33/35] arm/PCI: Tidy Success/Failure checks Date: Mon, 13 Jul 2020 14:22:45 +0200 [thread overview] Message-ID: <20200713122247.10985-34-refactormyself@gmail.com> (raw) In-Reply-To: <20200713122247.10985-1-refactormyself@gmail.com> Remove unnecessary check for 0. Signed-off-by: "Saheed O. Bolarinwa" <refactormyself@gmail.com> --- This patch depends on PATCH 32/35 arch/arm/mach-cns3xxx/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-cns3xxx/pcie.c b/arch/arm/mach-cns3xxx/pcie.c index 7020071a2dc5..c249d4cbf4f0 100644 --- a/arch/arm/mach-cns3xxx/pcie.c +++ b/arch/arm/mach-cns3xxx/pcie.c @@ -92,7 +92,7 @@ static int cns3xxx_pci_read_config(struct pci_bus *bus, unsigned int devfn, ret = pci_generic_config_read(bus, devfn, where, size, val); - if (ret == 0 && !bus->number && !devfn && + if (!ret && !bus->number && !devfn && (where & 0xffc) == PCI_CLASS_REVISION) /* * RC's class is 0xb, but Linux PCI driver needs 0x604 -- 2.18.2
WARNING: multiple messages have this Message-ID (diff)
From: "Saheed O. Bolarinwa" <refactormyself@gmail.com> To: helgaas@kernel.org, Russell King <linux@armlinux.org.uk> Cc: "Saheed O. Bolarinwa" <refactormyself@gmail.com>, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: [Linux-kernel-mentees] [RFC PATCH 33/35] arm/PCI: Tidy Success/Failure checks Date: Mon, 13 Jul 2020 14:22:45 +0200 [thread overview] Message-ID: <20200713122247.10985-34-refactormyself@gmail.com> (raw) In-Reply-To: <20200713122247.10985-1-refactormyself@gmail.com> Remove unnecessary check for 0. Signed-off-by: "Saheed O. Bolarinwa" <refactormyself@gmail.com> --- This patch depends on PATCH 32/35 arch/arm/mach-cns3xxx/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-cns3xxx/pcie.c b/arch/arm/mach-cns3xxx/pcie.c index 7020071a2dc5..c249d4cbf4f0 100644 --- a/arch/arm/mach-cns3xxx/pcie.c +++ b/arch/arm/mach-cns3xxx/pcie.c @@ -92,7 +92,7 @@ static int cns3xxx_pci_read_config(struct pci_bus *bus, unsigned int devfn, ret = pci_generic_config_read(bus, devfn, where, size, val); - if (ret == 0 && !bus->number && !devfn && + if (!ret && !bus->number && !devfn && (where & 0xffc) == PCI_CLASS_REVISION) /* * RC's class is 0xb, but Linux PCI driver needs 0x604 -- 2.18.2 _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-07-13 13:23 UTC|newest] Thread overview: 201+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-13 12:22 [RFC PATCH 00/35] Move all PCIBIOS* definitions into arch/x86 Saheed O. Bolarinwa 2020-07-13 12:22 ` Saheed O. Bolarinwa 2020-07-13 12:22 ` Saheed O. Bolarinwa 2020-07-13 12:22 ` Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-13 12:22 ` [RFC PATCH 01/35] xen-pciback: Change PCIBIOS_SUCCESSFUL to 0 Saheed O. Bolarinwa 2020-07-13 12:22 ` Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-13 12:22 ` [RFC PATCH 02/35] ssb: " Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-13 17:16 ` Larry Finger 2020-07-13 17:16 ` [Linux-kernel-mentees] " Larry Finger 2020-07-13 19:13 ` Saheed Bolarinwa 2020-07-13 19:13 ` [Linux-kernel-mentees] " Saheed Bolarinwa 2020-07-13 18:29 ` Arnd Bergmann 2020-07-13 18:29 ` [Linux-kernel-mentees] " Arnd Bergmann 2020-07-13 18:35 ` Larry Finger 2020-07-13 18:35 ` [Linux-kernel-mentees] " Larry Finger 2020-07-13 12:22 ` [RFC PATCH 03/35] scsi: ipr: " Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-13 12:22 ` [RFC PATCH 04/35] scsi: ipr: Tidy Success/Failure checks Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-13 12:22 ` [RFC PATCH 05/35] PCI: Change PCIBIOS_SUCCESSFUL to 0 Saheed O. Bolarinwa 2020-07-13 12:22 ` Saheed O. Bolarinwa 2020-07-13 12:22 ` Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-13 12:22 ` [RFC PATCH 06/35] PCI: Tidy Success/Failure checks Saheed O. Bolarinwa 2020-07-13 12:22 ` Saheed O. Bolarinwa 2020-07-13 12:22 ` Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-13 13:59 ` Gustavo Pimentel 2020-07-13 13:59 ` Gustavo Pimentel 2020-07-13 13:59 ` Gustavo Pimentel 2020-07-13 13:59 ` [Linux-kernel-mentees] " Gustavo Pimentel 2020-07-13 12:22 ` [RFC PATCH 07/35] PCI: Change PCIBIOS_SUCCESSFUL to 0 Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-13 12:22 ` [RFC PATCH 08/35] PCI: Tidy Success/Failure checks Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-13 12:22 ` [RFC PATCH 09/35] nvme-pci: Change PCIBIOS_SUCCESSFUL to 0 Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-13 12:22 ` Saheed O. Bolarinwa 2020-07-13 16:42 ` Rajashekar, Revanth 2020-07-13 16:42 ` [Linux-kernel-mentees] " Rajashekar, Revanth 2020-07-13 16:42 ` Rajashekar, Revanth 2020-07-13 18:24 ` Saheed Bolarinwa 2020-07-13 18:24 ` [Linux-kernel-mentees] " Saheed Bolarinwa 2020-07-13 18:24 ` Saheed Bolarinwa 2020-07-13 12:22 ` [RFC PATCH 10/35] nvme-pci: Tidy Success/Failure checks Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-13 12:22 ` Saheed O. Bolarinwa 2020-07-13 12:22 ` [RFC PATCH 11/35] r8169: Change PCIBIOS_SUCCESSFUL to 0 Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-13 12:22 ` [RFC PATCH 12/35] r8169: Tidy Success/Failure checks Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-13 13:45 ` Heiner Kallweit 2020-07-13 13:45 ` [Linux-kernel-mentees] " Heiner Kallweit 2020-07-13 13:09 ` Saheed Bolarinwa 2020-07-13 13:09 ` [Linux-kernel-mentees] " Saheed Bolarinwa 2020-07-13 12:22 ` [RFC PATCH 13/35] cxl: Change PCIBIOS_SUCCESSFUL to 0 Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-13 12:22 ` Saheed O. Bolarinwa 2020-07-13 12:22 ` [RFC PATCH 14/35] i2c/busses: " Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-17 14:58 ` Jean Delvare 2020-07-17 14:58 ` [Linux-kernel-mentees] " Jean Delvare 2020-07-18 19:05 ` Saheed Bolarinwa 2020-07-18 19:05 ` [Linux-kernel-mentees] " Saheed Bolarinwa 2020-07-22 11:06 ` Wolfram Sang 2020-07-22 11:06 ` [Linux-kernel-mentees] " Wolfram Sang 2020-07-13 12:22 ` [RFC PATCH 15/35] i2c/busses: Tidy Success/Failure checks Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-17 15:11 ` Jean Delvare 2020-07-17 15:11 ` [Linux-kernel-mentees] " Jean Delvare 2020-07-13 12:22 ` [RFC PATCH 16/35] hwmon: (sis5595) Change PCIBIOS_SUCCESSFUL to 0 Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-14 5:02 ` Guenter Roeck 2020-07-14 5:02 ` [Linux-kernel-mentees] " Guenter Roeck 2020-07-13 12:22 ` [RFC PATCH 17/35] hwmon: (sis5595) Tidy Success/Failure checks Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-14 5:04 ` Guenter Roeck 2020-07-14 5:04 ` [Linux-kernel-mentees] " Guenter Roeck 2020-07-13 12:22 ` [RFC PATCH 18/35] bcma: Change PCIBIOS_SUCCESSFUL to 0 Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-13 12:22 ` [RFC PATCH 19/35] atm: " Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-13 12:22 ` [RFC PATCH 20/35] atm: Tidy Success/Failure checks Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-13 12:22 ` [RFC PATCH 21/35] atm: Fix Style ERROR- assignment in if condition Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-13 12:22 ` [RFC PATCH 22/35] unicore32: Change PCIBIOS_SUCCESSFUL to 0 Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-13 12:22 ` [RFC PATCH 23/35] sparc/PCI: " Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-13 12:22 ` Saheed O. Bolarinwa 2020-07-13 12:22 ` [RFC PATCH 24/35] sh: " Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-13 12:22 ` Saheed O. Bolarinwa 2020-07-20 21:41 ` Rich Felker 2020-07-20 21:41 ` [Linux-kernel-mentees] " Rich Felker 2020-07-20 21:41 ` Rich Felker 2020-07-13 12:22 ` [RFC PATCH 25/35] sh: Tidy Success/Failure checks Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-13 12:22 ` Saheed O. Bolarinwa 2020-07-13 12:22 ` [RFC PATCH 26/35] powerpc: Change PCIBIOS_SUCCESSFUL to 0 Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-13 12:22 ` Saheed O. Bolarinwa 2020-07-13 12:22 ` [RFC PATCH 27/35] powerpc: Tidy Success/Failure checks Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-13 12:22 ` Saheed O. Bolarinwa 2020-07-13 12:22 ` [RFC PATCH 28/35] mips: Change PCIBIOS_SUCCESSFUL to 0 Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-13 12:22 ` [RFC PATCH 29/35] mips: Tidy Success/Failure checks Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-13 12:22 ` [RFC PATCH 30/35] microblaze: Change PCIBIOS_SUCCESSFUL to 0 Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-13 12:22 ` [RFC PATCH 31/35] m68k: " Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-13 12:22 ` [RFC PATCH 32/35] arm/PCI: " Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-13 12:22 ` Saheed O. Bolarinwa [this message] 2020-07-13 12:22 ` [Linux-kernel-mentees] [RFC PATCH 33/35] arm/PCI: Tidy Success/Failure checks Saheed O. Bolarinwa 2020-07-13 12:22 ` [RFC PATCH 34/35] PCI: Change PCIBIOS_SUCCESSFUL to 0 Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-13 12:22 ` [RFC PATCH 35/35] alpha: Tidy Success/Failure checks Saheed O. Bolarinwa 2020-07-13 12:22 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa 2020-07-13 15:08 ` [RFC PATCH 00/35] Move all PCIBIOS* definitions into arch/x86 Arnd Bergmann 2020-07-13 15:08 ` Arnd Bergmann 2020-07-13 15:08 ` Arnd Bergmann 2020-07-13 15:08 ` Arnd Bergmann 2020-07-13 15:08 ` [Linux-kernel-mentees] " Arnd Bergmann 2020-07-14 18:45 ` Bjorn Helgaas 2020-07-14 18:45 ` [Linux-kernel-mentees] " Bjorn Helgaas 2020-07-14 18:45 ` Bjorn Helgaas 2020-07-14 18:45 ` Bjorn Helgaas 2020-07-14 21:02 ` Kjetil Oftedal 2020-07-14 21:02 ` [Linux-kernel-mentees] " Kjetil Oftedal 2020-07-14 21:02 ` Kjetil Oftedal 2020-07-14 21:02 ` Kjetil Oftedal 2020-07-15 2:14 ` Benjamin Herrenschmidt 2020-07-15 2:14 ` [Linux-kernel-mentees] " Benjamin Herrenschmidt 2020-07-15 2:14 ` Benjamin Herrenschmidt 2020-07-15 2:14 ` Benjamin Herrenschmidt 2020-07-14 22:01 ` Arnd Bergmann 2020-07-14 22:01 ` [Linux-kernel-mentees] " Arnd Bergmann 2020-07-14 22:01 ` Arnd Bergmann 2020-07-14 22:01 ` Arnd Bergmann 2020-07-14 23:46 ` Bjorn Helgaas 2020-07-14 23:46 ` [Linux-kernel-mentees] " Bjorn Helgaas 2020-07-14 23:46 ` Bjorn Helgaas 2020-07-14 23:46 ` Bjorn Helgaas 2020-07-15 2:19 ` Benjamin Herrenschmidt 2020-07-15 2:19 ` [Linux-kernel-mentees] " Benjamin Herrenschmidt 2020-07-15 2:19 ` Benjamin Herrenschmidt 2020-07-15 2:19 ` Benjamin Herrenschmidt 2020-07-15 6:47 ` Arnd Bergmann 2020-07-15 6:47 ` [Linux-kernel-mentees] " Arnd Bergmann 2020-07-15 6:47 ` Arnd Bergmann 2020-07-15 6:47 ` Arnd Bergmann 2020-07-15 14:24 ` David Laight 2020-07-15 14:24 ` [Linux-kernel-mentees] " David Laight 2020-07-15 22:01 ` Bjorn Helgaas 2020-07-15 22:01 ` [Linux-kernel-mentees] " Bjorn Helgaas 2020-07-16 8:18 ` David Laight 2020-07-16 8:18 ` [Linux-kernel-mentees] " David Laight 2020-07-15 22:26 ` Benjamin Herrenschmidt 2020-07-15 22:26 ` [Linux-kernel-mentees] " Benjamin Herrenschmidt 2020-07-15 22:26 ` Benjamin Herrenschmidt 2020-07-15 22:26 ` Benjamin Herrenschmidt 2020-07-15 4:18 ` Oliver O'Halloran 2020-07-15 4:18 ` [Linux-kernel-mentees] " Oliver O'Halloran 2020-07-15 4:18 ` Oliver O'Halloran 2020-07-15 4:18 ` Oliver O'Halloran 2020-07-15 14:38 ` David Laight 2020-07-15 14:38 ` [Linux-kernel-mentees] " David Laight 2020-07-15 14:38 ` David Laight 2020-07-15 14:38 ` David Laight 2020-07-15 22:12 ` Bjorn Helgaas 2020-07-15 22:12 ` [Linux-kernel-mentees] " Bjorn Helgaas 2020-07-15 22:12 ` Bjorn Helgaas 2020-07-15 22:12 ` Bjorn Helgaas 2020-07-15 22:49 ` Benjamin Herrenschmidt 2020-07-15 22:49 ` [Linux-kernel-mentees] " Benjamin Herrenschmidt 2020-07-15 22:49 ` Benjamin Herrenschmidt 2020-07-15 22:49 ` Benjamin Herrenschmidt 2020-07-16 8:07 ` David Laight 2020-07-16 8:07 ` [Linux-kernel-mentees] " David Laight 2020-07-16 8:07 ` David Laight 2020-07-16 8:07 ` David Laight 2020-07-14 23:14 ` Rob Herring 2020-07-14 23:14 ` [Linux-kernel-mentees] " Rob Herring 2020-07-14 23:14 ` Rob Herring 2020-07-14 23:14 ` Rob Herring 2020-07-15 2:12 ` Benjamin Herrenschmidt 2020-07-15 2:12 ` [Linux-kernel-mentees] " Benjamin Herrenschmidt 2020-07-15 2:12 ` Benjamin Herrenschmidt 2020-07-15 2:12 ` Benjamin Herrenschmidt 2020-07-13 22:01 ` Bjorn Helgaas 2020-07-13 22:01 ` Bjorn Helgaas 2020-07-13 22:01 ` Bjorn Helgaas 2020-07-13 22:01 ` Bjorn Helgaas 2020-07-13 22:01 ` [Linux-kernel-mentees] " Bjorn Helgaas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200713122247.10985-34-refactormyself@gmail.com \ --to=refactormyself@gmail.com \ --cc=bjorn@helgaas.com \ --cc=helgaas@kernel.org \ --cc=linux-kernel-mentees@lists.linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=skhan@linuxfoundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.